Re: [2.6 patch] ip_conntrack_helper_h323.c: EXPORT_SYMBOL'ed functions shouldn't be static

2006-03-23 Thread David S. Miller
From: Patrick McHardy <[EMAIL PROTECTED]> Date: Fri, 24 Mar 2006 02:27:44 +0100 > I guess I should send it to lkml anyway. It boots fine, I couldn't > figure out how to compare checksums, since the time of compilation > and a couple other dynamically generated strings end up in the binary. This l

Re: [2.6 patch] ip_conntrack_helper_h323.c: EXPORT_SYMBOL'ed functions shouldn't be static

2006-03-23 Thread Patrick McHardy
David S. Miller wrote: > From: Adrian Bunk <[EMAIL PROTECTED]> > Date: Fri, 24 Mar 2006 01:08:01 +0100 > > >>EXPORT_SYMBOL'ed functions shouldn't be static. >> >>Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > > Fixed in Linus's tree as of yesterday. > > I actually have a patch from Patrick

Re: [2.6 patch] ip_conntrack_helper_h323.c: EXPORT_SYMBOL'ed functions shouldn't be static

2006-03-23 Thread Adrian Bunk
On Thu, Mar 23, 2006 at 04:13:14PM -0800, David S. Miller wrote: > From: Adrian Bunk <[EMAIL PROTECTED]> > Date: Fri, 24 Mar 2006 01:08:01 +0100 > > > EXPORT_SYMBOL'ed functions shouldn't be static. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > Fixed in Linus's tree as of yesterday.

Re: [2.6 patch] ip_conntrack_helper_h323.c: EXPORT_SYMBOL'ed functions shouldn't be static

2006-03-23 Thread David S. Miller
From: Adrian Bunk <[EMAIL PROTECTED]> Date: Fri, 24 Mar 2006 01:08:01 +0100 > EXPORT_SYMBOL'ed functions shouldn't be static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Fixed in Linus's tree as of yesterday. I actually have a patch from Patrick McHardy that will make this kind of error

[2.6 patch] ip_conntrack_helper_h323.c: EXPORT_SYMBOL'ed functions shouldn't be static

2006-03-23 Thread Adrian Bunk
EXPORT_SYMBOL'ed functions shouldn't be static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- linux-2.6.16-mm1-full/net/ipv4/netfilter/ip_conntrack_helper_h323.c.old 2006-03-23 19:29:58.0 +0100 +++ linux-2.6.16-mm1-full/net/ipv4/netfilter/ip_conntrack_helper_h323.c 2006-03-23 1