Re: [-mm patch] fix fs/nfs/nfsroot.c compile error

2007-05-07 Thread David Howells
Trond Myklebust <[EMAIL PROTECTED]> wrote: > It makes little or no sense to be forcing attributes like 'const' in a > typedef. That is basically stating that it is inconceivable to use > anything else. Clearly not the case here... Yeah. I think that there shouldn't be a typedef. There's no real

Re: [-mm patch] fix fs/nfs/nfsroot.c compile error

2007-05-07 Thread Trond Myklebust
On Mon, 2007-05-07 at 12:56 +0200, Adrian Bunk wrote: > On Mon, May 07, 2007 at 11:47:51AM +0100, David Howells wrote: > > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > > > match_table_t was made "const" and gcc doesn't like "const __initdata": > > > > Hmmm... My gcc seems quite happy with it. W

Re: [-mm patch] fix fs/nfs/nfsroot.c compile error

2007-05-07 Thread Adrian Bunk
On Mon, May 07, 2007 at 11:47:51AM +0100, David Howells wrote: > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > match_table_t was made "const" and gcc doesn't like "const __initdata": > > Hmmm... My gcc seems quite happy with it. What gcc are you using? 4.1 > Shouldn't __initdata override const

Re: [-mm patch] fix fs/nfs/nfsroot.c compile error

2007-05-07 Thread David Howells
Adrian Bunk <[EMAIL PROTECTED]> wrote: > match_table_t was made "const" and gcc doesn't like "const __initdata": Hmmm... My gcc seems quite happy with it. What gcc are you using? Shouldn't __initdata override const? > BTW: Why is this change to include/linux/parser.h in the net tree? Because

Re: [-mm patch] fix fs/nfs/nfsroot.c compile error

2007-05-05 Thread Trond Myklebust
On Sat, 2007-05-05 at 13:20 -0400, Trond Myklebust wrote: > On Sat, 2007-05-05 at 18:44 +0200, Adrian Bunk wrote: > > On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote: > > >... > > > Changes since 2.6.21-rc7-mm2: > > >... > > > git-net.patch > > >... > > > git trees > > >... > > > >

Re: [-mm patch] fix fs/nfs/nfsroot.c compile error

2007-05-05 Thread Trond Myklebust
On Sat, 2007-05-05 at 18:44 +0200, Adrian Bunk wrote: > On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote: > >... > > Changes since 2.6.21-rc7-mm2: > >... > > git-net.patch > >... > > git trees > >... > > match_table_t was made "const" and gcc doesn't like "const __initdata": Then p

[-mm patch] fix fs/nfs/nfsroot.c compile error

2007-05-05 Thread Adrian Bunk
On Sat, May 05, 2007 at 01:49:55AM -0700, Andrew Morton wrote: >... > Changes since 2.6.21-rc7-mm2: >... > git-net.patch >... > git trees >... match_table_t was made "const" and gcc doesn't like "const __initdata": <-- snip --> ... CC fs/nfs/nfsroot.o /home/bunk/linux/kernel-2.6/linux