Re: [PATCH v3] net: dsa: qca8k: enable port flow control

2019-07-29 Thread xiaofeis
l phy. Thanks Xiaofeis

Re: [PATCH v3] net: dsa: qca8k: enable port flow control

2019-07-28 Thread xiaofeis
On 2019-07-29 06:31, Andrew Lunn wrote: On Sun, Jul 28, 2019 at 08:57:50AM +0800, xiaofeis wrote: Set phy device advertising to enable MAC flow control. Hi Xiaofei. This is half of the needed change for MAC flow control. phy_support_asym_pause(phy) is used by the MAC to tell the PHY layer

[PATCH v3] net: dsa: qca8k: enable port flow control

2019-07-27 Thread xiaofeis
Set phy device advertising to enable MAC flow control. Signed-off-by: Xiaofei Shen --- Changes since V2: drivers/net/dsa/qca8k.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 232e8cc..e429e92 100644 --- a/drivers/ne

Re: [PATCH v2] net: dsa: qca8k: enable port flow control

2019-07-26 Thread xiaofeis
lot, you are correct. phy_support_asym_pause is the API to do this. Very appreciate for all your patinet explaination and good suggestion. Thanks Xiaofeis

Re: [PATCH] qca8k: enable port flow control

2019-07-23 Thread xiaofeis
Hi Andrew Thanks for your comments. I have sent a new patch based on net-next tree. Thanks Xiaofeis On 2019-07-19 21:13, Andrew Lunn wrote: On Fri, Jul 19, 2019 at 10:53:11AM +0800, xiaofeis wrote: Set phy device advertising to enable MAC flow control. Change-Id

[PATCH v2] net: dsa: qca8k: enable port flow control

2019-07-23 Thread xiaofeis
Set phy device advertising to enable MAC flow control. Signed-off-by: Xiaofei Shen --- drivers/net/dsa/qca8k.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index 232e8cc..c5ac426 100644 --- a/drivers/net/dsa/qca8k.c +++

[PATCH] qca8k: enable port flow control

2019-07-18 Thread xiaofeis
Set phy device advertising to enable MAC flow control. Change-Id: Ibf0f554b072fc73136ec9f7ffb90c20b25a4faae Signed-off-by: Xiaofei Shen --- drivers/net/dsa/qca8k.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c index d93be

Re: [PATCH] net: dsa: Implement flow_dissect callback for tag_qca

2019-03-27 Thread xiaofeis
On 2019-03-27 18:15, Vinod Koul wrote: On 27-03-19, 11:59, xiaofeis wrote: Add flow_dissect for qca tagged packet to get the right hash. Ideally this patch should have been tagged as V2. Anyhow the change looks fine so: Reviewed-by: Vinod Koul Signed-off-by: Xiaofei Shen --- net/dsa

Re: [PATCH] net: dsa: Inherit dev addr from master

2019-03-26 Thread xiaofeis
On 2019-02-25 21:21, Andrew Lunn wrote: I think we can remove the first inherit, but if keep it, we can see consistent address output by ifconfig -a before open master and slave interface. True But it also means we see inconsistent MAC addresses on the master. The MAC address changes on open.

[PATCH] net: dsa: Implement flow_dissect callback for tag_qca

2019-03-26 Thread xiaofeis
Add flow_dissect for qca tagged packet to get the right hash. Signed-off-by: Xiaofei Shen --- net/dsa/tag_qca.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/net/dsa/tag_qca.c b/net/dsa/tag_qca.c index e886a3c..f4b4de3 100644 --- a/net/dsa/tag_qca.c +++ b/net/dsa/tag_qca.c @@ -

Re: [PATCH] net: dsa: read mac address from DT for slave device

2019-03-26 Thread xiaofeis
On 2019-02-28 11:54, Florian Fainelli wrote: On 2/27/2019 6:23 PM, xiaof...@codeaurora.org wrote: On 2019-02-27 11:13, Florian Fainelli wrote: On 2/26/2019 6:04 PM, xiaof...@codeaurora.org wrote: On 2019-02-26 15:45, xiaof...@codeaurora.org wrote: On 2019-02-26 01:27, Florian Fainelli wrote:

[PATCH] net: dsa: Implement flow_dissect callback for tag_qca

2019-03-26 Thread xiaofeis
Add flow_dissect for qca tagged packet to get the right hash. Signed-off-by: xiaofeis --- net/dsa/tag_qca.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/net/dsa/tag_qca.c b/net/dsa/tag_qca.c index e886a3c..f4b4de3 100644 --- a/net/dsa/tag_qca.c +++ b/net/dsa/tag_qca.c

[PATCH] Documentation: devicetree: add a new optional property for port mac address

2019-03-10 Thread xiaofeis
Add documentation for a new optional property local-mac-address which is described in ethernet.txt. Signed-off-by: xiaofeis --- Documentation/devicetree/bindings/net/dsa/dsa.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.txt b

[PATCH] net: dsa: Add support for port mac address

2019-03-05 Thread xiaofeis
Allow port network device's mac address to be retrieved from the device tree. Signed-off-by: xiaofeis --- Documentation/devicetree/bindings/net/dsa/dsa.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.txt b/Documentation/devic

[PATCH] net: dsa: Add support for port mac address

2019-03-04 Thread xiaofeis
Allow port network device's mac address to be retrieved from the device tree. Signed-off-by: xiaofeis --- Documentation/devicetree/bindings/net/dsa/dsa.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/net/dsa/dsa.txt b/Documentation/devic

Re: [PATCH] net: dsa: read mac address from DT for slave device

2019-03-03 Thread xiaofeis
On 2019-02-28 11:54, Florian Fainelli wrote: On 2/27/2019 6:23 PM, xiaof...@codeaurora.org wrote: On 2019-02-27 11:13, Florian Fainelli wrote: On 2/26/2019 6:04 PM, xiaof...@codeaurora.org wrote: On 2019-02-26 15:45, xiaof...@codeaurora.org wrote: On 2019-02-26 01:27, Florian Fainelli wrote:

Re: [PATCH] net: dsa: read mac address from DT for slave device

2019-03-03 Thread xiaofeis
It would be good to document this in the binding. Andrew From 4c8597161975dbef5fbe814aeee93599b4c57d37 Mon Sep 17 00:00:00 2001 From: xiaofeis Date: Fri, 1 Mar 2019 13:54:52 +0800 Subject: [PATCH] net: dsa: Add support for port mac address Allow port network device's mac address

Re: [PATCH] net: dsa: read mac address from DT for slave device

2019-02-27 Thread xiaofeis
On 2019-02-27 11:13, Florian Fainelli wrote: On 2/26/2019 6:04 PM, xiaof...@codeaurora.org wrote: On 2019-02-26 15:45, xiaof...@codeaurora.org wrote: On 2019-02-26 01:27, Florian Fainelli wrote: On 2/25/19 5:28 AM, xiaof...@codeaurora.org wrote: Hi Florian We have two slave DSA interfaces, w

Re: [PATCH] net: dsa: read mac address from DT for slave device

2019-02-26 Thread xiaofeis
On 2019-02-27 10:04, xiaof...@codeaurora.org wrote: On 2019-02-26 15:45, xiaof...@codeaurora.org wrote: On 2019-02-26 01:27, Florian Fainelli wrote: On 2/25/19 5:28 AM, xiaof...@codeaurora.org wrote: Hi Florian We have two slave DSA interfaces, wan0 and lan0, one is for wan port, and the oth

Re: [PATCH] net: dsa: read mac address from DT for slave device

2019-02-26 Thread xiaofeis
On 2019-02-26 15:45, xiaof...@codeaurora.org wrote: On 2019-02-26 01:27, Florian Fainelli wrote: On 2/25/19 5:28 AM, xiaof...@codeaurora.org wrote: Hi Florian We have two slave DSA interfaces, wan0 and lan0, one is for wan port, and the other is for lan port. Customer has it's mac address pool

Re: [PATCH] net: dsa: read mac address from DT for slave device

2019-02-25 Thread xiaofeis
On 2019-02-26 01:27, Florian Fainelli wrote: On 2/25/19 5:28 AM, xiaof...@codeaurora.org wrote: Hi Florian We have two slave DSA interfaces, wan0 and lan0, one is for wan port, and the other is for lan port. Customer has it's mac address pool, they want to assign the mac address from the pool

Re: [PATCH] net: dsa: read mac address from DT for slave device

2019-02-25 Thread xiaofeis
Hi Florian We have two slave DSA interfaces, wan0 and lan0, one is for wan port, and the other is for lan port. Customer has it's mac address pool, they want to assign the mac address from the pool on wan0, lan0, and other interfaces like wifi, bt. Coreboot/uboot will populate it to the DTS nod

Re: [PATCH] net: dsa: Inherit dev addr from master

2019-02-25 Thread xiaofeis
is checking whether the address is valid firstly, if it already inherits a valid mac address, it will not inherit again. I think we can remove the first inherit, but if keep it, we can see consistent address output by ifconfig -a before open master and slave interface. Xiaofeis