Re: clean up and modularize arch dma_mapping interface V2

2017-06-26 Thread tndave
On 06/26/2017 02:47 AM, Christoph Hellwig wrote: On Sat, Jun 24, 2017 at 10:36:56AM -0500, Benjamin Herrenschmidt wrote: I think we still need to do it. For example we have a bunch new "funky" cases. I have no plan to do away with the selection - I just want a better interface than the curre

Re: clean up and modularize arch dma_mapping interface V2

2017-06-21 Thread tndave
On 06/16/2017 11:10 AM, Christoph Hellwig wrote: Hi all, for a while we have a generic implementation of the dma mapping routines that call into per-arch or per-device operations. But right now there still are various bits in the interfaces where don't clearly operate on these ops. This seri

Re: [PATCH] i40e: Fix incorrect pf->flags

2017-05-25 Thread tndave
On 05/25/2017 02:13 AM, Jeff Kirsher wrote: On Fri, 2017-05-19 at 18:01 -0700, Tushar Dave wrote: Fix bug introduced by 'commit 47994c119a36e ("i40e: remove hw_disabled_flags in favor of using separate flag bits")' that mistakenly wipes out pf->flags. Signed-off-by: Tushar Dave --- drivers/

Re: [PATCH] netpoll: Check for skb->queue_mapping

2017-04-20 Thread tndave
On 04/12/2017 03:37 PM, tndave wrote: On 04/06/2017 12:14 PM, Eric Dumazet wrote: On Thu, 2017-04-06 at 12:07 -0700, tndave wrote: +q_index = q_index % dev->real_num_tx_queues; cpu interrupted here and dev->real_num_tx_queues has reduced! +skb_set_queue_m

Re: [PATCH] netpoll: Check for skb->queue_mapping

2017-04-12 Thread tndave
On 04/06/2017 12:14 PM, Eric Dumazet wrote: On Thu, 2017-04-06 at 12:07 -0700, tndave wrote: + q_index = q_index % dev->real_num_tx_queues; cpu interrupted here and dev->real_num_tx_queues has reduced! + skb_set_queue_mapping(skb, q

Re: [PATCH] netpoll: Check for skb->queue_mapping

2017-04-06 Thread tndave
On 04/06/2017 03:26 AM, Eric Dumazet wrote: On Wed, 2017-04-05 at 19:06 -0700, Tushar Dave wrote: Reducing real_num_tx_queues needs to be in sync with skb queue_mapping otherwise skbs with queue_mapping greater than real_num_tx_queues can be sent to the underlying driver and can result in kern

Re: [PATCH] ixgbe: Check for skb->queue_mapping

2017-03-29 Thread tndave
On 03/29/2017 05:29 PM, Eric Dumazet wrote: On Wed, 2017-03-29 at 16:55 -0700, Tushar Dave wrote: There are events seen where skb->queue_mapping value is greater than adapter->num_tx_queue. In such cases, adapter->tx_ring becomes invalid (null) and xmit results in kernel panic. One such event

Re: [Intel-wired-lan] Question on ixgbe flow director

2017-03-08 Thread tndave
On 03/08/2017 01:03 PM, Alexander Duyck wrote: On Wed, Mar 8, 2017 at 11:30 AM, tndave wrote: On 03/08/2017 07:39 AM, Alexander Duyck wrote: On Tue, Mar 7, 2017 at 3:43 PM, tndave wrote: Hi, I have few questions regarding ixgbe flow director. As per my understanding flow director in

Re: [Intel-wired-lan] Question on ixgbe flow director

2017-03-08 Thread tndave
On 03/08/2017 07:39 AM, Alexander Duyck wrote: On Tue, Mar 7, 2017 at 3:43 PM, tndave wrote: Hi, I have few questions regarding ixgbe flow director. As per my understanding flow director in ixgbe can work in 2 exclusive ways, a. Using ATR filters - where flow director is setup in HW by

Question on ixgbe flow director

2017-03-07 Thread tndave
Hi, I have few questions regarding ixgbe flow director. As per my understanding flow director in ixgbe can work in 2 exclusive ways, a. Using ATR filters - where flow director is setup in HW by driver identifying transmit traffic. And based on that, receive traffic of the same flow get assigned/d

Re: [RFC PATCH 0/2] rx zero copy interface for af_packet

2017-01-31 Thread tndave
On 01/27/2017 01:33 PM, John Fastabend wrote: This is an experimental implementation of rx zero copy for af_packet. Its a bit rough and likely has errors but the plan is to clean it up over the next few months. And seeing I said I would post it in another thread a few days back here it is. T

Re: [RFC PATCH] i40e: enable PCIe relax ordering for SPARC

2016-12-28 Thread tndave
On 12/27/2016 04:40 PM, maowenan wrote: -Original Message- From: tndave [mailto:tushar.n.d...@oracle.com] Sent: Wednesday, December 28, 2016 6:28 AM To: maowenan; jeffrey.t.kirs...@intel.com; intel-wired-...@lists.osuosl.org Cc: netdev@vger.kernel.org; weiyongjun (A); Dingtianhong

Re: [RFC PATCH] i40e: enable PCIe relax ordering for SPARC

2016-12-27 Thread tndave
On 12/26/2016 03:39 AM, maowenan wrote: -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Tushar Dave Sent: Tuesday, December 06, 2016 1:07 AM To: jeffrey.t.kirs...@intel.com; intel-wired-...@lists.osuosl.org Cc: netdev@vger.kern

Re: [Intel-wired-lan] [RFC PATCH] i40e: enable PCIe relax ordering for SPARC

2016-12-08 Thread tndave
On 12/08/2016 04:45 PM, tndave wrote: On 12/08/2016 08:05 AM, Alexander Duyck wrote: On Thu, Dec 8, 2016 at 2:43 AM, David Laight wrote: From: Alexander Duyck Sent: 06 December 2016 17:10 ... I was thinking about it and I realized we can probably simplify this even further. In the

Re: [Intel-wired-lan] [RFC PATCH] i40e: enable PCIe relax ordering for SPARC

2016-12-08 Thread tndave
On 12/08/2016 08:05 AM, Alexander Duyck wrote: On Thu, Dec 8, 2016 at 2:43 AM, David Laight wrote: From: Alexander Duyck Sent: 06 December 2016 17:10 ... I was thinking about it and I realized we can probably simplify this even further. In the case of most other architectures the DMA_ATTR

Re: [Intel-wired-lan] [RFC PATCH] i40e: enable PCIe relax ordering for SPARC

2016-12-06 Thread tndave
On 12/06/2016 09:10 AM, Alexander Duyck wrote: On Mon, Dec 5, 2016 at 2:23 PM, tndave wrote: On 12/05/2016 01:54 PM, Alexander Duyck wrote: On Mon, Dec 5, 2016 at 9:07 AM, Tushar Dave wrote: Unlike previous generation NIC (e.g. ixgbe) i40e doesn't seem to have standard CSR where

Re: [Intel-wired-lan] [RFC PATCH] i40e: enable PCIe relax ordering for SPARC

2016-12-05 Thread tndave
On 12/05/2016 01:54 PM, Alexander Duyck wrote: On Mon, Dec 5, 2016 at 9:07 AM, Tushar Dave wrote: Unlike previous generation NIC (e.g. ixgbe) i40e doesn't seem to have standard CSR where PCIe relaxed ordering can be set. Without PCIe relax ordering enabled, i40e performance is significantly l

Re: [PATCH 0/2] net: Fix compiler warnings

2016-10-15 Thread tndave
On 10/15/2016 02:48 PM, David Miller wrote: From: Tushar Dave Date: Fri, 14 Oct 2016 17:06:04 -0700 Recently, ATU (iommu) changes are submitted to linux-sparc that enables 64bit DMA on SPARC. However, this change also makes 'incompatible pointer type' compiler warnings inevitable on sunqe an

Question on i40e PCIe relaxed ordering (RO)

2016-06-29 Thread tndave
Hi, Running iperf tcp test on 2 sparc systems with i40e connected back to back, I see huge number of 'port.rx_dropped' (on iperf server). Based on past experience with ixgbe, this could very well because of PCIe RO (relaxed ordering) not enabled. I am trying to confirm RO is enabled. i40e datash

i40e: Errors while turning off TSO

2016-05-16 Thread tndave
On systems with 128 CPUs, turning off TSO results in errors. Errors: i40e :03:00.0: failed to get tracking for 1 vectors for VSI 400, err=-12 i40e :03:00.0: Couldn't create FDir VSI i40e :03:00.0: i40e_ptp_init: PTP not supported on eth0 i40e :03:00.0: couldn't add VEB, err I40E_E

Re: i40e: Kernel unaligned access due to 'struct i40e_dma_mem' being 'packed'

2016-02-13 Thread tndave
On 01/30/2016 04:17 AM, tndave wrote: On 01/27/2016 10:56 PM, David Miller wrote: From: tndave Date: Wed, 27 Jan 2016 17:50:14 -0800 Hi, i40e driver has 'struct i40e_dma_mem' defined with 'packed' directive causing kernel unaligned errors on sparc (when 40e_allocate_

Re: i40e: Kernel unaligned access due to 'struct i40e_dma_mem' being 'packed'

2016-01-29 Thread tndave
On 01/27/2016 10:56 PM, David Miller wrote: From: tndave Date: Wed, 27 Jan 2016 17:50:14 -0800 Hi, i40e driver has 'struct i40e_dma_mem' defined with 'packed' directive causing kernel unaligned errors on sparc (when 40e_allocate_dma_mem_d() is being called) log_unali

i40e: Kernel unaligned access due to 'struct i40e_dma_mem' being 'packed'

2016-01-27 Thread tndave
Hi, i40e driver has 'struct i40e_dma_mem' defined with 'packed' directive causing kernel unaligned errors on sparc (when 40e_allocate_dma_mem_d() is being called) log_unaligned: 1031 callbacks suppressed Kernel unaligned access at TPC[448ae8] dma_4v_alloc_coherent+0x188/0x2e0 Kernel unaligned ac