On 7/30/20 12:20 PM, Peilin Ye wrote:
rds_notify_queue_get() is potentially copying uninitialized kernel stack
memory to userspace since the compiler may leave a 4-byte hole at the end
of `cmsg`.
In 2016 we tried to fix this issue by doing `= { 0 };` on `cmsg`, which
unfortunately does not alway
On 7/25/20 12:57 AM, Arnd Bergmann wrote:
On Fri, Jul 24, 2020 at 11:57 PM santosh.shilim...@oracle.com
wrote:
On 7/24/20 2:42 PM, Grygorii Strashko wrote:
Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
KSZ9031 PHY") the networking is broken on keysto
Hi Arnd, Olof,
On 7/24/20 2:42 PM, Grygorii Strashko wrote:
Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the
KSZ9031 PHY") the networking is broken on keystone-k2g-evm board.
The above board have phy-mode = "rgmii-id" and it is worked before because
KSZ9031 PHY started
On 6/1/19 12:54 AM, Zhu Yanjun wrote:
The variable cache_allocs is to indicate how many frags (KiB) are in one
rds connection frag cache.
The command "rds-info -Iv" will output the rds connection cache
statistics as below:
"
RDS IB Connections:
LocalAddr RemoteAddr Tos SL LocalDev
On 5/10/19 11:07 AM, Jason Gunthorpe wrote:
On Fri, May 10, 2019 at 11:02:35AM -0700, santosh.shilim...@oracle.com wrote:
On 5/10/19 10:55 AM, Jason Gunthorpe wrote:
On Fri, May 10, 2019 at 09:11:24AM -0700, Santosh Shilimkar wrote:
On 5/10/2019 5:54 AM, Jason Gunthorpe wrote:
On Mon, Apr
On 5/10/19 10:55 AM, Jason Gunthorpe wrote:
On Fri, May 10, 2019 at 09:11:24AM -0700, Santosh Shilimkar wrote:
On 5/10/2019 5:54 AM, Jason Gunthorpe wrote:
On Mon, Apr 29, 2019 at 04:37:19PM -0700, Santosh Shilimkar wrote:
From: Hans Westgaard Ry
RDS doesn't support RDMA on memory apertur
On 4/29/19 3:25 PM, David Miller wrote:
From: Santosh Shilimkar
Date: Thu, 25 Apr 2019 17:44:29 -0700
@@ -158,8 +158,9 @@ static int rds_pin_pages(unsigned long user_addr, unsigned
int nr_pages,
{
int ret;
- ret = get_user_pages_fast(user_addr, nr_pages, write, pages);
-
+
On 11/6/18 4:52 PM, Gerd Rausch wrote:
This reverts commit 56012459310a1dbcc55c2dbf5500a9f7571402cb.
Subject: rds_ib_post_reg_frmr spins and spins and spins
RDS kept spinning inside function "rds_ib_post_reg_frmr", waiting for
"i_fastreg_wrs" to become incremented:
while (atomic_dec_re
On 3/7/19 2:01 PM, Gerd Rausch wrote:
The proper "tos" value needs to be returned
to user-space (sockopt RDS_INFO_CONNECTIONS).
Fixes: 3eb450367d08 ("rds: add type of service(tos) infrastructure")
Signed-off-by: Gerd Rausch
---
net/rds/connection.c | 1 +
1 file changed, 1 insertion(+)
diff
On 9/11/18 12:38 PM, Tushar Dave wrote:
RDS module sits on top of TCP (rds_tcp) and IB (rds_rdma), so messages
arrive in form of skb (over TCP) and scatterlist (over IB/RDMA).
However, because socket filter only deal with skb (e.g. struct skb as
bpf context) we can only use socket filter for rds_
On 8/25/18 12:19 AM, Zhu Yanjun wrote:
In IPv4, the newly introduced rdma_read_gids is used to read the SGID/DGID
for the connection which returns GID correctly for RoCE transport as well.
In IPv6, rdma_read_gids is also used. The following are why rdma_read_gids
is introduced.
rdma_addr_get_dg
On 7/23/18 8:51 PM, Ka-Cheong Poon wrote:
This patch enables RDS to use IPv6 addresses. For RDS/TCP, the
listener is now an IPv6 endpoint which accepts both IPv4 and IPv6
connection requests. RDS/RDMA/IB uses a private data (struct
rds_ib_connect_private) exchange between endpoints at RDS connec
On 7/23/18 8:51 PM, Ka-Cheong Poon wrote:
There are many data structures (RDS socket options) used by RDS apps
which use a 32 bit integer to store IP address. To support IPv6,
struct in6_addr needs to be used. To ensure backward compatibility, a
new data structure is introduced for each of those
On 7/23/18 8:51 PM, Ka-Cheong Poon wrote:
This patch changes the internal representation of an IP address to use
struct in6_addr. IPv4 address is stored as an IPv4 mapped address.
All the functions which take an IP address as argument are also
changed to use struct in6_addr. But RDS socket laye
On 7/6/18 2:08 AM, Ka-Cheong Poon wrote:
On 07/06/2018 01:58 AM, Santosh Shilimkar wrote:
diff --git a/net/rds/connection.c b/net/rds/connection.c
index abef75d..ca72563 100644
--- a/net/rds/connection.c
+++ b/net/rds/connection.c
@@ -142,9 +151,12 @@ static void __rds_conn_path_init(stru
On 5/13/18 2:10 PM, Eric Biggers wrote:
On Wed, Mar 21, 2018 at 09:00:01AM -0700, syzbot wrote:
[...]
Still reproducible on Linus' tree (commit 66e1c94db3cd4) and linux-next
(next-20180511). Here's a simplified reproducer:
Thanks for the test case !!
Regards,
Santosh
On 4/23/18 6:39 PM, Zhu Yanjun wrote:
This reverts commit 3b12f73a5c2977153f28a224392fd4729b50d1dc.
After long time discussion and investigations, it seems that there
is no mem leak. So this patch is reverted.
Signed-off-by: Zhu Yanjun
---
Well your fix was not for any leaks but just proper l
On 4/11/18 12:57 AM, Ka-Cheong Poon wrote:
rds_sendmsg() calls rds_send_mprds_hash() to find a c_path to use to
send a message. Suppose the RDS connection is not yet up. In
rds_send_mprds_hash(), it does
if (conn->c_npaths == 0)
wait_event_interruptible(conn->c_hs_waitq
On 3/11/18 2:07 PM, Salvatore Mesoraca wrote:
Avoid VLA[1] by using an already allocated buffer passed
by the caller.
[1] https://lkml.org/lkml/2018/3/7/621
Signed-off-by: Salvatore Mesoraca
---
Acked-by: Santosh Shilimkar
On 3/11/18 2:07 PM, Salvatore Mesoraca wrote:
Avoid VLA[1] by using an already allocated buffer passed
by the caller.
[1] https://lkml.org/lkml/2018/3/7/621
Signed-off-by: Salvatore Mesoraca
---
Thanks for both VLA fixes Salvatore.
FWIW, Acked-by: Santosh Shilimkar
On 3/11/18 11:54 PM, santosh.shilim...@oracle.com wrote:
On 3/11/18 10:03 AM, Colin King wrote:
From: Colin Ian King
Functions rds_info_from_znotifier and rds_message_zcopy_from_user are
local to the source and do not need to be in global scope, so make them
static.
Cleans up sparse warnins
On 3/11/18 10:03 AM, Colin King wrote:
From: Colin Ian King
Functions rds_info_from_znotifier and rds_message_zcopy_from_user are
local to the source and do not need to be in global scope, so make them
static.
Cleans up sparse warnins:
net/rds/message.c:70:27: warning: symbol 'rds_info_from_zn
On 3/11/18 9:27 AM, Colin King wrote:
From: Colin Ian King
Variable sg_off is assigned a value but it is never read, hence it is
redundant and can be removed.
Cleans up clang warning:
net/rds/message.c:373:2: warning: Value stored to 'sg_off' is never read
Signed-off-by: Colin Ian King
---
On 3/1/18 9:07 PM, Ka-Cheong Poon wrote:
Commit 0933a578cd55 ("rds: tcp: use sock_create_lite() to create the
accept socket") has a reference counting issue in TCP socket creation
when accepting a new connection. The code uses sock_create_lite() to
create a kernel socket. But it does not do _
On 1/30/18 2:28 PM, Eric Biggers wrote:
On Mon, Dec 18, 2017 at 06:01:30PM +0100, 'Dmitry Vyukov' via syzkaller-bugs
wrote:
On Mon, Dec 18, 2017 at 5:46 PM, Santosh Shilimkar
wrote:
On 12/18/2017 4:36 AM, syzbot wrote:
Hello,
syzkaller hit the following crash on
6084b576dca2e898f5c101bae
On 12/31/17 4:33 AM, Sowmini Varadhan wrote:
On (12/30/17 21:09), santosh.shilim...@oracle.com wrote:
Right. This was loop transport in action so xmit will just flip
the direction with receive. And rds_recv_incoming() can race with
socket_release. rds_find_bound() is suppose to add ref count on
On 12/30/17 2:32 PM, Sowmini Varadhan wrote:
On (12/30/17 13:37), santosh.shilim...@oracle.com wrote:
[...]
Thats what I thought as well initially but since the reported case,
the rs seems to be valid where as sk seems to be freed up as part of
sock_release callback.
I dont understand the
On 12/30/17 12:26 PM, Sowmini Varadhan wrote:
On (12/30/17 11:36), Santosh Shilimkar wrote:
socket buffer can get freed as part of sock_close
callback so before adding reference check underneath
socket validity.
I'm not sure I understand this fix-
struct rds_sock is:
struct rds_sock {
On 12/30/17 1:17 AM, syzbot wrote:
Hello,
syzkaller hit the following crash on
fba961ab29e5ffb055592442808bb0f7962e05da
git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master
compiler: gcc (GCC) 7.1.1 20170620
.config is attached
Raw console output is attached.
Unfortunately,
On 12/21/17 8:17 PM, Avinash Repaka wrote:
RDS currently doesn't check if the length of the control message is
large enough to hold the required data, before dereferencing the control
message data. This results in following crash:
BUG: KASAN: stack-out-of-bounds in rds_rdma_bytes net/rds/send.c:
On 12/16/17 10:24 AM, Joe Perches wrote:
On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote:
On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang wrote:
+# Code simplification:
+#
+except ALLOC_WITH_MULTIPLY ib.c
+except PREFER_PR_LEVEL ib_cm.c ib_recv.c ib_send.c rdma_transport.c threads.c
On 8/30/17 4:49 AM, Arvind Yadav wrote:
rhashtable_params are not supposed to change at runtime. All
Functions rhashtable_* working with const rhashtable_params
provided by . So mark the non-const structs
as const.
Signed-off-by: Arvind Yadav
---
This is already addressed in net-next by [1]
R
On 8/7/17 2:31 PM, Franklin S Cooper Jr wrote:
Hi Santosh,
On 08/04/2017 12:07 PM, Santosh Shilimkar wrote:
Hi Franklin,
On 8/2/2017 1:18 PM, Franklin S Cooper Jr wrote:
Add D CAN nodes to 66AK2G based SoC dtsi.
Franklin S Cooper Jr (2):
dt-bindings: net: c_can: Update binding for clock
On 6/14/17 3:39 AM, Dan Carpenter wrote:
We accidentally return ERR_PTR(0) if ib_alloc_mr() fails. The caller
is expecting error pointers so it results in a NULL dereference.
Fixes: 1659185fb4d0 ("RDS: IB: Support Fastreg MR (FRMR) memory registration
mode")
Signed-off-by: Dan Carpenter
Tha
On 3/31/17 3:56 PM, Sowmini Varadhan wrote:
The rds_connect_worker() has a bug in the check that enforces the
canonical connection order described in the comments of
rds_tcp_state_change(). The intention is to make sure that all
the multipath connections are always initiated by the smaller IP
add
On 3/31/17 3:56 PM, Sowmini Varadhan wrote:
rds_conn_shutdown() runs in workq context, and marks the rds_connection
as DISCONNECTING before quiescing Tx/Rx paths. However, after all I/O
has quiesced, we may still find the rds_connection state to be
RDS_CONN_ERROR if an intervening FIN was process
On 3/12/17 12:33 PM, Leon Romanovsky wrote:
On Sun, Mar 12, 2017 at 04:07:55AM -0400, Zhu Yanjun wrote:
When rdma_accept fails, rdma_reject is called in it. As such, it is
not necessary to execute rdma_reject again.
Cc: Joe Jin
Cc: Junxiao Bi
Acked-by: Santosh Shilimkar
Signed-off-by: Zhu Ya
On 3/11/17 6:33 PM, Yanjun Zhu wrote:
Sorry. I have no test case to show some issue.
But from Linux Kernel Development Second Edition by Robert Love.
Yes I know the book and what the API does :D
Use spin_lock_irq is dangerous since spin_unlock_irq unconditionally
enables interrupts.
We can a
On 3/4/17 8:57 AM, Sowmini Varadhan wrote:
Dmitry Vyukov reported some syszkaller panics during netns deletion.
While I have not been able to reproduce those exact panics, my attempts
to do so uncovered a few other problems, which are fixed patch 2 and
patch 3 of this patch series. In addition,
On 2/24/17 11:12 AM, David Miller wrote:
From: Santosh Shilimkar
Date: Fri, 24 Feb 2017 08:49:19 -0800
On 2/24/2017 1:28 AM, Zhu Yanjun wrote:
When the function register_netdevice_notifier fails, the memory
allocated by kmem_cache_create should be freed by the function
kmem_cache_destroy.
Cc
On 2/21/17 6:29 AM, David Laight wrote:
The entire file should use the proper "__uX" kernel types
rather than the uint* ones.
The uint* ones are part of the C standard :-)
Should have been uint*_t :-)
On 2/20/17 7:18 PM, David Miller wrote:
From: Santosh Shilimkar
Date: Mon, 20 Feb 2017 14:16:53 -0800
Use "__uX/__sX" kernel types rather than current uint*/int* for
entire file.
Reviewed-by: Sowmini Varadhan
Signed-off-by: Santosh Shilimkar
---
v1->v2:
As suggested by David Miller, cleaned
On 1/10/17 4:56 PM, Bart Van Assche wrote:
Signed-off-by: Bart Van Assche
Acked-by: Santosh Shilimkar
On 9/4/16 11:23 AM, Leon Romanovsky wrote:
On Sun, Sep 04, 2016 at 05:57:20PM +0200, Christophe JAILLET wrote:
Le 04/09/2016 à 14:20, Leon Romanovsky a écrit :
On Sat, Sep 03, 2016 at 07:33:29AM +0200, Christophe JAILLET wrote:
Calling 'list_splice' followed by 'INIT_LIST_HEAD' is equivalent t
On 6/18/16 8:46 AM, Joshua Houghton wrote:
Fix coding style issues in the following files:
ib_cm.c: add space
loop.c: convert spaces to tabs
sysctl.c: add space
tcp.h:convert spaces to tabs
tcp_connect.c:remove extra indentation in switch statement
tcp_recv.c: convert sp
On 4/13/16 8:36 PM, David Miller wrote:
From: Santosh Shilimkar
Date: Fri, 8 Apr 2016 15:26:38 -0700
Patches are also available at below git tree.
git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux.git
for_4.6/net-next/rds-fixes
"Bug fixes for 4.6" do not get targetted at the ne
On 4/3/16 5:29 AM, Shamir Rabinovitch wrote:
On Thu, Mar 31, 2016 at 04:02:46PM -0400, David Miller wrote:
From: shamir rabinovitch
Date: Thu, 31 Mar 2016 02:29:22 -0400
Issue can be seen on platforms that use 8K and above page size
while rds fragment size is 4K. On those platforms single pag
On 4/1/16 6:14 PM, Leon Romanovsky wrote:
On Fri, Apr 01, 2016 at 12:47:24PM -0700, santosh shilimkar wrote:
(cc-ing netdev)
On 3/30/2016 7:59 PM, Wengang Wang wrote:
在 2016年03月31日 09:51, Wengang Wang 写道:
在 2016年03月31日 01:16, santosh shilimkar 写道:
Hi Wengang,
On 3/30/2016 9:19 AM, Leon
Hi Shamir,
Nice to see this one soon on the list,
Just to make $subject more relevant. How about below?
RDS: fix congestion map corruption for PAGE_SIZE > 8k
On 3/30/16 5:50 PM, shamir rabinovitch wrote:
Issue can be seen on platforms that use 8K and above page size
while rds fragment size is
On 2/28/16 11:51 AM, Or Gerlitz wrote:
On Sun, Feb 28, 2016 at 4:19 AM, Santosh Shilimkar
wrote:
RDS iWarp support code has become stale and non testable. As
indicated earlier, am dropping the support for it.
If new iWarp user(s) shows up in future, we can adapat the RDS IB
transprt for the sp
On 2/28/16 1:08 AM, Christoph Hellwig wrote:
On Sat, Feb 27, 2016 at 06:19:48PM -0800, Santosh Shilimkar wrote:
Discovere Fast Memmory Registration support using IB device
IB_DEVICE_MEM_MGT_EXTENSIONS. Certain HCA might support just FRMR
or FMR or both FMR and FRWR. In case both mr type are sup
On 2/28/16 1:05 AM, Christoph Hellwig wrote:
On Sat, Feb 27, 2016 at 06:19:38PM -0800, Santosh Shilimkar wrote:
RDS iWarp support code has become stale and non testable. As
indicated earlier, am dropping the support for it.
If new iWarp user(s) shows up in future, we can adapat the RDS IB
tra
Hi Dave,
On 2/26/16 9:43 PM, Santosh Shilimkar wrote:
Series is generated against net-next but also applies against Linus's tip
cleanly. The diff-stat looks bit scary since almost ~4K lines of code is
getting removed.
[...]
Entire patchset is available below git tree:
git://git.ker
Hi Sebastian,
On 11/27/15 8:00 AM, Sebastian Andrzej Siewior wrote:
It looks like an attempt to use CPU notifier here which was never
completed. Nobody tried to wire it up completely since 2k9. So I unwind
this code and get rid of everything not required. Oh look! 19 lines were
removed while cod
On 10/14/15 2:15 PM, Santosh Shilimkar wrote:
From: Santosh Shilimkar
To further improve the RDS connection scalabilty on massive systems
where number of sockets grows into tens of thousands of sockets, there
is a need of larger bind hashtable. Pre-allocated 8K or 16K table is
not very flexibl
On 10/11/15 1:49 PM, Sowmini Varadhan wrote:
Consider the following "duelling syn" sequence between two peers A and B:
A B
SYN1 -->
<-- SYN2
SYN2ACK -->
Note that the SYN/ACK has already been sent out by
On 10/11/15 1:46 PM, Sowmini Varadhan wrote:
The IP address passed to rds_bind() should be vetted by the
transport's ->laddr_check() for a previously bound transport.
This needs to be done to avoid cases where, for example,
the application has asked for an IB transport,
but the IP address passed
On 10/7/15 2:16 AM, David Miller wrote:
From: Santosh Shilimkar
Date: Mon, 5 Oct 2015 10:56:23 -0700
[v3]
Updated patch "[PATCH v2 05/14] RDS: defer the over_batch work to
send worker" as per David Miller's comment [4] to avoid the magic
value usage. Patch now makes use of already available b
On 10/1/15 9:19 AM, David Laight wrote:
From: Santosh Shilimkar
Sent: 30 September 2015 18:24
...
This is being addressed by simply using per bucket rw lock which makes the
locking simple and very efficient. The hash table size is still an issue and
I plan to address it by using re-sizable has
On 9/4/15 12:44 PM, Sasha Levin wrote:
On 09/04/2015 01:32 PM, santosh shilimkar wrote:
Sasha,
On 9/4/2015 9:43 AM, Sasha Levin wrote:
There was no verification that an underlying transport exists when creating
a connection, this would cause dereferencing a NULL ptr.
Signed-off-by: Sasha Lev
On 9/3/15 1:24 PM, Sowmini Varadhan wrote:
Only return a conn if the rds_conn_net(conn) matches the struct
net passed to rds_conn_lookup().
Fixes: 467fa15356ac ("RDS-TCP: Support multiple RDS-TCP listen endpoints,
one per netns.")
Signed-off-by: Sowmini Varadhan
---
Acked-by: Santos
On 8/25/15 3:55 PM, David Miller wrote:
From: kbuild test robot
Date: Wed, 26 Aug 2015 06:42:39 +0800
sparse warnings: (new ones prefixed by >>)
net/rds/ib_recv.c:382:28: sparse: incorrect type in initializer (different base
types)
net/rds/ib_recv.c:382:28:expected int [signed] can
62 matches
Mail list logo
