witch-statement (aad2eeaf4 "bpf: Simplify ptr_min_max_vals adjustment").
Move the check to the proper location in adjust_ptr_min_max_vals().
Fixes: 17efa65350c5a ("bpf: restrict unknown scalars of mixed signed bounds for
unprivileged")
Signed-off-by: Samuel Mendoza-Jonas
Reviewed
The Ethernet MAC and PHY are usually major consumers of power on boards
which may not be able to fully power off (those with no PMIC). Powering
down the MAC and internal PHY saves power while these boards are "off".
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Samuel Holland
---
d
This is a deinitialization function that always returned zero, and that
return value was always ignored. Have it return void instead.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 5 ++---
1 file changed, 2 insertions(+), 3
Use the appropriate function instead of reimplementing it,
and update the error message to match the code.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a
in patch 3
Samuel Holland (5):
net: stmmac: dwmac-sun8i: Return void from PHY unpower
net: stmmac: dwmac-sun8i: Remove unnecessary PHY power check
net: stmmac: dwmac-sun8i: Use reset_control_reset
net: stmmac: dwmac-sun8i: Minor probe function cleanup
net: stmmac: dwmac-sun8i: Add a
Adjust the spacing and use an explicit "return 0" in the success path
to make the function easier to parse.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
di
sun8i_dwmac_unpower_internal_phy already checks if the PHY is powered,
so there is no need to do it again here.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
On 2/8/21 10:29 AM, Alexander Duyck wrote:
> On Sun, Feb 7, 2021 at 10:32 PM Samuel Holland wrote:
>>
>> Use the appropriate function instead of reimplementing it,
>> and update the error message to match the code.
>>
>> Reviewed-by: Chen-Yu Tsai
On 2/8/21 7:20 AM, Andrew Lunn wrote:
> On Mon, Feb 08, 2021 at 12:31:34AM -0600, Samuel Holland wrote:
>> On 2/8/21 12:28 AM, Samuel Holland wrote:
>>> In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error
>>> pointers to optional clocks
On 2/8/21 12:28 AM, Samuel Holland wrote:
> In commit e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support"), error
> pointers to optional clocks were replaced by NULL to simplify the resume
> callback implementation. However, that commit missed that the IS_ERR
> check in mv
The Ethernet MAC and PHY are usually major consumers of power on boards
which may not be able to fully power off (those with no PMIC). Powering
down the MAC and internal PHY saves power while these boards are "off".
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Samuel Holland
---
d
Adjust the spacing and use an explicit "return 0" in the success path
to make the function easier to parse.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
di
op of net-next and with Chen-Yu's Reviewed-by tags.
Samuel Holland (5):
net: stmmac: dwmac-sun8i: Return void from PHY unpower
net: stmmac: dwmac-sun8i: Remove unnecessary PHY power check
net: stmmac: dwmac-sun8i: Use reset_control_reset
net: stmmac: dwmac-sun8i: Minor probe functi
sun8i_dwmac_unpower_internal_phy already checks if the PHY is powered,
so there is no need to do it again here.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git
This is a deinitialization function that always returned zero, and that
return value was always ignored. Have it return void instead.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 5 ++---
1 file changed, 2 insertions(+), 3
Use the appropriate function instead of reimplementing it,
and update the error message to match the code.
Reviewed-by: Chen-Yu Tsai
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a
esult, the check always passes, even for an invalid device tree.
Fixes: e5c02cf54154 ("i2c: mv64xxx: Add runtime PM support")
Reported-by: Dan Carpenter
Signed-off-by: Samuel Holland
---
drivers/i2c/busses/i2c-mv64xxx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dr
This is a deinitialization function that always returned zero, and that
return value was always ignored. Have it return void instead.
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a
The Ethernet MAC and PHY are usually major consumers of power on boards
which may not be able to fully power off (that have no PMIC). Powering
down the MAC and internal PHY saves power while these boards are "off".
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/st
These patches clean up some things I noticed while fixing suspend/resume
behavior. The first four are minor code improvements. The last one adds
a shutdown hook to minimize power consumption on boards without a PMIC.
Samuel Holland (5):
net: stmmac: dwmac-sun8i: Return void from PHY unpower
Use the appropriate function instead of reimplementing it,
and update the error message to match the code.
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/stmicro
Adjust the spacing and use an explicit "return 0" in the success path
to make the function easier to parse.
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethern
sun8i_dwmac_unpower_internal_phy already checks if the PHY is powered,
so there is no need to do it again here.
Signed-off-by: Samuel Holland
---
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet
t;net: stmmac: dwmac-sun8i: Handle integrated/external
MDIOs")
Signed-off-by: Samuel Holland
---
.../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 31 ++-
1 file changed, 23 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
b/drivers/ne
n in
exit path")
Signed-off-by: Samuel Holland
---
.../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 25 +++
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
b/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.
handling and driver removal.
Samuel Holland (4):
net: stmmac: dwmac-sun8i: Fix probe error handling
net: stmmac: dwmac-sun8i: Balance internal PHY resource references
net: stmmac: dwmac-sun8i: Balance internal PHY power
net: stmmac: dwmac-sun8i: Balance syscon (de)initialization
.../net
requires
changing the sun8i_dwmac_set_syscon parameters to priv's two relevant
members.
Fixes: 9f93ac8d4085 ("net-next: stmmac: Add dwmac-sun8i")
Fixes: 634db83b8265 ("net: stmmac: dwmac-sun8i: Handle integrated/external
MDIOs")
Signed-off-by: Samuel Holland
---
.../ne
("net: stmmac: dwmac-sun8i: Handle integrated/external
MDIOs")
Signed-off-by: Samuel Holland
---
.../net/ethernet/stmicro/stmmac/dwmac-sun8i.c | 27 ++-
1 file changed, 21 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c
b/drive
On Tue, 2020-12-22 at 06:13 +, Joel Stanley wrote:
> On Sun, 20 Dec 2020 at 12:40, John Wang <
> wangzhiqiang...@bytedance.com> wrote:
> >
> > When aggregating ncsi interfaces and dedicated interfaces to bond
> > interfaces, the ncsi response handler will use the wrong net device
> > to
> > fi
ok, I will add the Fixes line and send the v2 soon.
-邮件原件-
发件人: Leon Romanovsky [mailto:l...@kernel.org]
发送时间: 2020年12月9日 14:21
收件人: Jakub Kicinski
抄送: Zouwei (Samuel) ; sae...@nvidia.com;
da...@davemloft.net; netdev@vger.kernel.org; linux-r...@vger.kernel.org;
linux-ker
On Thu, 2020-11-12 at 16:42 +1030, Joel Stanley wrote:
> If a user unbinds and re-binds a NC-SI aware driver the kernel will
> attempt to register the netlink interface at runtime. The structure
> is
> marked __ro_after_init so registration fails spectacularly at this
> point.
Revi
_INTERFACE_MODE_RGMII.
Documentation/networking/phy.rst also makes this clear:
PHY_INTERFACE_MODE_RGMII: the PHY is not responsible for inserting any internal
delay by itself, it assumes that either the Ethernet MAC (if capable or the PCB
traces) insert the correct 1.5-2ns delay
Regards,
Samuel
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/dsa/sja1105/sja1105_vl.c:468:6: warning: variable ‘prev_time’ set
but not used [-Wunused-but-set-variable]
u32 prev_time = 0;
^
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/net/d
Both of you are right.
I neglected, and this patch is wrong.
Thanks.
On 2020/5/6 23:15, Joe Perches wrote:
On Wed, 2020-05-06 at 16:51 +0300, Luciano Coelho wrote:
On Tue, 2020-05-05 at 20:19 -0700, Joe Perches wrote:
On Wed, 2020-05-06 at 11:07 +0800, Samuel Zou wrote:
This silences the
Fix the following sparse warning:
drivers/net/ethernet/mediatek/mtk_eth_soc.c:68:5: warning:
symbol 'mtk_m32' was not declared. Should it be static?
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/net/ethernet/mediatek/mtk_eth_soc.c | 2 +-
1 file changed, 1 inser
This silences the following coccinelle warning:
"WARNING: sum of probable bitmasks, consider |"
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ne
Fixes coccicheck warning:
drivers/net/ethernet/ti/am65-cpts.c:1017:1-3: WARNING: PTR_ERR_OR_ZERO can be
used
Reported-by: Hulk Robot
Signed-off-by: Samuel Zou
---
drivers/net/ethernet/ti/am65-cpts.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet
On 2020/4/30 2:43, David Miller wrote:
From: Zou Wei
Date: Wed, 29 Apr 2020 12:17:40 +0800
fix coccinelle warning, use ARRAY_SIZE
drivers/net/ethernet/huawei/hinic/hinic_sriov.c:713:43-44: WARNING: Use
ARRAY_SIZE
--
Please don't put this "---" here.
diff --git a/drivers/n
Hi Joe,
Thanks for your comments, I will modify and send the v2
On 2020/4/29 11:23, Joe Perches wrote:
On Wed, 2020-04-29 at 11:15 +0800, Zou Wei wrote:
fix coccinelle warning, use ARRAY_SIZE
drivers/net/ethernet/huawei/hinic/hinic_sriov.c:713:43-44: WARNING: Use
ARRAY_SIZE
Reported-by: Hulk
Hi Johannes,
On Tue, May 14, 2019 at 11:02:31AM +0200, Johannes Berg wrote:
> Samuel clearly hasn't been working on this in many years and
> patches getting to the wireless list are just being ignored
> entirely now. Mark the subsystem as orphan to reflect the
> current state a
ut ()
> -> Netlink interface (msg with zero data length)
> -> user space application
>
> Error:
> Error detected
> -> ncsi_send_netlink_err ()
> -> Netlink interface (err msg)
> -> user space application
>
>
> Signed-off-by: Justin Lee
>
Reviewed-by: Samuel Mendoza-Jonas
On Wed, 2018-10-10 at 22:36 +, justin.l...@dell.com wrote:
> Hi Samuel,
>
> I am still testing your change and have some comments below.
>
> Thanks,
> Justin
>
>
> > This patch extends the ncsi-netlink interface with two new commands and
> > three
On Wed, 2018-10-10 at 18:11 +, justin.l...@dell.com wrote:
> +
> + len = nla_len(info->attrs[NCSI_ATTR_DATA]);
> + if (len < sizeof(struct ncsi_pkt_hdr)) {
> + netdev_info(ndp->ndev.dev, "NCSI: no command to send %u\n",
> + package_id);
> +
ut ()
> -> Netlink interface (msg with zero data length)
> -> user space application
>
> Error:
> Error detected
> -> ncsi_send_netlink_err ()
> -> Netlink interface (err msg)
> -> user space application
Hi Justin,
I've built
handler for OEM
> commands
> ncsi_rsp_handler_oem: This is a generic response handler for OEM commands
>
> Signed-off-by: Vijay Khemka
Reviewed-by: Samuel Mendoza-Jonas
Technically this patch should also be marked [PATCH net-next] to target
David's next tree.
> ---
> net/ncsi/
On Fri, 2018-09-28 at 18:15 +, justin.l...@dell.com wrote:
> The new command (NCSI_CMD_SEND_CMD) is added to allow user space application
> to send NC-SI command to the network card.
> Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and
> response.
>
> The work flow is as
handler for OEM
> commands
> ncsi_rsp_handler_oem: This is a generic response handler for OEM commands
>
> Signed-off-by: Vijay Khemka
Hi Vijay - looks good to me, and should be a good common base for your
and Justin's changes.
Reviewed-by: Samuel Mendoza-Jonas
> ---
> net
On Thu, 2018-09-27 at 21:08 +, justin.l...@dell.com wrote:
> The new command (NCSI_CMD_SEND_CMD) is added to allow user space application
> to send NC-SI command to the network card.
> Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and
> response.
>
> The work flow is as
On Thu, 2018-09-27 at 13:43 +1000, Samuel Mendoza-Jonas wrote:
> On Mon, 2018-09-24 at 17:08 -0700, Vijay Khemka wrote:
> > This patch adds OEM command to get mac address from NCSI device and and
> > configure the same to the network card.
> >
> > ncsi_cmd_arg - Modifie
re committing
to any one path
Justin - could you weigh in here and give a description of your intended
changes? Are you able to post your changes upstream so we can compare?
Regards,
Samuel
>
> On 9/24/18, 5:30 PM, "Joel Stanley" wrote:
>
> Hi Vijay,
>
>
On Mon, 2018-06-18 at 16:49 +0930, Joel Stanley wrote:
> Sam has been handing the maintenance of NCSI for a number release cycles
> now.
>
> Signed-off-by: Joel Stanley
I'm exposed!
Acked-by: Samuel Mendoza-Jonas
> ---
> MAINTAINERS | 5 +
> 1 file changed,
; DEBUG is set or this specific netdev_dbg is enabled
> via the dynamic debug control file.
Right this is fine for these sort of messages; very noisy and not particularly
critical.
For this and the other logging updates:
Acked-by: Samuel Mendoza-Jonas
>
> > Signed-off-by: Joel Stanley
5.265639]
==
Reported-by: Joel Stanley
Signed-off-by: Samuel Mendoza-Jonas
---
net/ncsi/internal.h | 34 +++---
net/ncsi/ncsi-manage.c | 226 +---
net/ncsi/ncsi-netlink.c | 20 ++--
net/ncsi/ncsi-rsp.c | 178 +--
4 files
5.265639]
==
Reported-by: Joel Stanley
Signed-off-by: Samuel Mendoza-Jonas
---
net/ncsi/internal.h | 34 +++---
net/ncsi/ncsi-manage.c | 226 +---
net/ncsi/ncsi-netlink.c | 20 ++--
net/ncsi/ncsi-rsp.c | 178 +--
4 files
NCSI_CMD_CLEAR_INTERFACE which clears any preferred setting.
Signed-off-by: Samuel Mendoza-Jonas
---
v2: Add a separate NCSI_CMD_CLEAR_INTERFACE command instead of allowing
missing attributes in NCSI_CMD_SET_INTERFACE.
include/uapi/linux/ncsi.h | 115 +
net/ncsi/Makefile | 2 +-
net/ncsi
On Mon, 2018-02-26 at 11:31 -0500, David Miller wrote:
> From: Samuel Mendoza-Jonas
> Date: Fri, 23 Feb 2018 15:15:18 +1100
>
> > + * @NCSI_CMD_SET_INTERFACE: set preferred package and channel combination.
> > + * Requires NCSI_ATTR_IFINDEX and the preferred NCS
: Samuel Mendoza-Jonas
---
include/uapi/linux/ncsi.h | 113 +
net/ncsi/Makefile | 2 +-
net/ncsi/internal.h | 3 +
net/ncsi/ncsi-manage.c| 30 +++-
net/ncsi/ncsi-netlink.c | 394 ++
net/ncsi/ncsi-netlink.h | 20 +++
6
On Thu, 2018-02-15 at 14:50 +1030, Joel Stanley wrote:
> Hey Sam,
>
> On Thu, Feb 15, 2018 at 2:00 PM, Samuel Mendoza-Jonas
> wrote:
> > Add a generic netlink family for NCSI. This supports two commands;
> > NCSI_CMD_PKG_INFO which returns information on packages
.
Signed-off-by: Samuel Mendoza-Jonas
---
net/ncsi/ncsi-aen.c | 35 +++
1 file changed, 3 insertions(+), 32 deletions(-)
diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c
index 67e708e98ccf..e7b05de1e6d1 100644
--- a/net/ncsi/ncsi-aen.c
+++ b/net/ncsi/ncsi-aen.c
Hi David,
This is the NFC pull request for 4.15. We have:
- A new netlink command for explicitly deactivating NFC targets
- i2c constification for all NFC drivers
- One NFC device allocation error path fix
The following changes since commit 2798b80b385384d51a81832556ee9ad25d175f9b:
Merge bran
ously.
Signed-off-by: Samuel Mendoza-Jonas
---
net/ncsi/ncsi-rsp.c | 31 ++-
1 file changed, 14 insertions(+), 17 deletions(-)
diff --git a/net/ncsi/ncsi-rsp.c b/net/ncsi/ncsi-rsp.c
index 58186c4102f0..efd933ff5570 100644
--- a/net/ncsi/ncsi-rsp.c
+++ b/net/ncsi/ncsi-
The NCSI driver is mostly silent which becomes a headache when trying to
determine what has occurred on the NCSI connection. This adds additional
logging in a few key areas such as state transitions and calling out
certain errors more visibly.
Signed-off-by: Samuel Mendoza-Jonas
---
net/ncsi
be backported along with it.
>
> Fixes: 20777bc57c34 ("NFC: fix broken device allocation")
> Cc: stable# 3.8
> Reported-by: Dan Carpenter
> Signed-off-by: Johan Hovold
> ---
> net/nfc/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks for the fix.
Cheers,
Samuel.
Correct the value of the HNCDSC AEN packet.
Fixes: 7a82ecf4cfb85 "net/ncsi: NCSI AEN packet handler"
Signed-off-by: Samuel Mendoza-Jonas
---
net/ncsi/ncsi-aen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ncsi/ncsi-aen.c b/net/ncsi/ncsi-aen.c
index 68
ff-by: Samuel Mendoza-Jonas
---
net/ncsi/ncsi-manage.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c
index b022deb39d31..0966eff48ce7 100644
--- a/net/ncsi/ncsi-manage.c
+++ b/net/ncsi/ncsi-manage.c
@@ -1005,12 +10
0x164)
[ 459.04] [<80033614>] (kthread) from [<8000a5e8>]
(ret_from_fork+0x14/0x2c)
This also updates the monitor instead of just returning if
ncsi_xmit_cmd() fails to send the get-link-status command so that the
monitor properly times out.
Fixes: e6f44ed6d04d3 "net/ncsi:
02
With this applied, no error reported on GVI response packets:
# ethtool --ncsi eth0 swstats
:
RESPONSE OK TIMEOUT ERROR
===
GVI 200
Signed-off-by: Gavin Shan
Signed-off-by: Samuel Mendoza-Jonas
et to active in order for deinitialization
and failover to be done.
Signed-off-by: Gavin Shan
Signed-off-by: Samuel Mendoza-Jonas
---
net/ncsi/ncsi-manage.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c
ind
only drop a new VLAN id if we are already tracking the
maximum allowed by the NCSI specification. Per-channel limits are
already handled by ncsi_add_filter(), but add a message to set_one_vid()
to make it obvious that the channel can not support any more VLAN ids.
Signed-off-by: Samuel Mendoza-Jonas
On Thu, 2017-09-21 at 18:11 -0700, David Miller wrote:
> From: Samuel Mendoza-Jonas
> Date: Fri, 22 Sep 2017 11:00:00 +1000
>
> > If we haven't configured a channel yet (or are in the process of doing
> > so) we won't have a hot_channel - does it make more s
On Wed, 2017-09-20 at 16:05 -0700, David Miller wrote:
> From: Samuel Mendoza-Jonas
> Date: Wed, 20 Sep 2017 14:12:51 +1000
>
> > When handling new VLAN tags in NCSI we check the maximum allowed number
> > of filters on the last active ("hot") channel. However if t
arn if it is missing.
Signed-off-by: Samuel Mendoza-Jonas
---
net/ncsi/ncsi-manage.c | 21 +++--
1 file changed, 15 insertions(+), 6 deletions(-)
diff --git a/net/ncsi/ncsi-manage.c b/net/ncsi/ncsi-manage.c
index 3fd3c39e6278..fc800f934beb 100644
--- a/net/ncsi/ncsi-manage.c
an_rx_kill_vid" [drivers/net/ethernet/faraday/ftgmac100.ko]
>>> undefined!
>>> ERROR: "ncsi_vlan_rx_add_vid" [drivers/net/ethernet/faraday/ftgmac100.ko]
>>> undefined!
Add definitions for !CONFIG_NET_NCSI to bring it into line with the rest
of ncsi.h
On Mon, 2017-08-28 at 16:50 -0700, David Miller wrote:
> From: Samuel Mendoza-Jonas
> Date: Mon, 28 Aug 2017 16:18:40 +1000
>
> > This series (mainly patch 2) adds VLAN filtering to the NCSI implementation.
> > A fair amount of code already exists in the NCSI stack for VL
lify state changes when kicking updated channel
Samuel Mendoza-Jonas (3):
net/ncsi: Fix several packet definitions
net/ncsi: Configure VLAN tag filter
ftgmac100: Support NCSI VLAN filtering when available
drivers/net/ethernet/faraday/ftgmac100.c | 5 +
include/net/ncsi.h
Signed-off-by: Samuel Mendoza-Jonas
---
v2: Rebased on latest net-next
net/ncsi/ncsi-cmd.c | 10 +-
net/ncsi/ncsi-pkt.h | 2 +-
net/ncsi/ncsi-rsp.c | 3 ++-
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c
index 5e03ed190e18
ber of VLAN tag filters is determined by the "Get Capabilities"
response from the channel.
Signed-off-by: Samuel Mendoza-Jonas
---
v3: - Add comment describing change to ncsi_find_filter()
- Catch NULL in clear_one_vid() from ncsi_get_filter()
- Simplify state changes whe
Register the ndo_vlan_rx_{add,kill}_vid callbacks and set the
NETIF_F_HW_VLAN_CTAG_FILTER if NCSI is available.
This allows the VLAN core to notify the NCSI driver when changes occur
so that the remote NCSI channel can be properly configured to filter on
the set VLAN tags.
Signed-off-by: Samuel
On Mon, 2017-08-14 at 11:39 +0930, Joel Stanley wrote:
> On Mon, Aug 14, 2017 at 10:59 AM, Samuel Mendoza-Jonas
> wrote:
> > Make use of the ndo_vlan_rx_{add,kill}_vid callbacks to have the NCSI
> > stack process new VLAN tags and configure the channel VLAN filter
> > ap
Register the ndo_vlan_rx_{add,kill}_vid callbacks and set the
NETIF_F_HW_VLAN_CTAG_FILTER if NCSI is available.
This allows the VLAN core to notify the NCSI driver when changes occur
so that the remote NCSI channel can be properly configured to filter on
the set VLAN tags.
Signed-off-by: Samuel
ber of VLAN tag filters is determined by the "Get Capabilities"
response from the channel.
Signed-off-by: Samuel Mendoza-Jonas
---
include/net/ncsi.h | 2 +
net/ncsi/internal.h| 11 ++
net/ncsi/ncsi-manage.c | 295 -
net/ncsi/ncsi-r
adds the appropriate flag and callbacks to the ftgmac100 driver to
enable filtering as it's a large consumer of NCSI (and what I've been
testing on).
Samuel Mendoza-Jonas (3):
net/ncsi: Fix several packet definitions
net/ncsi: Configure VLAN tag filter
ftgmac100: Support NCSI VLAN
Signed-off-by: Samuel Mendoza-Jonas
---
v2: Rebased on latest net-next
net/ncsi/ncsi-cmd.c | 10 +-
net/ncsi/ncsi-pkt.h | 2 +-
net/ncsi/ncsi-rsp.c | 3 ++-
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c
index 5e03ed190e18
On Fri, 2017-08-11 at 14:48 -0700, David Miller wrote:
> From: Samuel Mendoza-Jonas
> Date: Fri, 11 Aug 2017 16:16:45 +1000
>
> > This series (mainly patch 3) adds VLAN filtering to the NCSI implementation.
> > A fair amount of code already exists in the NCSI stack for VL
This is required for the VLAN core to call the add/kill callback for
VLAN IDs. 'ftgmac100' already supports VLAN tagging but this flag lets
the network stack know that we want to be notified of VLAN tags being
added or removed when we have NCSI support.
Signed-off-by: Samuel Men
Signed-off-by: Samuel Mendoza-Jonas
---
net/ncsi/ncsi-cmd.c | 10 +-
net/ncsi/ncsi-pkt.h | 2 +-
net/ncsi/ncsi-rsp.c | 3 ++-
3 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/net/ncsi/ncsi-cmd.c b/net/ncsi/ncsi-cmd.c
index db7083bfd476..1fec9fda7f60 100644
--- a/net/ncsi
adds the appropriate flag to the ftgmac100 driver to enable filtering
as it's a large consumer of NCSI (and what I've been testing on).
Samuel Mendoza-Jonas (3):
ftgmac: Include NETIF_F_HW_VLAN_CTAG_FILTER in features
net/ncsi: Fix several packet definitions
net/ncsi: Configure VLAN
ber of VLAN tag filters is determined by the "Get Capabilities"
response from the channel.
Signed-off-by: Samuel Mendoza-Jonas
---
drivers/net/ethernet/faraday/ftgmac100.c | 2 +
include/net/ncsi.h | 2 +
net/ncsi/internal.h | 11 +
Hi David,
This is the NFC pull request for 4.13. We have:
- A conversion to unified device and GPIO APIs for the
fdp, pn544, and st{21,-nci} drivers.
- A fix for NFC device IDs allocation.
- A fix for the nfcmrvl driver firmware download mechanism.
- A trf7970a DT and GPIO cleanup and clock set
ions(-)
Applied to nfc-next, thanks.
Cheers,
Samuel.
k
> Signed-off-by: Gustavo A. R. Silva
> ---
> net/nfc/nci/core.c | 9 -
> 1 file changed, 4 insertions(+), 5 deletions(-)
Applied to nfc-next, thanks.
Cheers,
Samuel.
dled NULL pointer
> dereference exceptions which can be triggered by malicious user-mode
> programs, if they omit one or both of these attributes.
>
> Signed-off-by: Mateusz Jurczyk
> ---
> net/nfc/netlink.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.
Cheers,
Samuel.
is would result in the
> disclosure of up to ~70 uninitialized bytes from the kernel stack to
> user-mode clients capable of creating AFC_NFC sockets.
>
> Signed-off-by: Mateusz Jurczyk
> ---
> net/nfc/llcp_sock.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied to nfc-next, thanks.
Cheers,
Samuel.
ze determination in four functions
> Delete an error message for a failed memory allocation in digital_in_send()
Both patches applied to nfc-next, thanks.
Cheers,
Samuel.
s like ksan is the
> > problem here...
>
> Of course kasan is the problem, but it really just does whatever we
> asked it to do, and cannot do any better as long as we inline many
> copies of tty_insert_flip_char() into kbd_keycode().
We didn't ask to inline put_queue into kbd_keycode.
Samuel
ction calls for k_handler[type]
> and/or f_handler[value] into inlines again when it has already
> determined the index to be constant.
Cool :) But I don't see how it can see find it out constant. The only
fn_handler[] caller is k_spec, using value as index. The only caller of
f_handler[] is kbd_keycode, using type as index, and keysym&0xff as
value. That is definitely not constant :) And it's only one caller, I
don't see how that can bloat.
Samuel
*vc)
> +static noinline_if_stackbloat void fn_send_intr(struct vc_data *vc)
This one is only referenced, not called, I don't see how that could pose
problem.
Samuel
e device-managed resources
> NFC: nfcmrvl: use nfc-device for firmware download
> NFC: nfcmrvl: fix firmware-management initialisation
> NFC: nfcmrvl_uart: fix device-node leak during probe
> NFC: nfcmrvl_usb: use interface as phy device
> NFC: nfcmrvl: allow gpio 0 for reset signalling
Applied, thanks.
Cheers,
Samuel.
NFC: remove TI nfcwilink driver
Samuel Ortiz (1):
MAINTAINERS: Remove Lauro and Aloisio from the NFC maintainers list
Sudip Mukherjee (1):
nfc: fdp: fix NULL pointer dereference
Tobias Klauser (1):
NFC: nfcmrvl: Include unaligned.h instead of access_ok.h
.../devicetree/bindings
NFC: nfcmrvl: fix firmware-management initialisation
> > NFC: nfcmrvl_uart: fix device-node leak during probe
> > NFC: nfcmrvl_usb: use interface as phy device
> > NFC: nfcmrvl: allow gpio 0 for reset signalling
>
> Any chance of getting these into 4.12, Samuel?
I have yo
1 - 100 of 286 matches
Mail list logo
