Question about setting custom STAB

2019-05-09 Thread Robert McCabe
Awhile ago I submitted this iproute2 patch: https://patchwork.ozlabs.org/patch/784165/ And the corresponding kernel patch: https://patchwork.ozlabs.org/patch/783696/ To allow the setting of arbitrary qdisc size table so that the packet scheduler code in __qdisc_calculate_pkt_len charges the corre

[bpf-next v2] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error

2019-04-19 Thread robert . mccabe
From: The BPF_PROG_LOAD condition for kernel version <= 5.1 is log->len_total > UINT_MAX >> 8 /* (16 * 1024 * 1024) - 1 */ Signed-off-by: McCabe, Robert J --- tools/lib/bpf/bpf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h i

Re: [PATCH bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error

2019-04-19 Thread Robert McCabe
> sending one patch was enough. no need to spam 5 times. Gosh that's embarrassing. I was having a difficult time sending the patch (I'm new at patchwork-based development). I'll submit a a new patch with your suggestion.

[PATCH bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error

2019-04-19 Thread robert . mccabe
From: "McCabe, Robert J" The BPF_PROG_LOAD condition for kernel version <= 5.1 is log->len_total > UINT_MAX >> 8 /* (16 * 1024 * 1024) - 1 */ Signed-off-by: rjmccabe3701 --- tools/lib/bpf/bpf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/bpf/bpf.h b/tools/

[PATCH bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error

2019-04-19 Thread robert . mccabe
From: "McCabe, Robert J" The BPF_PROG_LOAD condition for kernel version <= 5.1 is log->len_total > UINT_MAX >> 8 /* (16 * 1024 * 1024) - 1 */ Signed-off-by: rjmccabe3701 --- tools/lib/bpf/bpf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/bpf/bpf.h b/tools/

[PATCH bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error

2019-04-19 Thread robert . mccabe
From: The BPF_PROG_LOAD condition for kernel version <= 5.1 is log->len_total > UINT_MAX >> 8 /* (16 * 1024 * 1024) - 1 */ Signed-off-by: rjmccabe3701 --- tools/lib/bpf/bpf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h index

[PATCH bpf-next] libbpf: fix BPF_LOG_BUF_SIZE off-by-one error

2019-04-19 Thread robert . mccabe
From: "McCabe, Robert J" The BPF_PROG_LOAD condition for kernel version <= 5.1 is log->len_total > UINT_MAX >> 8 /* (16 * 1024 * 1024) - 1 */ Signed-off-by: rjmccabe3701 --- tools/lib/bpf/bpf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/bpf/bpf.h b/tools/

Re: [PATCH 1/1] net sched: Added the TC_LINKLAYER_CUSTOM linklayer type

2017-07-04 Thread Robert McCabe
>>Even so, the kernel patch you sent does not make any sense. Introduces >>TC_LINKLAYER_CUSTOM but does not use it. I needed to add this to the tc_link_layer enum in my iproute2 patch (https://patchwork.ozlabs.org/patch/784165/) enum tc_link_layer { TC_LINKLAYER_UNAWARE, /* Indicate unaware

Re: [PATCH 1/1] net sched: Added the TC_LINKLAYER_CUSTOM linklayer type

2017-07-04 Thread Robert McCabe
> You dump stab->data to user. How is this related to TC_LINKLAYER_CUSTOM > and howcome this "is to support user-space modification of the qdisc > stab" as your description says? I'm confused... I have a related patch for iproute2 where the "custom" link-layer is used to allow user modification of

Re: [PATCH 1/1] tc: custom qdisc pkt size translation table

2017-06-27 Thread Robert McCabe
Yeah, sorry didn't even think about that. I guess my first question would be is there another way via the iproute2 project where a user could configure the stab->data pkt size translation table used in the __qdisc_calculate_pkt_len method in the kernel source (net/sched/sched_api.c)? Also, let's s