Re: tg3 issues

2007-07-19 Thread pradeep singh
CCing: netdev On 7/19/07, patric <[EMAIL PROTECTED]> wrote: Hi, To start with, i'm not sure if this should go to the dev or user list, but i'll start here.. I'm currently running a nfsroot via a Broadcom NetXtreme 1000-SX card (BCM5701) and i have a big problem with the tg3 drivers autonegot

Re: Socket Buffers and Memory Managment

2007-07-19 Thread pradeep singh
On 7/19/07, vinay ravuri <[EMAIL PROTECTED]> wrote: How about the following approach: I allocate an skb of 0 bytes and replace data element of skb struct (i.e. skb.data = addr_given_by_hw) when the h/w interrupts me with a packet. I register for a destructor for this skb and when the kernel is

Re: [PATCH 1/2] Fix error checking in Vitesse IRQ config

2007-07-18 Thread pradeep singh
On 7/18/07, Andy Fleming <[EMAIL PROTECTED]> wrote: phy_read() returns a negative number if there's an error, but the error-checking code in the Vitesse driver's config_intr function triggers if phy_read() returns non-zero. Correct that. Signed-off-by: Andy Fleming <[EMAIL PROTECTED]> --- I mad

Re:

2007-07-05 Thread pradeep singh
On 7/5/07, Bhanu Kalyan Chetlapalli <[EMAIL PROTECTED]> wrote: subscribe netdev oops perhaps you need to send it to majordomo :-) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/maj

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-24 Thread pradeep singh
On 6/23/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Thu, 21 Jun 2007 18:48:30 +0530 "pradeep singh" <[EMAIL PROTECTED]> wrote: > Hi, > My mistake. > Resending after reformatting the patch by hand. > Looks like gmail messes the plain text patches. >

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-21 Thread pradeep singh
Hi, My mistake. Resending after reformatting the patch by hand. Looks like gmail messes the plain text patches. Thanks Signed-off-by: Pradeep Singh <[EMAIL PROTECTED]> --- drivers/net/chelsio/cxgb2.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/net/c

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-21 Thread pradeep singh
On 6/21/07, pradeep singh <[EMAIL PROTECTED]> wrote: Hi, This is second submission for a possible NULL dereference handling in the Chelsio's 10G driver. Thanks to Jens Axboe for pointing out my mistake of ignoring subsequent dereferences in init_one routine. Thanks Apologies, looks

[PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-21 Thread pradeep singh
Hi, This is second submission for a possible NULL dereference handling in the Chelsio's 10G driver. Thanks to Jens Axboe for pointing out my mistake of ignoring subsequent dereferences in init_one routine. Thanks Signed-off-by: Pradeep Singh <[EMAIL PROTECTED]> --- drivers/net/chel

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing

2007-06-21 Thread pradeep singh
On 6/21/07, Jens Axboe <[EMAIL PROTECTED]> wrote: On Thu, Jun 21 2007, pradeep singh wrote: > Hi > On 6/21/07, Jens Axboe <[EMAIL PROTECTED]> wrote: > >On Thu, Jun 21 2007, pradeep singh wrote: > >> Hi, > >> > >> Chelsio's in

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing

2007-06-21 Thread pradeep singh
Hi On 6/21/07, Jens Axboe <[EMAIL PROTECTED]> wrote: On Thu, Jun 21 2007, pradeep singh wrote: > Hi, > > Chelsio's in kernel 10G driver does not checks the return value from > t1_get_board_info() in cxgb2.c. > t1_get_board_info may return a NULL and we still go on to d

[PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing

2007-06-21 Thread pradeep singh
Hi, Chelsio's in kernel 10G driver does not checks the return value from t1_get_board_info() in cxgb2.c. t1_get_board_info may return a NULL and we still go on to dereference it in the for loop without checking for the NULL. This patch fixes this. Signed-off-by: Pradeep Singh <[EMAIL P

Re: Problems with list

2007-05-01 Thread pradeep singh
On 4/30/07, Martín Ferrari <[EMAIL PROTECTED]> wrote: I've been sending mail to linux-net and netdev without any success. I even subscribed to both lists, and still my mail doesn't deliver. I'm trying a different MUA to see if majordomo is eating my email for some obscure reason, please somebody