Re: [PATCH net-next 2/5] sctp: apply rhashtable api to send/recv path

2016-01-06 Thread mleitner
On Tue, Jan 05, 2016 at 02:07:11PM -0500, Vlad Yasevich wrote: > On 12/30/2015 10:50 AM, Xin Long wrote: > > apply lookup apis to two functions, for __sctp_endpoint_lookup_assoc > > and __sctp_lookup_association, it's invoked in the protection of sock > > lock, it will be safe, but sctp_lookup_asso

[PATCH] sctp: allow authenticating DATA chunks that are bundled with COOKIE_ECHO

2015-06-11 Thread mleitner
From: Marcelo Ricardo Leitner Currently, we can ask to authenticate DATA chunks and we can send DATA chunks on the same packet as COOKIE_ECHO, but if you try to combine both, the DATA chunk will be sent unauthenticated and peer won't accept it, leading to a communication failure. This happens be

[PATCH v3 1/2] sctp: rcu-ify addr_waitq

2015-06-05 Thread mleitner
From: Marcelo Ricardo Leitner That's needed for the next patch, so we break the lock inversion between netns_sctp->addr_wq_lock and socket lock on sctp_addr_wq_timeout_handler(). With this, we can traverse addr_waitq without taking addr_wq_lock, taking it just for the write operations. Signed-of

[PATCH v2 1/2] sctp: rcu-ify addr_waitq

2015-06-03 Thread mleitner
From: Marcelo Ricardo Leitner That's needed for the next patch, so we break the lock inversion between netns_sctp->addr_wq_lock and socket lock on sctp_addr_wq_timeout_handler(). With this, we can traverse addr_waitq without taking addr_wq_lock, taking it just for the write operations. Signed-of

[PATCH] sctp: fix ASCONF list handling

2015-05-27 Thread mleitner
From: Marcelo Ricardo Leitner ->auto_asconf_splist is per namespace and mangled by functions like sctp_setsockopt_auto_asconf() which doesn't guarantee any serialization. Also, the call to inet_sk_copy_descendant() was backuping ->auto_asconf_list through the copy but was not honoring ->do_auto_