From: Jon Maloy
We fix a warning from the htmldoc tool and an indentation error reported
by smatch. There are no functional changes in this commit.
Signed-off-by: Jon Maloy
---
net/tipc/socket.c | 2 +-
net/tipc/subscr.h | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/n
From: Jon Maloy
We move some warning printouts to more strategic locations to avoid
duplicates and yield more detailed information about the reported
problem.
Signed-off-by: Jon Maloy
Acked-by: Ying Xue
Acked-by: Hoang Le
Acked-by: Tung Nguyen
Acked-by: Xin Long
---
net/tipc/name_distr.c |
From: Jon Maloy
We reduce and localize the usage of the tipc_sub_xx() macros by adding a
corresponding member, with fields set in host-endian format, to struct
tipc_subscription.
Signed-off-by: Jon Maloy
Acked-by: Ying Xue
Acked-by: Hoang Le
Acked-by: Tung Nguyen
Acked-by: Xin Long
---
net
From: Jon Maloy
The function tipc_report_overlap() is called from the binding table
with numerous parameters taken from an instance of struct publication.
A closer look reveals that it always is safe to send along a pointer
to the instance itself, and hence reduce the call signature. We do
that i
From: Jon Maloy
We reduce the signature of tipc_find_service() and
tipc_create_service(). The reason for doing this might not
be obvious, but we plan to let struct tipc_uaddr contain
information that is relevant for these functions in a later
commit.
Signed-off-by: Jon Maloy
Acked-by: Ying Xue
From: Jon Maloy
We simplify the signatures of the functions tipc_service_create_range()
and tipc_service_find_range().
Signed-off-by: Jon Maloy
Acked-by: Ying Xue
Acked-by: Hoang Le
Acked-by: Tung Nguyen
Acked-by: Xin Long
---
net/tipc/name_table.c | 14 --
1 file changed, 8 in
From: Jon Maloy
We reduce the signature of tipc_nametbl_lookup_group() by using a
struct tipc_uaddr pointer. This entails a couple of minor changes in the
functions tipc_send_group_mcast/anycast/unicast/bcast() in socket.c
Signed-off-by: Jon Maloy
Acked-by: Ying Xue
Acked-by: Hoang Le
Acked-b
From: Jon Maloy
We follow up the preceding commits by reducing the signature of
the function tipc_nametbl_lookup_mcast_nodes().
Signed-off-by: Jon Maloy
Acked-by: Ying Xue
Acked-by: Hoang Le
Acked-by: Tung Nguyen
Acked-by: Xin Long
---
net/tipc/name_table.c | 8
net/tipc/name_tab
From: Jon Maloy
We reduce the signature of this function according to the same
principle as the preceding commits.
Signed-off-by: Jon Maloy
Acked-by: Ying Xue
Acked-by: Hoang Le
Acked-by: Tung Nguyen
Acked-by: Xin Long
---
net/tipc/name_table.c | 10 +-
net/tipc/name_table.h | 5 +
From: Jon Maloy
The binding table provides four different lookup functions, which
purpose is not obvious neither by their names nor by the (lack of)
descriptions.
We now give these functions names that better match their purposes,
and improve the comments that describe what they are doing.
Sign
From: Jon Maloy
We simplify the signature if function tipc_nametbl_lookup_anycast(),
using address structures instead of discrete integers.
This also makes it possible to make some improvements to the functions
__tipc_sendmsg() in socket.c and tipc_msg_lookup_dest() in msg.c.
Signed-off-by: Jon
From: Jon Maloy
Following the principles of the preceding commits, we reduce
the number of parameters passed along in tipc_sk_withdraw(),
tipc_nametbl_withdraw() and associated functions.
Signed-off-by: Jon Maloy
Acked-by: Ying Xue
Acked-by: Hoang Le
Acked-by: Tung Nguyen
Acked-by: Xin Long
From: Jon Maloy
We simplify the call signatures for tipc_nametbl_insert_publ() and
tipc_publ_create() so that fewer parameters are passed around.
Signed-off-by: Jon Maloy
Acked-by: Ying Xue
Acked-by: Hoang Le
Acked-by: Tung Nguyen
Acked-by: Xin Long
---
net/tipc/name_distr.c | 23 +
From: Jon Maloy
Using the new address structure tipc_uaddr, we simplify the signature
of function tipc_sk_publish() and tipc_namtbl_publish() so that fewer
parameters need to be passed around.
Signed-off-by: Jon Maloy
Acked-by: Ying Xue
Acked-by: Hoang Le
Acked-by: Tung Nguyen
Acked-by: Xin
From: Jon Maloy
We introduce a simplified version of struct sockaddr_tipc, using
anonymous unions and structures. Apart from being nicer to work with,
this struct will come in handy when we in a later commit add another
address type.
Signed-off-by: Jon Maloy
Acked-by: Ying Xue
Acked-by: Hoang
From: Jon Maloy
We instantiate struct publication in tipc_nametbl_insert_publ()
instead of as currently in tipc_service_insert_publ(). This has the
advantage that we can pass a pointer to the publication struct to
the next call levels, instead of the numerous individual parameters
we pass on now.
From: Jon Maloy
In a future commit we will introduce more members to struct publication.
In order to keep this structure comprehensible we now group some of
its current fields into the sub-structures where they really belong,
- A struct tipc_service_range for the functional address the publicatio
From: Jon Maloy
We do a number of cleanups and simplifications, especially regarding
call signatures in the binding table. This makes the code easier to
understand and serves as preparation for upcoming functional additions.
Jon Maloy (16):
tipc: re-organize members of struct publication
tip
From: Jon Maloy
We update the terminology in the code so that deprecated structure
names and macros are replaced with those currently recommended in
the user API.
struct tipc_portid -> struct tipc_socket_addr
struct tipc_name -> struct tipc_service_addr
struct tipc_name_seq -> struct tipc_
From: Jon Maloy
The 32-bit node number, aka node hash or node address, is calculated
based on the 128-bit node identity when it is not set explicitly by
the user. In future commits we will need to perform this hash operation
on peer nodes while feeling safe that we obtain the same result.
We do
From: Jon Maloy
We refactor the tipc_sk_bind() function, so that the lock handling
is handled separately from the logics. We also move some sanity
tests to earlier in the call chain, to the function tipc_bind().
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc/socket.c | 66 ++
From: Jon Maloy
We add some improvements that will be useful in future commits.
---
v2: fixed sparse warning in patch #2
Jon Maloy (3):
tipc: refactor tipc_sk_bind() function
tipc: make node number calculation reproducible
tipc: update address terminology in code
net/tipc/addr.c |
From: Jon Maloy
We refactor the tipc_sk_bind() function, so that the lock handling
is handled separately from the logics. We also move some sanity
tests to earlier in the call chain, to the function tipc_bind().
Acked-by: Ying Xue
Signed-off-by: Jon Maloy
---
net/tipc/socket.c | 66 ++
From: Jon Maloy
The 32-bit node number, aka node hash or node address, is calculated
based on the 128-bit node identity when it is not set explicitly by
the user. In future commits we will need to perform this hash operation
on peer nodes while feeling safe that we obtain the same result.
We do
From: Jon Maloy
We add some improvements that will be useful in future commits.
Jon Maloy (3):
tipc: refactor tipc_sk_bind() function
tipc: make node number calculation reproducible
tipc: update address terminology in code
net/tipc/addr.c | 7 ++-
net/tipc/addr.h | 1 +
n
From: Jon Maloy
We update the terminology in the code so that deprecated structure
names and macros are replaced with those currently recommended in
the user API.
struct tipc_portid -> struct tipc_socket_addr
struct tipc_name -> struct tipc_service_addr
struct tipc_name_seq -> struct tipc_
From: Jon Maloy
TIPC reserves 64 service types for current and future internal use.
Therefore, the bind() function is meant to block regular user sockets
from being bound to these values, while it should let through such
bindings from internal users.
However, since we at the design moment saw no
From: Jon Maloy
TIPC reserves 64 service types for current and future internal use.
Therefore, the bind() function is meant to block regular user sockets
from being bound to these values, while it should let through such
bindings from internal users.
However, since we at the design moment saw no
28 matches
Mail list logo
