Re: [PATCH 1/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-09-14 Thread jim . cromie
> > > > Please you should not be using netdev_info(). netdev_dbg() please. > > > > I changed most netif_msg_*()+netdev_*() to netif_*(), including > netif_dbg() in several places. However, after reading other drivers I > decided to leave this at INFO level. I think this is the way to go, > because

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread jim . cromie
calling out some thinkos On Thu, Jun 11, 2020 at 3:19 PM wrote: > > heres what I have in mind. whats described here is working. > I'll send it out soon > > commit 20298ec88cc2ed64269c8be7b287a24e60a5347e > Author: Jim Cromie > Date: Wed Jun 10 12:55:08 2020 -0600 &

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread jim . cromie
gt; need be converted into a mask when we compare them to the mask provided > by the user. > > > Daniel. heres what I have in mind. whats described here is working. I'll send it out soon commit 20298ec88cc2ed64269c8be7b287a24e60a5347e Author: Jim Cromie Date: Wed Jun

Re: [PATCH v3 0/7] Venus dynamic debug

2020-06-09 Thread jim . cromie
On Tue, Jun 9, 2020 at 4:23 PM Joe Perches wrote: > > On Tue, 2020-06-09 at 15:21 -0600, jim.cro...@gmail.com wrote: > > > > As Joe noted, there is a lot of ad-hockery to possibly clean up, > > but I dont grok how these levels should be distinguished from > > KERN_(WARN|INFO|DEBUG) constants. > >

Re: [PATCH v3 0/7] Venus dynamic debug

2020-06-09 Thread jim . cromie
On Tue, Jun 9, 2020 at 10:49 AM Joe Perches wrote: > > (adding Jim Cromie and comments) > thanks for bringing me in... > On Tue, 2020-06-09 at 09:03 -0700, Randy Dunlap wrote: > > On 6/9/20 4:13 AM, Matthew Wilcox wrote: > > > On Tue, Jun 09, 2020 at 01:45:57PM +03