答复: [PATCH] ipv4: fix the problem of ping failure in some cases

2020-08-23 Thread Guodeqing (A)
> -邮件原件- > 发件人: David Ahern [mailto:dsah...@gmail.com] > 发送时间: Monday, August 24, 2020 10:34 > 收件人: Guodeqing (A) ; da...@davemloft.net > 抄送: k...@kernel.org; netdev@vger.kernel.org > 主题: Re: [PATCH] ipv4: fix the problem of ping failure in some cases > > On 8/23

[PATCH] ipv4: fix the problem of ping failure in some cases

2020-08-22 Thread guodeqing
solve this problem. Fixes: 19e4e768064a8 ("ipv4: Fix raw socket lookup for local traffic") Signed-off-by: guodeqing --- include/net/inet_sock.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/inet_sock.h b/include/net/inet_sock.h index a3702d1..7707b1d 10

答复: 答复: [PATCH,v2] ipvlan: add the check of ip header checksum

2020-07-24 Thread Guodeqing (A)
> -邮件原件- > 发件人: Eric Dumazet [mailto:eric.duma...@gmail.com] > 发送时间: Friday, July 24, 2020 13:14 > 收件人: Guodeqing (A) ; Eric Dumazet > > 抄送: David Miller ; k...@kernel.org; > mahe...@google.com; netdev@vger.kernel.org > 主题: Re: 答复: [PATCH,v2] ipvlan: add the che

答复: [PATCH,v2] ipvlan: add the check of ip header checksum

2020-07-23 Thread Guodeqing (A)
should be discarded as soon as possible. Thanks. -邮件原件- 发件人: Eric Dumazet [mailto:eduma...@google.com] 发送时间: Thursday, July 23, 2020 10:15 收件人: Guodeqing (A) 抄送: David Miller ; k...@kernel.org; mahe...@google.com; netdev@vger.kernel.org 主题: Re: [PATCH,v2] ipvlan: add the check of ip

答复: [PATCH,v2] ipvlan: add the check of ip header checksum

2020-07-22 Thread Guodeqing (A)
Because ipvlan will do the ip forward, it will do a route lookup.if the ihl of the ip header is smaller than 5, this cause ip_fast_csum access the illegal address. -邮件原件- 发件人: Eric Dumazet [mailto:eduma...@google.com] 发送时间: Thursday, July 23, 2020 0:30 收件人: Guodeqing (A) 抄送: David

答复: [PATCH,v2] ipvlan: add the check of ip header checksum

2020-07-22 Thread Guodeqing (A)
} while (--ihl); 37 38 sum += ((sum >> 32) | (sum << 32)); 39 return csum_fold((__force u32)(sum >> 32)); 40 } I think this panic may be a problem, thanks. -邮件原件- 发件人: Cong Wang [mailto:xiyou.wangc...@gmail.com] 发送时间: Wednesday, July 22, 2020 3:39

[PATCH,v2] ipvlan: add the check of ip header checksum

2020-07-22 Thread guodeqing
check of ip header checksum and drop the illegal packets in l3/l3s mode. Signed-off-by: guodeqing --- drivers/net/ipvlan/ipvlan_core.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/ipvlan/ipvlan_core.c b/drivers/net/ipvlan/ipvlan_core.c index 8801d09

答复: [PATCH] ipvlan: add the check of ip header checksum

2020-07-22 Thread Guodeqing (A)
[mailto:xiyou.wangc...@gmail.com] 发送时间: Wednesday, July 22, 2020 3:39 收件人: Guodeqing (A) 抄送: David Miller ; Jakub Kicinski ; Mahesh Bandewar ; Eric Dumazet ; Linux Kernel Network Developers 主题: Re: [PATCH] ipvlan: add the check of ip header checksum On Tue, Jul 21, 2020 at 6:17 AM guodeqing wrote: > >

[PATCH] ipvlan: add the check of ip header checksum

2020-07-21 Thread guodeqing
add the check of ip header to drop the corruptted packets and to avoid a problem in some cases. Signed-off-by: guodeqing --- drivers/net/ipvlan/ipvlan_core.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ipvlan/ipvlan_core.c b/drivers/net/ipvlan/ipvlan_core.c index 8801d09

[PATCH,v2] ipvs: fix the connection sync failed in some cases

2020-07-16 Thread guodeqing
reader_queue is not read, so the rmem is not reclaimed. Here I add the check of whether the reader_queue of the udp sock is empty or not to solve this problem. Fixes: 2276f58ac589 ("udp: use a separate rx queue for packet reception") Reported-by: zhouxudong Signed-off-by: guodeqing

答复: [PATCH] ipvs: fix the connection sync failed in some cases

2020-07-16 Thread Guodeqing (A)
: Thursday, July 16, 2020 1:36 收件人: Guodeqing (A) 抄送: wens...@linux-vs.org; ho...@verge.net.au; pa...@netfilter.org; kad...@netfilter.org; f...@strlen.de; da...@davemloft.net; k...@kernel.org; netdev@vger.kernel.org; lvs-de...@vger.kernel.org; netfilter-de...@vger.kernel.org 主题: Re: [PATCH] ipvs: fix

[PATCH] ipvs: fix the connection sync failed in some cases

2020-07-14 Thread guodeqing
reader_queue is not read, so the rmem is not reclaimed. Here I add the check of whether the reader_queue of the udp sock is empty or not to solve this problem. Fixes: 7c13f97ffde6 ("udp: do fwd memory scheduling on dequeue") Reported-by: zhouxudong Signed-off-by: guodeqing --- net/netf

答复: [PATCH] net: Fix the arp error in some cases

2020-06-16 Thread Guodeqing (A)
rt->rt_uses_gateway = 1; } (ip_route_output_key_hash-> ip_route_output_key_hash_rcu-> __mkroute_output-> rt_set_nexthop) -邮件原件- 发件人: David Ahern [mailto:dsah...@gmail.com] 发送时间: Wednesday, June 17, 2020 11:10 收件人: Guodeqing (A) ; da...@davemloft.net 抄送: kuz...@ms2.i

[PATCH] net: Fix the arp error in some cases

2020-06-16 Thread guodeqing
correct scope is RT_SCOPE_HOST. Here I add a check of whether this is RT_TABLE_MAIN to solve this problem. Fixes: 3bfd847203c6("net: Use passed in table for nexthop lookups") Signed-off-by: guodeqing --- net/ipv4/fib_semantics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) di

[PATCH] net: Fix the arp error in some cases

2020-06-15 Thread guodeqing
HWtype HWaddress Flags MaskIface 6.6.6.6 (incomplete) eth0 The arp request address is error, this problem can be reproduced easily. Fixes: 3bfd847203c6("net: Use passed in table for nexthop lookups") Signed-off-by: guodeqing

答复: [PATCH] net: Fix the arp error in some cases

2020-06-14 Thread Guodeqing (A)
-邮件原件- 发件人: David Ahern [mailto:dsah...@gmail.com] 发送时间: Saturday, June 13, 2020 22:32 收件人: Guodeqing (A) ; da...@davemloft.net 抄送: kuz...@ms2.inr.ac.ru; netdev@vger.kernel.org; d...@cumulusnetworks.com; k...@kernel.org 主题: Re: [PATCH] net: Fix the arp error in some cases On 6/13/20

[PATCH] net: Fix the arp error in some cases

2020-06-12 Thread guodeqing
okups") Signed-off-by: guodeqing --- net/ipv4/fib_semantics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c index e53871e..1f75dc6 100644 --- a/net/ipv4/fib_semantics.c +++ b/net/ipv4/fib_semantics.c @@ -1109,7 +1109,7