Re: [PATCH net 02/15] ibmvnic: process HMC disable command

2020-11-23 Thread drt
On 2020-11-23 11:43, Jakub Kicinski wrote: On Sun, 22 Nov 2020 07:12:38 -0800 drt wrote: On 2020-11-21 15:36, Jakub Kicinski wrote: > On Fri, 20 Nov 2020 16:40:36 -0600 Lijun Pan wrote: >> From: Dany Madden >> >> Currently ibmvnic does not support the disable vnic command

Re: [PATCH net 02/15] ibmvnic: process HMC disable command

2020-11-22 Thread drt
On 2020-11-21 15:36, Jakub Kicinski wrote: On Fri, 20 Nov 2020 16:40:36 -0600 Lijun Pan wrote: From: Dany Madden Currently ibmvnic does not support the disable vnic command from the Hardware Management Console. This patch enables ibmvnic to process CRQ message 0x07, disable vnic adapter. Wha

Re: [PATCH net 10/15] ibmvnic: no reset timeout for 5 seconds after reset

2020-11-20 Thread drt
On 2020-11-20 14:40, Lijun Pan wrote: From: Dany Madden Reset timeout is going off right after adapter reset. This patch ensures that timeout is scheduled if it has been 5 seconds since the last reset. 5 seconds is the default watchdog timeout. Suggested-by: Brian King Signed-off-by: D

Re: [PATCH net v2 3/3] ibmvnic: skip tx timeout reset while in resetting

2020-11-20 Thread drt
On 2020-11-20 14:40, Lijun Pan wrote: Sometimes it takes longer than 5 seconds (watchdog timeout) to complete failover, migration, and other resets. In stead of scheduling another timeout reset, we wait for the current one to complete. Suggested-by: Brian King Signed-off-by: Lijun Pan Review

Re: [PATCH net v2 1/3] ibmvnic: fix call_netdevice_notifiers in do_reset

2020-11-20 Thread drt
On 2020-11-20 14:40, Lijun Pan wrote: When netdev_notify_peers was substituted in commit 986103e7920c ("net/ibmvnic: Fix RTNL deadlock during device reset"), call_netdevice_notifiers(NETDEV_RESEND_IGMP, dev) was missed. Fix it now. Fixes: 986103e7920c ("net/ibmvnic: Fix RTNL deadlock during de

Re: [PATCH net-next 12/12] ibmvnic: Do not replenish RX buffers after every polling loop

2020-11-12 Thread drt
On 2020-11-12 11:10, Thomas Falcon wrote: From: "Dwip N. Banerjee" Reduce the amount of time spent replenishing RX buffers by only doing so once available buffers has fallen under a certain threshold, in this case half of the total number of buffers, or if the polling loop exits before the pack

Re: [PATCH net-next 01/12] ibmvnic: Ensure that subCRQ entry reads are ordered

2020-11-12 Thread drt
On 2020-11-12 11:09, Thomas Falcon wrote: Ensure that received Subordinate Command-Response Queue entries are properly read in order by the driver. Signed-off-by: Thomas Falcon Acked-by: Dany Madden --- drivers/net/ethernet/ibm/ibmvnic.c | 4 1 file changed, 4 insertions(+) diff --g

Re: [PATCH net 1/2] ibmvnic: notify peers when failover and migration happen

2020-11-04 Thread drt
On 2020-10-30 13:27, Jakub Kicinski wrote: On Wed, 28 Oct 2020 00:57:41 -0500 Lijun Pan wrote: We need to notify peers only when failover and migration happen. It is unnecessary to call that in other events like FATAL, NON_FATAL, CHANGE_PARAM, and TIMEOUT resets since in those scenarios the MAC

Re: [PATCH net-next] ibmvnic: merge do_change_param_reset into do_reset

2020-11-04 Thread drt
On 2020-11-03 15:09, Jakub Kicinski wrote: On Sat, 31 Oct 2020 04:46:45 -0500 Lijun Pan wrote: Commit b27507bb59ed ("net/ibmvnic: unlock rtnl_lock in reset so linkwatch_event can run") introduced do_change_param_reset function to solve the rtnl lock issue. Majority of the code in do_change_para

Re: [PATCH 12/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues

2020-11-04 Thread drt
On 2020-11-04 01:06, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_

Re: [PATCH 09/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours

2020-11-04 Thread drt
On 2020-11-04 05:38, Andrew Lunn wrote: On Wed, Nov 04, 2020 at 09:06:07AM +, Lee Jones wrote: Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ib

Re: [PATCH v3 1/1] powerpc/vnic: Extend "failover pending" window

2020-10-30 Thread drt
On 2020-10-30 10:07, Sukadev Bhattiprolu wrote: Commit 5a18e1e0c193b introduced the 'failover_pending' state to track the "failover pending window" - where we wait for the partner to become ready (after a transport event) before actually attempting to failover. i.e window is between following two