Re: [PATCH] Fix buglets in mpc5200 FEC code that are corrupting memory.

2007-11-09 Thread Domen Puncer
erenced. > > Signed-off-by: Jon Smirl <[EMAIL PROTECTED]> Acked-by: Domen Puncer <[EMAIL PROTECTED]> I can't test it at the moment, but the patch is obviously correct, mapped buffer should be the _same_ as submitted. > > --- > > drivers/net/fec_mpc52

[PATCH v4.3] FEC - fast ethernet controller for mpc52xx

2007-10-26 Thread Domen Puncer
On 26/10/07 07:18 -0700, Dale Farnsworth wrote: > On Fri, Oct 26, 2007 at 01:59:09PM +0200, Domen Puncer wrote: > > +static irqreturn_t mpc52xx_fec_tx_interrupt(int irq, void *dev_id) > > +{ > > + struct net_device *dev = dev_id; > > + struct mpc52xx_fec_p

[PATCH v4.2] FEC - fast ethernet controller for mpc52xx

2007-10-26 Thread Domen Puncer
On 25/10/07 13:29 -0700, Dale Farnsworth wrote: > On Thu, Oct 25, 2007 at 09:41:14PM +0200, Domen Puncer wrote: > > On 25/10/07 11:57 -0700, Dale Farnsworth wrote: > > > Domen wrote: > > > > > use your platform's dma mapping functions, rather than virt_to_p

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Domen Puncer
On 25/10/07 11:57 -0700, Dale Farnsworth wrote: > Domen wrote: > > > use your platform's dma mapping functions, rather than virt_to_phys() > > > > > > it might be the exact same implementation, inside the platform > > > internals, but drivers shou

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Domen Puncer
On 25/10/07 05:29 -0400, Jeff Garzik wrote: > Domen Puncer wrote: > >+static int mpc52xx_fec_alloc_rx_buffers(struct bcom_task *rxtsk) > >+{ > >+while (!bcom_queue_full(rxtsk)) { > >+struct sk_buff *skb; > >+struct bcom_fec

[PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-19 Thread Domen Puncer
Driver for ethernet on mpc5200/mpc5200b SoCs (FEC). Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- On 18/10/07 15:14 -0400, Jeff Garzik wrote: > > except a resend combining patches 3 and 4 as requested :) OK, here it goes. Sorry for the delay. diffstat: drivers

Re: [PATCH v3 4/4] FEC mpc52xx: phy part of the driver\

2007-10-15 Thread Domen Puncer
On 14/10/07 16:05 -0600, Grant Likely wrote: > On 10/14/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > > PHY part of the driver for mpc5200(b) ethernet. > > Assuming I understand correctly, this comment is not correct and this > patch just adds an MDIO bus driver. PHY d

[PATCH v3 3/4] FEC mpc52xx: the driver

2007-10-14 Thread Domen Puncer
Driver for ethernet on mpc5200/mpc5200b SoCs (FEC). Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- drivers/net/Kconfig |1 drivers/net/Makefile |1 drivers/net/fec_mpc52xx/Kconfig | 15 drivers/net/fec_mpc52xx/Makefile |2 drive

[PATCH v3 2/4] FEC mpc52xx: add some bestcomm flags

2007-10-14 Thread Domen Puncer
Add masks and fix existing ones to match mpc5200b user's manual. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- arch/powerpc/sysdev/bestcomm/fec.h | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) Index: linux.git/arch/powerpc/sysdev/bes

[PATCH v3 1/4] FEC mpc52xx: device tree changes

2007-10-14 Thread Domen Puncer
Add device tree entries for lite5200b's FEC's PHY. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/lite5200b.dts | 18 +- 1 files changed, 17 insertions(+), 1 deletion(-) Index: linux.git/arch/powerpc/boot/d

[PATCH v3 4/4] FEC mpc52xx: phy part of the driver

2007-10-14 Thread Domen Puncer
PHY part of the driver for mpc5200(b) ethernet. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- drivers/net/fec_mpc52xx/Kconfig | 13 ++ drivers/net/fec_mpc52xx/Makefile |5 drivers/net/fec_mpc52xx/fec.c | 11 ++ drivers/net/fec_mpc52xx/fec.h |2 drive

[PATCH v3 0/4] FEC - fast ethernet controller for mpc52xx

2007-10-14 Thread Domen Puncer
Hello! If there are no objections, I would like to get this merged when bestcomm goes in (any time now?). It's split into four parts: 1 - device tree 2 - small bestcomm change 3 - the actual driver 4 - phy part of the driver Domen -- Domen Puncer | Research & De

Re: [RFC PATCH v0.2] net driver: mpc52xx fec

2007-10-02 Thread Domen Puncer
On 02/10/07 14:49 +0200, Sascha Hauer wrote: > > Hi Domen, Hi Sascha! > > On Sun, Sep 02, 2007 at 09:41:43AM +0200, Domen Puncer wrote: > + */ > > +static void fec_start(struct net_device *dev) > > +{ > > + struct fec_priv *priv = netdev_priv(dev); > &

Re: [PATCH] phy: export phy_mii_ioctl

2007-09-19 Thread Domen Puncer
On 18/09/07 15:17 -0400, Jon Smirl wrote: > On 9/18/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > > More testing and getting it to work properly on Phytec pcm030 would > > be great. > > I compiled it as a module: > CC [M] drivers/net/fec_mpc52xx/fec.o >

Re: [PATCH] phy: export phy_mii_ioctl

2007-09-18 Thread Domen Puncer
(I edited Cc: -jeff, +sven, hope you don't mind) On 17/09/07 18:08 -0400, Jon Smirl wrote: > On 9/17/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > > Export phy_mii_ioctl, so network drivers can use it when built > > as modules too. > > Domen, do you want to

[PATCH] phy: export phy_mii_ioctl

2007-09-17 Thread Domen Puncer
Export phy_mii_ioctl, so network drivers can use it when built as modules too. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- On 17/09/07 11:53 +0200, Sven Luther wrote: > On Sat, Sep 15, 2007 at 02:14:44PM +0200, Domen Puncer wrote: > > Updated and split version at: > >

Re: [RFC PATCH v0.2] net driver: mpc52xx fec

2007-09-15 Thread Domen Puncer
On 03/09/07 09:57 -0600, Grant Likely wrote: > On 9/2/07, Domen Puncer <[EMAIL PROTECTED]> wrote: > > Hi! > > > > new in this version: > > - fixed stuff that was commented on. > > - added 7-wire support (compile at least, if someone has the hardware, > >

[RFC PATCH v0.2] net driver: mpc52xx fec

2007-09-03 Thread Domen Puncer
oC-i.patch) If there are no objections, I would like this to be merged after bestcomm (mpc52xx dma engine) patches hit mainline, and that will hopefully be at the beginning of the 2.6.24 merge window. -- Driver for ethernet on mpc5200/mpc5200b SoCs (FEC). Signed-off-by: Domen Puncer <[EM

[PATCH] phy layer: fix genphy_setup_forced (don't reset)

2007-08-16 Thread Domen Puncer
Writing BMCR_RESET bit will reset MII_BMCR to default values. This is clearly not what we want. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- drivers/net/phy/phy_device.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: work-powerpc.git/drivers/net/phy/phy_de

Re: [RFC PATCH v0.1] net driver: mpc52xx fec

2007-08-13 Thread Domen Puncer
On 10/08/07 10:02 -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Aug 10, 2007 at 11:51:53AM +0200, Domen Puncer escreveu: > > +static u8 null_mac[6]; > > const OK. ... > > +static void fec_set_paddr(struct net_device *dev, u8 *mac) > > +{ > > + struct

[RFC PATCH v0.1] net driver: mpc52xx fec

2007-08-10 Thread Domen Puncer
52xx/ . I still have 'make CONFIG_FEC_MPC52xx_MDIO=n compile and work' on my TODO, maybe even ethtool support. Domen arch/powerpc/boot/dts/lite5200b.dts | 18 arch/powerpc/sysdev/bestcomm/fec.h | 14 drivers/net/fec_mpc52xx/Kconfig | 24 drivers/net/fec_mpc52x

[PATCH] phy layer: fix phy_mii_ioctl for autonegotiation

2007-08-07 Thread Domen Puncer
Fix a thinko (?) in setting phydev->autoneg. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- This fixes my "mii.h -> ethtool.h advertising #defines". I'm not sure why and how they're translated, but it does work now. Maybe they're just ignored, since m

phy_mii_ioctl - phydev->advertising ethtool.h vs. mii.h

2007-08-06 Thread Domen Puncer
000BASE-X half-duplex */ 74 #define ADVERTISE_100HALF 0x0080 /* Try for 100mbps half-duplex */ ... I'm I right that this is a bug? Comments, suggestions how to fix it? Domen - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of

Re: [PATCH] sb1000: prevent a potential NULL pointer dereference in sb1000_dev_ioctl()

2007-07-28 Thread Domen Puncer
L test of 'dev', yet we > dereference the pointer prior to that check. > This patch simply moves the dereference after the NULL test. But... it can't be called without a valid 'dev', no? A quick 'grep do_ioctl net/' confirms that all calls are in the form of 'de

[PATCH] ucc_geth_mii: fix __exit called from __init

2007-07-20 Thread Domen Puncer
void __exit uec_mdio_exit(void) is called from - static int __init ucc_geth_init(void) - static void __exit ucc_geth_exit(void) First one would make error path more than just an error. Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- drivers/net/ucc_geth_mii.c |3 ++- 1 file chan

[patch 1/6] drivers/net/eth16i.c : Use of the time_after() macro

2005-07-31 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of the time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --

[patch 5/6] drivers/net/seeq8005.c : Use of the time_before() macro

2005-07-31 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of the time_before() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>

[patch 6/7] net/ns83820: Fix "nocast type" warnings

2005-07-14 Thread domen
From: Victor Fusco <[EMAIL PROTECTED]> Fix the sparse warning "implicit cast to nocast type" File/Subsystem:drivers/net/ns83820.c Signed-off-by: Victor Fusco <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> -- --- ns83820.c |2 +- 1 file

[patch 4/7] drivers/net/3c523.c : Use of time_after macro

2005-07-14 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of the time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> -

[patch 5/7] net/sungem: Fix "nocast type" warnings

2005-07-14 Thread domen
From: Victor Fusco <[EMAIL PROTECTED]> Fix the sparse warning "implicit cast to nocast type" File/Subsystem:drivers/net/sungem.h Signed-off-by: Victor Fusco <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> -- --- sungem.h |2 +- 1 file

[patch 3/7] drivers/net/ns83820.c : Use of time_after_eq macro

2005-07-14 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of the time_after_eq() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]&g

[patch 7/7] cli() cleanup in and fec.c

2005-07-14 Thread domen
From: Brandon Niemczyk <[EMAIL PROTECTED]> replaces calls to save_flags(); cli() with spinlocks, it also makes some global variables that aren't used anywhere or declared in a header static. Signed-off-by: Brandon Niemczyk <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer

[patch 2/7] drivers/net/pcmcia/3c589_cs.c : Use of time_befor macro

2005-07-14 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_before() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> ---

[patch 1/7] drivers/net/tulip/pnic.c : Use of time_after macro

2005-07-14 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- pni

[patch 1/1] wireless/atmel: Audit return code of create_proc_*

2005-07-14 Thread domen
From: Christophe Lucas <[EMAIL PROTECTED]> Audit return of create_proc_* functions. Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- atmel.c |5 - 1 files changed, 4 insertions(+), 1 deletion(-) Index: quilt/dr

[patch 1/1] GCC4 wavelan_cs.c warning: large integer implicitly truncated to unsigned type

2005-07-14 Thread domen
be 512 bit times the interframe spacing. Signed-off-by: Jesse Millan <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- wavelan_cs.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Index: quilt/

[patch 3/3] net/sctp/objcnt: Audit return code of create_proc_*

2005-07-14 Thread domen
From: Christophe Lucas <[EMAIL PROTECTED]> Audit return of create_proc_* functions. Signed-off-by: Christophe Lucas <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- objcnt.c |6 +- 1 files changed, 5 insertions(+), 1 deletion(-) Index: quilt

[patch 1/1] drivers/net/hp100.c : Use of time_before macro

2005-07-14 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_before() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> -

[patch 2/3] skbuff.h: Fix "nocast type" warnings

2005-07-14 Thread domen
From: Victor Fusco <[EMAIL PROTECTED]> Fix the sparse warning "implicit cast to nocast type" File/Subsystem:include/linux/skbuff.h Signed-off-by: Victor Fusco <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> -- --- skbuff.h |3 ++- 1 files

[patch 1/3] netlink: Fix "nocast type" warnings

2005-07-14 Thread domen
From: Victor Fusco <[EMAIL PROTECTED]> Fix the sparse warning "implicit cast to nocast type" File/Subsystem:net/netlink/af_netlink.c Signed-off-by: Victor Fusco <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> -- --- af_netlink.c |

[patch 1/1] drivers/net/wan/: use of time_after macro

2005-07-14 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of the time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]&g

[patch 1/1] drivers/net/pcmcia/smc91c92_cs.c : Use of time_after macro

2005-07-14 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of the time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>

[patch 3/8] drivers/net/ne-h8300.c : Use of time_after() macro

2005-07-07 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> ---

[patch 5/8] drivers/net/arm/etherh.c : Use of time_after() macro

2005-07-07 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --

[patch 4/8] net/ioc3-eth: Use the DMA_{32,64}BIT_MASK constants

2005-07-07 Thread domen
e http://marc.theaimsgroup.com/?t=10800199301&r=1&w=2 for details Signed-off-by: Tobias Klauser <[EMAIL PROTECTED]> Signed-off-by: Ralf Baechle <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- ioc3-eth.c |7 --- 1 files changed, 4 insertions(+), 3 de

[patch 6/8] drivers/net/apne.c : Use of time_after() macro

2005-07-07 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>

[patch 7/8] drivers/net/ne.c : Use of time_after() macro

2005-07-07 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]>

[patch 8/8] drivers/net/zorro8390.c : Use of time_after() macro

2005-07-07 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> ---

[patch 2/8] drivers/net/wireless/strip.c : Use of time_after() macro

2005-07-07 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> -

[patch 1/8] drivers/net/ne2.c : Use of time_after() macro

2005-07-07 Thread domen
From: Marcelo Feitoza Parisi <[EMAIL PROTECTED]> Use of time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. --- ne2.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) Index: quilt/drivers/net/ne2.c ==

[patch 1/1] net: fix sparse warnings

2005-07-07 Thread domen
From: Victor Fusco <[EMAIL PROTECTED]> Fix the sparse warning "implicit cast to nocast type" Signed-off-by: Victor Fusco <[EMAIL PROTECTED]> Signed-off-by: Domen Puncer <[EMAIL PROTECTED]> --- include/linux/skbuff.h | 29 ++--- i