Re: [git patches] net driver updates

2008-02-25 Thread Divy Le Ray
et me know what's more convenient for you. Cheers, Divy -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [git patches] net driver updates

2008-02-20 Thread Divy Le Ray
> From: "Divy Le Ray" <[EMAIL PROTECTED]> > Date: Wed, 20 Feb 2008 21:57:08 -0800 > > > The driver is cxgb3 here, it uses LLTX. > > That's extremely unfortunate, hopefully you can update it to > use a model like tg3 and others use. LLTX is a lost cau

RE: [git patches] net driver updates

2008-02-20 Thread Divy Le Ray
> -Original Message- > From: David Miller [mailto:[EMAIL PROTECTED] > Sent: Wednesday, February 20, 2008 9:47 PM > To: [EMAIL PROTECTED] > Cc: Divy Le Ray; [EMAIL PROTECTED]; [EMAIL PROTECTED]; > netdev@vger.kernel.org > Subject: Re: [git patches] net driver updat

Re: [git patches] net driver updates

2008-02-20 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: Jeff Garzik wrote: Mostly fixes, a few cleanups (generally assisting fixes), and an exception for PS3 wireless because it had been posted, reviewed and acked for a while, just not committed. Please pull from 'upstream-davem' branch of master.

Re: [git patches] net driver updates

2008-02-11 Thread Divy Le Ray
; Hi Jeff, I thought I had NAK'ed the patch modifying sge.c from Krishna Kumar. Looking back at my answer at the time, I was obviously unclear. Can you please revert the drivers/net/cxgb3sge.c change ? Cheers, Divy -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2.6.25] cxgb3: Handle ARP completions that mark neighbors stale.

2008-02-06 Thread Divy Le Ray
use the arp entry can cause RDMA connection failures. Signed-off-by: Steve Wise <[EMAIL PROTECTED]> Acked-by: Divy Le Ray <[EMAIL PROTECTED]> Divy -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More m

Re: [PATCH] Optimize cxgb3 xmit path (a bit)

2008-01-30 Thread Divy Le Ray
the condition never hit even once). Thanks, Hi Krishna, Thanks for the work. There is however a bit more cleaning to do regarding the USE_GTS macro. I'll post a patch soon that will take your points in account. Cheers, Divy -- To unsubscribe from this list: send the

Re: [git patches] net driver fixes

2007-12-17 Thread Divy Le Ray
<http://vger.kernel.org/majordomo-info.html> The last thing I have from you, in netdev#upstream, is commit 75758e8aa4b7d5c651261ce653dd8d0b716e1eda Author: Divy Le Ray <[EMAIL PROTECTED]> Date: Wed Dec 5 10:15:01 2007 -0800 cxgb3 - T3C support update Update GPIO map

[PATCH 1/2 2.6.25] cxgb3 - parity initialization for T3C adapters.

2007-12-17 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Add parity initialization for T3C adapters. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h |1 drivers/net/cxgb3/cxgb3_main.c| 82 drivers/net/cxgb3/cxgb3_offload.c | 15 ++ drive

[PATCH 2/2 2.6.25] cxgb3 - Fix EEH, missing softirq blocking

2007-12-17 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> set_pci_drvdata() stores a pointer to the adapter, not the net device. Add missing softirq blocking in t3_mgmt_tx. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c | 14 -- drivers/net

Re: [git patches] net driver fixes

2007-12-17 Thread Divy Le Ray
and 12/06 ? I did not see them getting applied to the #upstream branch today. Cheers, Divy -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] cxgb3 - Parity initialization for T3C adapters

2007-12-14 Thread Divy Le Ray
Divy Le Ray wrote: Jeff Garzik wrote: Divy Le Ray wrote: > Jeff Garzik wrote: >> Divy Le Ray wrote: >>> From: Divy Le Ray <[EMAIL PROTECTED]> >>> >>> Add parity initialization for T3C adapters. >>> >>> Signed-off-by: Divy Le Ray <

Re: [PATCH 2/2] cxgb3 - Parity initialization for T3C adapters

2007-12-07 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: > Jeff Garzik wrote: >> Divy Le Ray wrote: >>> From: Divy Le Ray <[EMAIL PROTECTED]> >>> >>> Add parity initialization for T3C adapters. >>> >>> Signed-off-by: Divy Le Ray <[EMAIL PROTEC

Re: [PATCH 2/2] cxgb3 - Parity initialization for T3C adapters

2007-12-07 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Add parity initialization for T3C adapters. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h |1 drivers/net/cxgb3/cxgb3_main.c| 82 drive

Re: [PATCH 0/2] cxgb3 - driver update

2007-12-06 Thread Divy Le Ray
Divy Le Ray wrote: Jeff, I'm submitting a patch series for inclusion in 2.6.25. The patches are built against netdev#upstream. Here is a brief description: - Update GPIO pinning and MAC support for T3C adapters - Enable parity error detection. Jeff, I posted a third patch to fix the EEH

[PATCH 3/2] cxgb3 - Fix EEH, missing softirq blocking

2007-12-06 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> set_pci_drvdata() stores a pointer to the adapter, not the net device. Add missing softirq blocking in t3_mgmt_tx. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c | 14 -- drivers/net

[PATCH 2/2] cxgb3 - Parity initialization for T3C adapters

2007-12-05 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Add parity initialization for T3C adapters. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h |1 drivers/net/cxgb3/cxgb3_main.c| 82 drivers/net/cxgb3/cxgb3_offload.c | 15 ++ drive

[PATCH 1/2] cxgb3 - T3C support update

2007-12-05 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Update GPIO mapping for T3C. Update xgmac for T3C support. Fix typo in mtu table. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/regs.h | 27 ++- drivers/net/cxgb3/t3_hw.c |6 +++--- drive

[PATCH 0/2] cxgb3 - driver update

2007-12-05 Thread Divy Le Ray
Jeff, I'm submitting a patch series for inclusion in 2.6.25. The patches are built against netdev#upstream. Here is a brief description: - Update GPIO pinning and MAC support for T3C adapters - Enable parity error detection. Cheers, Divy -- To unsubscribe from this list: send the

Re: [LIKELY_SPAM][git patches] net driver fixes

2007-12-01 Thread Divy Le Ray
ode changes. Cheers, Divy -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] cxgb - revert file mode changes.

2007-12-01 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> revert inavertant file mode changes Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/chelsio/cxgb2.c |0 drivers/net/chelsio/pm3393.c |0 drivers/net/chelsio/sge.c|0 drivers/net/chelsio/sge.h|0 4 f

Re: [PATCH 0/3] cxgb - driver fixes.

2007-12-01 Thread Divy Le Ray
Ben Greear wrote: Divy Le Ray wrote: Jeff, I'm submitting a patch series for inclusion in 2.6.24 for the cxgb driver. The patches are built against Linus'git tree. Here is a brief description: - Ensure that GSO skbs have enough headroom before encapsulating them, - Fix a crash in

[PATCH 3/3] cxgb - fix stats

2007-11-27 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Fix MAC stats accounting. Fix get_stats. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/chelsio/cxgb2.c | 67 +++-- drivers/net/chelsio/pm3393.c | 112 +- drivers

[PATCH 1/3] cxgb - fix T2 GSO

2007-11-27 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> The patch ensures that a GSO skb has enough headroom to push an encapsulating cpl_tx_pkt_lso header. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/chelsio/cxgb2.c |3 ++- drivers/net/chelsio/sg

[PATCH 2/3] cxgb - fix NAPI

2007-11-27 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> netif_rx_complete() should be called only when work_done < budget. Signed-off-by: Divy Le ray <[EMAIL PROTECTED]> --- drivers/net/chelsio/sge.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/

[PATCH 0/3] cxgb - driver fixes.

2007-11-27 Thread Divy Le Ray
and report. Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/9 RESEND] cxgb3 - Use wild card for PCI subdevice ID match

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Subdevice ID is not necessarily set to 1. Use wild card for PCI device matching Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c | 24 1 files changed, 12 insertions(+), 12 deleti

Re: [PATCH 2/9] cxgb3 - Use wild card for PCI vendor ID match

2007-11-16 Thread Divy Le Ray
Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Vendor ID is not necessarily set to 1. This patch modifies the sub-device id, not the vendor id ... Use Vendor Id wild card for PCI device matching Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drive

[PATCH 9/9] cxgb3 - Fix I/O synchronization

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Synchronize memory access before ringing the Tx door bell. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/sge.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/cxgb3/sge.c b

[PATCH 8/9] cxgb3 - HW set up updates

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Disable PEX errors. The HW generates false positives. Update RSS hash function to a symmetric algorithm. Update T3C HW support Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c |2 +- drivers/net/

[PATCH 7/9] cxgb3 - sysfs methods clean up

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Remove unused argument in sysfs methods Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c | 19 +-- 1 files changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/net/cxgb3/cxgb3_main

[PATCH 6/9] cxgb3 - fix interaction with pktgen

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Do not use skb->cb to stash unmap info, save the info to the descriptor state. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/sge.c | 82 +++ 1 files changed, 40 in

[PATCH 4/9] cxgb3 - Add EEH support

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Add PCI recovery support Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c | 107 1 files changed, 107 insertions(+), 0 deletions(-) diff --git a/drivers/net/cxgb3/cx

[PATCH 5/9] cxgb3 - FW upgrade

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Bump up FW version to 5.0. Do not downgrade FW within the same major version range. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/t3_hw.c | 10 +++--- drivers/net/cxgb3/version.h |4 ++-- 2 files changed,

[PATCH 2/9] cxgb3 - Use wild card for PCI vendor ID match

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Vendor ID is not necessarily set to 1. Use Vendor Id wild card for PCI device matching Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c | 24 1 files changed, 12 insertions(+),

[PATCH 3/9] cxgb3 - Fix resources release.

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Remove sysfs entries before unregistering the net devices. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/cxgb3/cx

[PATCH 1/9] cxgb3 - fix MSI-X failure path

2007-11-16 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Return error code when msi-x settings fail. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drive

[PATCH 0/9] cxgb3 - driver update

2007-11-16 Thread Divy Le Ray
- FW upgrade - Fix interaction with pktgen - Remove unused argument in sysfs related methods - HW setup update - Synchronize I/O access on Tx path Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordom

[PATCH] chelsio - Fix skb->dev setting

2007-11-15 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> eth_type_trans() now sets skb->dev. Access skb->def after it gets set. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/chelsio/sge.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/n

Re: reproducible cxgb kernel panic in FC8 kernel 2.6.23.1-49

2007-11-15 Thread Divy Le Ray
bviously forgot the chelsio driver. I'm a bit behind on T2 updates. I will get to it in a few days. Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH net-2.6.24] cxgb3 - napi update

2007-09-09 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Embed napi_struct directly into sge_qset. Use napi_schedule/napi_complete. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/adapter.h| 20 +++--- drivers/net/cxgb3/cxgb3_main.c | 57 ++-

net-26.24 broken with XFRM off

2007-09-06 Thread Divy Le Ray
ix connected socket to use transformation. Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 5/7 RESEND] cxgb3 - CQ context operations time out too soon.

2007-09-05 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Currently, the driver only tries up to 5 times (5us) to get the results of a CQ context operation. Testing has shown the chip can take as much as 50us to return the response on SG_CONTEXT_CMD operations. So we up the retry count to 100 to cover high

[PATCH 7/7] cxgb3 - Update engine microcode version

2007-09-05 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> The new microcode engine version is set to 1.1.0 Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/cxgb3/common.h b/drive

[PATCH 4/7 RESEND] cxgb3 - Set the CQ_ERR bit in CQ contexts.

2007-09-05 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> The cxgb3 driver is incorrectly configuring the HW CQ context for CQ's that use overflow-avoidance. Namely the RDMA control CQ. This results in a bad DMA from the device to bus address 0. The solution is to set the CQ_ERR bit in the context for

[PATCH 6/7] cxgb3 - Add T3C rev

2007-09-05 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> add driver recognition for T3C rev board. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |1 + drivers/net/cxgb3/cxgb3_main.c |3 +++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a

[PATCH 2/7 RESEND] cxgb3 - log and clear PEX errors

2007-09-05 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Clear pciE PEX errors late at module load time. Log details when PEX errors occur. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/t3_hw.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drive

[PATCH 3/7 RESEND] cxgb3 - remove false positive in xgmac workaround

2007-09-05 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Qualify toggling of xgmac tx enable with not getting pause frames, we might not make forward progress because the peer is sending lots of pause frames. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |1 +

[PATCH 1/7 RESEND] cxgb3 - Firmware update

2007-09-05 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Update firmware version. Allow the driver to be up and running with older FW image Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |2 +- drivers/net/cxgb3/cxgb3_main.c |9 + drivers/net/c

Re: [PATCH 9/11] cxgb3 - engine microcode update

2007-09-05 Thread Divy Le Ray
> > I think 9-14 still need to be incorporated. I don't see them in your > upstream branch, and they aren't in linus' tree either. I am not the blocker here. Sorry for the delay - again. I'm resubmitting these patches against net#upstream. Cheers, Divy -

[PATCH 2.6.23 2/2] - cxgb3 engine microcode load

2007-08-29 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Load the engine microcode when an interface is brought up, instead of of doing it when the module is loaded. Loosen up tight binding between the driver and the engine microcode version. There is no need for microcode update with T3A boards. Fix th

[PATCH 2.6.23 1/2] cxgb3 - Fix dev->priv usage

2007-08-29 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> cxgb3 used netdev_priv() and dev->priv for different purposes. In 2.6.23, netdev_priv() == dev->priv, cxgb3 needs a fix. This patch is a partial backport of Dave Miller's changes in the net-2.6.24 git branch. Without this fix, cxgb3

[PATCH 2.6.23 0/2] cxgb3 driver fixes

2007-08-29 Thread Divy Le Ray
me - when a port is brought up as opposed to the module getting loaded. It does a better job at logging the loading activity, and loosen the strict version requirement currently in place. Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a m

Re: [PATCH 2.6.23 0/2] cxgb3 - Fix dev->priv usage

2007-08-29 Thread Divy Le Ray
ards and defaults to t3a_protocol_sram-1.0.44.bin even for T3B boards. I submitted a patch fixing this in netdev#upstream. I should propose the fix for 2.6.23 instead. Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED

[PATCH 2/2] iw_cxgb3 - dev->priv fix follow up

2007-08-28 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> The RDMA driver sitting on top of cxgb3 now uses the exported function dev2t3cdev() to retrieve the the t3cdev associated with a net_device. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/infiniband/hw/cxgb3/cxio_hal.c |2

[PATCH 2.6.23 1/2] cxgb3 - Fix dev->priv usage

2007-08-28 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> cxgb3 used netdev_priv() and dev->priv for different purposes. In 2.6.23, netdev_priv() == dev->priv, cxgb3 needs a fix. This patch is a partial backport of Dave Miller's changes in the net-2.6.24 git branch. Without this fix, cxgb3

[PATCH 2.6.23 0/2] cxgb3 - Fix dev->priv usage

2007-08-28 Thread Divy Le Ray
Jeff/Roland, I'm resubmitting the cxgb3 dev->priv fix for inclusion in 2.6.23. I also submit a follow-up patch for the iw_cxgb3 driver that fixes the previous infiniband breakage. Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a

Re: [PATCH 2.6.23 RESEND] cxgb3 - Fix dev->priv usage

2007-08-28 Thread Divy Le Ray
m adapter.h to an exported dev2t3cdev() in cxgb3_offload.c. Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2.6.23 RESEND] cxgb3 - Fix dev->priv usage

2007-08-23 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> cxgb3 used netdev_priv() and dev->priv for different purposes. In 2.6.23, netdev_priv() == dev->priv, cxgb3 needs a fix. This patch is a partial backport of Dave Miller's changes in the net-2.6.24 git branch. Without this fix, cxgb3

Re: [PATCH 0/3] cxgb3 driver update

2007-08-23 Thread Divy Le Ray
values passed to pci_write_config_dword() and it expects a host-endian as the last argument... It looks like a bug. Thanks for spotting this. Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 14/11] cxgb3 - CQ context operations time out too soon.

2007-08-22 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Currently, the driver only tries up to 5 times (5us) to get the results of a CQ context operation. Testing has shown the chip can take as much as 50us to return the response on SG_CONTEXT_CMD operations. So we up the retry count to 100 to cover high

[PATCH 13/11] cxgb3 - Set the CQ_ERR bit in CQ contexts.

2007-08-22 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> The cxgb3 driver is incorrectly configuring the HW CQ context for CQ's that use overflow-avoidance. Namely the RDMA control CQ. This results in a bad DMA from the device to bus address 0. The solution is to set the CQ_ERR bit in the context for

[PATCH 12/11] cxgb3 - remove false positive in xgmac workaround

2007-08-22 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Qualify toggling of xgmac tx enable with not getting pause frames, we might not make forward progress because the peer is sending lots of pause frames. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |1 +

[PATCH 0/3] cxgb3 driver update

2007-08-22 Thread Divy Le Ray
t the CQ_ERR bit in RDMA CQ contexts. - Update CQ context operations time out values Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 10/11] cxgb3 - Firmware update

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Update firmware version Allow the driver to be up and running with older FW image Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |2 +- drivers/net/cxgb3/cxgb3_main.c |9 + drivers/net/c

[PATCH 11/11] cxgb3 - log and clear PEX errors

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Clear pciE PEX errors late at module load time. Log details when PEX errors occur. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/t3_hw.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drive

[PATCH 8/11] cxgb3 - Update internal memory management

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Set PM1 internal memory to round robin mode It balances access to this internal memory for multiport adapters. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/regs.h |2 ++ drivers/net/cxgb3/t3_hw.c |2 ++ 2 file

[PATCH 9/11] cxgb3 - engine microcode update

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Load microcode engine when the interface is configured up. Bump up version to 1.1.0. Allow the driver to be and running with older microcode images. Allow ethtool to log the microcode version. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> ---

[PATCH 6/11 RESEND] cxgb3 - Fatal error update

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Stop the MAC when a fatal error is detected. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drive

[PATCH 7/11 RESEND] cxgb3 - log adapter serial number

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Log HW serial number when cxgb3 module is loaded. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |2 ++ drivers/net/cxgb3/cxgb3_main.c |6 -- drivers/net/cxgb3/t3_hw.c |3 ++- 3 file

[PATCH 5/11 RESEND] cxgb3 - tighten checks on TID values

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Enforce validity checks on connection ids Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_defs.h| 20 ++-- drivers/net/cxgb3/cxgb3_offload.c | 28 +++- 2 files

[PATCH 3/11 RESEND] cxgb3 - use immediate data for offload Tx

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Send small TX_DATA work requests as immediate data even when there are fragments. this avoids doing multiple DMAs for small fragmented packets. The driver already implements this optimization for small contiguous packets. Signed-off-by: Divy Le Ray &

[PATCH 4/11 RESEND] cxgb3 - Expose HW memory page info

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> A HW issue requires limiting the receive window size to 23 pages of internal memory. These pages can be configured to different sizes, thus the RDMA driver needs to know the page size to enforce the upper limit. Also assign explicit enum values. Sign

[PATCH 1/11 RESEND] cxgb3 - Update rx coalescing length

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Reduce Rx coalescing length to 12288 Large bursts from the adapter to the host create back pressure on the chip. Reducing the burst size avoids the issue. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |2

[PATCH 2/11 RESEND] cxgb3 - SGE doorbell overflow warning

2007-08-21 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Log doorbell Fifo overflow Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/regs.h |8 drivers/net/cxgb3/sge.c |4 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/net/cxgb3/regs

[PATCH 0/11] cxgb3 - driver updates

2007-08-21 Thread Divy Le Ray
ocode management, version is now 1.1.0 - Update FW management, version is now 4.6.0 - Ignore some HW errors until the HW is initialized Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordom

Re: [PATCH 9/13] cxgb3 - Update internal memory management

2007-08-14 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: > From: Divy Le Ray <[EMAIL PROTECTED]> > > Set PM1 internal memory to round robin mode > > Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> why? For multiport adapters, it balances access to this internal memory. Divy - To

Re: [PATCH 5/13] cxgb3 - Expose HW memory page info

2007-08-14 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: From: Divy Le Ray <[EMAIL PROTECTED]> Let the RDMA driver get HW page info to work around HW issues. Assign explicit enum values. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> "HW issues" -- you need to go into far more det

Re: [PATCH 4/13] cxgb3 - use immediate data for offload Tx

2007-08-14 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: > From: Divy Le Ray <[EMAIL PROTECTED]> > > Send small TX_DATA work requests as immediate data even when > there are fragments. > > Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> > --- > > drivers/net/cxgb3/sge.c |

Re: [PATCH 2/13] cxgb3 - Update rx coalescing length

2007-08-14 Thread Divy Le Ray
Jeff Garzik wrote: Divy Le Ray wrote: > From: Divy Le Ray <[EMAIL PROTECTED]> > > Set max Rx coalescing length to 12288 > > Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> > --- > > drivers/net/cxgb3/common.h |2 +- > 1 files changed, 1 insertions(+),

[PATCH 2.6.23] cxgb3 - Fix dev->priv usage

2007-08-13 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> cxgb3 used netdev_priv() and dev->priv for different purposes. In 2.6.23, netdev_priv() == dev->priv, cxgb3 needs a fix. This patch is a partial backport of Dave Miller's changes in the net-2.6.24 git branch. Signed-off-by: Divy Le Ray

[PATCH 0/13] cxgb3 - driver updates

2007-08-10 Thread divy
pdate FW management, version is now 4.6.0 - Ignore some HW errors until the HW is initialized - Check MSI/MSI-X after it got enabled Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordom

[PATCH 13/13] cxgb3 - test MSI capabilities

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Check that the HW in really in MSI/MSI-X mode when it was succesfully enabled. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c | 42 drivers/net/cxgb3/regs.h |

[PATCH 12/13] cxgb3 - log and clear PEX errors

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Clear pciE PEX errors late at module load time. Log details when PEX errors occur. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/t3_hw.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/drive

[PATCH 11/13] cxgb3 - Firmware update

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Update firmware version Allow the driver to be up and running with older FW image Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |2 +- drivers/net/cxgb3/cxgb3_main.c |9 + drivers/net/c

[PATCH 6/13] cxgb3 - tighten checks on TID values

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Enforce validity checks on connection ids Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_defs.h| 20 ++-- drivers/net/cxgb3/cxgb3_offload.c | 28 +++- 2 files

[PATCH 10/13] cxgb3 - engine microcode update

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Load microcode engine when the interface is configured up. Bump up version to 1.1.0. Allow the driver to be and running with older microcode images. Allow ethtool to log the microcode version. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> ---

[PATCH 7/13] cxgb3 - Fatal error update

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Stop the MAC when a fatal error is detected. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/cxgb3/cxgb3_main.c b/drive

[PATCH 8/13] cxgb3 - log adapter derial number

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Log HW serial number when cxgb3 module is loaded. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |2 ++ drivers/net/cxgb3/cxgb3_main.c |6 -- drivers/net/cxgb3/t3_hw.c |3 ++- 3 file

[PATCH 9/13] cxgb3 - Update internal memory management

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Set PM1 internal memory to round robin mode Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/regs.h |2 ++ drivers/net/cxgb3/t3_hw.c |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/

[PATCH 3/13] cxgb3 - SGE doorbell overflow warning

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Log doorbell Fifo overflow Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/regs.h |8 drivers/net/cxgb3/sge.c |4 2 files changed, 12 insertions(+), 0 deletions(-) diff --git a/drivers/net/cxgb3/regs

[PATCH 4/13] cxgb3 - use immediate data for offload Tx

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Send small TX_DATA work requests as immediate data even when there are fragments. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/sge.c | 17 +++-- 1 files changed, 11 insertions(+), 6 deletions(-) diff --g

[PATCH 5/13] cxgb3 - Expose HW memory page info

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Let the RDMA driver get HW page info to work around HW issues. Assign explicit enum values. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_ctl_defs.h | 52 +--- drivers/net/cxgb3/cxg

[PATCH 1/13] cxgb3 - MAC workaround update

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Update the MAC workaround to deal with switches that do not honor pause frames. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |1 + drivers/net/cxgb3/xgmac.c | 22 +++--- 2 files changed, 1

[PATCH 2/13] cxgb3 - Update rx coalescing length

2007-08-10 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Set max Rx coalescing length to 12288 Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/common.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/cxgb3/common.h b/drivers/net/cxgb3/co

Re: [2.6 patch] drivers/net/cxgb3/xgmac.c: remove dead code

2007-07-31 Thread Divy Le Ray
Adrian Bunk wrote: This patch removes dead code ("tx_xcnt" can never be != 0 at this place) spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Acked-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/xgmac.c |5 + 1 fil

Re: [PATCH] [drivers/net/cxgb3] removed several unneeded zero initilization

2007-07-20 Thread Divy Le Ray
Denis Cheng wrote: Cc: [EMAIL PROTECTED] Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> Acked-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/cxgb3_main.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/cxgb3/cxgb3_main.c b

Re: Who's allowed to set a skb destructor?

2007-07-05 Thread Divy Le Ray
oducing this code was discussed at the time. http://marc.info/?l=linux-netdev&m=117029329230969&w=2 Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2.6.22-rc5] cxgb2: handle possible NULL pointer dereferencing, take 2

2007-06-26 Thread Divy Le Ray
ore, and it has been quite stable. The activity is low. Cheers, Divy - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html - To unsubscribe from this li

[PATCH 2.6.22] cxgb3 - fix register to stop bc/mc traffic

2007-06-25 Thread Divy Le Ray
From: Divy Le Ray <[EMAIL PROTECTED]> Use the right register to stop broadcast/multicast traffic. Signed-off-by: Divy Le Ray <[EMAIL PROTECTED]> --- drivers/net/cxgb3/xgmac.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/cxgb3/xgmac

  1   2   3   >