Ok, I will respin the failed patches.
Thanks,
-Dhananjay
On Sat, 12 Jan 2008, Jeff Garzik wrote:
> patch conflicted with
>
> commit 1706287f6eb58726a9a0e5cbbde87f49757615e3
> Author: David S. Miller <[EMAIL PROTECTED]>
> Date: Mon Jan 7 20:51:29 2008 -0800
>
&g
lades caused by buggy
(non) processing rx status ring.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxen_nic.h
===
--- netdev-2.6.orig/drivers/net/netxen/netxen_nic.h
+++ netdev-2.6/
I agree for tx desc, the compiler would optimize.
But for rx (status) desc, I didn't like multiple le64_to_cpu()
for extracting various fields out of same status dword.
-Dhananjay
On Wed, 26 Dec 2007, Al Viro wrote:
> On Wed, Dec 26, 2007 at 10:23:59AM -0800, [EMAIL PROTECTED] wrote:
ssary check for tx
timeout in the driver itself, the network stack does that anyway.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: upstream/drivers/net/netxen/netxen_nic_main.c
===
--- upstream.orig/drivers
This patch fixes bug that doesn't quiesce second port when interface is
brought down, which could lead to unwarranted interrupt during rmmod /
ifdown.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: upstream/drivers/net/netxen/netxe
This patch simplifies netxen ISR and poll() routine. Interrupts are not
unmasked in interrupt routine based on a racy has_work() checks, but
left to the napi poll function to enable them.
This also fixes crash in netif_rx_action(), when work_done == budget.
Signed-off-by: Dhananjay Phadke
Recent netxen firmware has new scheme of generating MSI interrupts, it
raises interrupt and blocks itself, waiting for driver to unmask. This
reduces chance of spurious interrupts.
The driver will be able to deal with older firmware as well.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTEC
) processing rx status ring.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxen_nic.h
===
--- netdev-2.6.orig/drivers/net/netxen/netxen_nic.h
+++ netdev-2.6/drivers/net/netxen/netxen
Bumping up driver version to 3.4.18, several fixes have gone in since
version 3.4.2.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: upstream/drivers/net/netxen/netxen_nic.h
===
--- upstream.orig/drivers/net/
Changing MAINTAINERS for netxen nic driver.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: upstream/MAINTAINERS
===
--- upstream.orig/MAINTAINERS
+++ upstream/MAINTAINERS
@@ -2738,8 +2738,8 @@ T:git kern
Resending recent patch set with an additional patch to fix byte
ordering in tx desc besides the original bug fixes and some
enhancements in tx and rx.
Recreated these patches from a fresh cloned tree.
Thanks,
Dhananjay
--
MAINTAINERS |4 +-
drivers/net
Supposedly I had 2.6.24-rc2 as base for the patchset, but looks like it
had some stale code. I'll regenrate series on a fresh checkout.
-Dhananjay
On Sat, 22 Dec 2007, Jeff Garzik wrote:
> Patch does not apply to 2.6.24-rc.
>
> Was this "bug fix" series meant for
Probably I need to clean up much more junk like that from days before I
took over. I recently cleaned up a bit of rx and tx code, which is more
frequently executed.
The last one (byte swapping) is serious and I am gonna take care of that
in next patch.
Thanks,
-Dhananjay
On Sun, 23 Dec 2007
This patch fixes bug that doesn't quiesce second port when interface is
brought down, which could lead to unwarranted interrupt during rmmod/ifdown.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxe
Recent netxen firmware has new scheme of generating MSI interrupts, it
raises interrupt and blocks itself, waiting for driver to unmask. This
reduces chance of spurious interrupts.
The driver will be able to deal with older firmware as well.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTEC
ssary check for tx timeout
in the driver itself, the network stack does that anyway.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxen_nic_main.c
===
--- netdev-2.6.orig/drivers
This patch simplifies netxen ISR and poll() routine. Interrupts are not
unmasked in interrupt routine based on a racy has_work() checks, but left
to the poll function to enable them.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxen_nic_
Bumping up driver version to 3.4.18, several fixes have gone in since version
3.4.2.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxen_nic.h
===
--- netdev-2.6.orig/drivers/net/
Changing MAINTAINERS for netxen nic driver.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/MAINTAINERS
===
--- netdev-2.6.orig/MAINTAINERS
+++ netdev-2.6/MAINTAINERS
@@ -2738,8 +2738,8 @@ T:
Sending out 4 bugfixes and some improvements for the netxen nic driver.
Also updating driver version and maintainer. The patches are generated
against upstream branch.
MAINTAINERS |4 +-
drivers/net/netxen/netxen_nic.h | 10 +-
drivers/net/netxen/netxe
This looks good to me, I might chop off these #if 0 'ed functions in
my next round of patches.
Acked-by: Dhananjay Phadke <[EMAIL PROTECTED]>
On 11/5/07, Adrian Bunk <[EMAIL PROTECTED]> wrote:
> This patch contains the following cleanups:
> - static functions in .c fi
reporting in detail.
-Dhananjay
Vernon Mauery wrote:
> In doing some stress testing of the NetXen driver, I found that my machine
> was
> dying in all sorts of weird ways. I saw several different crashes, BUG
> messages in the TCP stack and some assert messages in the TCP stack as
Resubmitting the patch.
This patch improves ethtool support for printing correct ring statistics,
segmentation offload status, etc.
Signed-off by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxen
oops, ok regenerating patch 3 only.
On Fri, 31 Aug 2007, Jeff Garzik wrote:
> [EMAIL PROTECTED] wrote:
> > +static int netxen_nic_set_rx_csum(struct net_device *dev, u32 data)
> > +{
> > + struct netxen_adapter *adapter = netdev_priv(dev);
> > + adapter->rx_csum = 0;
> > + return 0;
> > +}
This patch improves ethtool support for printing correct ring statistics,
segmentation offload status, etc.
Signed-off by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxen_nic.h
===
--- netd
3 bugfixes for netxen NIC driver: one removes firmware initialzation
workaround, other fixes a crash during driver unload and third improves
ethtool support.
Generated against upstream-fixes branch.
drivers/net/netxen/netxen_nic.h |2 +-
drivers/net/netxen/netxen_nic_ethtool.c |
probe.
Signed-off by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxen_nic_main.c
===
--- netdev-2.6.orig/drivers/net/netxen/netxen_nic_main.c
+++ netdev-2.6/drivers/net/netxen/netxen_nic_main.c
@@ -
This patch fixes two problems during driver unload. The pci_disable_device()
call is before firmware reload, causing reads and writes across PCI bus after
disabling device. Second problem is the register window was wrong during
firmware reload
Signed-off by: Dhananjay Phadke <[EMAIL PROTEC
Some leftover code that makes use of adapter->lock in tx_timeout function,
which resets the interface under this lock. In close() when the workqueue
is flushed, prints the warning about sleeping with interrupts disabled
(when spinlock debug is enabled). The lock was required with private netxen
IOC
This is a workaround for firmware bug with 2nd port of multiport adapter,
where MAC address is reset. Driver just needs to overwrite it with the
value read from PROM.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxen_nic_
Resending the earlier patches, since the old patch got committed.
drivers/net/netxen/netxen_nic_main.c | 40 +
1 files changed, 21 insertions(+), 19 deletions(-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EM
This patch fixes masking of interrupts on multiport adapters. Also disables
interrupts upon ifdown interface. The wrong mask could result in interrupt
flood after interface is down.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxen_nic_
: Fix interrupt handling for multiport adapters
Thanks,
Dhananjay
On 7/25/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
[EMAIL PROTECTED] wrote:
> The firmware should be loaded after resetting hardware during PCI probe,
> besides module unload. This fixes issue with 2nd port of multiport
Jeff,
Any chance of these patches getting committed soon?
Thanks,
-Dhananjay Phadke
On 7/21/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:
These patches include fix for problem with 2nd port of multiport adapters
on IBM blades. Also improves interrupt handling for multiport ad
: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off-by: Wen Xiong <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxen_nic_main.c
===
--- netdev-2.6.orig/drivers/net/netxen/netxen_nic_main.c
+++ netdev-2.6/driver
This patch fixes masking of interrupts on multiport adapters. Also disables
interrupts upon ifdown interface. The wrong mask could result in interrupt
flood after interface is down.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen/netxen_nic_
These patches include fix for problem with 2nd port of multiport adapters
on IBM blades. Also improves interrupt handling for multiport adapters
avoiding interrupt flood after interrupt is down.
Generated against upstream-fixes.
drivers/net/netxen/netxen_nic.h |3 +-
drivers/net/net
Please ignore this patch. There's one more patch in the series. I will
send them together.
Thanks,
-Dhananjay
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Couple of bug fixes for netxen IMEZ adapter on powerpc blades. The firmware
must be loaded during probe and free PCI resources during module unload.
Please apply against #upstream-fixes.
drivers/net/netxen/netxen_nic.h |3 +-
drivers/net/netxen/netxen_nic_main.c | 48 ++
module unload are also suppressed.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off-by: Milan Bag <[EMAIL PROTECTED]>
Signed-off-by: Wen Xiong <[EMAIL PROTECTED]>
Index: netdev-2.6/drivers/net/netxen
Couple of bug fixes for netxen IMEZ adapter on powerpc blades. The firmware
must be loaded during probe and free PCI resources during module unload.
Please apply against #upstream-fixes.
drivers/net/netxen/netxen_nic.h |3 +-
drivers/net/netxen/netxen_nic_main.c | 48 ++
The MSI error wasn't fatal, so it was suppressed in recent fixes for
2.6.22-rc7. The driver in 2.6.21 had many bugs, but I ain't sure if
recent fixes are going to be pulled in Fedora kernel.
-Dhananjay
Ben Greear wrote:
> Hello!
>
> I just got some Netxen 10Gbe CX4 adapter
Yes those functions are large enough to be de-inlined. I would like to
shrink those to functions, by replacing the switch blocks with a simple
macros, since the mask registers are contiguous.
Will repost a patch based on your patch, after a bit of testing.
Thanks,
-Dhananjay
Stephen Hemminger
Resending patch 3/3 only.
These changes allow driver close routine to be called during module unload,
to clean-up buffers and other software resources, flush queues etc. Also,
hardware is reset to pristine state.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off-by: Mil
NetXen driver uses PCI function 0 to provide the functionality of MSI.
The patch makes driver check the bus master bit for function 0 and
enable it after the card initialization.
Signed-off-by: Dhananjay Phadke<[EMAIL PROTECTED]>
Signed-off-by: Milan Bag <[EMAIL PROTECTED]>
Signed
These changes allow driver close routine to be called during module unload,
to clean-up buffers and other software resources, flush queues etc. Also,
hardware is reset to pristine state.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off-by: Milan Bag <[EMAIL PROTECTED]>
Removed signal_pending checks during init, per Jeff's suggestion.
drivers/net/netxen/netxen_nic.h | 180 +++---
drivers/net/netxen/netxen_nic_hdr.h |2 +
drivers/net/netxen/netxen_nic_hw.c | 33 --
drivers/net/netxen/netxen_nic_init.c |
This patch updates the various access routines to access different
control and status settings present in different register locations.
This will fix problems related to working of different ports in
multi Port card.
Signed-off by: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off by: Mil
These changes allow driver close routine to be called during module unload,
to clean-up buffers and other software resources, flush queues etc. Also,
hardware is reset to pristine state.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off-by: Milan Bag <[EMAIL PROTECTED]>
This patch updates the various access routines to access different
control and status settings present in different register locations.
This will fix problems related to working of different ports in
multi Port card.
Signed-off by: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off by: Mil
Resending with changes suggested.
--
Dhananjay Phadke
NetXen Inc.
drivers/net/netxen/netxen_nic.h | 177 +++---
drivers/net/netxen/netxen_nic_hdr.h |2 +
drivers/net/netxen/netxen_nic_hw.c | 39 +--
drivers/net/netxen/netxen_nic_init.c
NetXen driver uses PCI function 0 to provide the functionality of MSI.
The patch makes driver check the bus master bit for function 0 and
enable it after the card initialization.
Signed-off-by: Dhananjay Phadke<[EMAIL PROTECTED]>
Signed-off-by: Milan Bag <[EMAIL PROTECTED]>
Signed
This stage is safe to bail out on signal. It's initializing about a
hundred registers
and trying to guaranty by retrying, so can get stretched too much on faulty h/w.
-Dhananjay
On 7/1/07, Jeff Garzik <[EMAIL PROTECTED]> wrote:
While strictly this is true, I strongly urge the
This patch updates the various access routines to access different
control and status settings present in different register locations.
This will fix problems related to working of different ports in
multi Port card.
Signed-off by: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off by: Mil
These changes allow driver close routine to be called during module unload,
to clean-up buffers and other software resources, flush queues etc. Also,
hardware is reset to pristine state.
Signed-off-by: Dhananjay Phadke <[EMAIL PROTECTED]>
Signed-off-by: Milan Bag <[EMAIL PROTECTED]>
Sending reworked patches based on Michael's feedback (originally sent
by Mithlesh Thukral). These patches address interrupt mask issues on
multiport adapters, as well as stability issues on powerpc blades.
--
Dhananjay Phadke
NetXen Inc.
drivers/net/netxen/netxen_nic.h |
NetXen driver uses PCI function 0 to provide the functionality of MSI.
The patch makes driver check the bus master bit for function 0 and
enable it after the card initialization.
Signed-off-by: Dhananjay Phadke<[EMAIL PROTECTED]>
Signed-off-by: Milan Bag <[EMAIL PROTECTED]>
Signed
There's change of guard from NetXen side. I have reworked Mithlesh's
original patches based on Michael's feedback. Will be sending out shortly.
--
Dhananjay Phadke
NetXen Inc.
On 6/22/07, Mithlesh Thukral <[EMAIL PROTECTED]> wrote:
Hi All,
I will be sending updates
Mithlesh,
You don't initialize max_mc_count anywhere. The multicast address pool
can hold 16 addresses for ports {0,1} and 4 for ports {2,3}. You should
have following line in the probe routine.
> adapter->max_mc_count = (adapter->portnum > 1) ? 4 : 16;
--
Dhananjay
rate specified in the tc
command.
Is getting poor performance after running tc over a bond is a known issue?
Please help me with this issue.
Thanks and regards,
---Dhananjay.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTE
60 matches
Mail list logo
