[v2 PATCH] net: ethernet: mtk-star-emac: fix wrong unmap in RX handling

2021-03-02 Thread Biao Huang
ot;) Acked-by: Bartosz Golaszewski Signed-off-by: Biao Huang --- drivers/net/ethernet/mediatek/mtk_star_emac.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c index a8

[v2 PATCH 0/1] net: ethernet: mtk-star-emac: fix wrong unmap in RX handling

2021-03-02 Thread Biao Huang
V2: update the comment for unmapping the old skb Biao Huang (1): net: ethernet: mtk-star-emac: fix wrong unmap in RX handling drivers/net/ethernet/mediatek/mtk_star_emac.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.25.1

[PATCH] net: ethernet: mtk-star-emac: fix wrong unmap in RX handling

2021-03-02 Thread Biao Huang
dling") Signed-off-by: Biao Huang --- drivers/net/ethernet/mediatek/mtk_star_emac.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c index a8641a407c06..96d2891f1675 100644 --- a/d

Re: [PATCH] net: stmmac: Fix RX Coalesce IOC always true issue

2020-06-09 Thread biao huang
On Tue, 2020-06-09 at 14:20 +, Jose Abreu wrote: > From: Biao Huang > Date: Jun/09/2020, 10:41:33 (UTC+00:00) > > > - rx_q->rx_count_frames += priv->rx_coal_frames; > > - if (rx_q->rx_count_frames > priv->rx_coal_frames) > > +

[PATCH] net: stmmac: Fix RX Coalesce IOC always true issue

2020-06-09 Thread Biao Huang
Currently rx_count_frames in stmmac_rx_refill always 0, which leads to use_rx_wd false, and IOC bit of rx_desc3 true forever. Fix it. Fixes: 6fa9d691b91ac ("net: stmmac: Prevent divide-by-zero") Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +

Re: [v2, PATCH 0/4] fix some bugs in stmmac

2019-05-13 Thread biao huang
Hi Andrew, Add a Fixes:tag in series v3, please review. On Tue, 2019-05-14 at 05:00 +0200, Andrew Lunn wrote: > On Tue, May 14, 2019 at 10:28:49AM +0800, Biao Huang wrote: > > changes in v2: > > > &

[v3, PATCH 1/4] net: stmmac: update rx tail pointer register to fix rx dma hang issue.

2019-05-13 Thread Biao Huang
the rx channel, so packets can be received continually Fixes: 54139cf3bb33 ("net: stmmac: adding multiple buffers for rx") Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/stmi

[v3, PATCH 2/4] net: stmmac: fix csr_clk can't be zero issue

2019-05-13 Thread Biao Huang
csr clock input") Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |6 +++--- .../net/ethernet/stmicro/stmmac/stmmac_platform.c |5 - 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b

[v3, PATCH 3/4] net: stmmac: write the modified value back to MTL_OPERATION_MODE

2019-05-13 Thread Biao Huang
The value of MTL_OPERATION_MODE is modified, and should be write back to the register. Fixes: d0a9c9f9c6d0 ("net: stmmac: configure mtl rx and tx algorithms") Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c |2 ++ 1 file changed, 2 insertions(+) di

[v3, PATCH 4/4] net: stmmac: dwmac-mediatek: modify csr_clk value to fix mdio read/write fail

2019-05-13 Thread Biao Huang
1. the frequency of csr clock is 66.5MHz, so the csr_clk value should be 0 other than 5. 2. the csr_clk can be got from device tree, so remove initialization here. Fixes: 9992f37e346b ("stmmac: dwmac-mediatek: add support for mt2712") Signed-off-by: Biao Huang --- .../net/ethern

[v3, PATCH 0/4] fix some bugs in stmmac

2019-05-13 Thread Biao Huang
dwmac-mediatek: modify csr_clk value to fix mdio read/write fail issue for dwmac-mediatek Biao Huang (4): net: stmmac: update

[v2, PATCH] add some features in stmmac

2019-05-13 Thread Biao Huang
. Biao Huang (1): net: stmmac: add support for hash table size 128/256 in dwmac4

[v2, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

2019-05-13 Thread Biao Huang
1. get hash table size in hw feature reigster, and add support for taller hash table(128/256) in dwmac4. 2. only clear PR/HMC/PM bits of GMAC_PACKET_FILTER, to avoid side effect to functions of other bits. Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/common.h |7

[v2, PATCH 4/4] net: stmmac: dwmac-mediatek: modify csr_clk value to fix mdio read/write fail

2019-05-13 Thread Biao Huang
1. the frequency of csr clock is 66.5MHz, so the csr_clk value should be 0 other than 5. 2. the csr_clk can be got from device tree, so remove initialization here. Change-Id: I3cd92fe380150fec6daa2d3acaab69a6d58344c0 Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c

[v2, PATCH 1/4] net: stmmac: update rx tail pointer register to fix rx dma hang issue.

2019-05-13 Thread Biao Huang
the rx channel, so packets can be received continually Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index

[v2, PATCH 0/4] fix some bugs in stmmac

2019-05-13 Thread Biao Huang
1 patch is for dwmac-mediatek: modify csr_clk value to fix mdio read/write fail issue for dwmac-mediatek

[v2, PATCH 3/4] net: stmmac: write the modified value back to MTL_OPERATION_MODE

2019-05-13 Thread Biao Huang
The value of MTL_OPERATION_MODE is modified, and should be write back to the register. Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c b/drivers/net

[v2, PATCH 2/4] net: stmmac: fix csr_clk can't be zero issue

2019-05-13 Thread Biao Huang
The specific clk_csr value can be zero, and stmmac_clk is necessary for MDC clock which can be set dynamically. So, change the condition from plat->clk_csr to plat->stmmac_clk to fix clk_csr can't be zero issue. Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/st

[PATCH 0/4] fix some bugs in stmmac

2019-04-28 Thread Biao Huang
iatek. Biao Huang (4): net: stmmac: update rx tail pointer register to fix rx dma hang

[v3, PATCH 0/2] add ethernet binding and modify ethernet driver for mt2712

2018-12-18 Thread Biao Huang
/2018/12/14/53 1. ethernet binding file move to this series. 2. remove fine tune property in device tree 3. remove fine tune flow in ethernet driver 4. set rgmii timing according to the value in device tree, and don't care whether phy insert internal delay or not. Biao Huang (2): net-nex

[v3, PATCH 2/2] net-next: stmmac: dwmac-mediatek: remove fine-tune property

2018-12-18 Thread Biao Huang
1. remove fine-tune property and related setting to simplify the timing adjustment flow. 2. set timing value according to the value from device tree, and will not care whether PHY insert internal delay. Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 71

[v3, PATCH 1/2] net-next: dt-binding: dwmac-mediatek: remove fine-tune property

2018-12-18 Thread Biao Huang
remove fine-tune property in device tree, modify the corresponding description in dt-binding. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 31 +++- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/Documentation/devicetree

[v2, PATCH 2/2] net-next: stmmac: dwmac-mediatek: remove fine-tune property

2018-12-17 Thread Biao Huang
1. remove fine-tune property and related setting to simplify the timing adjustment flow. 2. set timing value according to the value from device tree, and will not care whether PHY insert internal delay. Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 71

[v2, PATCH 0/2] add ethernet binding and modify ethernet driver for mt2712

2018-12-17 Thread Biao Huang
fine tune property in device tree 3. remove fine tune flow in ethernet driver 4. set rgmii timing according to the value in device tree, and don't care whether phy insert internal delay or not. Biao Huang (2): dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

[v2, PATCH 1/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

2018-12-17 Thread Biao Huang
The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 78 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree

[PATCH 2/2] net-next: stmmac: dwmac-mediatek: remove fine-tune property

2018-12-17 Thread Biao Huang
1. remove fine-tune property and related setting to simplify the timing adjustment flow. 2. set timing value according to the value from device tree, and will not care whether PHY insert internal delay. Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 71

[PATCH 1/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

2018-12-17 Thread Biao Huang
The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 78 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree

[PATCH 0/2] add ethernet binding and modify ethernet driver for mt2712

2018-12-17 Thread Biao Huang
in device tree, and don't care whether phy insert internal delay or not. Biao Huang (2): dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC net-next: stmmac: dwmac-mediatek: remove fine-tune property .../devicetree/bindings/net/mediatek-dwmac.txt |

Re: [v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-12-13 Thread biao huang
Dear Florian, Thanks for your comments. On Thu, 2018-12-13 at 21:11 -0800, Florian Fainelli wrote: > Le 12/13/18 à 7:01 PM, biao huang a écrit : > > Dear Andrew, > > Thanks for your comments. > > > > On Thu, 2018-12-13 at 13:33 +0100, Andrew Lunn wrote: >

Re: [v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-12-13 Thread biao huang
Dear Andrew, Thanks for your comments. On Thu, 2018-12-13 at 13:33 +0100, Andrew Lunn wrote: > Hi Biao > > > + case PHY_INTERFACE_MODE_RGMII: > > + /* the PHY is not responsible for inserting any internal > > +* delay by itself in PHY_INTERFACE_MODE_RGMII case, > >

Re: [v7, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

2018-12-13 Thread biao huang
Dear Andrew, Thanks for your comments. On Thu, 2018-12-13 at 13:36 +0100, Andrew Lunn wrote: > > +- mediatek,rx-delay-ps: RX clock delay macro value. Default is 0. > > + It should be defined for rgmii/rgmii-txid/mii/rmii interface. > > +Both delay properties need to be a multiple of 170

Re: [v7, PATCH 0/2] add Ethernet driver support for mt2712

2018-12-12 Thread biao huang
Dear All, Sorry, I misunderstood David's reply mail in v6 series, please ignore v7 series. Dear David, I send you another follow-up patch to fix up build warning, please check it. Thanks! On Thu, 2018-12-13 at 09:56 +0800, Biao Huang wrote: > Changes in v7: > Add MOD

[PATCH] net-next: stmmac: dwmac-mediatek: add module license info

2018-12-12 Thread Biao Huang
Add MODULE_LICENSE info to fix this: WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.o Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net

[v7, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

2018-12-12 Thread Biao Huang
The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 87 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree

[v7, PATCH 0/2] add Ethernet driver support for mt2712

2018-12-12 Thread Biao Huang
Changes in v7: Add MODULE_LICENSE info in driver. Biao Huang (2): net:stmmac: dwmac-mediatek: add support for mt2712 dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC .../devicetree/bindings/net/mediatek-dwmac.txt | 87 + drivers/net/ethernet/stmicro

[v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-12-12 Thread Biao Huang
Add Ethernet support for MediaTek SoCs from the mt2712 family Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/Kconfig|8 + drivers/net/ethernet/stmicro/stmmac/Makefile |1 + .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 413 3

[v6, PATCH 0/2] add Ethernet driver support for mt2712

2018-12-12 Thread Biao Huang
Changes in v6: modifications according to comments from Rob/Andrew/Sean: 1. use delay_ps instead of delay stage. 2. add comments in driver to avoid confusion. 2. rewrite set_delay function. 3. modify binding document for properties: tx-delay-ps/rx-delay-ps/pericfg etc. Biao Huang (2

[v6, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-12-12 Thread Biao Huang
Add Ethernet support for MediaTek SoCs from the mt2712 family Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/Kconfig|8 + drivers/net/ethernet/stmicro/stmmac/Makefile |1 + .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 408 3

[v6, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

2018-12-12 Thread Biao Huang
The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 87 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree

Re: [v5, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

2018-11-26 Thread biao huang
Dear Rob, Thanks for your comments. On Mon, 2018-11-26 at 15:46 -0600, Rob Herring wrote: > On Fri, Nov 23, 2018 at 09:31:16AM +0800, biao huang wrote: > > Dear Andrew, > > > > Thanks for you remind. > > > > Sincerely, I respect any comment fro

Re: [v2, PATCH 0/2] add Ethernet driver support for mt2712

2018-10-28 Thread biao huang
On Mon, 2018-10-29 at 11:04 +0800, Biao Huang wrote: > The mt2712 Ethernet IP is from Synopsys, so extend stmmac to support mt2712. > sorry, I forgot to add detail descriptions for these patches. changes in v2: --since STMMAC driver applied to most Synopsys ip Ethernet, I add dwmac-mediate

[PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

2018-10-28 Thread Biao Huang
The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 49 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree

[v2, PATCH 0/2] add Ethernet driver support for mt2712

2018-10-28 Thread Biao Huang
The mt2712 Ethernet IP is from Synopsys, so extend stmmac to support mt2712.

[PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

2018-10-28 Thread Biao Huang
Add Ethernet support for MediaTek SoCs from the mt2712 family Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/Kconfig|8 + drivers/net/ethernet/stmicro/stmmac/Makefile |1 + .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 364 3