[PATCH net-next] netfilter: conntrack: Remove unused variable declaration

2021-03-10 Thread YueHaibing
commit e97c3e278e95 ("tproxy: split off ipv6 defragmentation to a separate module") left behind this. Signed-off-by: YueHaibing --- include/net/netfilter/ipv6/nf_conntrack_ipv6.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/net/netfilter/ipv6/nf_conntrack_ipv6.h b/i

[PATCH] nfp: Fix passing zero to 'PTR_ERR'

2020-11-12 Thread YueHaibing
nfp_cpp_from_nfp6000_pcie() returns ERR_PTR() and never returns NULL. The NULL test should be removed, also return correct err. Fixes: 63461a028f76 ("nfp: add the PF driver") Signed-off-by: YueHaibing --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 4 +--- 1 file changed, 1 inser

[PATCH] net: dsa: sja1105: Fix return value check in sja1105_ptp_clock_register()

2020-11-12 Thread YueHaibing
quot;) Signed-off-by: YueHaibing --- drivers/net/dsa/sja1105/sja1105_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/sja1105/sja1105_ptp.c b/drivers/net/dsa/sja1105/sja1105_ptp.c index 1b90570b257b..1e41d491c854 100644 --- a/drivers/net/dsa/sja1105/sja1105_ptp.c +

[PATCH] net: macb: Fix passing zero to 'PTR_ERR'

2020-11-12 Thread YueHaibing
Check PTR_ERR with IS_ERR to fix this. Fixes: cd5afa91f078 ("net: macb: Add null check for PCLK and HCLK") Signed-off-by: YueHaibing --- drivers/net/ethernet/cadence/macb_main.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethern

[PATCH net-next] net/mlx5: Fix passing zero to 'PTR_ERR'

2020-11-12 Thread YueHaibing
never returns NULL, so NULL test should be removed. Signed-off-by: YueHaibing --- drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_ofld.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c | 2 +-

[PATCH net-next] openvswitch: Use IS_ERR instead of IS_ERR_OR_NULL

2020-10-30 Thread YueHaibing
Fix smatch warning: net/openvswitch/meter.c:427 ovs_meter_cmd_set() warn: passing zero to 'PTR_ERR' dp_meter_create() never returns NULL, use IS_ERR instead of IS_ERR_OR_NULL to fix this. Signed-off-by: YueHaibing --- net/openvswitch/meter.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH] sfp: Fix error handing in sfp_probe()

2020-10-30 Thread YueHaibing
gpiod_to_irq() never return 0, but returns negative in case of error, check it and set gpio_irq to 0. Fixes: 73970055450e ("sfp: add SFP module support") Signed-off-by: YueHaibing --- drivers/net/phy/sfp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drive

[PATCH net-next] net/mlx5e: Remove duplicated include

2020-10-30 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rx.c index 599f5b5ebc97..58c177756dc4 100644

[PATCH net-next] net: hns3: Remove duplicated include

2020-10-30 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c index 3606240025a8

[PATCH net-next] liquidio: cn68xx: Remove duplicated include

2020-10-30 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/ethernet/cavium/liquidio/cn68xx_device.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c b/drivers/net/ethernet/cavium/liquidio/cn68xx_device.c index 2a6d1cadac9e

Re: [PATCH] bpfilter: Fix build error with CONFIG_BPFILTER_UMH

2020-10-15 Thread Yuehaibing
On 2020/10/16 3:57, Alexei Starovoitov wrote: > On Thu, Oct 15, 2020 at 12:26 PM Jakub Kicinski wrote: >> >> On Thu, 15 Oct 2020 12:03:14 -0700 Alexei Starovoitov wrote: >>> On Thu, Oct 15, 2020 at 11:56 AM Jakub Kicinski wrote: How so? It's using in-tree headers instead of system ones. >

[PATCH] bpfilter: Fix build error with CONFIG_BPFILTER_UMH

2020-10-14 Thread YueHaibing
. scripts/Makefile.userprogs:43: recipe for target 'net/bpfilter/main.o' failed make[2]: *** [net/bpfilter/main.o] Error 1 Add missing include path to fix this. Signed-off-by: YueHaibing --- net/bpfilter/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ne

[PATCH net-next] netfilter: nf_tables_offload: Remove unused macro FLOW_SETUP_BLOCK

2020-09-18 Thread YueHaibing
commit 9a32669fecfb ("netfilter: nf_tables_offload: support indr block call") left behind this. Signed-off-by: YueHaibing --- net/netfilter/nf_tables_offload.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/netfilter/nf_tables_offload.c b/net/netfilter/nf_tables_offlo

[PATCH net-next] ipvs: Remove unused macros

2020-09-18 Thread YueHaibing
They are not used since commit e4ff67513096 ("ipvs: add sync_maxlen parameter for the sync daemon") Signed-off-by: YueHaibing --- net/netfilter/ipvs/ip_vs_sync.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sy

[PATCH net-next] tipc: Remove unused macro CF_SERVER

2020-09-18 Thread YueHaibing
It is no used any more, so can remove it. Signed-off-by: YueHaibing --- net/tipc/topsrv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/tipc/topsrv.c b/net/tipc/topsrv.c index 1489cfb941d8..5f6f86051c83 100644 --- a/net/tipc/topsrv.c +++ b/net/tipc/topsrv.c @@ -48,7 +48,6 @@ #define

[PATCH 2/5] wlcore: Remove unused function no_write_handler()

2020-09-18 Thread YueHaibing
There is no caller in tree, so can remove it. Signed-off-by: YueHaibing --- drivers/net/wireless/ti/wlcore/debugfs.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/net/wireless/ti/wlcore/debugfs.c b/drivers/net/wireless/ti/wlcore/debugfs.c index 48adb1876ab9..cce8d75d8b81

[PATCH] ath11k: Remove unused function ath11k_htc_restore_tx_skb()

2020-09-18 Thread YueHaibing
There is no caller in tree, so can remove it. Signed-off-by: YueHaibing --- drivers/net/wireless/ath/ath11k/htc.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/htc.c b/drivers/net/wireless/ath/ath11k/htc.c index e9e354fc11fa..4de2350dfbf3 100644

Re: [PATCH net-next] genetlink: Remove unused function genl_err_attr()

2020-09-17 Thread Yuehaibing
On 2020/9/18 2:34, Cong Wang wrote: > On Wed, Sep 16, 2020 at 9:33 AM YueHaibing wrote: >> >> It is never used, so can remove it. > > This is a bit confusing, it was actually used before, see commit > ab0d76f6823cc3a4e2. Yes,thanks for reminding, will be careful later. > . >

[PATCH v2 net-next] netdev: Remove unused functions

2020-09-16 Thread YueHaibing
There is no callers in tree, so can remove it. Signed-off-by: YueHaibing Reviewed-by: Saeed Mahameed --- v2: fix title typo 'funtions' --> 'functions' --- include/linux/netdevice.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/include/linux/netd

Re: [PATCH -next] net/sched: Remove unused function qdisc_queue_drop_head()

2020-09-16 Thread Yuehaibing
Pls drop this duplicate. On 2020/9/16 22:16, YueHaibing wrote: > It is not used since commit a09ceb0e0814 ("sched: remove qdisc->drop") > > Signed-off-by: YueHaibing > --- > include/net/sch_generic.h | 6 -- > 1 file changed, 6 deletions(-) > > dif

[PATCH net-next] net/sched: Remove unused function qdisc_queue_drop_head()

2020-09-16 Thread YueHaibing
It is not used since commit a09ceb0e0814 ("sched: remove qdisc->drop") Signed-off-by: YueHaibing --- include/net/sch_generic.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h index d60e7c39d60c..6c762457122f 100644 ---

[PATCH -next] net/sched: Remove unused function qdisc_queue_drop_head()

2020-09-16 Thread YueHaibing
It is not used since commit a09ceb0e0814 ("sched: remove qdisc->drop") Signed-off-by: YueHaibing --- include/net/sch_generic.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h index d60e7c39d60c..6c762457122f 100644 ---

[PATCH net-next] netfilter: nf_tables: Remove ununsed function nft_data_debug

2020-09-16 Thread YueHaibing
It is never used, so can be removed. Signed-off-by: YueHaibing --- include/net/netfilter/nf_tables.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/include/net/netfilter/nf_tables.h b/include/net/netfilter/nf_tables.h index 8ceca0e419b3..c4c526507ddb 100644 --- a/include/net

[PATCH net-next] netdev: Remove unused funtions

2020-09-16 Thread YueHaibing
There is no callers in tree, so can remove it. Signed-off-by: YueHaibing --- include/linux/netdevice.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 157e0242e9ee..909b1fbb0481 100644 --- a/include/linux/netdevice.h

[PATCH net-next] genetlink: Remove unused function genl_err_attr()

2020-09-16 Thread YueHaibing
It is never used, so can remove it. Signed-off-by: YueHaibing --- include/net/genetlink.h | 8 1 file changed, 8 deletions(-) diff --git a/include/net/genetlink.h b/include/net/genetlink.h index 6e5f1e1aa822..b9eb92f3fe86 100644 --- a/include/net/genetlink.h +++ b/include/net

[PATCH] brcmsmac: phytbl_lcn: Remove unused variable 'dot11lcn_gain_tbl_rev1'

2020-09-09 Thread YueHaibing
emove unused array 'dot11lcnphytbl_rx_gain_info_rev1'") left behind this, remove it. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- .../brcm80211/brcmsmac/phy/phytbl_lcn.c | 99 --- 1 file changed, 99 deletions(-) diff --git a/drivers/net/wireles

[PATCH] brcmsmac: phy_lcn: Remove unused variable lcnphy_rx_iqcomp_table_rev0

2020-09-09 Thread YueHaibing
("brcmsmac: phy_lcn: Remove a bunch of unused variables") left behind this, remove it. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- .../broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 55 --- 1 file changed, 55 deletions(-) diff --git a/drivers/net/wireless/broadcom

[PATCH] qtnfmac: Remove unused macro QTNF_DMP_MAX_LEN

2020-09-09 Thread YueHaibing
There is no caller in tree, so remove it. Signed-off-by: YueHaibing --- drivers/net/wireless/quantenna/qtnfmac/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/quantenna/qtnfmac/core.c b/drivers/net/wireless/quantenna/qtnfmac/core.c index 6aafff9d4231

[PATCH] ath10k: Remove unused macro ATH10K_ROC_TIMEOUT_HZ

2020-09-09 Thread YueHaibing
There is no caller in tree, so can remove it. Signed-off-by: YueHaibing --- drivers/net/wireless/ath/ath10k/mac.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index fed8682f266f..5991d0ac41ad 100644 --- a

[PATCH] wlcore: Remove unused macro WL1271_SUSPEND_SLEEP

2020-09-09 Thread YueHaibing
commit 45aa7f071b06 ("wlcore: Use generic runtime pm calls for wowlan elp configuration") left behind this, remove it. Signed-off-by: YueHaibing --- drivers/net/wireless/ti/wlcore/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ti/wlcore/main.c b/d

[PATCH] ath11k: Remove unused inline function htt_htt_stats_debug_dump()

2020-09-09 Thread YueHaibing
There is no caller in tree, so can remove it. Signed-off-by: YueHaibing --- .../net/wireless/ath/ath11k/debug_htt_stats.c | 44 --- 1 file changed, 44 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/debug_htt_stats.c b/drivers/net/wireless/ath/ath11k

Re: [PATCH] mwifiex: pcie: Fix -Wunused-const-variable warnings

2020-09-07 Thread Yuehaibing
commit 77dacc8fc64c ("mwifiex: pcie: Move tables to the only place they're used") do the same things. On 2020/9/7 16:34, Kalle Valo wrote: > YueHaibing wrote: > >> These variables only used in pcie.c, move them to .c file >> can silence these warnings: &g

[PATCH] mwifiex: sdio: Fix -Wunused-const-variable warnings

2020-09-02 Thread YueHaibing
not used [-Wunused-const-variable=] static const struct mwifiex_sdio_device mwifiex_sdio_sd8786 = { ^~~ Signed-off-by: YueHaibing --- drivers/net/wireless/marvell/mwifiex/sdio.c | 427 drivers/net/wireless/marvell

[PATCH] mwifiex: pcie: Fix -Wunused-const-variable warnings

2020-09-02 Thread YueHaibing
mwifiex_pcie8766 = { ^~~~ Signed-off-by: YueHaibing --- drivers/net/wireless/marvell/mwifiex/pcie.c | 149 drivers/net/wireless/marvell/mwifiex/pcie.h | 149 2 files changed, 149 insertions(+), 149 deletions

[PATCH] mwifiex: wmm: Fix -Wunused-const-variable warnings

2020-09-02 Thread YueHaibing
header file to fix these warnings. Signed-off-by: YueHaibing --- drivers/net/wireless/marvell/mwifiex/main.c | 2 ++ drivers/net/wireless/marvell/mwifiex/wmm.c | 15 +++ drivers/net/wireless/marvell/mwifiex/wmm.h | 18 ++ 3 files changed, 19 insertions(+), 16

[PATCH net-next] net/mlx5e: kTLS, Avoid kzalloc(GFP_KERNEL) under spinlock

2020-09-01 Thread YueHaibing
A spin lock is held before kzalloc, it may sleep with holding the spinlock, so we should use GFP_ATOMIC instead. This is detected by coccinelle. Fixes: 0419d8c9d8f8 ("net/mlx5e: kTLS, Add kTLS RX resync support") Signed-off-by: YueHaibing --- drivers/net/ethernet/mellanox/mlx5/cor

[PATCH net-next] net: sungem: Remove unneeded cast from memory allocation

2020-09-01 Thread YueHaibing
Remove dma_alloc_coherent return value cast. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/net/ethernet/sun/sungem.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/sun/sungem.c b/drivers/net/ethernet/sun/sungem.c index

[PATCH net-next] liquidio: Remove unneeded cast from memory allocation

2020-09-01 Thread YueHaibing
Remove unneeded return value cast. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/net/ethernet/cavium/liquidio/octeon_droq.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_droq.c b/drivers/net

[PATCH] ath11k: Mark two variables as __maybe_unused

2020-08-31 Thread YueHaibing
Fix -Wunused-variable warnings: drivers/net/wireless/ath/ath11k/debug.c:36:20: warning: ‘htt_bp_lmac_ring’ defined but not used [-Wunused-variable] drivers/net/wireless/ath/ath11k/debug.c:15:20: warning: ‘htt_bp_umac_ring’ defined but not used [-Wunused-variable] Signed-off-by: YueHaibing

[PATCH] libertas_tf: Remove unused macro QOS_CONTROL_LEN

2020-08-29 Thread YueHaibing
There is no caller in tree. Signed-off-by: YueHaibing --- drivers/net/wireless/marvell/libertas_tf/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/marvell/libertas_tf/main.c b/drivers/net/wireless/marvell/libertas_tf/main.c index 02bd7c99b358..cb494b59de93 100644

[PATCH net-next] net/wan/fsl_ucc_hdlc: Add MODULE_DESCRIPTION

2020-08-29 Thread YueHaibing
Add missing MODULE_DESCRIPTION. Signed-off-by: YueHaibing --- drivers/net/wan/fsl_ucc_hdlc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c index 9edd94679283..dca97cd7c4e7 100644 --- a/drivers/net/wan/fsl_ucc_hdlc.c +++ b

[PATCH net-next] net: dl2k: Remove unused macro DRV_NAME

2020-08-29 Thread YueHaibing
There is no caller in tree any more. Signed-off-by: YueHaibing --- drivers/net/ethernet/dlink/dl2k.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/dlink/dl2k.c b/drivers/net/ethernet/dlink/dl2k.c index be6d8a9ada27..e8e563d6e86b 100644 --- a/drivers/net/ethernet/dlink

[PATCH net-next] net: hns: Remove unused macro AE_NAME_PORT_ID_IDX

2020-08-29 Thread YueHaibing
There is no caller in tree. Signed-off-by: YueHaibing --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c index b43dec0560a8

[PATCH net-next] net: wan: slic_ds26522: Remove unused macro DRV_NAME

2020-08-29 Thread YueHaibing
There is no caller in tree any more. Signed-off-by: YueHaibing --- drivers/net/wan/slic_ds26522.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/wan/slic_ds26522.c b/drivers/net/wan/slic_ds26522.c index 29053bec694e..8e3b1c717c10 100644 --- a/drivers/net/wan/slic_ds26522.c

[PATCH] lib80211: Remove unused macro DRV_NAME

2020-08-29 Thread YueHaibing
There is no caller in tree any more. Signed-off-by: YueHaibing --- net/wireless/lib80211.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/wireless/lib80211.c b/net/wireless/lib80211.c index cc7b9fd5c166..d66a913027e0 100644 --- a/net/wireless/lib80211.c +++ b/net/wireless/lib80211.c

[PATCH net-next] tipc: Remove unused macro TIPC_NACK_INTV

2020-08-29 Thread YueHaibing
There is no caller in tree any more. Signed-off-by: YueHaibing --- net/tipc/link.c | 5 - 1 file changed, 5 deletions(-) diff --git a/net/tipc/link.c b/net/tipc/link.c index b7362556da95..a2989f22ebb6 100644 --- a/net/tipc/link.c +++ b/net/tipc/link.c @@ -216,11 +216,6 @@ enum { #define

[PATCH net-next] tipc: Remove unused macro TIPC_FWD_MSG

2020-08-29 Thread YueHaibing
There is no caller in tree any more. Signed-off-by: YueHaibing --- net/tipc/socket.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 2679e97e0389..fd5bfaab8661 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -52,7 +52,6 @@ #define

[PATCH net-next] mptcp: Remove unused macro MPTCP_SAME_STATE

2020-08-29 Thread YueHaibing
There is no caller in tree any more. Signed-off-by: YueHaibing --- net/mptcp/protocol.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c index 1aad411a0e46..e6216c4f308c 100644 --- a/net/mptcp/protocol.c +++ b/net/mptcp/protocol.c @@ -24,8 +24,6

[PATCH net-next] netfilter: xt_HMARK: Use ip_is_fragment() helper

2020-08-27 Thread YueHaibing
Use ip_is_fragment() to simpify code. Signed-off-by: YueHaibing --- net/netfilter/xt_HMARK.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/xt_HMARK.c b/net/netfilter/xt_HMARK.c index 713fb38541df..8928ec56c388 100644 --- a/net/netfilter/xt_HMARK.c +++ b/net

[PATCH] net: cdc_ncm: Fix build error

2020-08-25 Thread YueHaibing
hook into set_rx_mode to admit multicast traffic") Signed-off-by: YueHaibing --- drivers/net/usb/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig index a7fbc3ccd29e..c7bcfca7d70b 100644 --- a/drivers/net/usb/Kconfig +++ b/drivers/net/usb/Kc

Re: [PATCH v2] net: stmmac: Fix signedness bug in stmmac_probe_config_dt()

2020-08-19 Thread Yuehaibing
On 2020/8/19 1:04, Andrew Lunn wrote: > On Tue, Aug 18, 2020 at 11:15:00PM +0800, YueHaibing wrote: >> The "plat->phy_interface" variable is an enum and in this context GCC >> will treat it as an unsigned int so the error handling is never >> triggered. >&

[PATCH v2] net: stmmac: Fix signedness bug in stmmac_probe_config_dt()

2020-08-18 Thread YueHaibing
The "plat->phy_interface" variable is an enum and in this context GCC will treat it as an unsigned int so the error handling is never triggered. Fixes: b9f0b2f634c0 ("net: stmmac: platform: fix probe for ACPI devices") Signed-off-by: YueHaibing --- v2: use rc to do err ha

Re: [PATCH] net: stmmac: Fix signedness bug in stmmac_probe_config_dt()

2020-08-18 Thread Yuehaibing
On 2020/8/18 22:51, Andreas Schwab wrote: > On Aug 18 2020, YueHaibing wrote: > >> The "plat->phy_interface" variable is an enum and in this context GCC >> will treat it as an unsigned int so the error handling is never >> triggered. >> >> Fixes

[PATCH] net: stmmac: Fix signedness bug in stmmac_probe_config_dt()

2020-08-18 Thread YueHaibing
The "plat->phy_interface" variable is an enum and in this context GCC will treat it as an unsigned int so the error handling is never triggered. Fixes: b9f0b2f634c0 ("net: stmmac: platform: fix probe for ACPI devices") Signed-off-by: YueHaibing --- drivers/net/

[PATCH -next] vdpa: Remove duplicate include

2020-08-18 Thread YueHaibing
Remove duplicate include file Signed-off-by: YueHaibing --- drivers/vhost/vdpa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 3fab94f88894..95e2b8307a2a 100644 --- a/drivers/vhost/vdpa.c +++ b/drivers/vhost/vdpa.c @@ -22,7 +22,6

[PATCH] dpaa2-eth: Fix passing zero to 'PTR_ERR' warning

2020-08-04 Thread YueHaibing
Fix smatch warning: drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:2419 alloc_channel() warn: passing zero to 'ERR_PTR' setup_dpcon() should return ERR_PTR(err) instead of zero in error handling case. Fixes: d7f5a9d89a55 ("dpaa2-eth: defer probe on object allocate") Signe

[PATCH net-next] fib: Fix undef compile warning

2020-08-03 Thread YueHaibing
net/core/fib_rules.c:26:7: warning: "CONFIG_IP_MULTIPLE_TABLES" is not defined, evaluates to 0 [-Wundef] #elif CONFIG_IP_MULTIPLE_TABLES ^ Fixes: 8b66a6fd34f5 ("fib: fix another fib_rules_ops indirect call wrapper problem") Signed-off-by:

[PATCH net-next] ip_vti: Fix unused variable warning

2020-07-30 Thread YueHaibing
If CONFIG_INET_XFRM_TUNNEL is set but CONFIG_IPV6 is n, net/ipv4/ip_vti.c:493:27: warning: 'vti_ipip6_handler' defined but not used [-Wunused-variable] Signed-off-by: YueHaibing --- net/ipv4/ip_vti.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv4/ip_vti.c b/net/ipv

[PATCH net-next] sfc_ef100: remove duplicated include from ef100_netdev.c

2020-07-28 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/ethernet/sfc/ef100_netdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/ef100_netdev.c b/drivers/net/ethernet/sfc/ef100_netdev.c index 4c3caac2c8cc..ec9ca81fed85 100644 --- a/drivers/net

[PATCH v2] tools/bpftool: Fix error handing in do_skeleton()

2020-07-17 Thread YueHaibing
Fix pass 0 to PTR_ERR, also dump more err info using libbpf_strerror. Fixes: 5dc7a8b21144 ("bpftool, selftests/bpf: Embed object file inside skeleton") Signed-off-by: YueHaibing Reviewed-by: Quentin Monnet --- v2: use libbpf_strerror --- tools/bpf/bpftool/gen.c | 5 - 1 file

[PATCH] tools/bpftool: Fix error return code in do_skeleton()

2020-07-14 Thread YueHaibing
The error return code should be PTR_ERR(obj) other than PTR_ERR(NULL). Fixes: 5dc7a8b21144 ("bpftool, selftests/bpf: Embed object file inside skeleton") Signed-off-by: YueHaibing --- tools/bpf/bpftool/gen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/b

[PATCH net-next] netpoll: Remove unused inline function netpoll_netdev_init()

2020-07-14 Thread YueHaibing
commit d565b0a1a9b6 ("net: Add Generic Receive Offload infrastructure") left behind this, remove it. Signed-off-by: YueHaibing --- include/linux/netpoll.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/linux/netpoll.h b/include/linux/netpoll.h index f47af135bd56..e6

[PATCH net-next] mptcp: Remove unused inline function mptcp_rcv_synsent()

2020-07-14 Thread YueHaibing
commit 263e1201a2c3 ("mptcp: consolidate synack processing.") left behind this, remove it. Signed-off-by: YueHaibing --- include/net/mptcp.h | 4 1 file changed, 4 deletions(-) diff --git a/include/net/mptcp.h b/include/net/mptcp.h index 46d0487d2b22..02158c257bd4 100644 --- a/i

[PATCH net-next] net: flow: Remove unused inline function

2020-07-14 Thread YueHaibing
It is not used since commit 09c7570480f7 ("xfrm: remove flow cache") Signed-off-by: YueHaibing --- include/net/flow.h | 18 -- 1 file changed, 18 deletions(-) diff --git a/include/net/flow.h b/include/net/flow.h index a50fb77a0b27..929d3ca614d0 100644 --- a/include/

[PATCH net-next] cipso: Remove unused inline functions

2020-07-14 Thread YueHaibing
They are not used any more since commit b1edeb102397 ("netlabel: Replace protocol/NetLabel linking with refrerence counts") Signed-off-by: YueHaibing --- include/net/cipso_ipv4.h | 12 1 file changed, 12 deletions(-) diff --git a/include/net/cipso_ipv4.h b/include/net/ci

[PATCH net-next] lan743x: Remove duplicated include from lan743x_main.c

2020-06-24 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/ethernet/microchip/lan743x_main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c index 9585467cf11c..2373e72d2d29 100644 --- a

Re: [PATCH] sunrpc: need delete xprt->timer in xs_destroy

2020-06-05 Thread Yuehaibing
The issue trigger like this: mount_fs nfs_try_mount nfs_create_server nfs_init_server nfs_init_client nfs_create_rpc_client rpc_create xprt_create_transport xs_setup_udp xs_setup_xprt INIT_DELAYED_WORK(xs_udp_setup_socket)//timer

Re: [PATCH] net: genetlink: Fix memleak in genl_family_rcv_msg_dumpit()

2020-06-02 Thread Yuehaibing
On 2020/6/3 2:04, Cong Wang wrote: > On Mon, Jun 1, 2020 at 11:47 PM YueHaibing wrote: >> @@ -630,6 +625,9 @@ static int genl_family_rcv_msg_dumpit(const struct >> genl_family *family, >> err = __netlink_dump_start(net->

[PATCH] seg6: Fix slab-out-of-bounds in fl6_update_dst()

2020-06-01 Thread YueHaibing
("seg6: fix SRH processing to comply with RFC8754") Signed-off-by: YueHaibing --- net/ipv6/exthdrs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c index 5a8bbcdcaf2b..f5304bf33ab1 100644 --- a/net/ipv6/exthdrs.c +++ b/net/ipv6

[PATCH] net: genetlink: Fix memleak in genl_family_rcv_msg_dumpit()

2020-06-01 Thread YueHaibing
nk.c:1329 [<27eb500d>] netlink_sendmsg+0x793/0xc80 net/netlink/af_netlink.c:1918 [<6e6952a8>] sock_sendmsg_nosec net/socket.c:652 [inline] [<6e6952a8>] sock_sendmsg+0x139/0x170 net/socket.c:672 Fixes: 1927f41a22a0 ("net: genetlink: introduce dum

[PATCH net-next] tipc: Fix NULL pointer dereference in __tipc_sendstream()

2020-05-28 Thread YueHaibing
Nagle algorithm effectiveness") Signed-off-by: YueHaibing --- net/tipc/socket.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index d6b67d07d22e..2943561399f1 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -1588,

[PATCH] mt76: mt7615: Use kmemdup in mt7615_queue_key_update()

2020-05-28 Thread YueHaibing
Use kmemdup rather than duplicating its implementation Signed-off-by: YueHaibing --- drivers/net/wireless/mediatek/mt76/mt7615/main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/main.c b/drivers/net/wireless/mediatek/mt76

[PATCH net-next] tipc: remove set but not used variable 'prev'

2020-05-28 Thread YueHaibing
eness") left behind this, remove it. Signed-off-by: YueHaibing --- net/tipc/msg.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/tipc/msg.c b/net/tipc/msg.c index 23809039dda1..c0afcd627c5e 100644 --- a/net/tipc/msg.c +++ b/net/tipc/msg.c @@ -212,7 +212,7 @@ int tipc_buf

Re: [PATCH v2] xfrm: policy: Fix xfrm policy match

2020-05-24 Thread Yuehaibing
On 2020/5/23 17:02, Xin Long wrote: > On Fri, May 22, 2020 at 8:39 PM Yuehaibing wrote: >> >> On 2020/5/22 13:49, Xin Long wrote: >>> On Fri, May 22, 2020 at 9:45 AM Yuehaibing wrote: >>>> >>>> On 2020/5/21 14:49, Xin Long wrote: >&g

Re: [PATCH v2] xfrm: policy: Fix xfrm policy match

2020-05-22 Thread Yuehaibing
On 2020/5/22 13:49, Xin Long wrote: > On Fri, May 22, 2020 at 9:45 AM Yuehaibing wrote: >> >> On 2020/5/21 14:49, Xin Long wrote: >>> On Tue, May 19, 2020 at 4:53 PM Steffen Klassert >>> wrote: >>>> >>>> On Fri, May 15, 2020 at 04:3

[PATCH -next] mt76: mt7915: Fix build error

2020-05-21 Thread YueHaibing
, chang it to WARN_ON. Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets") Signed-off-by: YueHaibing --- drivers/net/wireless/mediatek/mt76/mt7915/mcu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt

Re: [PATCH v2] xfrm: policy: Fix xfrm policy match

2020-05-21 Thread Yuehaibing
On 2020/5/21 14:49, Xin Long wrote: > On Tue, May 19, 2020 at 4:53 PM Steffen Klassert > wrote: >> >> On Fri, May 15, 2020 at 04:39:57PM +0800, Yuehaibing wrote: >>> >>> Friendly ping... >>> >>> Any plan for this issue? >> >> Ther

Re: [PATCH v2] xfrm: policy: Fix xfrm policy match

2020-05-15 Thread Yuehaibing
Friendly ping... Any plan for this issue? On 2020/4/22 20:53, YueHaibing wrote: > While update xfrm policy as follow: > > ip -6 xfrm policy update src fd00::1/128 dst fd00::2/128 dir in \ > priority 1 mark 0 mask 0x10 > ip -6 xfrm policy update src fd00::1/128 dst fd0

[PATCH] iwlwifi: mvm: Remove unused inline function iwl_mvm_tid_to_ac_queue

2020-05-06 Thread YueHaibing
commit cfbc6c4c5b91 ("iwlwifi: mvm: support mac80211 TXQs model") left behind this, remove it. Signed-off-by: YueHaibing --- drivers/net/wireless/intel/iwlwifi/mvm/sta.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/sta.c b/d

[PATCH net-next] net/smc: remove set but not used variables 'del_llc, del_llc_resp'

2020-05-05 Thread YueHaibing
^ net/smc/smc_llc.c: In function 'smc_llc_process_srv_delete_link': net/smc/smc_llc.c:1311:33: warning: variable 'del_llc_resp' set but not used [-Wunused-but-set-variable] struct smc_llc_msg_del_link *del_llc_resp; ^ Signed-off-by:

[PATCH net-next] net: ipa: remove duplicated include from ipa_mem.c

2020-05-05 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/net/ipa/ipa_mem.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ipa/ipa_mem.c b/drivers/net/ipa/ipa_mem.c index aa8f6b0f3d50..3ef814119aab 100644 --- a/drivers/net/ipa/ipa_mem.c +++ b/drivers/net/ipa/ipa_mem.c

[PATCH net-next] net: sierra_net: Remove unused inline function

2020-05-05 Thread YueHaibing
There's no callers in-tree Signed-off-by: YueHaibing --- drivers/net/usb/sierra_net.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/usb/sierra_net.c b/drivers/net/usb/sierra_net.c index 389d19dd7909..0abd257b634c 100644 --- a/drivers/net/usb/sierra_net.c +++ b/driver

[PATCH net-next] bnx2x: Remove unused inline function bnx2x_vf_vlan_credit

2020-05-05 Thread YueHaibing
commit 05cc5a39ddb7 ("bnx2x: add vlan filtering offload") left behind this, remove it. Signed-off-by: YueHaibing --- .../net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 21 --- 1 file changed, 21 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c

[PATCH net-next] net: sched: choke: Remove unused inline function choke_set_classid

2020-05-05 Thread YueHaibing
There's no callers in-tree anymore since commit 5952fde10c35 ("net: sched: choke: remove dead filter classify code") Signed-off-by: YueHaibing --- net/sched/sch_choke.c | 5 - 1 file changed, 5 deletions(-) diff --git a/net/sched/sch_choke.c b/net/sched/sch_choke.c ind

[PATCH net-next] sunrpc: Remove unused function ip_map_update

2020-05-05 Thread YueHaibing
commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.") left behind this, remove it. Signed-off-by: YueHaibing --- net/sunrpc/svcauth_unix.c | 9 - 1 file changed, 9 deletions(-) diff --git a/net/sunrpc/svcauth_unix.c b/net/sunrpc/svcauth_un

[PATCH net-next] net: microchip: Remove unused inline function is_bits_set

2020-05-05 Thread YueHaibing
There's no callers in-tree. Signed-off-by: YueHaibing --- drivers/net/ethernet/microchip/encx24j600-regmap.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/microchip/encx24j600-regmap.c b/drivers/net/ethernet/microchip/encx24j600-regmap.c index 1f496fa

[PATCH net-next] myri10ge: Remove unused inline function myri10ge_vlan_ip_csum

2020-05-05 Thread YueHaibing
commit 4ca3221fe4b6 ("myri10ge: Convert from LRO to GRO") left behind this, remove it. Signed-off-by: YueHaibing --- drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/d

[PATCH net-next] net: stmmac: Remove unused inline function stmmac_rx_threshold_count

2020-05-05 Thread YueHaibing
There's no caller in-tree since commit 2af6106ae949 ("net: stmmac: Introducing support for Page Pool") Signed-off-by: YueHaibing --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/s

[PATCH net-next] can: c_can: Remove unused inline function

2020-05-05 Thread YueHaibing
commit 524369e2391f ("can: c_can: remove obsolete STRICT_FRAME_ORDERING Kconfig option") left behind this, remove it. Signed-off-by: YueHaibing --- drivers/net/can/c_can/c_can.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net

[PATCH net-next] net: mv643xx_eth: Remove unused inline function sum16_as_be

2020-05-05 Thread YueHaibing
commit 84411f73b884 ("net: mv643xx_eth: Avoid setting the initial TCP checksum") left behind this, remove it. Signed-off-by: YueHaibing --- drivers/net/ethernet/marvell/mv643xx_eth.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/marvell/mv643xx_eth.c

[PATCH net-next] ixgbe: Remove unused inline function ixgbe_irq_disable_queues

2020-05-05 Thread YueHaibing
commit b5f69ccf6765 ("ixgbe: avoid bringing rings up/down as macvlans are added/removed") left behind this, remove it. Signed-off-by: YueHaibing --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 29 --- 1 file changed, 29 deletions(-) diff --git a/drivers/net/ethe

[PATCH net-next] net: sun: cassini: Remove unused inline functions

2020-05-05 Thread YueHaibing
There's no callers in-tree anymore. Signed-off-by: YueHaibing --- drivers/net/ethernet/sun/cassini.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c index 3ee6ab104cb9..e6e25960da4f 100644 --- a/dr

[PATCH net-next] net: tehuti: remove unused inline function bdx_tx_db_size

2020-05-05 Thread YueHaibing
There's no callers in-tree anymore. Signed-off-by: YueHaibing --- drivers/net/ethernet/tehuti/tehuti.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/net/ethernet/tehuti/tehuti.c b/drivers/net/ethernet/tehuti/tehuti.c index 40a2ce0ca808..e28727297563 100644

Re: [PATCH] xfrm: policy: Only use mark as policy lookup key

2020-04-29 Thread Yuehaibing
On 2020/4/24 11:48, Yuehaibing wrote: > On 2020/4/23 17:43, Xin Long wrote: >> On Thu, Apr 23, 2020 at 4:41 PM Yuehaibing wrote: >>> >>> On 2020/4/23 14:37, Xin Long wrote: >>>> On Thu, Apr 23, 2020 at 10:26 AM Yuehaibing wrote: >>>>> >&g

Re: [PATCH bpf-next] libbpf: fix false unused variable warning

2020-04-29 Thread Yuehaibing
On 2020/4/30 9:25, Andrii Nakryiko wrote: > Some versions of GCC falsely detect that vi might not be initialized. That's > not true, but let's silence it with NULL initialization. > Title should be fixed 'unused' --> 'uninitialized' ? > Signed-off-by: Andrii Nakryiko > --- > tools/lib/bpf/libb

Re: [PATCH bpf-next] libbpf: fix false unused variable warning

2020-04-29 Thread Yuehaibing
On 2020/4/30 9:25, Andrii Nakryiko wrote: > Some versions of GCC falsely detect that vi might not be initialized. That's > not true, but let's silence it with NULL initialization. > This title seems not appropriate, 'unused' --> 'initialized' ? > Signed-off-by: Andrii Nakryiko > --- > tools/

[PATCH net-next] hinic: make a bunch of functions static

2020-04-29 Thread YueHaibing
These fucntions is used only in hinic_sriov.c, so make them static to fix sparse warnings. Reported-by: Hulk Robot Signed-off-by: YueHaibing --- .../net/ethernet/huawei/hinic/hinic_sriov.c | 91 ++- 1 file changed, 48 insertions(+), 43 deletions(-) diff --git a/drivers/net

[PATCH net-next] net/smc: remove unused inline function smc_curs_read

2020-04-29 Thread YueHaibing
commit bac6de7b6370 ("net/smc: eliminate cursor read and write calls") left behind this. Signed-off-by: YueHaibing --- net/smc/smc_cdc.h | 17 - 1 file changed, 17 deletions(-) diff --git a/net/smc/smc_cdc.h b/net/smc/smc_cdc.h index 861dc24c588c..5a19e5e2280e 100644

[PATCH net-next] ila: remove unused inline function ila_addr_is_ila

2020-04-29 Thread YueHaibing
There's no callers in-tree anymore since commit 84287bb32856 ("ila: add checksum neutral map auto"). Signed-off-by: YueHaibing --- net/ipv6/ila/ila.h | 5 - 1 file changed, 5 deletions(-) diff --git a/net/ipv6/ila/ila.h b/net/ipv6/ila/ila.h index bb6fc0d54dae..ad5f6f6ba333 1

[PATCH net-next] net: hsr: remove unused inline functions

2020-04-29 Thread YueHaibing
There's no callers in-tree anymore. Signed-off-by: YueHaibing --- net/hsr/hsr_main.h | 19 --- 1 file changed, 19 deletions(-) diff --git a/net/hsr/hsr_main.h b/net/hsr/hsr_main.h index 7321cf8d6d2c..f74193465bf5 100644 --- a/net/hsr/hsr_main.h +++ b/net/hsr/hsr_m

  1   2   3   4   >