[PATCH net-next RESEND 1/2] devlink: Expose port function commands to control roce

2021-02-02 Thread Yishai Hadas
ction: hw_addr 00:00:00:00:00:00 roce on $ devlink port function set pci/:06:00.0/2 roce off $ devlink port show pci/:06:00.0/2 pci/:06:00.0/2: type eth netdev enp6s0pf0vf1 flavour pcivf pfnum 0 vfnum 1 function: hw_addr 00:11:22:33:44:55 roce off Signed-off-by: Yishai

[PATCH net-next RESEND 2/2] net/mlx5: E-Switch, Implement devlink port function cmds to control roce

2021-02-02 Thread Yishai Hadas
Implement devlink port function commands to enable / disable roce. This is used to control the roce device capabilities. Signed-off-by: Yishai Hadas Reviewed-by: Parav Pandit Signed-off-by: Saeed Mahameed --- .../device_drivers/ethernet/mellanox/mlx5.rst | 32 .../net/ethernet/mellanox

[PATCH net-next RESEND 0/2] devlink: Add port function attribute to enable/disable roce

2021-02-02 Thread Yishai Hadas
e memory efficient way. Patch summary: Patch-1 adds devlink attribute to control roce Patch-2 implements mlx5 callbacks for roce control Yishai Hadas (2): devlink: Expose port function commands to control roce net/mlx5: E-Switch, Implement devlink port function cmds to control roce .../de

[PATCH net-next 2/2] net/mlx5: E-Switch, Implement devlink port function cmds to control roce

2021-02-01 Thread Yishai Hadas
Implement devlink port function commands to enable / disable roce. This is used to control the roce device capabilities. Signed-off-by: Yishai Hadas Reviewed-by: Parav Pandit Signed-off-by: Saeed Mahameed --- .../device_drivers/ethernet/mellanox/mlx5.rst | 32 .../net/ethernet/mellanox

[PATCH net-next 1/2] devlink: Expose port function commands to control roce

2021-02-01 Thread Yishai Hadas
ction: hw_addr 00:00:00:00:00:00 roce on $ devlink port function set pci/:06:00.0/2 roce off $ devlink port show pci/:06:00.0/2 pci/:06:00.0/2: type eth netdev enp6s0pf0vf1 flavour pcivf pfnum 0 vfnum 1 function: hw_addr 00:11:22:33:44:55 roce off Signed-off-by: Yishai

[PATCH net-next 0/2] devlink: Add port function attribute to enable/disable roce

2021-02-01 Thread Yishai Hadas
ch-1 adds devlink attribute to control roce Patch-2 implements mlx5 callbacks for roce control Yishai Hadas (2): devlink: Expose port function commands to control roce net/mlx5: E-Switch, Implement devlink port function cmds to control roce .../device_drivers/ethernet/mellanox/mlx5.

Re: [PATCH mlx5-next v1] RDMA/mlx5: Cleanup the synchronize_srcu() from the ODP flow

2021-01-31 Thread Yishai Hadas
On 1/29/2021 2:23 PM, Saeed Mahameed wrote: diff --git a/drivers/net/ethernet/mellanox/mlx5/core/mr.c b/drivers/net/ethernet/mellanox/mlx5/core/mr.c index 9eb51f06d3ae..50af84e76fb6 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/mr.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/mr.c @@ -56

Re: [PATCH rdma-next v1 11/12] IB/mlx5: Implement DEVX dispatching event

2019-06-25 Thread Yishai Hadas
On 6/24/2019 9:06 PM, Jason Gunthorpe wrote: On Mon, Jun 24, 2019 at 07:55:32PM +0300, Yishai Hadas wrote: + /* Explicit filtering to kernel events which may occur frequently */ + if (event_type == MLX5_EVENT_TYPE_CMD || + event_type == MLX5_EVENT_TYPE_PAGE_REQUEST

Re: [PATCH rdma-next v1 12/12] IB/mlx5: Add DEVX support for CQ events

2019-06-24 Thread Yishai Hadas
On 6/24/2019 3:04 PM, Jason Gunthorpe wrote: On Tue, Jun 18, 2019 at 08:15:40PM +0300, Leon Romanovsky wrote: From: Yishai Hadas Add DEVX support for CQ events by creating and destroying the CQ via mlx5_core and set an handler to manage its completions. Signed-off-by: Yishai Hadas Signed

Re: [PATCH rdma-next v1 11/12] IB/mlx5: Implement DEVX dispatching event

2019-06-24 Thread Yishai Hadas
On 6/24/2019 3:03 PM, Jason Gunthorpe wrote: On Tue, Jun 18, 2019 at 08:15:39PM +0300, Leon Romanovsky wrote: From: Yishai Hadas Implement DEVX dispatching event by looking up for the applicable subscriptions for the reported event and using their target fd to signal/set the event. Signed

Re: [PATCH rdma-next v1 10/12] IB/mlx5: Enable subscription for device events over DEVX

2019-06-24 Thread Yishai Hadas
On 6/24/2019 2:57 PM, Jason Gunthorpe wrote: On Tue, Jun 18, 2019 at 08:15:38PM +0300, Leon Romanovsky wrote: From: Yishai Hadas Enable subscription for device events over DEVX. Each subscription is added to the two level XA data structure according to its event number and the DEVX object

Re: [PATCH rdma-next v1 09/12] IB/mlx5: Register DEVX with mlx5_core to get async events

2019-06-24 Thread Yishai Hadas
On 6/24/2019 2:52 PM, Jason Gunthorpe wrote: On Tue, Jun 18, 2019 at 08:15:37PM +0300, Leon Romanovsky wrote: void __mlx5_ib_remove(struct mlx5_ib_dev *dev, diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h index 9cf23ae6324e..556af34b788b 100644 +++ b/d

Re: [PATCH rdma-next v1 08/12] IB/mlx5: Introduce MLX5_IB_OBJECT_DEVX_ASYNC_EVENT_FD

2019-06-24 Thread Yishai Hadas
On 6/24/2019 2:51 PM, Jason Gunthorpe wrote: On Tue, Jun 18, 2019 at 08:15:36PM +0300, Leon Romanovsky wrote: From: Yishai Hadas Introduce MLX5_IB_OBJECT_DEVX_ASYNC_EVENT_FD and its initial implementation. This object is from type class FD and will be used to read DEVX async events. Signed

Re: [PATCH mlx5-next v1 1/8] net/mlx5: Add forward compatible support for the FTE match data

2018-07-15 Thread Yishai Hadas
On 7/15/2018 11:03 AM, Or Gerlitz wrote: On Sun, Jul 15, 2018 at 10:26 AM, Yishai Hadas wrote: On 7/12/2018 11:53 PM, Or Gerlitz wrote: On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: From: Yishai Hadas Use the PRM size including the reserved when working with the FTE match data

Re: [PATCH mlx5-next v1 1/8] net/mlx5: Add forward compatible support for the FTE match data

2018-07-15 Thread Yishai Hadas
On 7/12/2018 11:53 PM, Or Gerlitz wrote: On Wed, Jul 11, 2018 at 2:10 PM, Leon Romanovsky wrote: From: Yishai Hadas Use the PRM size including the reserved when working with the FTE match data. is this actually a bug fix? No, it's some requirement from the new API to enable fo

Re: [PATCH mlx5-next 2/9] net/mlx5: Add support for flow table destination number

2018-07-11 Thread Yishai Hadas
On 7/11/2018 1:26 AM, Saeed Mahameed wrote: On Sun, Jul 8, 2018 at 3:24 AM, Leon Romanovsky wrote: From: Yishai Hadas Add support to set a destination from a flow table number. This functionality will be used in downstream patches from this series by the DEVX stuff. Signed-off-by: Yishai

Re: [PATCH rdma-next 6/9] IB/mlx5: Introduce vendor create and destroy flow methods

2018-07-11 Thread Yishai Hadas
On 7/10/2018 8:44 PM, Jason Gunthorpe wrote: On Sun, Jul 08, 2018 at 01:24:42PM +0300, Leon Romanovsky wrote: +static int UVERBS_HANDLER(MLX5_IB_METHOD_CREATE_FLOW)(struct ib_device *ib_dev, + struct ib_uverbs_file *file, +

Re: [PATCH rdma-next 4/9] IB/mlx5: Introduce flow steering matcher object

2018-07-11 Thread Yishai Hadas
On 7/10/2018 8:34 PM, Jason Gunthorpe wrote: On Sun, Jul 08, 2018 at 01:24:40PM +0300, Leon Romanovsky wrote: From: Yishai Hadas Introduce flow steering matcher object and its create and destroy methods. This matcher object holds some mlx5 specific driver properties that matches the underlay

Re: [PATCH rdma-next v2 09/20] IB/core: Improve uverbs_cleanup_ucontext algorithm

2018-06-18 Thread Yishai Hadas
On 6/17/2018 10:51 PM, Jason Gunthorpe wrote: On Sun, Jun 17, 2018 at 12:59:55PM +0300, Leon Romanovsky wrote: +void uverbs_cleanup_ucontext(struct ib_ucontext *ucontext, bool device_removed) +{ /* * Waits for all remove_commit and alloc_commit to finish. Logically, We

Re: [PATCH rdma-next v3 00/14] Verbs flow counters support

2018-05-31 Thread Yishai Hadas
On 5/31/2018 4:43 PM, Leon Romanovsky wrote: From: Leon Romanovsky Changelog: v2->v3: * Change function mlx5_fc_query signature to hide the details of internal core driver struct mlx5_fc * Add commen to data[] field at struct mlx5_ib_flow_counters_data (mlx5-abi.h) * Use array of stru

Re: [PATCH rdma-next v3 08/14] IB/core: Support passing uhw for create_flow

2018-05-31 Thread Yishai Hadas
; Raed Salem ; Yishai Hadas ; Saeed Mahameed ; linux-netdev Subject: [PATCH rdma-next v3 08/14] IB/core: Support passing uhw for create_flow From: Matan Barak This is required when user-space drivers need to pass extra information regarding how to handle this flow steering specification. Reviewed

Re: [PATCH mlx5-next v2 11/13] IB/mlx5: Add flow counters binding support

2018-05-30 Thread Yishai Hadas
On 5/30/2018 6:06 PM, Jason Gunthorpe wrote: On Wed, May 30, 2018 at 03:31:34PM +0300, Yishai Hadas wrote: On 5/29/2018 10:56 PM, Jason Gunthorpe wrote: On Tue, May 29, 2018 at 04:09:15PM +0300, Leon Romanovsky wrote: diff --git a/include/uapi/rdma/mlx5-abi.h b/include/uapi/rdma/mlx5-abi.h

Re: [PATCH mlx5-next v2 11/13] IB/mlx5: Add flow counters binding support

2018-05-30 Thread Yishai Hadas
On 5/29/2018 10:56 PM, Jason Gunthorpe wrote: On Tue, May 29, 2018 at 04:09:15PM +0300, Leon Romanovsky wrote: diff --git a/include/uapi/rdma/mlx5-abi.h b/include/uapi/rdma/mlx5-abi.h index 508ea8c82da7..ef3f430a7050 100644 +++ b/include/uapi/rdma/mlx5-abi.h @@ -443,4 +443,18 @@ enum { enum {

Re: [PATCH rdma-next 3/3] IB/mlx5: Introduce a new mini-CQE format

2018-05-28 Thread Yishai Hadas
capability and enables its setting via mlx5 UHW data as part of query device and cq creation. Reviewed-by: Yishai Hadas Reviewed-by: Guy Levi Signed-off-by: Yonatan Cohen Signed-off-by: Leon Romanovsky drivers/infiniband/hw/mlx5/cq.c | 42 +-- drivers/infiniband

Re: mlx4 BUG_ON in probe path

2016-11-17 Thread Yishai Hadas
On 11/16/2016 8:25 PM, Bjorn Helgaas wrote: Hi Yishai, Johannes has been working on an mlx4 initialization problem on an IBM x3850 X6. The underlying problem is a PCI core issue -- we're setting RCB in the Mellanox device, which means it thinks it can generate 128-byte Completions, even though

Re: [PATCH] IB/mlx4: avoid a -Wmaybe-uninitialize warning

2016-10-25 Thread Yishai Hadas
[-Werror=maybe-uninitialized] The problem here is that gcc won't track the state of the variable across a spin_unlock. Moving the assignment out of the lock is safe here and avoids the warning. Signed-off-by: Arnd Bergmann Reviewed-by: Yishai Hadas --- drivers/net/ethernet/mellanox

Re: [GIT] Networking

2016-03-21 Thread Yishai Hadas
On 3/19/2016 6:42 AM, David Miller wrote: There is a merge conflict against the RDMA tree pull wrt the mlx4 driver, which I don't know how to resolve. Can you please point on the conflict ? is it still open that needs our input ?

Re: [PATCH 3/5] net/mlx4: fix some error handling in mlx4_multi_func_init()

2016-02-10 Thread Yishai Hadas
On 2/9/2016 10:11 PM, Rasmus Villemoes wrote: The while loop after err_slaves should use post-decrement; otherwise we'll fail to do the kfrees for i==0, and will run into out-of-bounds accesses if the setup above failed already at i==0. The predecrement in the --port is ok, since ->vlan_filter i

Re: [PATCH] mlx4_core: Fix fallback from MSI-X to INTx

2015-05-27 Thread Yishai Hadas
On 5/23/2015 2:12 AM, Benjamin Poirier wrote: The test in mlx4_load_one() to remove MLX4_FLAG_MSI_X expects mlx4_NOP() to fail with -EBUSY. It is also necessary to avoid the reset since the device is not fully reinitialized before calling mlx4_start_hca() a second time. Note that this will also