Re: [PATCH 00/10] thunderbolt: Add DMA traffic test driver

2020-11-04 Thread Yehezkel Bernat
bind to. > > The DMA traffic test driver creates a tunnel through the fabric and then > sends and receives data frames over the tunnel checking for different > errors. For the whole series, Acked-by: Yehezkel Bernat

Re: [PATCH 09/10] thunderbolt: Add DMA traffic test driver

2020-11-04 Thread Yehezkel Bernat
On Wed, Nov 4, 2020 at 4:00 PM Mika Westerberg wrote: > > +#define DMA_TEST_DATA_PATTERN 0x0123456789abcdefLL Have you considered making it configurable? For mem test, for example, there is a reason to try different patterns. Not sure if it's relevant here.

Re: [PATCH net-next] net: thunderbolt: Add comment clarifying prtcstns flags

2020-06-22 Thread Yehezkel Bernat
On Mon, Jun 22, 2020 at 7:30 PM Mika Westerberg wrote: > > ThunderboltIP protocol currently has two flags from which we only > support and set match frags ID. The first flag is reserved for full E2E > flow control. Add a comment that clarifies them. > > Suggested-by: Yehezkel Be

Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

2020-06-15 Thread Yehezkel Bernat
On Mon, Jun 15, 2020 at 6:55 PM Mika Westerberg wrote: > > On Mon, Jun 15, 2020 at 06:41:32PM +0300, Yehezkel Bernat wrote: > > > I think you are talking about the "prtstns" property in the network > > > driver. There we only set TBNET_MATCH_FRAGS_ID (bit 1)

Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

2020-06-15 Thread Yehezkel Bernat
On Mon, Jun 15, 2020 at 6:32 PM Mika Westerberg wrote: > > On Mon, Jun 15, 2020 at 06:15:47PM +0300, Yehezkel Bernat wrote: > > On Mon, Jun 15, 2020 at 5:22 PM Mika Westerberg > > wrote: > > > > > > On Mon, Jun 15, 2020 at 05:18:38PM +0300, Yehezkel Bernat wr

Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

2020-06-15 Thread Yehezkel Bernat
On Mon, Jun 15, 2020 at 5:22 PM Mika Westerberg wrote: > > On Mon, Jun 15, 2020 at 05:18:38PM +0300, Yehezkel Bernat wrote: > > On Mon, Jun 15, 2020 at 4:51 PM Greg Kroah-Hartman > > wrote: > > > > > > On Mon, Jun 15, 2020 at 04:45:22PM +0300, Yehezkel Bernat

Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

2020-06-15 Thread Yehezkel Bernat
On Mon, Jun 15, 2020 at 4:51 PM Greg Kroah-Hartman wrote: > > On Mon, Jun 15, 2020 at 04:45:22PM +0300, Yehezkel Bernat wrote: > > On Mon, Jun 15, 2020 at 4:02 PM Mika Westerberg > > wrote: > > > > > > diff --git a/include/linux/thunderbolt.h b/inc

Re: [PATCH 4/4] thunderbolt: Get rid of E2E workaround

2020-06-15 Thread Yehezkel Bernat
On Mon, Jun 15, 2020 at 4:02 PM Mika Westerberg wrote: > > diff --git a/include/linux/thunderbolt.h b/include/linux/thunderbolt.h > index ff397c0d5c07..5db2b11ab085 100644 > --- a/include/linux/thunderbolt.h > +++ b/include/linux/thunderbolt.h > @@ -504,8 +504,6 @@ struct tb_ring { > #define RING