Re: netfilter: does the API break or something else ?

2020-05-14 Thread Xiubo Li
On 2020/5/14 18:54, Phil Sutter wrote: Hi, On Wed, May 13, 2020 at 11:20:35PM +0800, Xiubo Li wrote: Recently I hit one netfilter issue, it seems the API breaks or something else. Just for the record, this was caused by a misconfigured kernel. Yeah, thanks Phil for your help. BRs Xiubo

netfilter: does the API break or something else ?

2020-05-13 Thread Xiubo Li
Hi Experts, Recently I hit one netfilter issue, it seems the API breaks or something else. On CentOS8.1 with the recent upstream kernel built from source, such as 5.6.0-rc6/5.7.0-rc4. When running the following command: $ sudo bash -c 'iptables -A FORWARD -o enp3s0f1 -i ceph-brx -j ACCEPT' i

[PATCH v2] netfilter: fix possible ZERO_SIZE_PTR pointer dereferencing error.

2016-06-01 Thread Xiubo Li
GFP_KERNEL); if (ops == NULL) return ERR_PTR(-ENOMEM); So this patch will fix this with just doing the zero check before kmalloc() is called. Maybe the case above will never happen here, but in theory. Signed-off-by: Xiubo Li --- Changes in V2: - Using the nf.git tree instead. net

Re: [PATCH] netfilter: fix possible ZERO_SIZE_PTRpointerdereferencing error.

2016-06-01 Thread Xiubo Li
On 01/06/2016 19:04, Pablo Neira Ayuso wrote: On Wed, Jun 01, 2016 at 05:52:59PM +0800, Xiubo Li wrote: net/netfilter/x_tables.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c index c8a0b7d..4df8e38 100644 --- a/net/netfilter

Re: [PATCH] netfilter: fix possible ZERO_SIZE_PTR pointerdereferencing error.

2016-06-01 Thread Xiubo Li
BRs Xiubo Li

[PATCH] netfilter: fix possible ZERO_SIZE_PTR pointer dereferencing error.

2016-06-01 Thread Xiubo Li
NEL); if (ops == NULL) return ERR_PTR(-ENOMEM); So this patch fix this with just doing the zero check before calling kmalloc() is called. Maybe the case above will never happen here, but in theory. Signed-off-by: Xiubo Li --- net/netfilter/x_tables.c | 3 +++ 1 file changed, 3