ms: 1'
> > can be dropped.
> >
> > adi,ad5758 is an oddball which defined an enum of arrays. While a valid
> > schema, it is simpler as a whole to only define scalar constraints.
Acked-by: Wolfram Sang # for I2C
signature.asc
Description: PGP signature
conditionally anyhow.
>
> Signed-off-by: Uwe Kleine-König
Acked-by: Wolfram Sang # for I2C
signature.asc
Description: PGP signature
Document the compatible value for the RAVB block in the Renesas R-Car
V3U (R8A779A0) SoC. This variant has no stream buffer, so we only need
to add the new compatible and add it to the TX delay block.
Reviewed-by: Geert Uytterhoeven
Acked-by: Rob Herring
Signed-off-by: Wolfram Sang
---
Please
essed while the
> device is suspended, causing undefined behavior, which may crash the
> system.
>
> Fix this by wrapping the PHY bitbang accessors in the sh_eth driver by
> wrappers that take care of Runtime PM, to resume the device when needed.
>
> Reported-by: Wolfram Sang
> Suggested-by: Andrew Lunn
> Signed-off-by: Geert Uytterhoeven
Tested-by: Wolfram Sang
Thanks for debugging and fixing this, Geert!
signature.asc
Description: PGP signature
On Mon, Jan 18, 2021 at 04:06:55PM +0100, Geert Uytterhoeven wrote:
> Export mdiobb_read() and mdiobb_write(), so Ethernet controller drivers
> can call them from their MDIO read/write wrappers.
>
> Signed-off-by: Geert Uytterhoeven
Tested-by: Wolfram Sang
signature.asc
Desc
> I thought as much, but maybe there is some driver which can offload
> whole i2c_transfer to HW, and has to pass the addresses of the buffers
> to the HW, and the HW can have problems if the buffers overlap
> somewhere...
Well, sure, you can never know what crazy HW is out there :) But that
shou
> My question is whether this is allowed, whether the msgs array passed
> to the i2c_transfer() function can have multiple msgs pointing to the
> same buffer (the one into which the original page is first stored
> with first i2c_msg and then restored from it in the last i2c_msg).
Sending the mess
n ping the host
successfully. So, I think at least the first three patches are ready.
Let me know your thoughts!
All the best,
Wolfram
Tho Vu (2):
arm64: dts: renesas: r8a779a0: Add Ethernet-AVB support
arm64: dts: renesas: falcon: Add Ethernet-AVB support
Wolfram Sang (3):
dt-bin
Document the compatible value for the RAVB block in the Renesas R-Car
V3U (R8A779A0) SoC. This variant has no stream buffer, so we only need
to add the new compatible.
Signed-off-by: Wolfram Sang
---
Documentation/devicetree/bindings/net/renesas,etheravb.yaml | 1 +
1 file changed, 1 insertion
> - unlikely(dma_mapping_error(dev, dma_addr))
> + dma_mapping_error(dev, dma_addr)
>
> Signed-off-by: Heiner Kallweit
Acked-by: Wolfram Sang # for I2C
signature.asc
Description: PGP signature
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index e32ef3f01fe8..b13b1cbcac29 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1785,7 +1785,7 @@ static int i801_probe(struct pci_dev *dev, const struct
> pci_device_id *id)
>
..@alsa-project.org
> Cc: linux-...@vger.kernel.org
> Cc: linux-...@lists.infradead.org
> Cc: netdev@vger.kernel.org
> Cc: linux-...@vger.kernel.org
> Cc: linux-ser...@vger.kernel.org
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Rob Herring
I trust you guys in figuring out the details, so for touching I2C:
Acked-by: Wolfram Sang
signature.asc
Description: PGP signature
On Sat, May 02, 2020 at 04:26:56PM +0200, Wolfram Sang wrote:
> The 'pengutronix' address is defunct for years. Use the proper contact
> address.
>
> Signed-off-by: Wolfram Sang
Ping?
> ---
> drivers/net/can/mscan/mpc5xxx_can.c | 2 +-
> 1 file changed, 1 insert
On Sun, Jul 26, 2020 at 09:11:25PM +0300, Kalle Valo wrote:
> Wolfram Sang writes:
>
> > On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote:
> >> Missing this firmware is not fatal, my wifi card still works. Even more,
> >> I couldn't find any docum
On Thu, Jun 25, 2020 at 06:52:10PM +0200, Wolfram Sang wrote:
> Missing this firmware is not fatal, my wifi card still works. Even more,
> I couldn't find any documentation what it is or where to get it. So, I
> don't think the users should be notified if it is missing. If y
On Wed, Jul 15, 2020 at 12:09:01PM +0100, Lad Prabhakar wrote:
> Document i2c controller for RZ/G2H (R8A774E1) SoC, which is compatible
> with R-Car Gen3 SoC family.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Applied to for-next, thanks!
signature.asc
Descript
On Wed, Jul 15, 2020 at 12:09:02PM +0100, Lad Prabhakar wrote:
> Document IIC controller for RZ/G2H (R8A774E1) SoC, which is compatible
> with R-Car Gen3 SoC family.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Applied to for-next, thanks!
signature.asc
Descript
Hi Alexander,
thanks for trying to fix this, yet I have some doubts.
On Mon, Jun 29, 2020 at 10:31:21PM +0200, Alexander A. Klimov wrote:
> Rationale:
> https://lore.kernel.org/linux-doc/20200626110706.7b5d4...@lwn.net/
I think we need some text here. Clicking on a link to understand what a
patc
remove it.
Signed-off-by: Wolfram Sang
---
This is only build tested because I wanted to get your opinions first. I
couldn't find any explanation about yoyo, so I am entering unknown
territory here.
drivers/net/wireless/intel/iwlwifi/iwl-dbg-tlv.c | 2 +-
1 file changed, 1 insertion
> > According to the Hardware User's Manual Rev. 1.00, the registers do exist
> > on all RZ/G1, except for RZ/G1E (see below).
> >
> >"(automatic transmission can be used as a hardware function, but this is
> > not meaningful for actual use cases)."
> >
> > (whatever that comment may mean?
Hi Prabhakar,
> > Leaves us with a seperate compatible entry for it?
> >
> Sounds okay to me, how about "renesas,iic-no-dvfs" ? So that this
> could be used on all the SoC's which don't support DVFS.
Well, the feature missing is used for DVFS, but its name is "automatic
transmission". So, I'd rat
> Its similar to as seen on Rcar-H2 where just the A15 cores are up and
> A7 cores fail to boot. Attached is the boot log where reboot works as
> expected with all A15 core up. Although I have tested the internal
> release based on 3.10 where all the cores are up which used bootarg
> apmu=multiclu
> > However, both versions (with and without automatic transmission) are
> > described with the same "renesas,iic-r8a7742" compatible. Is it possible
> > to detect the reduced variant at runtime somehow?
> >
> I couldn't find anything the manual that would be useful to detect at runtime.
>
> > My
it against similar SoCs (like the
previous patched). So, for that:
Reviewed-by: Wolfram Sang
However, just to make sure, have you checked the WDT (especially reboot)
with SMP and multiple CPU cores enabled? Some early Gen2 SoCs had issues
there.
signature.asc
Description: PGP signature
On Fri, May 15, 2020 at 04:08:56PM +0100, Lad Prabhakar wrote:
> RZ/G1H (R8A7742) watchdog implementation is compatible with R-Car Gen2,
> therefore add relevant documentation.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Reviewe
ristian Rotariu
>
Reviewed-by: Wolfram Sang
signature.asc
Description: PGP signature
On Fri, May 15, 2020 at 04:08:54PM +0100, Lad Prabhakar wrote:
> Document APMU and SMP enable method for RZ/G1H (also known as r8a7742)
> SoC.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Reviewed-by: Wolfram Sang
signature.asc
Description: PGP signature
On Fri, May 15, 2020 at 04:08:53PM +0100, Lad Prabhakar wrote:
> Define the generic R8A7742 part of the Ether device node.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Reviewed-by: Wolfram Sang
signature.asc
Description: PGP signature
On Fri, May 15, 2020 at 04:08:52PM +0100, Lad Prabhakar wrote:
> Add Ethernet AVB support for R8A7742 SoC.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Reviewed-by: Wolfram Sang
signature.asc
Description: PGP signature
On Fri, May 15, 2020 at 04:08:50PM +0100, Lad Prabhakar wrote:
> Document RZ/G1H (R8A7742) SoC bindings.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Reviewed-by: Wolfram Sang
signature.asc
Description: PGP signature
On Fri, May 15, 2020 at 04:08:51PM +0100, Lad Prabhakar wrote:
> Document RZ/G1H (R8A7742) SoC bindings.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Reviewed-by: Wolfram Sang
signature.asc
Description: PGP signature
On Fri, May 15, 2020 at 04:08:49PM +0100, Lad Prabhakar wrote:
> Add the sata devices nodes to the R8A7742 device tree.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Reviewed-by: Wolfram Sang
signature.asc
Description: PGP signature
On Fri, May 15, 2020 at 04:08:48PM +0100, Lad Prabhakar wrote:
> Document SATA support for the RZ/G1H, which is compatible with
> R-Car Gen2 SoC family.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Reviewed-by: Wolfram Sang
signature.as
On Fri, May 15, 2020 at 04:08:47PM +0100, Lad Prabhakar wrote:
> Describe MMC0 device node in the R8A7742 device tree.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Reviewed-by: Wolfram Sang
signature.asc
Description: PGP signature
On Fri, May 15, 2020 at 04:08:46PM +0100, Lad Prabhakar wrote:
> Add the SDHI devices nodes to the R8A7742 device tree.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Reviewed-by: Wolfram Sang
signature.asc
Description: PGP signature
On Fri, May 15, 2020 at 04:08:42PM +0100, Lad Prabhakar wrote:
> Document IIC controller for RZ/G1H (R8A7742) SoC, which is compatible
> with R-Car Gen2 SoC family.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Reviewed-by: Wolfram Sang
fine-grained (e.g. group all simple additions
like this in one patch) but still:
Reviewed-by: Wolfram Sang
signature.asc
Description: PGP signature
On Fri, May 15, 2020 at 04:08:45PM +0100, Lad Prabhakar wrote:
> Add support for r8a7742 SoC. Renesas RZ/G1H (R8A7742) SDHI is identical to
> the R-Car Gen2 family.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
I think we can skip this because of the generic fallbac
On Fri, May 15, 2020 at 04:08:44PM +0100, Lad Prabhakar wrote:
> Document SDHI controller for RZ/G1H (R8A7742) SoC, which is compatible
> with R-Car Gen2 SoC family.
>
> Signed-off-by: Lad Prabhakar
> Reviewed-by: Marian-Cristian Rotariu
>
Reviewed-by: Wolfram Sang
On Fri, May 15, 2020 at 04:08:43PM +0100, Lad Prabhakar wrote:
> Add the I2C[0-3] and IIC[0-3] devices nodes to the R8A7742 device tree.
>
> Automatic transmission for PMIC control is not available on IIC3 hence
> compatible string "renesas,rcar-gen2-iic" and "renesas,rmobile-iic" is
> not added t
The 'pengutronix' address is defunct for years. Use the proper contact
address.
Signed-off-by: Wolfram Sang
---
drivers/net/can/mscan/mpc5xxx_can.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/mscan/mpc5xxx_can.c
b/drivers/net/can/mscan/mpc
Signed-off-by: Wolfram Sang
---
include/net/flow_dissector.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h
index 9a074776f70b66..d1fcf2442a423b 100644
--- a/include/net/flow_dissector.h
+++ b/include/net
nd.
Based on v4.17-rc3.
Wolfram Sang (9):
dt-bindings: i2c: fix typo 'can by' to 'can be'
powerpc/watchdog: fix typo 'can by' to 'can be'
base: core: fix typo 'can by' to 'can be'
hwmon: fschmd: fix typo 'can by' to &#x
ptr =
- platform_get_drvdata(pdev)
+ dev_get_drvdata(d)
<... when != pdev
- &pdev->dev
+ d
...>
Kind regards,
Wolfram
Wolfram Sang (61):
ARM: plat-samsung: simplify getting .drvdata
ata: simplify getting .drvdata
auxdisplay: simplify getting .drvda
We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang
---
Build tested only. buildbot is happy. Please apply individually.
drivers/net/dsa/bcm_sf2.c | 6 ++
drivers/net/dsa/qca8k.c | 6 ++
2 files
We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang
---
Build tested only. buildbot is happy. Please apply individually.
drivers/net/ethernet/davicom/dm9000.c | 6 ++
1 file changed, 2 insertions
We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang
---
Build tested only. buildbot is happy. Please apply individually.
drivers/net/ethernet/cadence/macb_main.c | 6 ++
1 file changed, 2 insertions
We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang
---
Build tested only. buildbot is happy. Please apply individually.
drivers/net/ethernet/smsc/smc91x.c | 3 +--
1 file changed, 1 insertion(+), 2
We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang
---
Build tested only. buildbot is happy. Please apply individually.
drivers/net/ethernet/ti/cpsw.c | 6 ++
drivers/net/ethernet/ti
We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang
---
Build tested only. buildbot is happy. Please apply individually.
drivers/net/ethernet/wiznet/w5300.c | 6 ++
1 file changed, 2 insertions(+), 4
We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang
---
Build tested only. buildbot is happy. Please apply individually.
drivers/ptp/ptp_dte.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions
We should get drvdata from struct device directly. Going via
platform_device is an unneeded step back and forth.
Signed-off-by: Wolfram Sang
---
Build tested only. buildbot is happy. Please apply individually.
net/dsa/legacy.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff
On Tue, Apr 17, 2018 at 10:50:29AM +0200, Simon Horman wrote:
> From: Kazuya Mizuguchi
>
> Signed-off-by: Kazuya Mizuguchi
> Signed-off-by: Simon Horman
> ---
> drivers/net/ethernet/renesas/ravb.h | 5 -
> drivers/net/ethernet/renesas/ravb_main.c | 15 ---
> 2 files chang
On Tue, Apr 17, 2018 at 10:50:26AM +0200, Simon Horman wrote:
> From: Masaru Nagai
>
> [ 58.490829] =
> [ 58.495205] [ INFO: inconsistent lock state ]
> [ 58.499583] 4.9.0-yocto-standard-7-g2ef7caf #57 Not tainted
> [ 58.505529]
> @@ -2302,6 +2305,7 @@ static int __maybe_unused ravb_resume(struct device
> *dev)
> {
> struct net_device *ndev = dev_get_drvdata(dev);
> struct ravb_private *priv = netdev_priv(ndev);
> + struct platform_device *pdev = priv->pdev;
Minor nit: I'd save this line...
> + if
> I did that too but got no results. Perhaps right shifting constants is
> pretty uncommon. I can put that in the complete rule though.
Please do. Even if rare, we would want this bug pointed out, right? :)
signature.asc
Description: PGP signature
Hi Julia,
> and got the results below. I can make a version for the kernel shortly.
It should probably take care of right-shifting, too?
Thanks,
Wolfram
signature.asc
Description: PGP signature
Due to a typo, the mask was destroyed by a comparison instead of a bit
shift.
Reported-by: Geert Uytterhoeven
Signed-off-by: Wolfram Sang
---
Only build tested.
drivers/net/can/m_can/m_can.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/can/m_can/m_can.c b
> I found two more using "git grep 'define.*0x[0-9a-f]* < '":
I added '[0-9]\+' at the end of the regex to reduce the number of false
positives...
> drivers/net/can/m_can/m_can.c:#define RXFC_FWM_MASK (0x7f <
> RXFC_FWM_SHIFT)
> drivers/usb/gadget/udc/goku_udc.h:#define INT_EPnNAK(n)
> (0x0
Due to a typo, the mask was destroyed by a comparison instead of a bit
shift.
Signed-off-by: Wolfram Sang
---
Only build tested. To be applied individually per subsystem.
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net
x27;coding style' issue with a low prio.
Wolfram Sang (4):
v4l: vsp1: fix mask creation for MULT_ALPHA_RATIO
drm/exynos: fix comparison to bitshift when dealing with a mask
v4l: dvb-frontends: stb0899: fix comparison to bitshift when dealing
with a mask
net: amd-xgbe: fix comparison to
Can you please update your CC list? There is nothing i2c related in this
patch series, so you could drop the i2c-list.
signature.asc
Description: PGP signature
> > I was hoping to have Michael merge this since the bulk of the platform is
> > under him,
> > cc:ing you mostly to be aware that I am orphaning a driver in your
> > subsystems.
>
> Let me answer for Jean since I took over I2C in November 2012 ;) I'd
> think the entry can go completely. The l
ean since I took over I2C in November 2012 ;) I'd
think the entry can go completely. The last 'F:' tag for the platform
catches the I2C driver anyhow. But in general:
Acked-by: Wolfram Sang
Thanks,
Wolfram
>
>
> Thanks,
>
> -Olof
>
> MAINTAINERS | 9
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/wireless/realtek/rtlwifi/usb.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/usb.c
b/drivers/net/wireless/realtek/rtlwifi
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/wireless/marvell/mwifiex/usb.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/usb.c
b/drivers/net/wireless
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/wireless/marvell/libertas_tf/if_usb.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/net/wireless/marvell/libertas_tf/if_usb.c
b/drivers/net/wireless
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/usb/hso.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 4b4458616693f9..c5544d36c54f96 100644
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/wireless/intersil/orinoco/orinoco_usb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/wireless/intersil/orinoco/orinoco_usb.c
b/drivers/net/wireless
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/can/usb/peak_usb/pcan_usb_core.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/net/can/usb/peak_usb/pcan_usb_core.c
b/drivers/net/can/usb/peak_usb
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/can/usb/usb_8dev.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/can/usb/usb_8dev.c b/drivers/net/can/usb/usb_8dev.c
index a731720f1d1325..108a30e1509756
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/can/usb/esd_usb2.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c
index 784a9002fbb930..be928ce62d32e0 100644
--- a
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/usb/usbnet.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 3bfb592093263b..d5071e364d40e1 100644
--- a
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
b/drivers/net
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/wimax/i2400m/usb-notif.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wimax/i2400m/usb-notif.c
b/drivers/net/wimax/i2400m/usb-notif.c
index fc1355d98bc6ae..5d429f81612546
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/wireless/ath/ar5523/ar5523.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/wireless/ath/ar5523/ar5523.c
b/drivers/net/wireless/ath/ar5523/ar5523.c
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/can/usb/gs_usb.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
index 6f0cbc38782e68..77e3cc06a30c8c
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/can/usb/kvaser_usb.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/can/usb/kvaser_usb.c b/drivers/net/can/usb/kvaser_usb.c
index 6f1f3b675ff553
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/usb/lan78xx.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 6a9d474b08b21c..432b8a3ae35491 100644
--- a
kmalloc will print enough information in case of failure.
Signed-off-by: Wolfram Sang
---
drivers/net/can/usb/ems_usb.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c
index 71f0e791355b9c..b3d02759c226bb
when we talked about it at LCJ in
Tokyo a few weeks ago.
Wolfram Sang (16):
net: can: usb: ems_usb: don't print error when allocating urb fails
net: can: usb: esd_usb2: don't print error when allocating urb fails
net: can: usb: gs_usb: don't print error when allocating urb fai
From: Wolfram Sang
The clk API may return 0 on clk_get_rate, so we should check the result before
using it as a divisor.
Signed-off-by: Wolfram Sang
Acked-by: Sergei Shtylyov
---
The original patch was marked as "NOT APPLICABLE" in patchwork. I reviewed
again and can't see w
On Wed, Mar 02, 2016 at 11:33:33PM +0100, Wolfram Sang wrote:
> From: Wolfram Sang
>
> The clk API may return 0 on clk_get_rate, so we should check the result before
> using it as a divisor.
>
> Signed-off-by: Wolfram Sang
Ping.
> ---
>
> Should go indi
oks like proper refactoring. Thanks!
For the I2C part:
Acked-by: Wolfram Sang
signature.asc
Description: PGP signature
From: Wolfram Sang
The clk API may return 0 on clk_get_rate, so we should check the result before
using it as a divisor.
Signed-off-by: Wolfram Sang
---
Should go individually via subsystem tree.
drivers/net/ethernet/renesas/ravb_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a
Here is the outcome of researching if the result of clk_get_rate() was directly
used as a divisor without checking if it is 0. Inspired by a Coverity report.
Wolfram Sang (6):
ide: palm_bk3710: test clock rate to avoid division by 0
net: ethernet: renesas: ravb_main: test clock rate to avoid
> >Reported-by: coverity (CID 1056464)
> >Signed-off-by: Wolfram Sang
>
>Will you respin or should I?
Please go ahead. You have more knowledge about this driver, so you will
be faster.
Reported-by: Wolfram Sang
signature.asc
Description: PGP signature
From: Wolfram Sang
When allocating an skb fails, rxdesc is still NULL (or the previous ring
index on further iterations of the loop). However, this pointer is
dereferenced after the loop. So, make sure rxdesc is updated immediately
at the beginning of the loop.
Reported-by: coverity (CID
On Wed, Mar 02, 2016 at 10:21:34AM +0900, Simon Horman wrote:
> On Tue, Mar 01, 2016 at 05:37:59PM +0100, Wolfram Sang wrote:
> > From: Wolfram Sang
> >
> > This change will also make Coverity happy by avoiding a theoretical NULL
> > pointer dereference; yet another
From: Wolfram Sang
This change will also make Coverity happy by avoiding a theoretical NULL
pointer dereference; yet another reason is to use the above helper function
to tighten the code and make it more readable.
Signed-off-by: Wolfram Sang
---
Tested on a Lager board.
drivers/net
From: Wolfram Sang
This change will also make Coverity happy by avoiding a theoretical NULL
pointer dereference; yet another reason is to use the above helper function
to tighten the code and make it more readable.
Signed-off-by: Wolfram Sang
---
Compile tested only. I am on the road and
91 matches
Mail list logo
