Reviewed-by: Wengang Wang
thanks,
wengang
On 10/27/2016 2:46 AM, shamir.rabinovi...@oracle.com wrote:
From: shamir rabinovitch
rds use Kconfig option called "RDS_DEBUG" to enable rds debug messages.
This option cause the rds Makefile to add -DDEBUG to the rds gcc command
l
akes the master become
the target device that ip_rt_update_pmtu tries to update PMTU to.
Signed-off-by: Wengang Wang
---
net/ipv4/route.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 85f184e..7e766b5 100644
--- a/net/ipv4/route.c
+++ b/
ets doesn't
change so all later fragments/packets are dropped too.
The fix is letting build_skb_flow_key() take care of the transition of
device index from bonding slave to the master. That makes the master become
the target device that ip_rt_update_pmtu tries to update PMTU to.
Signed-off-by: Weng
care of the transition of
device index from bonding slave to the master. That makes the master become
the target device that ip_rt_update_pmtu tries to update PMTU to.
Signed-off-by: Wengang Wang
---
net/ipv4/route.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/net/ipv4/route
在 2016年01月21日 12:05, Jay Vosburgh 写道:
Wengang Wang wrote:
[...]
For ipip, yes seems update_pmtu is called in line for each call of
queue_xmit. Do you know if it's a good configuration for ipip + bonding?
Yes, it is.
Other's comment and suggestion?
I agree wi
在 2016年01月20日 23:18, Sabrina Dubroca 写道:
2016-01-20, 13:32:13 +0800, Wengang Wang wrote:
In a bonding setting, we determines fragment size according to MTU and
PMTU associated to the bonding master. If the slave finds the fragment
size is too big, it drops the fragment and calls
在 2016年01月20日 17:56, zhuyj 写道:
On 01/20/2016 05:47 PM, Wengang Wang wrote:
在 2016年01月20日 15:54, zhuyj 写道:
On 01/20/2016 03:38 PM, Wengang Wang wrote:
在 2016年01月20日 14:24, zhuyj 写道:
On 01/20/2016 01:32 PM, Wengang Wang wrote:
In a bonding setting, we determines fragment size according
Please see if the V2 is clear.
thanks,
wengang
在 2016年01月06日 16:18, zhuyj 写道:
On 01/06/2016 04:14 PM, Wengang Wang wrote:
在 2016年01月06日 16:00, zhuyj 写道:
On 01/06/2016 03:45 PM, Wengang Wang wrote:
在 2016年01月06日 15:35, zhuyj 写道:
IMHO, "The path MTU is set to the active slave device
care of the transition of
device index from bonding slave to the master. That makes the master become
the target device that ip_rt_update_pmtu tries to update PMTU to.
Signed-off-by: Wengang Wang
---
net/ipv4/route.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/
在 2016年01月06日 16:00, zhuyj 写道:
On 01/06/2016 03:45 PM, Wengang Wang wrote:
在 2016年01月06日 15:35, zhuyj 写道:
IMHO, "The path MTU is set to the active slave device, not the
bonding master."
Can we set PMTU to bonding master when path MTU is set to the active
slave device?
Actually
MTU to the active slave failed(it didn't found a route on
slave).
So "set PMTU to bonding master when path MTU is set to the active slave
device" is lacking a base.
thanks,
wengang
If not appropriate, you can ignore it.
Best Regards!
Zhu Yanjun
On 01/06/2016 03:06 PM, Wenga
Hmm, we are not changing device MTU but PMTU...
thanks,
wengang
在 2016年01月06日 14:44, zhuyj 写道:
IMHO, the following comments will help us all.
case NETDEV_CHANGEMTU:
/* TODO: Should slaves be allowed to
* independently alter their MTU? For
er PMTU is changed to 2044 after the
first send(hopefully), for the seconds send the fragment size is set to
2044.
To fix in bonding code, I don't find where we can.
thanks,
wengang
在 2016年01月06日 14:19, zhuyj 写道:
IMHO, this should fix in bonding driver because the active slave mtu
should b
在 2016年01月06日 14:18, David Miller 写道:
From: Wengang Wang
Date: Wed, 6 Jan 2016 13:49:28 +0800
@@ -523,11 +523,20 @@ static void build_skb_flow_key(struct flowi4 *fl4, const
struct sk_buff *skb,
const struct sock *sk)
{
const struct iphdr *iph
slave to the master.
Signed-off-by: Wengang Wang
---
net/ipv4/route.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 85f184e..3053f10 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -523,11 +523,20 @@ static void
Hi,
Any comment on this patch?
thanks,
wengang
在 2015年09月25日 09:52, Wengang Wang 写道:
This is the v2, comparing the v1, the changes is:
* for loopback outbound device, it continue skipping cached route;
for others, it goes through the cached route.
For multicast, we should find valid
ust set).
But actually the second and later multicast packets got dropped too. And
the reason is that the neighor looking up(fib_lookup) is skipped because of
the socket is not bound to device(sk_bound_dev_if being 0). After applied
the patch I proposed here, it works fine.
Signed-off-by: Wengang W
Hi David,
在 2015年09月25日 05:22, David Miller 写道:
From: Wengang Wang
Date: Mon, 21 Sep 2015 16:00:09 +0800
This is the v2, comparing the v1, the changes is:
* for loopback outbound device, it continue skipping cached route;
for others, it goes through the cached route.
There are many
e pmtu I just set).
But actually the second and later multi-cast packages got dropped too. And
the reason is that the neighor looking up(fib_lookup) is skipped because of
the socket is not bound to device(sk_bound_dev_if being 0). After applied
the patch I proposed here, it works fine.
Signed-of
Hi David,
Thanks for your review on this.
在 2015年09月18日 12:20, David Miller 写道:
From: Wengang Wang
Date: Wed, 16 Sep 2015 14:34:15 +0800
For multi-cast, we should find valid route(thus get the meaniful pmtu) for
the package on the socket which is not bound to a device(sk_bound_dev_if
being
of
the socket is not bound to device(sk_bound_dev_if being 0). After applied
the patch I proposed here, it works fine.
Signed-off-by: Wengang Wang
---
net/ipv4/route.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 5f4a556..032481a
21 matches
Mail list logo
