[PATCH net-next] rds: Fix some typos for rds

2021-03-23 Thread Wang Hai
s/alloced/allocated/ s/synching/syncing/ s/connction/connection/ s/beween/between/ Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/rds/ib_ring.c | 2 +- net/rds/ib_send.c | 2 +- net/rds/send.c | 4 ++-- net/rds/tcp_recv.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions

[PATCH net-next] 6lowpan: Fix some typos in nhc_udp.c

2021-03-23 Thread Wang Hai
s/Orignal/Original/ s/infered/inferred/ Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/6lowpan/nhc_udp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/6lowpan/nhc_udp.c b/net/6lowpan/nhc_udp.c index 8a3507524f7b..33f17bd8cda7 100644 --- a/net/6lowpan

[PATCH net-next] net/packet: Fix a typo in af_packet.c

2021-03-23 Thread Wang Hai
s/sequencially/sequentially/ Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/packet/af_packet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 6bbc7a448593..fe29fc1b8b9d 100644 --- a/net/packet/af_packet.c +++ b

[PATCH net-next] net/tls: Fix a typo in tls_device.c

2021-03-23 Thread Wang Hai
s/beggining/beginning/ Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/tls/tls_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tls/tls_device.c b/net/tls/tls_device.c index f7fb7d2c1de1..89a5d4fad0a2 100644 --- a/net/tls/tls_device.c +++ b/net/tls

[PATCH] Revert "mm/slub: fix a memory leak in sysfs_slab_add()"

2021-01-28 Thread Wang Hai
her error cases of __kmem_cache_create() do not free this. So, revert the commit dde3c6b72a16 ("mm/slub: fix a memory leak in sysfs_slab_add()") to fix this. Reported-by: syzbot+d0bd96b4696c1ef67...@syzkaller.appspotmail.com Fixes: dde3c6b72a16 ("mm/slub: fix a memory leak in sysfs_sla

[PATCH v2] net: bridge: Fix a warning when del bridge sysfs

2020-12-11 Thread Wang Hai
that do not exist. Fixes: bb900b27a2f4 ("bridge: allow creating bridge devices with netlink") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2: Fix this by check br_sysfs_addbr() return value as Nik's suggestion net/bridge/br.c | 5 - 1 file changed, 4 insertions(+),

[PATCH net] openvswitch: fix error return code in validate_and_copy_dec_ttl()

2020-12-04 Thread Wang Hai
quot;) Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/openvswitch/flow_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/openvswitch/flow_netlink.c b/net/openvswitch/flow_netlink.c index ec0689ddc635..4c5c2331e764 100644 --- a/net/openvswitch/flow_n

[PATCH net] net: mvpp2: Fix error return code in mvpp2_open()

2020-12-03 Thread Wang Hai
Fix to return negative error code -ENOENT from invalid configuration error handling case instead of 0, as done elsewhere in this function. Fixes: 4bb043262878 ("net: mvpp2: phylink support") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/marvell/mvpp2/mvpp2_

[PATCH net] net: bridge: Fix a warning when del bridge sysfs

2020-12-01 Thread Wang Hai
0x40 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xa9 Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/bridge/br_sysfs_br.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c index 7db06e3f642a..1e9cbf31d904 100644 --- a/net

[PATCH net v3] ipvs: fix possible memory leak in ip_vs_control_net_init

2020-11-24 Thread Wang Hai
erwise a memory leak will occur. Also, add some '#ifdef CONFIG_PROC_FS' because proc_create_net* return NULL when PROC is not used. Fixes: b17fc9963f83 ("IPVS: netns, ip_vs_stats and its procfs") Fixes: 61b1ab4583e2 ("IPVS: netns, add basic init per netns.") Reported-b

[PATCH net v2] ipv6: addrlabel: fix possible memory leak in ip6addrlbl_net_init

2020-11-23 Thread Wang Hai
t;31a10c08>] do_syscall_64+0x33/0x40 [<99df30e7>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 We should free all rules when we catch an error in ip6addrlbl_net_init(). otherwise a memory leak will occur. Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Support RFC3484 configurable address selec

[PATCH net] ipv6: addrlabel: fix possible memory leak in ip6addrlbl_net_init

2020-11-21 Thread Wang Hai
t;31a10c08>] do_syscall_64+0x33/0x40 [<99df30e7>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 We should free all rules when we catch an error in ip6addrlbl_net_init(). otherwise a memory leak will occur. Fixes: 2a8cc6c89039 ("[IPV6] ADDRCONF: Support RFC3484 configurable address sel

[PATCH net v2] ipvs: fix possible memory leak in ip_vs_control_net_init

2020-11-20 Thread Wang Hai
CONFIG_PROC_FS' because proc_create_net* return NULL when PROC is not used. Fixes: b17fc9963f83 ("IPVS: netns, ip_vs_stats and its procfs") Fixes: 61b1ab4583e2 ("IPVS: netns, add basic init per netns.") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2: add some

[PATCH net] ipvs: fix possible memory leak in ip_vs_control_net_init

2020-11-19 Thread Wang Hai
netns, ip_vs_stats and its procfs") Fixes: 61b1ab4583e2 ("IPVS: netns, add basic init per netns.") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/netfilter/ipvs/ip_vs_ctl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/ne

[PATCH bpf] selftests/bpf: fix error return code in run_getsockopt_test()

2020-11-16 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 65b4414a05eb ("selftests/bpf: add sockopt test that exercises BPF_F_ALLOW_MULTI") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- tools/testing/sel

[PATCH net] inet_diag: Fix error path to cancel the meseage in inet_req_diag_fill()

2020-11-16 Thread Wang Hai
nlmsg_cancel() needs to be called in the error path of inet_req_diag_fill to cancel the message. Fixes: d545caca827b ("net: inet: diag: expose the socket mark to privileged processes.") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/ipv4/inet_diag.c | 4 +++- 1 file

[PATCH net] qtnfmac: fix error return code in qtnf_pcie_probe()

2020-11-14 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: b7da53cd6cd1 ("qtnfmac_pcie: use single PCIe driver for all platforms") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/wireless/quantenna/qt

[PATCH net] net/mlx5: fix error return code in mlx5e_tc_nic_init()

2020-11-14 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: aedd133d17bc ("net/mlx5e: Support CT offload for tc nic flows") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/mellanox/mlx5/core/e

[PATCH net] Bluetooth: Fix potential null pointer dereference in create_le_conn_complete

2020-11-13 Thread Wang Hai
The pointer 'conn' may be null. Before being used by hci_connect_le_scan_cleanup(), The pointer 'conn' must be checked whether it is null. Fixes: 28a667c9c279 ("Bluetooth: advertisement handling in new connect procedure") Reported-by: Hulk Robot Signed-off-by

[PATCH v4 bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-13 Thread Wang Hai
progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, it should be closed. Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface") Signed-off-by: Wang Hai --- v3->v4: delete 'err = 0' v2->v3: add 'err

[PATCH net] net: marvell: prestera: fix error return code in prestera_pci_probe()

2020-11-13 Thread Wang Hai
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 4c2703dfd7fa ("net: marvell: prestera: Add PCI interface support") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/marvell/prestera/pres

[PATCH v2 net] devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill()

2020-11-13 Thread Wang Hai
If sb_occ_port_pool_get() failed in devlink_nl_sb_port_pool_fill(), msg should be canceled by genlmsg_cancel(). Fixes: df38dafd2559 ("devlink: implement shared buffer occupancy monitoring interface") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2: use goto instead of

[PATCH net] devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill()

2020-11-11 Thread Wang Hai
If sb_occ_port_pool_get() failed in devlink_nl_sb_port_pool_fill(), msg should be canceled by genlmsg_cancel(). Fixes: df38dafd2559 ("devlink: implement shared buffer occupancy monitoring interface") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/core/devlink.c | 4 ++

[PATCH v3 bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-11 Thread Wang Hai
progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, it should be closed. Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface") Signed-off-by: Wang Hai --- v2->v3: add 'err = 0' before successful return v

[PATCH net] cosa: Add missing kfree in error path of cosa_write

2020-11-10 Thread Wang Hai
If memory allocation for 'kbuf' succeed, cosa_write() doesn't have a corresponding kfree() in exception handling. Thus add kfree() for this function implementation. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net

[PATCH v2 bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-09 Thread Wang Hai
progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, it should be closed. Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface") Signed-off-by: Wang Hai --- v1->v2: use cleanup tag instead of repeated closes tools

[PATCH net] tipc: fix memory leak in tipc_topsrv_start()

2020-11-09 Thread Wang Hai
3c>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 'srv' is malloced in tipc_topsrv_start() but not free before leaving from the error handling cases. We need to free it. Fixes: 5c45ab24ac77 ("tipc: make struct tipc_server private for server.c") Reported-by: Hulk Robot Signed-of

[PATCH bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-08 Thread Wang Hai
progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, it should be closed. Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface") Signed-off-by: Wang Hai --- tools/bpf/bpftool/net.c | 2 ++ 1 file changed, 2 insertions(+)

[PATCH net-next] net: tipc: Supply missing udp_media.h include file

2020-09-18 Thread Wang Hai
totype for ‘tipc_udp_nl_dump_remoteip’ [-Wmissing-prototypes] net/tipc/udp_media.c:532:5: warning: no previous prototype for ‘tipc_udp_nl_add_bearer_data’ [-Wmissing-prototypes] net/tipc/udp_media.c:614:5: warning: no previous prototype for ‘tipc_udp_nl_bearer_add’ [-Wmissing-prototypes] Signed-off-by

[PATCH net-next] net: hns3: Supply missing hclge_dcb.h include file

2020-09-18 Thread Wang Hai
arning: no previous prototype for ‘hclge_dcb_ops_set’ [-Wmissing-prototypes] Signed-off-by: Wang Hai --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c b/drivers/net/ethernet/hisi

[PATCH net-next] liquidio: Fix -Wmissing-prototypes warnings for liquidio

2020-09-18 Thread Wang Hai
arning: no previous prototype for ‘octeon_read_device_mem32’ [-Wmissing-prototypes] drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:194:6: warning: no previous prototype for ‘octeon_write_device_mem32’ [-Wmissing-prototypes] Signed-off-by: Wang Hai --- drivers/net/ethernet/cavium/liquidio/cn68x

[PATCH net-next] net/appletalk: Supply missing net/Space.h include file

2020-09-18 Thread Wang Hai
totype for ‘cops_probe’ [-Wmissing-prototypes] drivers/net/appletalk/ltpc.c:1014:28: warning: no previous prototype for ‘ltpc_probe’ [-Wmissing-prototypes] Signed-off-by: Wang Hai --- drivers/net/appletalk/cops.c | 2 ++ drivers/net/appletalk/ltpc.c | 2 ++ 2 files changed, 4 insertions(+) di

[PATCH net-next] net: cxgb3: Fix some kernel-doc warnings

2020-09-10 Thread Wang Hai
7;adapter' description in 't3_set_proto_sram' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/chelsio/cxgb3/t3_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb3/t3_hw.c b/drivers/net/ethernet/

[PATCH net-next 0/6] Fix some kernel-doc warnings for hns

2020-09-10 Thread Wang Hai
Fix some kernel-doc warnings for hns. Wang Hai (6): hinic: Fix some kernel-doc warnings in hinic_hw_io.c net: hns: fix 'cdev' kernel-doc warning in hnae_ae_unregister() net: hns: Fix some kernel-doc warnings in hns_dsaf_xgmac.c net: hns: Fix some kernel-doc warnings in hns_en

[PATCH net-next 1/6] hinic: Fix some kernel-doc warnings in hinic_hw_io.c

2020-09-10 Thread Wang Hai
meter 'rq_msix_entry' description in 'hinic_io_create_qps' Rename these wrong names. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/huawei/hinic/hinic_hw_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethern

[PATCH net-next 2/6] net: hns: fix 'cdev' kernel-doc warning in hnae_ae_unregister()

2020-09-10 Thread Wang Hai
Rename cdev to hdev. Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/hisilicon/hns/hnae.c:444: warning: Excess function parameter 'cdev' description in 'hnae_ae_unregister' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/

[PATCH net-next 6/6] net: hns: Fix a kernel-doc warning in hinic_hw_eqs.c

2020-09-10 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/huawei/hinic/hinic_hw_eqs.c:115: warning: Excess function parameter 'hw_handler' description in 'hinic_aeq_register_hw_cb' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/e

[PATCH net-next 5/6] net: hns: Fix a kernel-doc warning in hinic_hw_api_cmd.c

2020-09-10 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/huawei/hinic/hinic_hw_api_cmd.c:382: warning: Excess function parameter 'size' description in 'api_cmd' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/huawei/hinic/hinic_hw

[PATCH net-next 3/6] net: hns: Fix some kernel-doc warnings in hns_dsaf_xgmac.c

2020-09-10 Thread Wang Hai
'cmd' description in 'hns_xgmac_get_regs' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_xgmac

[PATCH net-next 4/6] net: hns: Fix some kernel-doc warnings in hns_enet.c

2020-09-10 Thread Wang Hai
r 'p' description in 'hns_set_multicast_list' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/hisilicon/hns/hns_enet.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_enet.c b/drivers/net

[PATCH net-next 0/3] Fix some kernel-doc warnings for i40e

2020-09-10 Thread Wang Hai
Wang Hai (3): i40e: Fix some kernel-doc warnings in i40e_client.c i40e: Fix some kernel-doc warnings in i40e_common.c i40e: Fix a kernel-doc warning in i40e_ptp.c drivers/net/ethernet/intel/i40e/i40e_client.c | 2 -- drivers/net/ethernet/intel/i40e/i40e_common.c | 2 -- drivers/net

[PATCH net-next 2/3] i40e: Fix some kernel-doc warnings in i40e_common.c

2020-09-10 Thread Wang Hai
buff_size' description in 'i40e_aq_start_lldp' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/intel/i40e/i40e_common.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_common.c b/drivers/net/ethernet/int

[PATCH net-next 1/3] i40e: Fix some kernel-doc warnings in i40e_client.c

2020-09-10 Thread Wang Hai
x27;existing' description in 'i40e_client_add_instance' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/intel/i40e/i40e_client.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c b/drivers/net/ethernet/int

[PATCH net-next] igb: Fix some kernel-doc warnings in e1000_82575.c

2020-09-10 Thread Wang Hai
7;adv100m' description in 'igb_set_eee_i350' drivers/net/ethernet/intel/igb/e1000_82575.c:2655: warning: Excess function parameter 'adv100m' description in 'igb_set_eee_i354' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/intel/igb/

[PATCH net-next] igb: Fix some kernel-doc warnings in e1000_82575.c

2020-09-10 Thread Wang Hai
7;adv100m' description in 'igb_set_eee_i350' drivers/net/ethernet/intel/igb/e1000_82575.c:2655: warning: Excess function parameter 'adv100m' description in 'igb_set_eee_i354' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/intel/igb/

[PATCH net-next 1/3] e1000e: Fix some kernel-doc warnings in ich8lan.c

2020-09-10 Thread Wang Hai
#x27;addr' description in '__e1000_access_emi_reg_locked' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/n

[PATCH net-next 0/3] Fix some kernel-doc warnings for e1000/e1000e

2020-09-10 Thread Wang Hai
Wang Hai (3): e1000e: Fix some kernel-doc warnings in ich8lan.c e1000e: Fix some kernel-doc warnings in netdev.c e1000: Fix a bunch of kerneldoc parameter issues in e1000_hw.c drivers/net/ethernet/intel/e1000/e1000_hw.c | 7 +-- drivers/net/ethernet/intel/e1000e/ich8lan.c | 4

[PATCH net-next 2/3] e1000e: Fix some kernel-doc warnings in netdev.c

2020-09-10 Thread Wang Hai
description in 'e1000e_hwtstamp_set' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/n

[PATCH net-next 3/3] e1000: Fix a bunch of kerneldoc parameter issues in e1000_hw.c

2020-09-10 Thread Wang Hai
ter 'total_collisions' description in 'e1000_update_adaptive' drivers/net/ethernet/intel/e1000/e1000_hw.c:5079: warning: Excess function parameter 'downshift' description in 'e1000_check_downshift' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/n

[PATCH net-next 3/3] i40e: Fix a kernel-doc warning in i40e_ptp.c

2020-09-10 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/intel/i40e/i40e_ptp.c:270: warning: Excess function parameter 'vsi' description in 'i40e_ptp_rx_hang' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/intel/i40e/i40e_ptp.c | 1

[PATCH net-next] net: cavium: Fix a bunch of kerneldoc parameter issues

2020-09-09 Thread Wang Hai
function parameter 'ptp' description in 'cavium_ptp_settime' drivers/net/ethernet/cavium/common/cavium_ptp.c:208: warning: Excess function parameter 'ptp' description in 'cavium_ptp_enable' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/n

[PATCH net-next] ath5k: fix 'mode' kernel-doc warning in ath5k_hw_pcu_init()

2020-09-09 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath5k/pcu.c:955: warning: Excess function parameter 'mode' description in 'ath5k_hw_pcu_init' This parameter is not in use. Remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/ne

[PATCH net-next] cipso: fix 'audit_secid' kernel-doc warning in cipso_ipv4.c

2020-09-08 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): net/ipv4/cipso_ipv4.c:510: warning: Excess function parameter 'audit_secid' description in 'cipso_v4_doi_remove' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/ipv4/cipso_ipv4.c | 2 +- 1 file changed, 1 inse

[PATCH net-next] net: wimax: i2400m: fix 'msg_skb' kernel-doc warning in i2400m_msg_to_dev()

2020-09-08 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/wimax/i2400m/control.c:709: warning: Excess function parameter 'msg_skb' description in 'i2400m_msg_to_dev' This parameter is not in use. Remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- driv

[PATCH net-next] netlabel: Fix some kernel-doc warnings

2020-09-08 Thread Wang Hai
#x27;calipso_req_delattr' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/netlabel/netlabel_calipso.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netlabel/netlabel_calipso.c b/net/netlabel/netlabel_calipso.c index 249da67d50a2..1a98247ab148 100644 ---

[PATCH net-next] bnx2x: Fix some kernel-doc warnings

2020-09-08 Thread Wang Hai
'tc' description in 'bnx2x_setup_tc' Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c b/drivers/net/e

[PATCH net-next] net: ethernet: dnet: Remove set but unused variable 'len'

2020-09-07 Thread Wang Hai
ted)") involved this unused variable, remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/dnet.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/dnet.c b/drivers/net/ethernet/dnet.c index db98274501a0..3143df9a398c

[PATCH net-next] mt76: mt7615: Remove set but unused variable 'index'

2020-09-07 Thread Wang Hai
888 ("mt76: mt7615: implement testmode support") involved this unused variable, remove it. Signed-off-by: Wang Hai --- drivers/net/wireless/mediatek/mt76/mt7615/testmode.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/testmode.c b/

[PATCH net-next v2] net/packet: Remove unused macro BLOCK_PRIV

2020-09-05 Thread Wang Hai
BLOCK_PRIV is never used after it was introduced. So better to remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2: Corrected the wrong comment net/packet/af_packet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c in

[PATCH net-next] can: peak_canfd: Remove unused macros

2020-09-04 Thread Wang Hai
CANFD_CLK_SEL_DIV_MASK and CANFD_OPTIONS_SET are never used after they were introduced. Remove them. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/can/peak_canfd/peak_pciefd_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/can/peak_canfd

[PATCH net-next] can: kvaser_pciefd: Remove unused macro KVASER_PCIEFD_KCAN_CTRL_EFRAME

2020-09-04 Thread Wang Hai
KVASER_PCIEFD_KCAN_CTRL_EFRAME is never used after it was introduced. So better to remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/can/kvaser_pciefd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c

[PATCH net-next] rxrpc: Remove unused macro rxrpc_min_rtt_wlen

2020-09-04 Thread Wang Hai
rxrpc_min_rtt_wlen is never used after it was introduced. So better to remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/rxrpc/rtt.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/rxrpc/rtt.c b/net/rxrpc/rtt.c index 928d8b34a3ee..a056c9bcf1d6 100644 --- a/net/rxrpc

[PATCH net-next] net/packet: Remove unused macro BLOCK_PRIV

2020-09-04 Thread Wang Hai
BPDU_TYPE_TCN is never used after it was introduced. So better to remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/packet/af_packet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index da8254e680f9..c430672c6a67 100644

[PATCH net-next] NFC: digital: Remove two unused macroes

2020-09-04 Thread Wang Hai
DIGITAL_NFC_DEP_REQ_RES_TAILROOM is never used after it was introduced. DIGITAL_NFC_DEP_REQ_RES_HEADROOM is no more used after below commit e8e7f4217564 ("NFC: digital: Remove useless call to skb_reserve()") Remove them. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/nfc/dig

[PATCH net-next] caif: Remove duplicate macro SRVL_CTRL_PKT_SIZE

2020-09-04 Thread Wang Hai
Remove SRVL_CTRL_PKT_SIZE which is defined more than once. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/caif/cfsrvl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/caif/cfsrvl.c b/net/caif/cfsrvl.c index d0a4d0ac7045..9cef9496a707 100644 --- a/net/caif/cfsrvl.c +++ b/net

[PATCH net-next] netfilter: ebt_stp: Remove unused macro BPDU_TYPE_TCN

2020-09-04 Thread Wang Hai
BPDU_TYPE_TCN is never used after it was introduced. So better to remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/bridge/netfilter/ebt_stp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/bridge/netfilter/ebt_stp.c b/net/bridge/netfilter/ebt_stp.c index 0d6d20c9105e

[PATCH net-next] SUNRPC: remove duplicate include

2020-08-18 Thread Wang Hai
Remove linux/sunrpc/auth_gss.h which is included more than once Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/sunrpc/auth_gss/trace.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/sunrpc/auth_gss/trace.c b/net/sunrpc/auth_gss/trace.c index d26036a57443..76685abba60f 100644

[PATCH net-next] net: ipa: remove duplicate include

2020-08-18 Thread Wang Hai
Remove linux/notifier.h which is included more than once Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ipa/ipa.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ipa/ipa.h b/drivers/net/ipa/ipa.h index 55115cfb2972..407fee841a9a 100644 --- a/drivers/net/ipa

[PATCH net v2] net: gemini: Fix missing free_netdev() in error path of gemini_ethernet_port_probe()

2020-08-18 Thread Wang Hai
Replace alloc_etherdev_mq with devm_alloc_etherdev_mqs. In this way, when probe fails, netdev can be freed automatically. Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2

[PATCH net] net: gemini: Fix missing free_netdev() in error path of gemini_ethernet_port_probe()

2020-08-18 Thread Wang Hai
Fix the missing free_netdev() before return from gemini_ethernet_port_probe() in the error handling case. Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/cortina/gem

[PATCH net] net: qcom/emac: add missed clk_disable_unprepare in error path of emac_clks_phase1_init

2020-08-09 Thread Wang Hai
Fix the missing clk_disable_unprepare() before return from emac_clks_phase1_init() in the error handling case. Fixes: b9b17debc69d ("net: emac: emac gigabit ethernet controller driver") Reported-by: Hulk Robot Signed-off-by: Wang Hai Acked-by: Timur Tabi --- drivers/net/ethernet/qua

[PATCH net] net: qcom/emac: Fix missing clk_disable_unprepare() in error path of emac_probe

2020-08-06 Thread Wang Hai
gabit ethernet controller driver") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/qualcomm/emac/emac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qualcomm/emac/emac.c b/drivers/net/ethernet/qualcomm/emac/emac.c index 20

[PATCH net] wl1251: fix always return 0 error

2020-07-30 Thread Wang Hai
wl1251_event_ps_report() should not always return 0 because wl1251_ps_set_mode() may fail. Change it to return 'ret'. Fixes: f7ad1eed4d4b ("wl1251: retry power save entry") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/wireless/ti/wl1251/event.c | 2 +

[PATCH net] net: gemini: Fix missing clk_disable_unprepare() in error path of gemini_ethernet_port_probe()

2020-07-30 Thread Wang Hai
Fix the missing clk_disable_unprepare() before return from gemini_ethernet_port_probe() in the error handling case. Fixes: 4d5ae32f5e1e ("net: ethernet: Add a driver for Gemini gigabit ethernet") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/cortina/ge

[PATCH net] net: ll_temac: Use devm_platform_ioremap_resource_byname()

2020-07-30 Thread Wang Hai
("net: ll_temac: Extend support to non-device-tree platforms") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/xilinx/ll_temac_main.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/d

[PATCH net] qtnfmac: Missing platform_device_unregister() on error in qtnf_core_mac_alloc()

2020-07-29 Thread Wang Hai
Add the missing platform_device_unregister() before return from qtnf_core_mac_alloc() in the error handling case. Fixes: 616f5701f4ab ("qtnfmac: assign each wiphy to its own virtual platform device") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/wireless/quanten

[PATCH net-next] liquidio: Replace vmalloc with kmalloc in octeon_register_dispatch_fn()

2020-07-29 Thread Wang Hai
The size of struct octeon_dispatch is too small, it is better to use kmalloc instead of vmalloc. Suggested-by: Joe Perches Signed-off-by: Wang Hai --- drivers/net/ethernet/cavium/liquidio/octeon_device.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers

[PATCH net-next] net: hix5hd2_gmac: Remove unneeded cast from memory allocation

2020-07-24 Thread Wang Hai
Coccinelle software. Signed-off-by: Wang Hai --- drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c index 4fb776920..8b2bf8503 100644 --- a

[PATCH net-next] liquidio: Remove unneeded cast from memory allocation

2020-07-24 Thread Wang Hai
Remove casting the values returned by memory allocation function. Coccinelle emits WARNING: ./drivers/net/ethernet/cavium/liquidio/octeon_device.c:1155:14-36: WARNING: casting value returned by memory allocation function to (struct octeon_dispatch *) is useless. Signed-off-by: Wang Hai

[PATCH net-next] net: qed: Remove unneeded cast from memory allocation

2020-07-21 Thread Wang Hai
Remove casting the values returned by memory allocation function. Coccinelle emits WARNING: casting value returned by memory allocation unction to (struct roce_destroy_qp_req_output_params *) is useless. This issue was detected by using the Coccinelle software. Signed-off-by: Wang Hai

[PATCH net-next v3] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range

2020-07-20 Thread Wang Hai
Fix sparse build warning: drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning: Using plain integer as NULL pointer Reported-by: Hulk Robot Signed-off-by: Wang Hai Suggested-by: Joe Perches Acked-by: Shay Agroskin --- v1->v2: Improve code readability based on Joe Perche

[PATCH net-next v2] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range

2020-07-19 Thread Wang Hai
Fix sparse build warning: drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning: Using plain integer as NULL pointer Reported-by: Hulk Robot Signed-off-by: Wang Hai Suggested-by: Joe Perches Acked-by: Shay Agroskin --- v1->v2: Improve code readability based on Joe Perche

[PATCH -next] net: hsr: remove redundant null check

2020-07-18 Thread Wang Hai
Because kfree_skb already checked NULL skb parameter, so the additional checks are unnecessary, just remove them. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/hsr/hsr_forward.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/hsr/hsr_forward.c b/net/hsr

[PATCH -next] net: ena: use NULL instead of zero

2020-07-18 Thread Wang Hai
Fix sparse build warning: drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning: Using plain integer as NULL pointer Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH -next] bpf: Make some functions static

2020-07-18 Thread Wang Hai
s not declared. Should it be static? net/bpf/test_run.c:164:14: warning: symbol 'bpf_modify_return_test' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/bpf/test_run.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --g

[PATCH] net: dsa: felix: Make some symbols static

2020-07-18 Thread Wang Hai
static? Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/dsa/ocelot/felix_vsc9959.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/ocelot/felix_vsc9959.c b/drivers/net/dsa/ocelot/felix_vsc9959.c index 1dd9e348152d..2067776773f7 100644 -

[PATCH v2] nfc: nci: add missed destroy_workqueue in nci_register_device

2020-07-17 Thread Wang Hai
When nfc_register_device fails in nci_register_device, destroy_workqueue() shouled be called to destroy ndev->tx_wq. Fixes: 3c1c0f5dc80b ("NFC: NCI: Fix nci_register_device init sequence") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- v1->v2: Change the module from "

[PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe failure

2020-07-16 Thread Wang Hai
The driver forgets to call destroy_workqueue when cxgb3 probe fails. Add the missed calls to fix it. Fixes: 4d22de3e6cc4 ("Add support for the latest 1G/10G Chelsio adapter, T3.") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 1

[PATCH] net: cxgb3: add missed destroy_workqueue in nci_register_device

2020-07-16 Thread Wang Hai
When nfc_register_device fails in nci_register_device, destroy_workqueue() shouled be called to destroy ndev->tx_wq. Fixes: 3c1c0f5dc80b ("NFC: NCI: Fix nci_register_device init sequence") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/nfc/nci/core.c | 5 - 1 fi

[PATCH] net: ethernet: ave: Fix error returns in ave_init

2020-07-16 Thread Wang Hai
Hulk Robot Signed-off-by: Wang Hai --- drivers/net/ethernet/socionext/sni_ave.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c index f2638446b62e..81b554dd7221 100644 --- a/drivers/net/ethernet

[PATCH] net: smc91x: Fix possible memory leak in smc_drv_probe()

2020-07-15 Thread Wang Hai
If try_toggle_control_gpio() failed in smc_drv_probe(), free_netdev(ndev) should be called to free the ndev created earlier. Otherwise, a memleak will occur. Fixes: 7d2911c43815 ("net: smc91x: Fix gpios for device tree based booting") Reported-by: Hulk Robot Signed-off-by: Wang Hai --

[PATCH v2] 9p/trans_fd: Fix concurrency del of req_list in p9_fd_cancelled/p9_read_work

2020-06-12 Thread Wang Hai
xes: 60ff779c4abb ("9p: client: remove unused code and any reference to "cancelled" function") Reported-by: syzbot+77a25acfa0382e06a...@syzkaller.appspotmail.com Signed-off-by: Wang Hai --- v1->v2: 1. Add ignoring replies associated with a cancelled request. 2. Improved s

[PATCH] mld: fix memory leak in ipv6_mc_destroy_dev()

2020-06-11 Thread Wang Hai
t;] __x64_sys_setsockopt+0xba/0x150 net/socket.c:2145 [<c7bc11c5>] do_syscall_64+0xa1/0x530 arch/x86/entry/common.c:295 [<5fb7a3f3>] entry_SYSCALL_64_after_hwframe+0x49/0xb3 Fixes: 1666d49e1d41 ("mld: do not remove mld souce list info when set link down

[PATCH] 9p/trans_fd: Fix concurrency del of req_list in p9_fd_cancelled/p9_read_work

2020-06-10 Thread Wang Hai
d. Fixes: 60ff779c4abb ("9p: client: remove unused code and any reference to "cancelled" function") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/9p/trans_fd.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/net/9p/trans_fd.c b/net/9p/tran

[PATCH] dccp: Fix possible memleak in dccp_init and dccp_fini

2020-06-09 Thread Wang Hai
dccp_orphan_count. It need to goto out_free_percpu when inet_hashinfo2_init_mod() failed. Fixes: c92c81df93df ("net: dccp: fix kernel crash on module load") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- include/net/inet_hashtables.h | 6 ++ net/dccp/proto.c | 7 +-

[PATCH] yam: fix possible memory leak in yam_init_driver

2020-06-04 Thread Wang Hai
If register_netdev(dev) fails, free_netdev(dev) needs to be called, otherwise a memory leak will occur. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: Hulk Robot Signed-off-by: Wang Hai --- drivers/net/hamradio/yam.c | 1 + 1 file changed, 1 insertion(+) diff --git a/d