Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-05 Thread Victor Julien
On 04-06-2020 15:48, Willem de Bruijn wrote: > On Thu, Jun 4, 2020 at 5:47 AM Victor Julien wrote: >> >> On 02-06-2020 22:18, Willem de Bruijn wrote: >>> On Tue, Jun 2, 2020 at 4:05 PM Victor Julien wrote: >>>> >>>> On 02-06-2020 21:38, Willem de

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-04 Thread Victor Julien
On 02-06-2020 22:18, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 4:05 PM Victor Julien wrote: >> >> On 02-06-2020 21:38, Willem de Bruijn wrote: >>> On Tue, Jun 2, 2020 at 3:22 PM Victor Julien wrote: >>>> >>>> On 02-06-2020 21:03, Willem de

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
On 02-06-2020 22:18, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 4:05 PM Victor Julien wrote: >> >> On 02-06-2020 21:38, Willem de Bruijn wrote: >>> On Tue, Jun 2, 2020 at 3:22 PM Victor Julien wrote: >>>> >>>> On 02-06-2020 21:03, Willem de

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
On 02-06-2020 21:38, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 3:22 PM Victor Julien wrote: >> >> On 02-06-2020 21:03, Willem de Bruijn wrote: >>> On Tue, Jun 2, 2020 at 2:31 PM Victor Julien wrote: >>>> On 02-06-2020 19:37, Willem de Bruijn wrote:

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
On 02-06-2020 21:29, Jakub Kicinski wrote: > On Tue, 2 Jun 2020 21:22:11 +0200 Victor Julien wrote: >> - receiver uses nfp (netronome) driver: TP_STATUS_CSUM_VALID set for >> every packet, including the bad TCP ones >> - receiver uses ixgbe driver: TP_STATUS_CSUM_VALI

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
On 02-06-2020 21:03, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 2:31 PM Victor Julien wrote: >> On 02-06-2020 19:37, Willem de Bruijn wrote: >>> On Tue, Jun 2, 2020 at 1:03 PM Victor Julien wrote: >>>> >>>> On 02-06-2020 16:29, Willem de Bruijn w

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
Hi Willem, On 02-06-2020 19:37, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 1:03 PM Victor Julien wrote: >> >> On 02-06-2020 16:29, Willem de Bruijn wrote: >>> On Tue, Jun 2, 2020 at 4:05 AM Victor Julien wrote: >>>> >>>> Introduce a n

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
On 02-06-2020 16:29, Willem de Bruijn wrote: > On Tue, Jun 2, 2020 at 4:05 AM Victor Julien wrote: >> >> Introduce a new flag (TP_STATUS_CSUM_UNNECESSARY) to indicate >> that the driver has completely validated the checksums in the packet. >> >> The TP_STATUS_C

Re: [PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
2-06-2020 10:05, Victor Julien wrote: > Introduce a new flag (TP_STATUS_CSUM_UNNECESSARY) to indicate > that the driver has completely validated the checksums in the packet. > > The TP_STATUS_CSUM_UNNECESSARY flag differs from TP_STATUS_CSUM_VALID > in that the new flag will only be s

[PATCH net-next v2] af-packet: new flag to indicate all csums are good

2020-06-02 Thread Victor Julien
for many of the packets. This patch has been tested with Suricata with the virtio driver, where it reduced the ammount of time spent in the Suricata TCP checksum validation to about half. Signed-off-by: Victor Julien --- Documentation/networking/packet_mmap.rst | 80 +--- incl

Re: [PATCH net-next] af-packet: new flag to indicate all csums are good

2020-06-01 Thread Victor Julien
On 01-06-2020 23:45, David Miller wrote: > From: Victor Julien > Date: Mon, 1 Jun 2020 22:49:37 +0200 > >> @@ -472,6 +472,12 @@ TP_STATUS_CSUM_VALIDThis flag indicates that at >> least the transport >> validated on the kernel s

[PATCH net-next] af-packet: new flag to indicate all csums are good

2020-06-01 Thread Victor Julien
ata TCP checksum validation to about half. Signed-off-by: Victor Julien --- Documentation/networking/packet_mmap.rst | 6 ++ include/uapi/linux/if_packet.h | 1 + net/packet/af_packet.c | 3 +++ 3 files changed, 10 insertions(+) diff --git a/Documentation/network

Re: [PATCH] packet: Use symmetric hash for PACKET_FANOUT_HASH.

2016-07-04 Thread Victor Julien
g in on the RX side. As the said tools often rely on the hashing for load balancing to multiple threads/processes, the hashing should be done symmetrically. -- - Victor Julien http://www.inliniac.net/ PGP: http://www.inliniac.net/victorjulien.asc -