[PATCH 2.6.22 4/4]S2IO: Implementing review comments from old patches

2007-07-22 Thread Veena Parat
- Incorporated Jeff Garzik's comments on coding standards Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -urpN patch_3/drivers/net/s2io.c patch_4/drivers/net/s2io.c --- patch_3/drivers/net/s2io.c 2007-07-19 17:44:54.0 +0530 +++ patch_4/drivers/net/s2io.c 2007-

[PATCH 2.6.22 3/4]S2IO: Checking for the return value of pci map function

2007-07-22 Thread Veena Parat
- Checking for the return value of pci map function - Implemented Francois Romieu's comments on eliminating code duplication using goto - Implemented Francois Romieu's comments on using a temporary variable for accessing statistics structure Signed-off-by: Veena Parat <[EM

RE: [PATCH 2.6.22 1/4]S2IO: Removing MSI support from driver

2007-07-22 Thread Veena Parat
Hi, The patch number is incorrect in the below mail. It should be [PATCH 2.6.22 2/4] instead of [PATCH 2.6.22 1/4]. Pls consider it as the second patch in this series. Sorry for the inconvenience. Regards Veena -Original Message- From: Veena Parat [mailto:[EMAIL PROTECTED] Sent

[PATCH 2.6.22 1/4]S2IO: Removing MSI support from driver

2007-07-22 Thread Veena Parat
- Removed MSI support from driver - unused feature - Replaced request_mem_region with pci_request_regions Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -urpN patch_1/drivers/net/s2io.c patch_2/drivers/net/s2io.c --- patch_1/drivers/net/s2io.c 2007-07-19 14:20:53.0

[PATCH 2.6.22 1/4]S2IO: Removing 3 buffer mode support from the driver

2007-07-22 Thread Veena Parat
- Removed 3 buffer mode support from driver - unused feature - Incorporated Jeff Garzik's comments on elimination of inline typecasting - Code cleanup : Removed a few extra spaces Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -urpN org/drivers/net/s2io.c patch_1/drivers

[PATCH 2.6.22 3/4]S2IO: Removing 3 buffer mode support from the driver

2007-07-12 Thread Veena Parat
- Removed 3 buffer mode support from driver - unused feature Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -Nurp 2.0.23.1P2/drivers/net/s2io.c 2.0.23.1P3/drivers/net/s2io.c --- 2.0.23.1P2/drivers/net/s2io.c 2007-07-04 02:05:10.0 -0700 +++ 2.0.23.1P3/drivers/net/

[PATCH 2.6.22 4/4]S2IO: Implementing review comments from old patches

2007-07-12 Thread Veena Parat
Implementation of review comments - Incorporated Jeff Garzik's comments on coding standards - Incorporated Andreas Schwab's comments on redundant condition check Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -Nurp 2.0.23.1P3/drivers/net/s2io.c 2.0.23.1P4/dr

[PATCH 2.6.22 2/4]S2IO: Removing MSI support from the driver

2007-07-12 Thread Veena Parat
- Removed MSI support from driver - unused feature - Incorporated Jeff Garzik's comments on elimination of inline typecasting Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -Nurp 2.0.23.1P1/drivers/net/s2io.c 2.0.23.1P2/drivers/net/s2io.c --- 2.0.23.1P1/drivers/net/s2io.c

PATCH 2.6.22 3/4]S2IO: Removing 3 buffer mode support from the driver

2007-07-12 Thread Veena Parat
- Removed 3 buffer mode support from driver - unused feature Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -Nurp 2.0.23.1P2/drivers/net/s2io.c 2.0.23.1P3/drivers/net/s2io.c --- 2.0.23.1P2/drivers/net/s2io.c 2007-07-04 02:05:10.0 -0700 +++ 2.0.23.1P3/drivers/net/

[PATCH 2.6.22 1/4]S2IO: Adding checks to check the return value of pci mapping function

2007-07-12 Thread Veena Parat
- Adding checks to check the return value of pci mapping function Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -Nurp 2.0.23.1/drivers/net/s2io.c 2.0.23.1P1/drivers/net/s2io.c --- 2.0.23.1/drivers/net/s2io.c 2007-07-03 08:54:02.0 -0700 +++ 2.0.23.1P1/drivers/net/

[PATCH 2.6.22 2/4]S2IO: Removing MSI support from the driver

2007-06-19 Thread Veena Parat
1.Removed MSI support from driver - unused feature 2.Removed pci_request_regions call to allocate bar2 as it is not used in driver 3.Removed pci_release_regions since pci_request_regions is not done Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -urpN patch_1/drivers/net/s2io.c p

[PATCH 2.6.22 1/4]S2IO: Adding checks to check the return value of pci mapping function

2007-06-19 Thread Veena Parat
Adding checks to check the return value of pci mapping function Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -urpN org/drivers/net/s2io.c patch_1/drivers/net/s2io.c --- org/drivers/net/s2io.c 2007-05-17 20:35:39.0 +0530 +++ patch_1/drivers/net/s2io.c 2007-05-17

[PATCH 2.6.22 4/4]S2IO: Implementing review comments from old patches

2007-06-19 Thread Veena Parat
Implementation of review comments 1. Incorporated Jeff Garzik's comments on coding standards. 2. Incorporated Andreas Schwab's comments on redundant condition check. Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -urpN patch_3/drivers/net/s2io.c patch_4/drivers/net/s2

[PATCH 2.6.22 3/4]S2IO: Removing 3 buffer mode support from the driver

2007-06-19 Thread Veena Parat
Removed 3 buffer mode support from driver - unused feature Signed-off-by: Veena Parat <[EMAIL PROTECTED]> --- diff -urpN patch_2/drivers/net/s2io.c patch_3/drivers/net/s2io.c --- patch_2/drivers/net/s2io.c 2007-05-21 15:15:11.0 +0530 +++ patch_3/drivers/net/s2io.c 2007-06-07