[tipc-discussion] [net v3 1/1] tipc: fix memory leak caused by tipc_buf_append()

2020-10-26 Thread Tung Nguyen
hat the original skb is not freed after freeing the fragment 2 times in case skb_unshare() returns NULL. Fixes: ed42989eab57 ("tipc: fix the skb_unshare() in tipc_buf_append()") Acked-by: Jon Maloy Reported-by: Thang Hoang Ngo Signed-off-by: Tung Nguyen --- net/tipc/msg.c | 5 ++--- 1

[tipc-discussion] [net v2 1/1] tipc: fix memory leak caused by tipc_buf_append()

2020-10-26 Thread Tung Nguyen
the original skb is not freed after freeing the fragment 2 times in case skb_unshare() returns NULL. Fixes: ed42989eab57 ("fix the skb_unshare() in tipc_buf_append()") Acked-by: Jon Maloy Reported-by: Thang Hoang Ngo Signed-off-by: Tung Nguyen --- net/tipc/msg.c | 5 ++--- 1 file chan

[tipc-discussion] [net v1 1/1] tipc: fix memory leak caused by tipc_buf_append()

2020-10-25 Thread Tung Nguyen
skb is not NULL. Fixes: ed42989eab57 ("fix the skb_unshare() in tipc_buf_append()") Acked-by: Jon Maloy Reported-by: Thang Hoang Ngo Signed-off-by: Tung Nguyen --- net/tipc/msg.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/tipc/msg.c b/net/tipc/msg.c

[tipc-discussion] [net v1 1/1] tipc: allow to build NACK message in link timeout function

2020-07-20 Thread Tung Nguyen
ilt to send back to another peer. Fixes: commit 02288248b051 ("tipc: eliminate gap indicator from ACK messages") Acked-by: Jon Maloy Signed-off-by: Tung Nguyen --- net/tipc/link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/link.c b/net/tipc/link.c inde

[net v3 1/1] tipc: fix race condition causing hung sendto

2019-02-24 Thread Tung Nguyen
remove_wait_queue(); | } | }| This commit fixes it by adding memory barrier to tipc_sk_proto_rcv() and tipc_wait_for_cond(). Acked-by: Jon Maloy Signed-off-by: Tung Nguyen --- net/tipc/socket.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/n

[tipc-discussion][net v2 1/1] tipc: fix race condition causing hung sendto

2019-02-20 Thread Tung Nguyen
remove_wait_queue(); | } | }| This commit fixes it by adding memory barrier to tipc_sk_proto_rcv() and tipc_wait_for_cond(). Acked-by: Jon Maloy Signed-off-by: Tung Nguyen --- net/tipc/socket.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a

[tipc-discussion][net 1/1] tipc: fix race condition causing hung sendto

2019-02-18 Thread Tung Nguyen
remove_wait_queue(); | } | }| This commit fixes it by adding memory barrier to tipc_sk_proto_rcv() and tipc_wait_for_cond(). Acked-by: Jon Maloy Signed-off-by: Tung Nguyen --- net/tipc/socket.c | 4 1 file changed, 4 insertions(+) mode change 100644 => 100

[tipc-discussion][net 0/1] tipc: fix race condition between sleep/wakeup

2019-02-18 Thread Tung Nguyen
Fix issue of hung sendto() in user space. Tung Nguyen (1): tipc: fix race condition causing hung sendto net/tipc/socket.c | 4 1 file changed, 4 insertions(+) mode change 100644 => 100755 net/tipc/socket.c -- 2.17.1

[tipc-discussion][net 0/2] improvement for wait and wakeup

2019-02-18 Thread Tung Nguyen
Some improvements for tipc_wait_for_xzy(). Tung Nguyen (2): tipc: improve function tipc_wait_for_cond() tipc: improve function tipc_wait_for_rcvmsg() net/tipc/socket.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) -- 2.17.1

[tipc-discussion][net 1/2] tipc: improve function tipc_wait_for_cond()

2019-02-18 Thread Tung Nguyen
ait() with add_wait_queue() as the pair function with remove_wait_queue(). Acked-by: Ying Xue Acked-by: Jon Maloy Signed-off-by: Tung Nguyen --- net/tipc/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 1217c90a363b..81b87916a

[tipc-discussion][net 2/2] tipc: improve function tipc_wait_for_rcvmsg()

2019-02-18 Thread Tung Nguyen
-off-by: Tung Nguyen --- net/tipc/socket.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/net/tipc/socket.c b/net/tipc/socket.c index 81b87916a0eb..684f2125fc6b 100644 --- a/net/tipc/socket.c +++ b/net/tipc/socket.c @@ -1677,7 +1677,7 @@ static void tipc_sk_send_ack