Hi Paul,
Am 07.12.2016 um 22:08 schrieb Paul Bolle:
> On Wed, 2016-12-07 at 21:57 +0100, Tilman Schmidt wrote:
>> Not much of a mess, I reckon. Everything that has been allocated and
>> registered up to that point is properly deallocated and unregistered.
>> The code just fai
s a nuisance and a
waste of RAM, but not much more.
HTH
Tilman
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.
signature.asc
Description: OpenPGP digital signature
lace, Paul already did show you the place.
>
> To which source code place do you refer here?
Obviously the one Paul pointed out to you in detail in his mail dated
Mon, 26 Sep 2016 23:13:54 +0200.
HTH,
Tilman
--
Tilman Schmidt
til...@imap.cc
ly reclaimed
> after it would return a null pointer?
No. Should I? Do you?
Regards,
Tilman
--
Tilman Schmidt
til...@imap.cc
CJ16-Refactor_Strings-WSang_0.pdf
>
> Signed-off-by: Markus Elfring
The patch is fine but the link in the commit message is irrelevant.
Please remove it.
(Yes, I read through the whole presentation to verify that. It was fun,
even.)
--
Tilman Schmidt
til...@imap.cc
hat is of secondary importance,
and if you want to do that, as a minimum you have to make sure that you
don't introduce new bugs.
Thanks,
Tilman
--
Tilman Schmidt
til...@imap.cc
e has
> ISDN support which is actively used.
AFAIK none of these uses I4L anymore. Asterisk dropped I4L support with
version 2 if my memory is correct and nowadays uses CAPI, mISDN or its
own DAHDI interface.
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
-over-TCP service
- last but not least, via the mISDNcapid daemon and mISDN
Of course this cuts off anything that doesn't pass through libcapi20.so,
including applications that (against the standard) access /dev/capi20
directly but also the capidrv.ko i4l compatibility shim.
--
Tilman Schmidt
Am 07.03.2016 um 09:48 schrieb Paul Bolle:
> On za, 2016-03-05 at 14:08 +0100, Tilman Schmidt wrote:
>> As a consequence, owners of HiSAX type adapters are in fact stuck with
>> the old hisax driver if they want to continue using i4l userspace
>> tools.
>
> Do you know
tristate
+ default ISDN_I4L
help
This option provides the glue code to hook up CAPI driven cards to
the legacy isdn4linux link layer. If you have a card which is
Jm2c,
Tilman
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.
signature.asc
Description: OpenPGP digital signature
; gigaset_device_release() to get to our struct cardstate. Which has the
> net effect of leaking a struct ser_cardstate at every call of this
> driver's tty close() operation. So using container_of() has the
> additional benefit of actually working.
>
> Reported-by: Dmitry Vyukov
kfree_skb() /
> dev_consume_skb_any().
Would you mind adding a kerneldoc comment for the new API function?
Thanks,
Tilman
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.
signature.asc
Description: OpenPGP digital signature
fectly fine
> with that.)
I think as a maintainer you are supposed to sign off patches for the
code you maintain. My signed-off as recently retired ex-maintainer was
probably still good enough in July. I'm unsure whether it still is today.
Regards,
Tilman
--
Tilman Schmidt
cs)
>>>> + return;
>>>> + dev_set_drvdata(dev, NULL);
>
> This is of marginal value and (I think) unnecessary; it implies
> the core will use the device after release, which would trigger
> many problems if true.
Agreed, but I'm just moving existing code here. Dropping the
dev_set_drvdata() call would be an unrelated change which should be done
in a separate patch if I understand the rules correctly.
Regards,
Tilman
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.
signature.asc
Description: OpenPGP digital signature
w but
> only moved around, but I think that's still an opportunity to have
> another look at that code.)
I'm a big fan of one change per patch. If we also want to modify the
moved code then that should be done in a separate patch. It makes
bisecting so much easier. Same reason why
Am 08.12.2015 um 23:16 schrieb One Thousand Gnomes:
> The right fix as far as I can see is to remove the tests although
> WARN_ON() combined with your tty->ops change might be safer.
Feel free to submit a patch.
>> It's pretty obvious that this should have been part of commit
>> f34d7a5b7010 ("t
en through the cracks in my last series.
Patch 2/3 should go into stable releases all the way back to 2.6.32.
It applies cleanly to release 3.*/4.* with at most offset 1.
For release 2.6.32 there is a trivial merge conflict with a removed
comment line.
Thanks,
Tilman
Tilman Schmidt (3):
ser_gi
device->platform_data and platform_device->resource are never used
and remain NULL through their entire life. Drops the kfree() calls
for them from the device release method.
Signed-off-by: Tilman Schmidt
Reported-by: Paul Bolle
---
drivers/isdn/gigaset/ser-gigaset.c | 5 -
1 file c
When shutting down the device, the struct ser_cardstate must not be
kfree()d immediately after the call to platform_device_unregister()
since the embedded struct platform_device is still in use.
Move the kfree() call to the release method instead.
Signed-off-by: Tilman Schmidt
Fixes
Commit f34d7a5b changed tty->driver to tty->ops but left NULL checks
for tty->driver untouched. Fix.
Signed-off-by: Tilman Schmidt
Fixes: f34d7a5b7010 ("tty: The big operations rework")
---
drivers/isdn/gigaset/ser-gigaset.c | 6 +++---
1 file changed, 3 insertions(+), 3
n't claim anything like completeness for mine.
> In the mean time you might want to turn your patch into something that
> can actually be applied (with or without my Sign-off or Ack; I don't
> care how it finds its way into the tree). Please add add
> Fixes: 2869b23e4b95 (&q
Am 06.12.2015 um 21:12 schrieb Paul Bolle:
> On zo, 2015-12-06 at 16:29 +0100, Tilman Schmidt wrote:
>> So the solution might be as simple as moving the kfree() call from
>> gigaset_freecshw() to gigaset_device_release(). Something like this:
>>
>> --- a/drivers/isdn/gig
latform_device(dev);
+ struct cardstate *cs = dev_get_drvdata(dev);
- /* adapted from platform_device_release() in
drivers/base/platform.c */
- kfree(dev->platform_data);
- kfree(pdev->resource);
+ if (!cs)
+ return;
+ dev_set_drvdata(dev, NULL);
+ kfree(cs->hw.ser);
+ cs->hw.ser = NULL;
}
/*
(Off the top of my hat, completely untested, don't even know if that
will compile.)
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.
signature.asc
Description: OpenPGP digital signature
le value, but it has never been anything
but 1 in the entire in-tree history of the driver.)
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et des bougies pour nous protéger.
signature.asc
Description: OpenPGP digital signature
is (malloc'ed and) free'd.
I wonder how that will behave if someone attaches two of the devices to
different serial ports. Not likely, but not forbidden either.
Regards,
Tilman
--
Tilman Schmidt E-Mail: til...@imap.cc
Bonn, Germany
Nous, on a des fleurs et
t.
[...]
> The platform_device embedded in struct ser_cardstate hasn't been released when
> you kfree() the memory it's in.
Btw I don't see a timer_list object in struct platform_device either.
Nor in the embedded struct device.
--
Tilman Schmidt
Am 29.11.2015 um 19:22 schrieb Peter Hurley:
> On 11/29/2015 10:30 AM, Tilman Schmidt wrote:
>>
>> Judging from the backtrace below this must be the call
>>
>> kfree(cs->hw.ser);
>>
>> in drivers/isdn/gigaset/ser-gigaset.c line 375.
>
freecshw+0xe1/0x120
There are functions by this name in all three Gigaset hardware dependent
modules (bas_gigaset, ser_gigaset and usb_gigaset), but ...
> [ 413.562723] [] gigaset_freecs+0x2ad/0x600
> [ 413.564240] [] gigaset_tty_close+0x210/0x280
this function only exists in ser_gigaset.
Mention that the ldisc open method must set tty->receive_room, and
that many methods are optional. Add description of receive_buf2 method.
Signed-off-by: Tilman Schmidt
---
Documentation/serial/tty.txt | 60
1 file changed, 39 insertions(+),
Am 14.07.2015 um 01:14 schrieb Peter Hurley:
> On 07/13/2015 06:37 PM, Tilman Schmidt wrote:
>> Commit 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc"),
>> first merged in kernel release 3.10, caused the following regression
>> in the Gigaset M
e value in the ldisc open method.
Fixes: 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc")
Signed-off-by: Tilman Schmidt
---
drivers/isdn/gigaset/ser-gigaset.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/gigaset/ser-gi
The line discipline read and write methods are optional so the dummy
methods in ser_gigaset are unnecessary and can be removed.
Signed-off-by: Tilman Schmidt
---
drivers/isdn/gigaset/ser-gigaset.c | 24
1 files changed, 0 insertions(+), 24 deletions(-)
diff --git a
This series fixes a serious regression in the Gigaset M101 driver
introduced in kernel release 3.10 and removes some unneeded code.
Please also queue up patch 1 of the series for inclusion in the
stable/longterm releases 3.10 and later.
Tilman Schmidt (2):
isdn/gigaset: reset tty->receive_r
ndidate for porting to the kernel
CAPI interface, had anyone bothered. Which reinforces the impression
that no-one is using this anymore.
Note also that the FTP URL mentioned in Documentation/isdn/README.pcbit
doesn't exist anymore.
--
Tilman Schmidt E-Mail: til
Paul E. McKenney schrieb:
On Fri, Feb 22, 2008 at 01:52:53AM +0100, Tilman Schmidt wrote:
So the nf_conntrack BUG is fixed, but the crash (and of course the
swapper "spinlock bad magic" BUG) persists.
Do you have CONFIG_DEBUG_PREEMPT set? That would help find any other
bugs
Am 22.02.2008 01:40 schrieb Tilman Schmidt:
>>
>> [NETFILTER]: nf_conntrack: fix smp_processor_id() in preemptible code
>> warning
>
> Yes, it does; and the system also survives substantially longer.
> (IOW, it hasn't crashed on me so far.)
Which of course it
[NETFILTER]: nf_conntrack: fix smp_processor_id() in preemptible code
> warning
Yes, it does; and the system also survives substantially longer.
(IOW, it hasn't crashed on me so far.)
Thanks,
T.
--
Tilman Schmidt E-Mail: [EMAIL PROTECTED]
Bonn, Germa
; details to the point where we could change the protocol header
> pointers into 32-bit offsets which saves 4 bytes per such pointer per
> protocol header stored in struct sk_buff.
Thanks for the explanation.
--
Tilman SchmidtE-Mail: [EMAIL PROTECTED]
Bonn,
patch Thomas forwarded does fix the
> problem.
Which one would that be? I might try it for comparison.
Thanks,
Tilman
--
Tilman Schmidt E-Mail: [EMAIL PROTECTED]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar
39 matches
Mail list logo
