The man page of ip-macsec and the existance of the tool makes it seem like
the user could just configure static keys once, and be done with it. That is
not the case. Some form or key management must be done in user space.
Add a note about that.
Signed-off-by: Thomas Haller
---
man/man8/ip
# rule add priority 10 realms 1/0xF
# rule add priority 10 realms 0/0xF
# ip rule
10: from all lookup main 15
10: from all lookup main realms 1/15
The previous behavior was there since the beginning.
Signed-off-by: Thomas Haller
---
ip/iprule.c | 2 +-
1 file
e end
of the line should be printed consistently (or not).
Signed-off-by: Thomas Haller
---
ip/iprule.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/iprule.c b/ip/iprule.c
index 2479c3ab..ce6b7cd3 100644
--- a/ip/iprule.c
+++ b/ip/iprule.c
@@ -468,7 +468,7 @@ int print
For all other actions we avoid the trailing space, so do it here
as well.
Signed-off-by: Thomas Haller
---
ip/iprule.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/iprule.c b/ip/iprule.c
index 83aef38e..2479c3ab 100644
--- a/ip/iprule.c
+++ b/ip/iprule.c
@@ -443,7
:
# ip rule add priority 10 protocol 10 type 1
will be printed as
10: from all lookup 1 proto mrt
The only visible effect of the patch is to avoid the double-space and
avoid a trailing space if the action is FR_ACT_TO_TBL.
Signed-off-by: Thomas Haller
---
ip/iprule.c | 84
Signed-off-by: Thomas Haller
---
ip/iprule.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/iprule.c b/ip/iprule.c
index 4e9437de..0bd4c636 100644
--- a/ip/iprule.c
+++ b/ip/iprule.c
@@ -455,7 +455,7 @@ int print_rule(struct nlmsghdr *n, void *arg)
pr
"to_tbl": "blackhole"
},
This is an API break of JSON output as it was added in v4.17.0.
Still change it as the API is relatively new and unstable.
Fixes: 0dd4ccc56c0e ("iprule: add json support")
Signed-off-by: Thomas Haller
---
ip/iprule.c | 2 +-
1 file chan
le"
},
Still, as this is already released API from v4.17.0, stick to it.
Only add a comment for this oddity.
Related: 0dd4ccc56c0e ("iprule: add json support")
Signed-off-by: Thomas Haller
---
If it is still permissible to change the API, I can also send a patch to
rename "
rt, not when it
> does
> not. Let's lower its level.
>
> Signed-off-by: Lubomir Rintel
Hi,
a NetworkManager maintainer here.
Acked-By: Thomas Haller
> ---
> net/ipv6/addrconf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net
Hi David,
On Mon, 2018-09-03 at 20:54 -0600, David Ahern wrote:
> From init_net:
> $ ip monitor all-nsid
I thought the concern of the patch is the overhead of sending one
additional RTM_NEWLINK message. This workaround has likely higher
overhead. More importantly, it's so cumbersome, that I dou
Hi,
On Sat, 2018-09-01 at 17:45 -0600, David Ahern wrote:
> On 9/1/18 3:05 AM, Lorenzo Bianconi wrote:
> >
> > I was thinking about the commit 38e01b30563a and then I realized I
> > misread the code
> > yesterday. The commit 38e01b30563a provides all relevant info but
> > it
> > emits the event
>
Signed-off-by: Thomas Haller
---
Changes in v2:
- "0" is not a valid table ID.
man/man8/ip-route.8.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/man8/ip-route.8.in b/man/man8/ip-route.8.in
index 803de3b9..705ceb20 100644
--- a/man/man8/ip-route.8.in
+++
Signed-off-by: Thomas Haller
---
man/man8/ip-route.8.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/man/man8/ip-route.8.in b/man/man8/ip-route.8.in
index 803de3b9..9717b959 100644
--- a/man/man8/ip-route.8.in
+++ b/man/man8/ip-route.8.in
@@ -322,7 +322,7 @@ normal routing
On Tue, 2016-12-06 at 17:12 -0600, Dan Williams wrote:
>
> > libnl1 rejects the IFLA_INFO_DATA attribute because it expects it
> > to
> > contain a sub-attribute. Since the payload size is zero it doesn't
> > match the policy and parsing fails.
> >
> > There's no problem with libnl3 because its p
On Tue, 2015-11-24 at 12:44 +0100, Phil Sutter wrote:
> On Mon, Nov 23, 2015 at 04:04:50PM -0800, Stephen Hemminger wrote:
> > On Thu, 22 Oct 2015 10:34:28 +0200
> > Thomas Haller wrote:
> >
> > > Kernel allows for zero IPv4 peer addresses (IFA_ADDRESS):
On Thu, 2015-10-22 at 20:56 +0200, Thomas Graf wrote:
> On 10/22/15 at 07:21pm, Hannes Frederic Sowa wrote:
> > Hi Thomas,
> >
> > On Thu, Oct 22, 2015, at 18:45, Thomas Graf wrote:
> > > I understand the race but when does it occur? Whoever creates
> > > the original interface owns it and is resp
On Thu, 2015-10-22 at 16:52 +0200, Nicolas Dichtel wrote:
> Le 21/10/2015 19:12, Hannes Frederic Sowa a écrit :
> > Hello,
> >
> > On Wed, Oct 21, 2015, at 17:56, David Miller wrote:
> > > From: Jiri Benc
> > > Date: Wed, 21 Oct 2015 17:25:02 +0200
> > >
> > > > On Wed, 21 Oct 2015 08:32:14 -070
.
>
> I don't see any way the user space application can prevent this.
> There
> will always be a race between receiving netlink notifications and
> sending config requests.
>
> I guess Thomas Haller can elaborate more as he ran into this.
Jiri,
It's really jus
attribute means that the peer
is 0.0.0.0. See inet_fill_ifaddr(), which does:
if ((ifa->ifa_address &&
nla_put_in_addr(skb, IFA_ADDRESS, ifa->ifa_address)) ||
Signed-off-by: Thomas Haller
---
ip/ipaddress.c | 15 +--
1 file changed, 9 insertions(+), 6 dele
19 matches
Mail list logo
