Re: net: decnet: TODO Items

On Sun, Jul 19, 2020 at 10:06:49AM -0700, Stephen Hemminger wrote: > On Fri, 17 Jul 2020 11:48:16 +0530 > Suraj Upadhyay wrote: > > > Hi Maintainers and Developers, > > I am interested in the DECnet TODO list. > > I just need a quick response whether they are wor

[RESEND] net: decnet: TODO Items

isted works or not. Thanks, Suraj Upadhyay. signature.asc Description: PGP signature

net: decnet: TODO Items

isted works or not. Thanks, Suraj Upadhyay. signature.asc Description: PGP signature

[PATCH] net: decnet: af_decnet: Simplify goto loop.

Replace goto loop with while loop. Signed-off-by: Suraj Upadhyay --- net/decnet/af_decnet.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c index 0a46ea3bddd5..7d7ae2dd69b8 100644 --- a/net/decnet/af_decnet.c

[PATCH] staging: qlge/qlge_main.c: Replace depracated MSI API.

Replace the depracated MSI API pci_enable_msi() with pci_alloc_irq_vectors(). Signed-off-by: Suraj Upadhyay --- drivers/staging/qlge/qlge_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c index

Re: [PATCH v2] ipvs: clean code for ip_vs_sync.c

for (i=0; i + for (i = 0; i < nr_conns; i++) { > union ip_vs_sync_conn *s; > unsigned int size; > int retc; > @@ -1444,7 +1444,7 @@ static int bind_mcastif_addr(struct socket *sock, > struct net_device

Re: [PATCH 6/6] staging: qlge: qlge_ethtool: Remove one byte memset.

On Tue, Jul 14, 2020 at 12:22:05PM -0700, Joe Perches wrote: > On Wed, 2020-07-15 at 00:36 +0530, Suraj Upadhyay wrote: > > On Tue, Jul 14, 2020 at 11:57:23AM -0700, Joe Perches wrote: > > > On Mon, 2020-07-13 at 17:17 +0300, Dan Carpenter wrote: > > > > On Mon, Ju

[PATCH 4/4] ixgbe/ixgbe_ethtool.c: Remove unnecessary usages of memset.

Replace memsets of 1 byte with simple assignment. Issue found with checkpatch.pl Signed-off-by: Suraj Upadhyay --- drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers

[PATCH 2/4] e1000e/ethtool.c : Remove unnecessary usages of memset.

Replace memsets of 1 byte with simple assignments. Issue found with checkpatch.pl Signed-off-by: Suraj Upadhyay --- drivers/net/ethernet/intel/e1000e/ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/ethtool.c b/drivers/net

[PATCH 3/4] igb/igb_ethtool.c : Remove unnecessary usages of memset.

Replace memsets of 1 byte with simple assignment. Issue found with checkpatch.pl Signed-off-by: Suraj Upadhyay --- drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net

[PATCH 1/4] e1000/e1000_ethtool.c: Remove unnecessary usages of memset

Replace memsets of 1 byte with simple assignments. Issue reported by checkpatch.pl. Signed-off-by: Suraj Upadhyay --- drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000/e1000_ethtool.c b

Re: [PATCH 6/6] staging: qlge: qlge_ethtool: Remove one byte memset.

On Tue, Jul 14, 2020 at 11:57:23AM -0700, Joe Perches wrote: > On Mon, 2020-07-13 at 17:17 +0300, Dan Carpenter wrote: > > On Mon, Jul 13, 2020 at 05:52:22PM +0530, Suraj Upadhyay wrote: > > > Use direct assignment instead of using memset with just one byte as an > > >

Re: [PATCH] decnet: dn_dev: Remove an unnecessary label.

On Tue, Jul 14, 2020 at 04:16:15PM +0200, Julia Lawall wrote: > > > On Tue, 14 Jul 2020, Suraj Upadhyay wrote: > > > Remove the unnecessary label from dn_dev_ioctl() and make its error > > handling simpler to read. > > > > Signed-off-by: Suraj Upadhyay

[PATCH v2] decnet: dn_dev: Remove an unnecessary label.

Remove the unnecessary label from dn_dev_ioctl() and make its error handling simpler to read. Signed-off-by: Suraj Upadhyay --- Changes: v2: Fixed indentation of break statement. On Julia's Advise. net/decnet/dn_dev.c | 8 +++- 1 file changed, 3 insertions(+), 5 dele

[PATCH] decnet: dn_dev: Remove an unnecessary label.

Remove the unnecessary label from dn_dev_ioctl() and make its error handling simpler to read. Signed-off-by: Suraj Upadhyay --- net/decnet/dn_dev.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/net/decnet/dn_dev.c b/net/decnet/dn_dev.c index 65abcf1b3210

[PATCH 6/6] staging: qlge: qlge_ethtool: Remove one byte memset.

Use direct assignment instead of using memset with just one byte as an argument. Issue found by checkpatch.pl. Signed-off-by: Suraj Upadhyay --- Hii Maintainers, Please correct me if I am wrong here. --- drivers/staging/qlge/qlge_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 5/6] staging: qlge: qlge_mpi: Simplify while statements.

Simplify while loops into more readable and simple for loops. Signed-off-by: Suraj Upadhyay --- drivers/staging/qlge/qlge_mpi.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/staging/qlge/qlge_mpi.c b/drivers/staging/qlge

[PATCH 4/6] staging: qlge: qlge_main: Simplify while statements.

Simplify while loops into more readable and simple for loops. Signed-off-by: Suraj Upadhyay --- drivers/staging/qlge/qlge_main.c | 49 ++-- 1 file changed, 22 insertions(+), 27 deletions(-) diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge

[PATCH 3/6] staging: qlge: qlge_dbg: Simplify while statements

Simplify while loops into more readable and simple for loops. Signed-off-by: Suraj Upadhyay --- drivers/staging/qlge/qlge_dbg.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c index 32fbd30a6a2e

[PATCH 1/6] staging: qlge: qlge.h: Function definition arguments should have names.

Issue found with checkpatch.pl Signed-off-by: Suraj Upadhyay --- drivers/staging/qlge/qlge.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h index 05e4f47442a3..48bc494028ce 100644 --- a/drivers/staging/qlge

[PATCH 2/6] staging: qlge: qlge.h: Insert line after declaration.

Issue found by checkpatch.pl Signed-off-by: Suraj Upadhyay --- drivers/staging/qlge/qlge.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h index 48bc494028ce..483ce04789ed 100644 --- a/drivers/staging/qlge/qlge.h +++ b/drivers

[PATCH 0/6] staging: qlge: General cleanup and refactor.

Hii, This patchest aims to remove several of the checkpatch.pl warnings and refactor some ugly while loops into for loops for better readability. Some of the issues are found with checkpatch and others were listed in qlge/TODO. Thanks, Suraj Upadhyay (6): staging: qlge: qlge.h

Re: [PATCH] staging: qlge: Remove pci-dma-compat wrapper APIs.

On Mon, Jul 13, 2020 at 01:59:59PM +0900, Benjamin Poirier wrote: > On 2020-07-11 18:16 +0530, Suraj Upadhyay wrote: > > The legacy API wrappers in include/linux/pci-dma-compat.h > > should go away as it creates unnecessary midlayering > > for include/linux/dma-mapping.h

[PATCH] staging: qlge: Remove pci-dma-compat wrapper APIs.

- pci_set_consistent_dma_mask(E1, E2) + dma_set_coherent_mask(&E1->dev, E2) @@ expression E1, E2; @@ - pci_set_dma_mask(E1, E2) + dma_set_mask(&E1->dev, E2) Signed-off-by: Suraj Upadhyay --- This change is proposed by Christoph Hellwig in the post https://ma

[PATCH] staging: qlge: qlge_ethtool.c: Proper indentation.

Remove extra indentations from if-statement. Signed-off-by: Suraj Upadhyay --- drivers/staging/qlge/qlge_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/qlge/qlge_ethtool.c b/drivers/staging/qlge/qlge_ethtool.c index 949abd53a7a9..16fcdefa9687