The sizeof(u32) is hardcoded. It's better to use the config value in
regmap.
It increases the size of target object, but it's flexible when new mcp chip
need other val_bytes.
Signed-off-by: Su Yanjun
---
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 9 ++---
1 file changed, 6
在 2021/1/22 下午3:22, Marc Kleine-Budde 写道:
On 1/22/21 7:22 AM, Su Yanjun wrote:
When i debug mcp2518fd, some method to track registers is
needed. This easy debug interface will be ok.
NACK
As the driver uses regmap, everything should be there already.
To read use:
| cat /sys/kernel/debug
在 2021/1/22 下午3:26, Marc Kleine-Budde 写道:
On 1/22/21 4:02 AM, Su Yanjun wrote:
Recently i use mcp2518fd on 4.x kernel which multiple write is not
backported, regmap_raw_write will cause old kernel crash because the
tx buffer in driver is smaller then 2K. Use regmap_bulk_write instead
for
When i debug mcp2518fd, some method to track registers is
needed. This easy debug interface will be ok.
For example,
read a register at 0xe00:
echo 0xe00 > can_get_reg
cat can_get_reg
write a register at 0xe00:
echo 0xe00,0x60 > can_set_reg
Signed-off-by: Su Yanjun
---
.../net/c
The sizeof(u32) is hardcoded. It's better to use the config value in
regmap.
It increases the size of target object, but it's flexible when new mcp chip
need other val_bytes.
Signed-off-by: Su Yanjun
---
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 9 ++---
1 file changed, 6
Recently i use mcp2518fd on 4.x kernel which multiple write is not
backported, regmap_raw_write will cause old kernel crash because the
tx buffer in driver is smaller then 2K. Use regmap_bulk_write instead
for compatibility.
Signed-off-by: Su Yanjun
---
drivers/net/can/spi/mcp251xfd/mcp251xfd
The sizeof(u32) is hardcoded. IMO it's better to use the config value in
regmap.
Thanks
在 2021/1/21 下午5:21, Marc Kleine-Budde 写道:
On Thu, Jan 21, 2021 at 05:10:05PM +0800, Su Yanjun wrote:
Please describe why you change this.
No functional effect.
Not quite:
scripts/bloat-o-meter
No functional effect.
Signed-off-by: Su Yanjun
---
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
index
No functional effect.
Signed-off-by: Su Yanjun
---
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
index
list_is_singular() can tell whether a list has just one entry.
So we use list_is_singular（) here.
Signed-off-by: Hui Su
---
net/atm/br2684.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/atm/br2684.c b/net/atm/br2684.c
index 3e17a5ecaa94..398f7e086cf4 100644
--- a
to fix
this problem.
And what you say is related to the lo interface. I'm not sure whether
the lo interface needs a ll adreess.
IMO the ll address is used to get l2 address by sending ND ns. The lo is
very special.
Thanks
Su
"2.1. Addressing Model"
...
"All inte
noderef] *nlsk
[...]
So introduce a new wrapper function of nlmsg_unicast to handle type
conversions.
This patch also fixes a direct access of a rcu protected socket.
Fixes: be33690d8fcf("[XFRM]: Fix aevent related crash")
Signed-off-by: Su Yanjun
---
Changes from v2:
- add 'F
On 2019/3/5 15:31, Steffen Klassert wrote:
On Tue, Mar 05, 2019 at 03:08:49PM +0800, Su Yanjun
wrote:
On 2019/3/5 14:49, Herbert Xu wrote:
On Sun, Mar 03, 2019 at 10:47:39PM -0500, Su Yanjun wrote:
When i review xfrm_user.c code, i found some potentical bug in it.
In xfrm_user_rcvmsg if
noderef] *nlsk
[...]
So introduce a new wrapper function of nlmsg_unicast to handle type
conversions.
No functional change.
Signed-off-by: Su Yanjun
---
Changes from v1:
- fix spelling mistakes and the sparse tool' warnings
include/net/netns/xfrm.h | 2 +-
For rcu protected pointers, we'd bettter add '__rcu' for them.
No functional change.
Signed-off-by: Su Yanjun
---
include/net/netns/xfrm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/netns/xfrm.h b/include/net/netns/xfrm.h
index 59f45b1..d2a36
When i review xfrm_user.c code, i found some potentical bug in it.
In xfrm_user_rcvmsg if type parameter from user space is set to
XFRM_MSG_MAX or XFRM_MSG_NEWSADINFO or XFRM_MSG_NEWSPDINFO. It will cause
xfrm_user_rcv_msg referring to null entry in xfrm_dispatch array.
Signed-off-by: Su
On 2019/3/1 16:43, Sergei Shtylyov wrote:
Hello!
On 01.03.2019 8:56, Su Yanjun wrote:
From: Su Yanjun
Because nf_conntrack_helper_unregister maybe used in an unloadable
module,
it uses 'synchronize_rcu' which may cause kernel panic.
According to the artical:
Article?
From: Su Yanjun
Because nf_conntrack_helper_unregister maybe used in an unloadable module,
it uses 'synchronize_rcu' which may cause kernel panic.
According to the artical:
RCU and Unloadable Modules
https://lwn.net/Articles/217484/
When we have a heavy rcu callback load, then s
ocess in ipcomp virtual
tunnel.
Signed-off-by: Su Yanjun
---
Based on Linus' master branch.
Changes from v1:
- use a separate handler for ipip packet processing in ipcomp virtual tunnel
net/ipv4/ip_vti.c | 50 ++
1 file changed, 50 insertio
On 1/4/2019 3:43 PM, Steffen Klassert wrote:
On Thu, Jan 03, 2019 at 07:48:41AM -0500, Su Yanjun wrote:
Recently we run a network test over ipcomp virtual tunnel.We find that
if a ipv4 packet needs fragment, then the peer can't receive
it.
We deep into the code and find that when packet
ocess in ipcomp virtual
tunnel.
Signed-off-by: Su Yanjun
---
net/ipv4/ip_vti.c | 25 -
1 file changed, 24 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/ip_vti.c b/net/ipv4/ip_vti.c
index de31b30..63de2f6 100644
--- a/net/ipv4/ip_vti.c
+++ b/net/ipv4/ip_vti.c
@@ -6
Signed-off-by: Su Yanjun
---
net/ipv6/reassembly.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c
index a5bb59e..36a3d8d 100644
--- a/net/ipv6/reassembly.c
+++ b/net/ipv6/reassembly.c
@@ -210,7 +210,7 @@ static int ip6_frag_queue
d=0
When 8139cp starts to work then cp_tx will check
num_queued mismatchs the complete_bytes.
The patch will check IntrMask before check IntrStatus in cp_interrupt.
When 8139cp interrupt is disabled, just return.
Signed-off-by: Su Yanjun
---
drivers/net/ethernet/realtek/8139cp.c | 5 +
1 fil
From: "Su, Xuemin"
There is a corner case in which udp packets belonging to a same
flow are hashed to different socket when hslot->count changes from 10
to 11:
1) When hslot->count <= 10, __udp_lib_lookup() searches udp_table->hash,
and always passes 'daddr'
From: "Su, Xuemin"
There is a corner case in which udp packets belonging to a same
flow are hashed to different socket when hslot->count changes from 10
to 11:
1) When hslot->count <= 10, __udp_lib_lookup() searches udp_table->hash,
and always passes 'daddr'
On Wed 2016-06-08 at 08:43 -0700, Eric Dumazet wrote:
> I am not convinced this is the right way to fix the issue.
>
> Fact that you did not change udp4_lib_lookup2() is telling me something.
>
>
> 1) If host has 100 different IP, and 10 sockets bound to 0.0.0.0:53
> 2) If we receive datagrams
From: "Su, Xuemin"
There is a corner case in which udp packets belonging to a same
flow are hashed to different socket when hslot->count changes from 10
to 11:
1) When hslot->count <= 10, __udp_lib_lookup() searches udp_table->hash,
and always passes 'daddr'
From: "Su, Xuemin"
There is a corner case in which udp packets belonging to a same
flow are hashed to different socket when hslot->count changes from 10
to 11:
1) When hslot->count <= 10, __udp_lib_lookup() searches udp_table->hash,
and always passes 'daddr'
During hwsim_init_netlink(), we should call genl_unregister_family()
if failed on netlink_register_notifier() since the genetlink is
already registered.
Signed-off-by: Su Kang Yin
---
drivers/net/wireless/mac80211_hwsim.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a
During hwsim_init_netlink(), we should call genl_unregister_family()
if failed on netlink_register_notifier() since the genetlink is
already registered.
Signed-off-by: Su Kang Yin
---
drivers/net/wireless/mac80211_hwsim.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a
30 matches
Mail list logo
