Re: linux-next: manual merge of the jc_docs tree with the vfs and net-next trees

2020-05-18 Thread Stephen Kitt
tree and commit: 2f4c33063ad7 ("docs: sysctl/kernel: document ngroups_max") from the jc_docs tree. Hmm...that's somewhat messy. I somehow managed to miss the change to kernel/sysctl.c that doesn't have much to do with documentation. Stephen (Kitt): I've reverted

Re: [PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-09 Thread Stephen Kitt
On Sat, 9 May 2020 21:05:48 +0200, Stephen Kitt wrote: > On Sat, 9 May 2020 10:59:14 -0700, Jakub Kicinski wrote: > > What if we went back to your original proposal of an empty struct but > > added in an extern in front? That way we should get linker error on > > pointer re

Re: [PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-09 Thread Stephen Kitt
On Sat, 9 May 2020 10:59:14 -0700, Jakub Kicinski wrote: > On Sat, 9 May 2020 10:13:22 +0200 Stephen Kitt wrote: > > On Fri, 8 May 2020 20:50:25 -0700, Jakub Kicinski > > wrote: > > > On Fri, 8 May 2020 14:04:57 +0200 Stephen Kitt wrote: > > > > C

Re: [PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-09 Thread Stephen Kitt
Hi, Thanks for taking the time to review my patch. On Fri, 8 May 2020 20:50:25 -0700, Jakub Kicinski wrote: > On Fri, 8 May 2020 14:04:57 +0200 Stephen Kitt wrote: > > Commit c7228317441f ("net: Use a more standard macro for > > INET_ADDR_COOKIE") added a __deprecated

[PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-08 Thread Stephen Kitt
' attribute warnings entirely and for good"), __deprecated doesn't do anything and should be avoided. This patch changes INET_ADDR_COOKIE to declare a dummy struct so that any subsequent use of the cookie's name will in all likelihood break the build. It also removes the __depreca

Re: [PATCH] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-08 Thread Stephen Kitt
On Tue, 28 Apr 2020 14:07:46 -0700 (PDT), David Miller wrote: > From: Stephen Kitt > Date: Tue, 28 Apr 2020 09:52:31 +0200 > > > This patch changes INET_ADDR_COOKIE to declare a dummy typedef (so it > > makes checkpatch.pl complain, sorry...) > > This is trading

[PATCH] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-04-28 Thread Stephen Kitt
ood break the build. It also removes the __deprecated marker. Signed-off-by: Stephen Kitt --- include/net/inet_hashtables.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/net/inet_hashtables.h b/include/net/inet_hashtables.h index ad64ba6a057f..8a1391d82406 100644 -