Re: [PATCH v3 5/7] venus: Add debugfs interface to set firmware log level

2020-06-11 Thread Stanimir Varbanov
Hi Greg, Thanks for the comments! On 6/9/20 2:12 PM, Greg Kroah-Hartman wrote: > On Tue, Jun 09, 2020 at 01:46:02PM +0300, Stanimir Varbanov wrote: >> +int venus_dbgfs_init(struct venus_core *core) >> +{ >> +core->root = debugfs_create_dir("venus", NU

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-11 Thread Stanimir Varbanov
On 6/11/20 1:52 PM, Daniel Thompson wrote: > On Wed, Jun 10, 2020 at 11:42:43PM -0700, Joe Perches wrote: >> On Thu, 2020-06-11 at 08:26 +0200, Greg Kroah-Hartman wrote: >>> On Wed, Jun 10, 2020 at 01:23:56PM -0700, Joe Perches wrote: On Wed, 2020-06-10 at 12:49 -0700, Joe Perches wrote: >>>

Re: [PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-10 Thread Stanimir Varbanov
On 6/9/20 2:14 PM, Greg Kroah-Hartman wrote: > On Tue, Jun 09, 2020 at 01:46:03PM +0300, Stanimir Varbanov wrote: >> Here we introduce few debug macros with levels (low, medium and >> high) and debug macro for firmware. Enabling the particular level >> will be done by dyna

Re: [PATCH v3 1/7] Documentation: dynamic-debug: Add description of level bitmask

2020-06-10 Thread Stanimir Varbanov
Hi Greg, On 6/9/20 2:16 PM, Greg Kroah-Hartman wrote: > On Tue, Jun 09, 2020 at 01:45:58PM +0300, Stanimir Varbanov wrote: >> This adds description of the level bitmask feature. >> >> Cc: Jonathan Corbet (maintainer:DOCUMENTATION) >> >> Signed-off-by: Stanimir V

[PATCH v3 1/7] Documentation: dynamic-debug: Add description of level bitmask

2020-06-09 Thread Stanimir Varbanov
This adds description of the level bitmask feature. Cc: Jonathan Corbet (maintainer:DOCUMENTATION) Signed-off-by: Stanimir Varbanov --- Documentation/admin-guide/dynamic-debug-howto.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/admin-guide/dynamic-debug

[PATCH v3 0/7] Venus dynamic debug

2020-06-09 Thread Stanimir Varbanov
added change in the dynamic_debug and in documentation - added respective pr_debug_level and dev_dbg_level regards, Stan [1] https://lkml.org/lkml/2020/5/21/668 Stanimir Varbanov (7): Documentation: dynamic-debug: Add description of level bitmask dynamic_debug: Group debug messages by

[PATCH v3 4/7] printk: Add pr_debug_level macro over dynamic one

2020-06-09 Thread Stanimir Varbanov
Introduce new pr_debug_level macro over dynamic_debug level one to allow dynamic debugging to show only important messages. Signed-off-by: Stanimir Varbanov --- include/linux/printk.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/linux/printk.h b/include/linux/printk.h index

[PATCH v3 2/7] dynamic_debug: Group debug messages by level bitmask

2020-06-09 Thread Stanimir Varbanov
tedt Cc: Greg Kroah-Hartman Suggested-by: Joe Perches Signed-off-by: Stanimir Varbanov --- fs/btrfs/ctree.h | 12 +--- include/linux/acpi.h | 3 +- include/linux/dev_printk.h| 3 +- include/linux/dynamic_debug.h | 55 --- include/linux/

[PATCH v3 6/7] venus: Make debug infrastructure more flexible

2020-06-09 Thread Stanimir Varbanov
debug/control If you want to enable all levels: echo 'module venus_dec level 0x07 +p' > debugfs/dynamic_debug/control All the features which dynamic debugging provide are preserved. And finaly all dev_dbg are translated to VDBGX with appropriate debug levels. Signed-off-by: Stani

[PATCH v3 7/7] venus: Add a debugfs file for SSR trigger

2020-06-09 Thread Stanimir Varbanov
The SSR (SubSystem Restart) is used to simulate an error on FW side of Venus. We support following type of triggers - fatal error, div by zero and watchdog IRQ. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/dbgfs.c | 31 +++ 1 file changed, 31

[PATCH v3 5/7] venus: Add debugfs interface to set firmware log level

2020-06-09 Thread Stanimir Varbanov
This will be useful when debugging specific issues related to firmware HFI interface. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/Makefile| 2 +- drivers/media/platform/qcom/venus/core.c | 5 drivers/media/platform/qcom/venus/core.h | 3

[PATCH v3 3/7] dev_printk: Add dev_dbg_level macro over dynamic one

2020-06-09 Thread Stanimir Varbanov
Add dev_dbg_level macro wrapper over dynamic debug one for dev_dbg variants. Signed-off-by: Stanimir Varbanov --- include/linux/dev_printk.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/dev_printk.h b/include/linux/dev_printk.h index 7b50551833e1..d639dc60d84d