Re: [PATCH] Staging: irda: Prefer 'unsigned int' to bare use of 'unsigned'

2018-01-05 Thread Shyam Saini
Hi, Did you read this? https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/irda/TODO Thanks, Shyam > This patch fixes the following checkpatch.pl issue at multiple lines: > > WARNING: Prefer 'unsigned int' to bare use of 'unsigned' > > Signed-off-by: Sumit P

Re: [PATCH] qed: Replace memset with eth_zero_addr

2017-01-16 Thread Shyam Saini
On Mon, Jan 16, 2017 at 02:58:19PM -0500, David Miller wrote: > From: Shyam Saini > Date: Tue, 17 Jan 2017 00:21:38 +0530 > > > Use eth_zero_addr to assign zero address to the given address array > > instead of memset when the second argument in memset is address > >

[PATCH] qed: Replace memset with eth_zero_addr

2017-01-16 Thread Shyam Saini
Use eth_zero_addr to assign zero address to the given address array instead of memset when the second argument in memset is address of zero. Also, it makes the code clearer Signed-off-by: Shyam Saini --- drivers/net/ethernet/qlogic/qed/qed_l2.c| 2 +- drivers/net/ethernet/qlogic/qed

[PATCH] qed: Replace memset with eth_zero_addr

2017-01-16 Thread Shyam Saini
Use eth_zero_addr to assign zero address to the given address array instead of memset when the second argument in memset is address of zero. Also, it makes the code clearer Signed-off-by: Shyam Saini --- drivers/net/ethernet/qlogic/qed/qed_l2.c| 2 +- drivers/net/ethernet/qlogic/qed

[PATCH] qed: Replace memset with eth_zero_addr

2017-01-16 Thread Shyam Saini
Use eth_zero_addr to assign zero address to the given address array instead of memset when the second argument in memset is address of zero. Also, it makes the code clearer Signed-off-by: Shyam Saini --- drivers/net/ethernet/qlogic/qed/qed_l2.c| 2 +- drivers/net/ethernet/qlogic/qed

Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr

2017-01-16 Thread Shyam Saini
On Mon, Jan 16, 2017 at 11:46:06AM -0500, David Miller wrote: > From: Shyam Saini > Date: Mon, 16 Jan 2017 14:54:35 +0530 > > > On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote: > >> > >> Please do not ever submit two patches which have the same

Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr

2017-01-16 Thread Shyam Saini
On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote: > > Please do not ever submit two patches which have the same exact commit > header line, as these two patches do. > > When someone looks into the shortlog of GIT history all they will see > is "qed: Replace memset with eth_zero_addr"

[PATCH] sfc: Replace memset with eth_zero_addr

2017-01-15 Thread Shyam Saini
Use eth_zero_addr to assign zero address to the given address array instead of memset when the second argument in memset is address of zero which makes the code clearer and also add header file linux/etherdevice.h Signed-off-by: Shyam Saini --- drivers/net/ethernet/sfc/ef10_sriov.c | 3 ++- 1

[PATCH 1/2] qed: Replace memset with eth_zero_addr

2017-01-15 Thread Shyam Saini
Use eth_zero_addr to assign zero address to the given address array instead of memset when the second argument in memset is address of zero. Also, it makes the code clearer Signed-off-by: Shyam Saini --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 2/2] qed: Replace memset with eth_zero_addr

2017-01-15 Thread Shyam Saini
Use eth_zero_addr to assign zero address to the given address array instead of memset when the second argument in memset is address of zero. Also, it makes the code clearer Signed-off-by: Shyam Saini --- drivers/net/ethernet/qlogic/qed/qed_sriov.c | 7 +++ 1 file changed, 3 insertions(+), 4

[PATCH] cxgb4: Remove redundant memset before memcpy

2017-01-13 Thread Shyam Saini
de of the loop. Signed-off-by: Shyam Saini --- drivers/net/ethernet/chelsio/cxgb4/sched.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/sched.c b/drivers/net/ethernet/chelsio/cxgb4/sched.c index cbd68a8..c902635 100644 --- a/drivers/net/ethernet/chelsio

[PATCH] cxgb4: Remove redundant memset before memcpy

2017-01-13 Thread Shyam Saini
The region set by the call to memset, immediately overwritten by the subsequent call to memcpy and thus makes the memset redundant Signed-off-by: Shyam Saini --- drivers/net/ethernet/chelsio/cxgb4/sched.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4

[PATCH] net: Use kmemdup instead of kmalloc and memcpy

2016-12-23 Thread Shyam Saini
when some other buffer is immediately copied into allocated region. Replace calls to kmalloc followed by a memcpy with a direct call to kmemdup. Signed-off-by: Shyam Saini --- drivers/net/virtio_net.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/virtio_net.c

Re: How to submit potential patch in linux kernel

2016-09-29 Thread Shyam Saini
On Thu, 2016-09-29 at 13:15 +0300, Daniel Baluta wrote: > Hi Shyam, > > On Thu, Sep 29, 2016 at 1:02 PM, Andrew Lunn wrote: > > > > On Thu, Sep 29, 2016 at 04:32:29AM +0530, Shyam Saini wrote: > > > > > > Hi everyone, > > > > > > I&#x

How to submit potential patch in linux kernel

2016-09-28 Thread Shyam Saini
Hi everyone, I'm Shyam, final year undergraduate student. I wanted to know how one can submit potential linux kernel patch in networking subsystem. Thanks, Shyam