RE: [Intel-wired-lan] [PATCH V2 net] ice: Re-organizes reqstd/avail {R, T}XQ check/code for efficiency+readability

2021-04-20 Thread Salil Mehta
> From: Brelinski, TonyX [mailto:tonyx.brelin...@intel.com] > Sent: Tuesday, April 20, 2021 9:26 PM > > > From: Intel-wired-lan On Behalf Of > > Salil Mehta > > Sent: Tuesday, April 13, 2021 3:45 PM > > To: da...@davemloft.net; k...@kernel.org >

[PATCH V2 net] ice: Re-organizes reqstd/avail {R,T}XQ check/code for efficiency+readability

2021-04-13 Thread Salil Mehta
t;ice: Implement ethtool ops for channels") Cc: intel-wired-...@lists.osuosl.org Cc: Jeff Kirsher Signed-off-by: Salil Mehta -- Change V1->V2 (*) Fixed the comments from Anthony Nguyen(Intel) Link: https://lkml.org/lkml/2021/4/12/1997 --- drivers/net/ethernet/intel/ice/ice_lib.c | 14

RE: [PATCH net] ice: Re-organizes reqstd/avail {R,T}XQ check/code for efficiency+readability

2021-04-13 Thread Salil Mehta
Hi Anthony, Thanks for reviewing! > From: Nguyen, Anthony L [mailto:anthony.l.ngu...@intel.com] > Sent: Monday, April 12, 2021 11:41 PM > To: da...@davemloft.net; k...@kernel.org; Salil Mehta > Cc: netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Brandeburg, Jesse > ; linux..

[PATCH net] ice: Re-organizes reqstd/avail {R,T}XQ check/code for efficiency+readability

2021-04-10 Thread Salil Mehta
ement ethtool ops for channels") Signed-off-by: Salil Mehta --- drivers/net/ethernet/intel/ice/ice_lib.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c index d13c7fc8fb0a..16

[PATCH net] net: hns3: Trivial spell fix in hns3 driver

2021-04-09 Thread Salil Mehta
Some trivial spelling mistakes which caught my eye during the review of the code. Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 2 +- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions

RE: [Linuxarm] Re: [PATCH net] net: hns3: Limiting the scope of vector_ring_chain variable

2021-04-06 Thread Salil Mehta
anks Salil > From: patchwork-bot+netdev...@kernel.org > [mailto:patchwork-bot+netdev...@kernel.org] > Sent: Monday, April 5, 2021 11:10 PM > To: Salil Mehta > Cc: da...@davemloft.net; k...@kernel.org; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; Linuxarm ; > linux...

[PATCH net] net: hns3: Limiting the scope of vector_ring_chain variable

2021-04-05 Thread Salil Mehta
Limiting the scope of the variable vector_ring_chain to the block where it is used. Fixes: 424eb834a9be ("net: hns3: Unified HNS3 {VF|PF} Ethernet Driver for hip08 SoC") Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 3 ++- 1 file changed, 2 insert

[PATCH V2 net 2/2] net: hns3: Remove un-necessary 'else-if' in the hclge_reset_event()

2021-04-05 Thread Salil Mehta
Code to defer the reset(which caps the frequency of the reset) schedules the timer and returns. Hence, following 'else-if' looks un-necessary. Fixes: 9de0b86f6444 ("net: hns3: Prevent to request reset frequently") Signed-off-by: Salil Mehta --- drivers/net/ethernet/h

[PATCH V2 net 0/2] Misc. fixes for hns3 driver

2021-04-05 Thread Salil Mehta
Fixes for the miscellaneous problems found during the review of the code. Change Summary: Patch 1/2, Change V1->V2: [1] Fixed comments from Leon Romanovsky Link: https://lkml.org/lkml/2021/4/4/14 Patch 2/2, Change V1->V2: None Salil Mehta (2): net: hns3: Remove the lef

[PATCH V2 net 1/2] net: hns3: Remove the left over redundant check & assignment

2021-04-05 Thread Salil Mehta
This removes the left over check and assignment which is no longer used anywhere in the function and should have been removed as part of the below mentioned patch. Fixes: 012fcb52f67c ("net: hns3: activate reset timer when calling reset_event") Signed-off-by: Salil Mehta -- V1->

RE: [PATCH net 1/2] net: hns3: Remove the left over redundant check & assignment

2021-04-05 Thread Salil Mehta
> From: Leon Romanovsky [mailto:l...@kernel.org] > Sent: Monday, April 5, 2021 1:43 PM > To: Salil Mehta > Cc: da...@davemloft.net; k...@kernel.org; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; Linuxarm ; > linux...@openeuler.org > Subject: Re: [PATCH net 1/2]

RE: [PATCH net 1/2] net: hns3: Remove the left over redundant check & assignment

2021-04-05 Thread Salil Mehta
Hi Leon, Thanks for the review. > From: Leon Romanovsky [mailto:l...@kernel.org] > Sent: Sunday, April 4, 2021 7:26 AM > To: Salil Mehta > Cc: da...@davemloft.net; k...@kernel.org; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; Linuxarm ; > linux...@openeuler.org >

[PATCH net 2/2] net: hns3: Remove un-necessary 'else-if' in the hclge_reset_event()

2021-04-02 Thread Salil Mehta
Code to defer the reset(which caps the frequency of the reset) schedules the timer and returns. Hence, following 'else-if' looks un-necessary. Fixes: 9de0b86f6444 ("net: hns3: Prevent to request reset frequently") Signed-off-by: Salil Mehta --- drivers/net/ethernet/h

[PATCH net 1/2] net: hns3: Remove the left over redundant check & assignment

2021-04-02 Thread Salil Mehta
This removes the left over check and assignment which is no longer used anywhere in the function and should have been removed as part of the below mentioned patch. Fixes: 012fcb52f67c ("net: hns3: activate reset timer when calling reset_event") Signed-off-by: Salil Mehta --- d

[PATCH net 0/2] Misc. fixes for hns3 driver

2021-04-02 Thread Salil Mehta
Fixes for the miscellaneous problems found during the review of the code. Salil Mehta (2): net: hns3: Remove the left over redundant check & assignment net: hns3: Remove un-necessary 'else-if' in the hclge_reset_event() drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

RE: [PATCH V2 net-next 0/2] net: hns3: adds two VLAN feature

2020-05-28 Thread Salil Mehta
Hi Jakub/David, > From: Jakub Kicinski [mailto:k...@kernel.org] > Sent: Wednesday, May 27, 2020 8:31 PM > To: tanhuazhong > Cc: David Miller ; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; Salil Mehta ; > Zhuangyuzeng (Yisen) ; Linuxarm > Subject: Re: [PATCH V2 ne

RE: Question about setting speed and duplex failed after auto-negotiation disabled on marvell phy

2019-03-01 Thread Salil Mehta
(+) LinuxArm > From: Michal Vokáč [mailto:michal.vo...@ysoft.com] > Sent: Friday, March 1, 2019 12:58 PM > To: liweihang > Cc: netdev@vger.kernel.org; da...@davemloft.net; linyunsheng > ; Zhuangyuzeng (Yisen) > ; Salil Mehta ; lipeng > (Y) ; shenjian (K) > Subject: Re

RE: [PATCH] net: hns: Fix object reference leaks in hns_dsaf_roce_reset()

2019-02-18 Thread Salil Mehta
> From: John Garry > Sent: Friday, February 15, 2019 12:00 PM > > On 15/02/2019 11:25, Salil Mehta wrote: > >> From: John Garry > >> Sent: Friday, February 15, 2019 10:52 AM > >> > >> On 14/02/2019 06:41, Huang Zijiang wrote: > >>> The

[PATCH net] net: hns: Fixes the missing put_device in positive leg for roce reset

2019-02-18 Thread Salil Mehta
This patch fixes the missing device reference release-after-use in the positive leg of the roce reset API of the HNS DSAF. Fixes: c969c6e7ab8c ("net: hns: Fix object reference leaks in hns_dsaf_roce_reset()") Reported-by: John Garry Signed-off-by: Salil Mehta --- drivers/ne

RE: [PATCH] net: hns: Fix object reference leaks in hns_dsaf_roce_reset()

2019-02-15 Thread Salil Mehta
> From: John Garry > Sent: Friday, February 15, 2019 10:52 AM > > On 14/02/2019 06:41, Huang Zijiang wrote: > > The of_find_device_by_node() takes a reference to the underlying device > > structure, we should release that reference. > > of_find_device_by_node() is not called for every path, so is

RE: [PATCH net-next] net: hns3: Fix potential NULL dereference on allocation error

2019-01-28 Thread Salil Mehta
> From: yuehaibing > Sent: Friday, January 25, 2019 3:14 AM > To: da...@davemloft.net; Zhuangyuzeng (Yisen) ; > Salil Mehta ; lipeng (Y) > Cc: linux-ker...@vger.kernel.org; netdev@vger.kernel.org; yuehaibing > > Subject: [PATCH net-next] net: hns3: Fix potential NULL derefe

RE: hns: question regarding ae_node device node refcounting

2019-01-11 Thread Salil Mehta
Hi Alexey, > From: Alexey Khoroshilov [mailto:khoroshi...@ispras.ru] > Sent: Saturday, December 22, 2018 9:55 PM > To: Zhuangyuzeng (Yisen) ; Salil Mehta > ; lipeng (Y) > Cc: Alexey Khoroshilov ; David S. Miller > ; netdev@vger.kernel.org; linux- > ker...@vger

[PATCH V2 net-next 3/6] net: hns3: Add "status register" information query function

2018-12-15 Thread Salil Mehta
2: 0x2 DFX_MSIX_INFO_NIC_3: 0x2 DFX_MSIX_INFO_ROC_0: 0xc000 DFX_MSIX_INFO_ROC_1: 0x0 DFX_MSIX_INFO_ROC_2: 0x0 DFX_MSIX_INFO_ROC_3: 0x0 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 15 + .../net/ethernet/hisilicon/hns3/

[PATCH V2 net-next 2/6] net: hns3: Add "manager table" information query function

2018-12-15 Thread Salil Mehta
0 |0 01 |c2:f1:c5:82:68:17|0 |0|0 ||0 |00 |00 |0 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 5 +- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 19 +++ .../ethernet/hisilicon/hns3/

[PATCH V2 net-next 0/6] net: hns3: Add more commands to Debugfs in HNS3 driver

2018-12-15 Thread Salil Mehta
This patch-set adds few more debugfs commands to HNS3 Ethernet Driver. Support has been added to query info related to below items: 1. Packet buffer descriptor ("echo bd info [queue no] [bd index] > cmd") 2. Manager table("echo dump mng tbl > cmd") 3. Dfx status register("echo dump reg ssu [prt id]

[PATCH V2 net-next 5/6] net: hns3: Add "queue map" information query function

2018-12-15 Thread Salil Mehta
47 784 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h| 1 + drivers/net/ethernet/hisilicon/hns3/hnae3.h| 1 + drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 33 ++ .../et

[PATCH V2 net-next 6/6] net: hns3: Add "tm map" status information query function

2018-12-15 Thread Salil Mehta
From: liuzhongzhu This patch prints dcb register status information by module. debugfs command: root@(none)# echo dump tm map 100 > cmd queue_id | qset_id | pri_id | tc_id 0100 | 0065| 08 | 00 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/

[PATCH V2 net-next 4/6] net: hns3: Add "dcb register" status information query function

2018-12-15 Thread Salil Mehta
ned-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 7 ++ .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 9 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 102 + .../ethernet/hisilicon/hns3/hns

[PATCH V2 net-next 1/6] net: hns3: Add "bd info" query function

2018-12-15 Thread Salil Mehta
off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 79 +- 1 file changed, 78 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c b/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c index 86d667a3730a..9a0265

RE: [PATCH net-next 0/6] net: hns3: Add more commands to Debugfs in HNS3 driver

2018-12-15 Thread Salil Mehta
> From: David Miller [mailto:da...@davemloft.net] > Sent: Friday, December 14, 2018 10:37 PM > To: Salil Mehta > Cc: Zhuangyuzeng (Yisen) ; lipeng (Y) > ; mehta.sa...@opnsrc.net; netdev@vger.kernel.org; > linux-ker...@vger.kernel.org; Linuxarm > Subject: Re: [PATCH net-nex

[PATCH net-next 0/6] net: hns3: Add more commands to Debugfs in HNS3 driver

2018-12-11 Thread Salil Mehta
This patch-set adds few more debugfs commands to HNS3 Ethernet Driver. Support has been added to query info related to below items: 1. Packet buffer descriptor ("echo bd info [queue no] [bd index] > cmd") 2. Manager table("echo dump mng tbl > cmd") 3. Dfx status register("echo dump reg ssu [prt id]

[PATCH net-next 1/6] net: hns3: Add "bd info" query function

2018-12-11 Thread Salil Mehta
off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 79 +- 1 file changed, 78 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c b/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c index 86d667a..9a02655 100644

[PATCH net-next 3/6] net: hns3: Add "status register" information query function

2018-12-11 Thread Salil Mehta
2: 0x2 DFX_MSIX_INFO_NIC_3: 0x2 DFX_MSIX_INFO_ROC_0: 0xc000 DFX_MSIX_INFO_ROC_1: 0x0 DFX_MSIX_INFO_ROC_2: 0x0 DFX_MSIX_INFO_ROC_3: 0x0 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 15 + .../net/ethernet/hisilicon/hns3/

[PATCH net-next 5/6] net: hns3: Add "queue map" information query function

2018-12-11 Thread Salil Mehta
47 784 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h| 1 + drivers/net/ethernet/hisilicon/hns3/hnae3.h| 1 + drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 33 ++ .../et

[PATCH net-next 2/6] net: hns3: Add "manager table" information query function

2018-12-11 Thread Salil Mehta
0 |0 01 |c2:f1:c5:82:68:17|0 |0|0 ||0 |00 |00 |0 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 1 + .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 19 +++ .../ethernet/hisilicon/hns3/

[PATCH net-next 6/6] net: hns3: Add "tm map" status information query function

2018-12-11 Thread Salil Mehta
From: liuzhongzhu This patch prints dcb register status information by module. debugfs command: root@(none)# echo dump tm map 100 > cmd queue_id | qset_id | pri_id | tc_id 0100 | 0065| 08 | 00 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/

[PATCH net-next 4/6] net: hns3: Add "dcb register" status information query function

2018-12-11 Thread Salil Mehta
ned-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 7 ++ .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 9 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 102 + .../ethernet/hisilicon/hns3/hns

[PATCH net-next 01/14] net: hns3: remove existing process error functions and reorder hw_blk table

2018-12-07 Thread Salil Mehta
in this patch set. 2. Fixed order issue of the hw_blk table. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 12 - .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 462 + .../net/ethernet/hisilicon/hns3

[PATCH net-next 00/14] net: hns3: Additions/optimizations related to HNS3 H/W err handling

2018-12-07 Thread Salil Mehta
. Add handling for the HW RAS and MSIx errors in the modules MAC, PPP PF, MSIx SRAM, RCB and SSU. [PATCH 10-13] 6. Add handling of RoCEE RAS errors. [PATCH 14] Salil Mehta (1): net: hns3: add handling of hw errors reported through MSIX Shiju Jose (13): net: hns3: remove existing process

[PATCH net-next 12/14] net: hns3: handle hw errors of PPU(RCB)

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch enables and handles hw RAS and MSIx errors of PPU(RCB). Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 3 + .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 162 + .../net

[PATCH net-next 07/14] net: hns3: add handling of hw ras errors using new set of commands

2018-12-07 Thread Salil Mehta
From: Shiju Jose 1. This patch adds handling of hw ras errors using new set of common commands. 2. Updated the error message tables to match the register's name and error status returned by the commands. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- .../net/eth

[PATCH net-next 10/14] net: hns3: add handling of hw errors of MAC

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch adds enable and handling of hw errors of the MAC block. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 1 + .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 48 ++ .../net

[PATCH net-next 09/14] net: hns3: add handling of hw errors reported through MSIX

2018-12-07 Thread Salil Mehta
required. Hence, a new reset type UNKNOWN reset has been introduced which effectively defers the assertion of the reset till we get hold of kind of errors at later time. Signed-off-by: Salil Mehta Signed-off-by: Shiju Jose --- drivers/net/ethernet/hisilicon/hns3/hnae3.h| 1 + .../net

[PATCH net-next 03/14] net: hns3: re-enable error interrupts on hw reset

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch adds calling hclge_hw_error_set_state function to re-enable the error interrupts those will be disabled on the hw reset. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 2 +- drivers/net/ethernet

[PATCH net-next 04/14] net: hns3: deletes unnecessary settings of the descriptor data

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch deletes unnecessary setting of the descriptor data to 0 for disabling error interrupts because it is already done by the hclge_cmd_setup_basic_desc function. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf

[PATCH net-next 02/14] net: hns3: rename enable error interrupt functions

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch - renames the enable error interrupt functions. The reason is that these functions are used for both enable and disable error interrupts. - removes redundant logs from the enable error interrupt functions. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta

[PATCH net-next 06/14] net: hns3: add optimization in the hclge_hw_error_set_state

2018-12-07 Thread Salil Mehta
From: Shiju Jose 1. This patch adds minor loop optimization in the hclge_hw_error_set_state function. 2. Adds logging module's name if it fails to configure the error interrupts. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/h

[PATCH net-next 05/14] net: hns3: rename process_hw_error function

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch renames process_hw_error function to handle_hw_ras_error function to match the purpose of the function. This is because hw errors reported through ras and msix interrupts will be handled separately. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- drivers

[PATCH net-next 08/14] net: hns3: deleted logging 1 bit errors

2018-12-07 Thread Salil Mehta
errors in the hw registers. Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 37 -- 1 file changed, 37 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c b/drivers/net/ethernet

[PATCH net-next 11/14] net: hns3: handle hw errors of PPP PF

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch handles PF hw errors of PPP(Programmable Packet Processor). Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH net-next 13/14] net: hns3: handle hw errors of SSU

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch enables and handles hw errors of the Storage Switch Unit(SSU). Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 2 + .../net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c | 187

[PATCH net-next 14/14] net: hns3: add handling of RDMA RAS errors

2018-12-07 Thread Salil Mehta
From: Shiju Jose This patch handles the RDMA RAS errors. 1. Enable RAS interrupt, print error detail info and clear error status. 2. Do CORE reset to recovery when these non-fatal errors happened. Signed-off-by: Xiaofei Tan Signed-off-by: Shiju Jose Signed-off-by: Salil Mehta --- .../net

RE: [RFC net-next 3/9] net: hns3: Add "port vlan table" information query function

2018-12-04 Thread Salil Mehta
> From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Tuesday, December 4, 2018 10:56 AM > To: Salil Mehta > Cc: David Miller ; jakub.kicin...@netronome.com; > Zhuangyuzeng (Yisen) ; lipeng (Y) > ; mehta.sa...@opnsrc.net; netdev@vger.kernel.org; > linux-ker...@vger

RE: [RFC net-next 3/9] net: hns3: Add "port vlan table" information query function

2018-12-04 Thread Salil Mehta
> From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, December 3, 2018 11:13 PM > To: jakub.kicin...@netronome.com > Cc: Salil Mehta ; Zhuangyuzeng (Yisen) > ; lipeng (Y) ; > mehta.sa...@opnsrc.net; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; Linuxar

[RFC net-next 1/9] net: hns3: Add "bd info" query function

2018-12-02 Thread Salil Mehta
off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 79 +- 1 file changed, 78 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c b/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c index 86d667a3730a..9a026556df0e

[RFC net-next 2/9] net: hns3: Add "mac table" information query function

2018-12-02 Thread Salil Mehta
c_addr |UM_MC_RDATA |0556 |33:33:00:00:00:01 |:0001::: |2812 |33:33:ff:82:68:17 |:0001::: |2844 |01:00:5e:00:00:01 |:0001::: root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil

[RFC net-next 4/9] net: hns3: Add "vf vlan table" information query function

2018-12-02 Thread Salil Mehta
@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 1 + .../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 93 ++ 2 files changed, 94 insertions(+) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_debugf

[RFC net-next 6/9] net: hns3: Add "status register" information query function

2018-12-02 Thread Salil Mehta
2: 0x2 DFX_MSIX_INFO_NIC_3: 0x2 DFX_MSIX_INFO_ROC_0: 0xc000 DFX_MSIX_INFO_ROC_1: 0x0 DFX_MSIX_INFO_ROC_2: 0x0 DFX_MSIX_INFO_ROC_3: 0x0 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 15 + .../net/ethernet/hisilicon/hns3/

[RFC net-next 7/9] net: hns3: Add "dcb register" status information query function

2018-12-02 Thread Salil Mehta
ned-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 7 ++ .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 9 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 102 + .../ethernet/hisilicon/hns3/hns

[RFC net-next 5/9] net: hns3: Add "manager table" information query function

2018-12-02 Thread Salil Mehta
0 |0 01 |c2:f1:c5:82:68:17|0 |0|0 ||0 |00 |00 |0 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 1 + .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 16 ++ .../ethernet/hisilicon/hns3/

[RFC net-next 8/9] net: hns3: Add "queue map" information query function

2018-12-02 Thread Salil Mehta
47 784 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hclge_mbx.h| 1 + drivers/net/ethernet/hisilicon/hns3/hnae3.h| 1 + drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 33 ++ .../et

[RFC net-next 9/9] net: hns3: Add "tm map" status information query function

2018-12-02 Thread Salil Mehta
From: liuzhongzhu This patch prints dcb register status information by module. debugfs command: root@(none)# echo dump tm map 100 > cmd queue_id | qset_id | pri_id | tc_id 0100 | 0065| 08 | 00 root@(none)# Signed-off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/

[RFC net-next 3/9] net: hns3: Add "port vlan table" information query function

2018-12-02 Thread Salil Mehta
off-by: liuzhongzhu Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 1 + .../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c | 80 ++ .../ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h | 3 + 3 files changed, 84 insertions(+) diff --git a/drive

[RFC net-next 0/9] net: hns3: Add more commands to Debugfs in HNS3 driver

2018-12-02 Thread Salil Mehta
This patch-set adds few more debugfs commands to HNS3 Ethernet Driver. Support has been added to query info related to below items: 1. Packet buffer descriptor ("echo bd info [queue no] [bd index] > cmd") 2. Mac Forward table("echo dump mac tbl > cmd") 3. Port vlan Forward table("echo dump port vla

[PATCH net-next 1/2] net: hns3: Support "ethtool -d" for HNS3 VF driver

2018-11-29 Thread Salil Mehta
From: Jian Shen This patch adds "ethtool -d" support for HNS3 VF Driver. Signed-off-by: Jian Shen Signed-off-by: Salil Mehta --- .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 120 + .../ethernet/hisilicon/hns3/hns3vf/hclgevf_main.h | 54 +

[PATCH net-next 0/2] Adds VF/PF PCIe reg dump(ethtool -d) support to HNS3 driver

2018-11-29 Thread Salil Mehta
This patchset adds VF/PF PCIe register dump support to HNS3 VF and PF driver using "ethtool -d" command. Jian Shen (2): net: hns3: Support "ethtool -d" for HNS3 VF driver net: hns3: Adds support to dump(using ethool-d) PCIe regs in HNS3 PF driver .../ethernet/hisilicon/hns3/hns3pf/hclge_

[PATCH net-next 2/2] net: hns3: Adds support to dump(using ethool-d) PCIe regs in HNS3 PF driver

2018-11-29 Thread Salil Mehta
From: Jian Shen This patch adds support to dump PF PCIe registers using ethtool -d for HNS3 PF Driver. Signed-off-by: Jian Shen Signed-off-by: Salil Mehta --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 120 - .../ethernet/hisilicon/hns3/hns3pf/hclge_main.h

[PATCH net-next] net: hns3: Config NIC port speed same as that of optical module

2018-11-26 Thread Salil Mehta
From: Peng Li Port 0/1 of HiP08 supports 10G and 25G. This patch adds a change to configure NIC port speed same as that of optical module(SFP/QFSP). Driver gets the optical module speed and sets NIC port speed accordingly. Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- .../net

[PATCH V2 net-next 0/5] net: hns3: Add support of hardware GRO to HNS3 Driver

2018-11-15 Thread Salil Mehta
This patch-set adds support of hardware assisted GRO feature to HNS3 driver on Rev B(=0x21) platform. Current hardware only supports TCP/IPv{4|6} flows. Change Log: V1->V2: 1. Remove redundant print reported by Leon Romanovsky. Link: https://lkml.org/lkml/2018/11/13/715 Peng Li (5): net: hns

[PATCH net-next 11/12] net: hns3: Fix client initialize state issue when roce client initialize failed

2018-09-19 Thread Salil Mehta
Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hnae3.c | 12 +--- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 3 +++ drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 9 +++

[PATCH net-next 03/10] net: hns3: Fix for waterline not setting correctly

2018-07-06 Thread Salil Mehta
hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff -

[PATCH net-next 02/12] net: hns3: Add support for tx_accept_tag2 and tx_accept_untag2 config

2018-05-25 Thread Salil Mehta
From: Peng Li HNS3 Hardware can support up to two VLAN tags in transmit leg, the PPP module can handle the packets based on the tag1 and tag2 config. This patch adds support for tag2 config for vlan handling Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon

[PATCH net-next 03/12] net: hns3: Add STRP_TAGP field support for hardware revision 0x21

2018-05-25 Thread Salil Mehta
bit, 0 indicates the tag is not stripped and 1 indicates the tag is stripped. This patch adds STRP_TAGP support for revision(0x21), and does not change the revision(0x20) action. Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 42

[PATCH net-next 07/12] net: hns3: Fixes the init of the VALID BD info in the descriptor

2018-05-25 Thread Salil Mehta
this bit was not being (re-)initialized properly and hence was causing problems. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by: Fuyun Liang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/h

[PATCH net-next 05/12] net: hns3: Fix for PF mailbox receving unknown message

2018-05-25 Thread Salil Mehta
Fixes: c1a81619d73a ("net: hns3: Add mailbox interrupt handling to PF driver") Signed-off-by: Xi Wang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c | 23 +++--- 1 file changed, 20 insertions(+), 3 deletions(-

[PATCH net-next 00/12] Misc. bug fixes & some minor additions to HNS3 driver

2018-05-25 Thread Salil Mehta
This patch-set provides some bug fixes figured out during testing and review. It also provides some additions due to running of the existing code on the new revision of the HNS3 hardware. Fuyun Liang (3): net: hns3: Fixes the init of the VALID BD info in the descriptor net: hns3: Removes unnec

[PATCH net-next 01/12] net: hns3: Updates RX packet info fetch in case of multi BD

2018-05-25 Thread Salil Mehta
size from the first descriptor and information like VLAN should be fetched from last BD. Signed-off-by: Peng Li Reviewed-by: Yisen Zhuang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 36 - 1 file changed, 18 insertions(+), 18 deletions

[PATCH net-next 09/12] net: hns3: Clear TX/RX rings when stopping port & un-initializing client

2018-05-25 Thread Salil Mehta
ensure the buffer is clean when port is started. We should clear the rings when clients are being un-initialized as well. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by: Fuyun Liang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --

[PATCH net-next 10/12] net: hns3: Remove unused led control code

2018-05-25 Thread Salil Mehta
, the dirver just needs to deal with locate command. So the codes for link led, traffic led and speed led are useless now. This patch removes these redundant codes. Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h

[PATCH net-next 06/12] net: hns3: Fixes the state to indicate client-type initialization

2018-05-25 Thread Salil Mehta
the initialization state. Fixes: 38caee9d3ee8 ("net: hns3: Add support of the HNAE3 framework") Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hnae3.c | 49 +++-- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 4 ++

[PATCH net-next 08/12] net: hns3: Removes unnecessary check when clearing TX/RX rings

2018-05-25 Thread Salil Mehta
ned-off-by: Fuyun Liang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index d1ef104..4c13

[PATCH net-next 11/12] net: hns3: Adds support for led locate command for copper port

2018-05-25 Thread Salil Mehta
between driver and firmware. Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 12 ++-- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 35 +++--- 2 files changed, 6 insertions(+), 41

[PATCH net-next 12/12] net: hns3: Fixes initalization of RoCE handle and makes it conditional

2018-05-25 Thread Salil Mehta
F HCL(Hardware Compatibility Layer) Support") Reported-by: Xinwei Kong Reported-by: Zhou Wang Signed-off-by: Lijun Ou Signed-off-by: Zhou Wang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

[PATCH net-next 04/12] net: hns3: Add support to enable TX/RX promisc mode for H/W rev(0x21)

2018-05-25 Thread Salil Mehta
From: Peng Li HCLGE_PROMISC_TX_EN_B and HCLGE_PROMISC_RX_EN_B are not supported on pdev revision(0x20), new revision(0x21) supports them. Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.h | 2 ++ drivers/net/ethernet/hisilicon/hns3

[PATCH net-next 3/9] net: hns3: cleanup of return values in hclge_init_client_instance()

2018-05-19 Thread Salil Mehta
From: Jian Shen Removes the goto and directly returns in case of errors as part of the cleanup. Signed-off-by: Jian Shen Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 14 ++ 1 file changed, 6 insertions(+), 8

[PATCH net-next 1/9] net: hns3: Fixes error reported by Kbuild and internal review

2018-05-19 Thread Salil Mehta
This patch fixes the error reported by Intel's kbuild and fixes a return value in one of the legs, caught during review of the original patch sent by kbuild. Fixes: fdb793670a00 ("net: hns3: Add support of .sriov_configure in HNS3 driver") Signed-off-by: Fengguang Wu Signed-off-

[PATCH net-next 0/9] Misc. bug fixes and cleanup for HNS3 driver

2018-05-19 Thread Salil Mehta
hclge_is_special_opcode Jian Shen (1): net: hns3: cleanup of return values in hclge_init_client_instance() Peng Li (1): net: hns3: Fixes API to fetch ethernet header length with kernel default Salil Mehta (1): net: hns3: Fixes error reported by Kbuild and internal review Xi Wang (3

[PATCH net-next 4/9] net: hns3: Fix the missing client list node initialization

2018-05-19 Thread Salil Mehta
From: Xi Wang This patch fixes the missing initialization of the client list node in the hnae3_register_client() function. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by: Xi Wang Signed-off-by: Peng Li Signed-off-by: S

[PATCH net-next 2/9] net: hns3: Fixes API to fetch ethernet header length with kernel default

2018-05-19 Thread Salil Mehta
r the first Buffer Descriptor if the packet is spanning across multiple descriptors. Kernel default eth_get_headlen API does the job correctly. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by: Peng Li Reviewed-by: Yisen Zhuang Signed-off-

[PATCH net-next 9/9] net: hns3: Fix for CMDQ and Misc. interrupt init order problem

2018-05-19 Thread Salil Mehta
adjusting the location of some function. Fixes: e2cb1dec9779 ("net: hns3: Add HNS3 VF HCL(Hardware Compatibility Layer) Support") Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- .../net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c| 16 -

[PATCH net-next 7/9] net: hns3: Fix for netdev not running problem after calling net_stop and net_open

2018-05-19 Thread Salil Mehta
updating the link state in ae_stop function. Fixes: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") Signed-off-by: Fuyun Liang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 3 +++

[PATCH net-next 8/9] net: hns3: Fixes kernel panic issue during rmmod hns3 driver

2018-05-19 Thread Salil Mehta
ad of spin_lock_bh. Fixes: 68c0a5c70614 ("net: hns3: Add HNS3 IMP(Integrated Mgmt Proc) Cmd Interface Support") Signed-off-by: Xi Wang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 4 ++-- 1 file changed, 2 insertions(

[PATCH net-next 6/9] net: hns3: Use enums instead of magic number in hclge_is_special_opcode

2018-05-19 Thread Salil Mehta
, HCLGE_OPC_STATS_32_BIT = 0x0031, HCLGE_OPC_STATS_MAC = 0x0032, }; Signed-off-by: Huazhong Tan Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c | 6 +- 1 file changed, 5 insertions(+), 1

[PATCH net-next 5/9] net: hns3: Fix for hns3 module is loaded multiple times problem

2018-05-19 Thread Salil Mehta
x158/0x208 [ 23.729300] el0_svc_naked+0x30/0x34 This patch fixes it by adding module version info. Fixes: 38caee9d3ee8 ("net: hns3: Add support of the HNAE3 framework") Signed-off-by: Xi Wang Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hnae3.c | 1 +

[PATCH net-next 01/10] net: hns3: Fix for deadlock problem occurring when unregistering ae_algo

2018-05-15 Thread Salil Mehta
calling hnae3_register_ae_dev. Mutex_trylock can be replaced with mutex_lock. Fixes: 424eb834a9be ("net: hns3: Unified HNS3 {VF|PF} Ethernet Driver for hip08 SoC") Signed-off-by: Fuyun Liang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hn

[PATCH net-next 02/10] net: hns3: Fix for the null pointer problem occurring when initializing ae_dev failed

2018-05-15 Thread Salil Mehta
d-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hnae3.c | 6 ++ drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 5 + drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 6 ++ 3 files changed, 9 insertions(+

[PATCH net-next 00/10] Misc. Bug Fixes and clean-ups for HNS3 Driver

2018-05-15 Thread Salil Mehta
This patch-set mainly introduces various bug fixes, cleanups and one very small enhancement to existing HN3 driver code. Fuyun Liang (7): net: hns3: Fix for deadlock problem occurring when unregistering ae_algo net: hns3: Fix for the null pointer problem occurring when initializing ae_

[PATCH net-next 04/10] net: hns3: Change return type of hnae3_register_ae_dev

2018-05-15 Thread Salil Mehta
function. This patch changes the return type of hnae3_register_ae_dev from int to void. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hnae3.c | 5 + drivers/net/ethernet/hisilicon/hns3/hnae3.h | 2 +- drivers

[PATCH net-next 03/10] net: hns3: Add a check for client instance init state

2018-05-15 Thread Salil Mehta
Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hnae3.c | 15 --- drivers/net/ethernet/hisilicon/hns3/hnae3.h | 1 + 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hnae3.c b/drivers/net/ethernet/hisilicon/hns3/hna

[PATCH net-next 05/10] net: hns3: Change return type of hnae3_register_ae_algo

2018-05-15 Thread Salil Mehta
to define return type as int. This patch changes the return type of hnae3_register_ae_algo from int to void. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li Signed-off-by: Salil Mehta --- drivers/net/ethernet/hisilicon/hns3/hnae3.c | 4 +--- drivers/net/ethernet/hisilicon/hns3

  1   2   3   4   5   6   >