Re: [PATCH v2] lan743x: correctly handle chips with internal PHY

2020-11-09 Thread Roelof Berg
. > I would love to test this patch on fixed-link, but unfortunately Yes, understandable, it’s quite dome effort. I will e-mail the company that owns the test setup. They have their own pcba‘s ready meanwhile, so maybe they can give me the EVM setup and I can use it for testing your and other pa

Re: [PATCH v2] lan743x: correctly handle chips with internal PHY

2020-11-08 Thread Roelof Berg
My last customer has a fixed link setup, contact me if you need one. Maybe they let me have it and I can test all future patches on fixed link as well. I tested the current driver version on a Lan7430 EVM in a PC by the way and it seemed to be working. I have the EVM still here if needed. Greet

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Roelof Berg
. (I’m sending this e-mail through a Microchip Lan7430 by the way :) Roelof Berg > > Adding #define DEBUG to the top of drivers/net/phy/phy.c will get you > some debug info. > > […] >Andrew >

[PATCH] lan743x: Use correct MAC_CR configuration for 1 GBit speed

2020-06-03 Thread Roelof Berg
Corrected the MAC_CR configuration bits for 1 GBit operation. The data sheet allows MAC_CR(2:1) to be 10 and also 11 for 1 GBit/s speed, but only 10 works correctly. Devices tested: Microchip Lan7431, fixed-phy mode Microchip Lan7430, normal phy mode Signed-off-by: Roelof Berg --- drivers/net

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Roelof Berg
I’m testing with Microchip Lan7430, which is an integrated circuit that contains MAC and PHY in one package. With the release kernel the hardware works fine, so the overall configuration is ok (jumpers). I will verify wether the effective RGMII and delay settings, you mention, are equal in both

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Roelof Berg
If I find a fix, would I need to submit a delta patch (to our last one) or a full patch ? Thanks. > So lets try to fix it. > >Thanks > Andrew >

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Roelof Berg
y-phy autoneg ? And is this (inband mdio) maybe the reason why the may-phy autosense feature exists in the silicon ? Thanks, Roelof > Am 03.06.2020 um 17:59 schrieb Andrew Lunn : > > On Wed, Jun 03, 2020 at 04:52:32PM +0200, Roelof Berg wrote: >> TEST REPORT: BROKEN PATCH >>

Re: [PATCH] lan743x: Added fixed link and RGMII support / Options for proceeding ?

2020-06-03 Thread Roelof Berg
auto-negotiation feature. Maybe splitting distinct features into distinct patches is the most defensive approach, now that device testing disconfirmed our promising approach ? Thanks everyone for cooperating on this feature, Roelof > Roelof Berg : > > Testing note [...] > - Di

Re: [PATCH] lan743x: Added fixed link and RGMII support / BROKEN PATCH

2020-06-03 Thread Roelof Berg
TEST REPORT: BROKEN PATCH Thanks to everyone for working on the fixed link feature of lan743x eth driver. I received more test hardware today, and one piece of hardware (EVBlan7430) becomes incompatible by the patch. We need to roll back for now. Sorry. I’ll discuss about options of how to proc

[PATCH] lan743x: Added fixed link and RGMII support

2020-05-29 Thread Roelof Berg
phy-connection-type = "rgmii"; fixed-link { speed = <100>; full-duplex; }; }; }; }; Signed-off-by: Roelof Berg --- .../net/ethernet/microchip/lan743x_ethtool.c | 4 +-

[PATCH] lan743x: Added fixed link support

2020-05-20 Thread Roelof Berg
phy-connection-type = "rgmii"; fixed-link { speed = <100>; full-duplex; }; }; }; }; Signed-off-by: Roelof Berg --- drivers/net/ethernet/microchip/lan743x_main.c | 10

Re: [PATCH] lan743x: Added fixed link support

2020-05-19 Thread Roelof Berg
Hi Andrew, thank you for the example, your input got me further. Sorry if my e-mails made the impression that the MAC is sending MDIO on its own. It can issue MDIO but I assume it will do this only on request of the MCU. I read the data sheets again and found what might have confused us. There

Re: [PATCH] lan743x: Added fixed link support

2020-05-18 Thread Roelof Berg
Hi, thanks a lot for guiding me. A thought on the transparency of fixed-phy regarding this section: > >> +/* Set duplex mode */ >> +if (phydev->duplex) >> +data |= MAC_CR_DPX_; >> +else >> +

Re: [PATCH] lan743x: Added fixed link support

2020-05-18 Thread Roelof Berg
Hi, thanks a lot for going into detail. I also want to make sure that everything will be right. > Am 18.05.2020 um 01:50 schrieb Andrew Lunn : > + /* Configure MAC to fixed link parameters */ + data = lan743x_csr_read(adapter, MAC_CR); +

Re: [PATCH] lan743x: Added fixed link support

2020-05-17 Thread Roelof Berg
To Everyone: I need a test hardware recommendation for a lan7431/0 NIC in normal mode (not fixed-link mode). In prior patches this was not necessary, because I was able to ensure 100% backwards compatibility by careful coding alone. But I might soon come to a point where I need to test phy-conne

[PATCH] lan743x: Added fixed link support

2020-05-16 Thread Roelof Berg
fixed-link { speed = <100>; full-duplex; }; }; }; }; Signed-off-by: Roelof Berg --- drivers/net/ethernet/microchip/lan743x_main.c | 93 +--

[PATCH] lan743x: Added fixed link support

2020-05-13 Thread Roelof Berg
fixed-link { speed = <100>; full-duplex; }; }; }; }; Signed-off-by: Roelof Berg --- drivers/net/ethernet/microchip/lan743x_main.c | 94 +--

Re: [PATCH] lan743x: Added fixed_phy support / Question regarding proper devicetree

2020-05-01 Thread Roelof Berg
Working status: I added fixed_phy support to the Microchip lan743x ethernet driver and for upstream contribution I need to make it runtime configurable via the device tree. Question: There are, amongst other, the following devices on my target (i.mx6): /soc/aips-bus@210/ethernet@2188000 /s

Re: [PATCH] lan743x: Added fixed_phy support

2020-04-28 Thread Roelof Berg
> What is the MCU? ARM? Yes, i.mx6 with ARM. > >> […] > > If you are using ARM, device tree is the way to go. > Andrew > Sounds reasonable, I’ll move the fixed_phy configuration for lan743x from .config to the device tree, thanks a lot Andrew. Roelof