Pekka Enberg wrote:
Hi Richard,
On Dec 10, 2007 9:29 PM, Richard Knutsson <[EMAIL PROTECTED]> wrote:
Remove local definition of TRUE/FALSE.
This is already fixed in Francois' tree:
http://git.kernel.org/?p=linux/kernel/git/romieu/netdev-2.6.git;a=c
Remove local definition of TRUE/FALSE.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/ipg.h b/drivers/net/ipg.h
index d5d092c..4484778 100644
--- a/drivers/net/ipg.h
+++ b/drivers/net/ipg.h
@@ -490,38 +490,34 @@ enum ipg_regs {
*
David Miller wrote:
From: Richard Knutsson <[EMAIL PROTECTED]>
Date: Thu, 06 Dec 2007 15:37:46 +0100
David Miller wrote:
But this time I'll just let you know up front that I
don't see much value in this patch. It is not a clear
improvement to replace int's with
es? Do you
use integers for ASCII characters too? It can also avoid some potential
bugs like the 'if (i == TRUE)'...
What is wrong with 'size_t' (since it is unsigned, compared to (some)
'int')?
/Richard Knutsson
--
To unsubscribe from this list: send the line
xff)<<24) | (((d>>8)&0xff)<<16) | (((d>>16)&0xff)<<8)|
((d>>24)&0xff)
Sorry for the late response, but would it not be better/easier to use
BIT() instead (or a global #define LLBIT(nr) (1ULL << (nr))) and just
recalculate the values?
Convert to generic boolean
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64)
Diffed against Linus' git-tree.
Sent 2007-05-01, no replys
diff --git a/drivers/net/3c505.c b/drivers/net/3c505.c
index e985a85.
Convert to generic boolean
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64)
Diffed against Linus' git-tree.
Sent 2007-05-01, no replys
diff --git a/drivers/net/tokenring/ibmtr.c b/drivers/net/tokenrin
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64)
Diffed against Linus' git-tree.
diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c
index e8c9f27..635d0ab 100644
--- a/drivers/net/8139cp.c
+++ b/drive
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64)
Diffed against Linus' git-tree.
de4x5.c | 98
de4x5.h |9 -
2 files changed, 49 in
Convert to generic boolean.
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64)
Diffed against Linus' git-tree.
diff --git a/drivers/net/dm9000.c b/drivers/net/dm9000.c
index 8cc1174..6fb3815 100644
--- a/dri
Convert to generic boolean
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64)
Diffed against Linus' git-tree.
diff --git a/drivers/net/tokenring/ibmtr.c b/drivers/net/tokenring/ibmtr.c
index 1e8958e..0c69e
Convert to generic boolean
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Compile-tested with all(yes|mod|no)config on x86(|_64) & sparc(|64)
Diffed against Linus' git-tree.
diff --git a/drivers/net/3c505.c b/drivers/net/3c505.c
index e985a85..acede30 100644
--- a/driv
Convert pci_module_init() to pci_register_driver().
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
Compile-tested with "allyes", "allmod" & "allno" on i386
diff --git a/drivers/net/wan/pc300too.c b/drivers/net/wan/pc300too.c
index bc156
27;t those functions be converted to return 'bool' when the
description say so (happy to do it).
Richard Knutsson
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/netxen/netxen_nic_main.c
b/drivers/net/netxen/netxen_nic_main.c
index 8a5792f..96e1bee 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -1144,7 +1144,7 @@ stat
Herbert Xu wrote:
On Mon, Nov 21, 2005 at 01:52:49PM +0100, Richard Knutsson wrote:
This patch requirer the
"net-fix-compiler-error-on-dgrsc-when-config_pci.patch" (added to the
-mm tree after 2.6.15-rc1-mm2):
---
devel/drivers/net/dgrs.c~net-fix-compiler-error-on-dgrsc-when-
Herbert Xu wrote:
Richard Knutsson <[EMAIL PROTECTED]> wrote:
We need it even if pci_register_driver() and pci_register_driver() is
empty shells. And instead of removing #endif CONFIG_PCI for
I don't think so. Please see my previous patch where pci_register_driver
is no
Herbert Xu wrote:
On Mon, Nov 21, 2005 at 01:52:49PM +0100, Richard Knutsson wrote:
This patch requirer the
"net-fix-compiler-error-on-dgrsc-when-config_pci.patch" (added to the
-mm tree after 2.6.15-rc1-mm2):
---
devel/drivers/net/dgrs.c~net-fix-compiler-error-on-dgrsc-when-
Herbert Xu wrote:
On Sun, Nov 20, 2005 at 04:35:46PM +0100, Richard Knutsson wrote:
-#ifdef CONFIG_EISA
- cardcount = eisa_driver_register(&dgrs_eisa_driver);
+ cardcount = dgrs_register_eisa();
if (cardcount < 0)
return cardcount;
Herbert Xu wrote:
Richard Knutsson <[EMAIL PROTECTED]> wrote:
diff -Narup a/drivers/net/dgrs.c b/drivers/net/dgrs.c
--- a/drivers/net/dgrs.c2005-11-19 20:17:51.0 +0100
+++ b/drivers/net/dgrs.c2005-11-19 20:29:52.0 +0100
@@ -1458,6 +1458,8 @@ static
Richard Knutsson wrote:
Andrew Morton wrote:
Richard Knutsson <[EMAIL PROTECTED]> wrote:
*/
> #ifdef CONFIG_EISA
>-eisacount = eisa_driver_register(&dgrs_eisa_driver);
>-if (eisacount < 0)
>-return eisacount;
>-#endif
>-#
Andrew Morton wrote:
Richard Knutsson <[EMAIL PROTECTED]> wrote:
*/
> #ifdef CONFIG_EISA
>- eisacount = eisa_driver_register(&dgrs_eisa_driver);
>- if (eisacount < 0)
>- return eisacount;
>-#endif
>-#ifdef CONFIG_PCI
>
22 matches
Mail list logo
