[PATCH 3/3] selinux: Add SELinux GTP support

2020-10-15 Thread Richard Haines
The SELinux GTP implementation is explained in: Documentation/security/GTP.rst Signed-off-by: Richard Haines --- Documentation/security/GTP.rst | 61 ++ security/selinux/hooks.c| 66 + security/selinux/include/classmap.h | 2

[PATCH 0/3] Add LSM/SELinux support for GPRS Tunneling Protocol (GTP)

2020-10-15 Thread Richard Haines
that it is visible to the LSM modules for storing the security blob. 2) Remove pr_debug's from gtp.c security_* calls. 3) Minor GTP.rst updates. 4) Added netdev to distribution list. Richard Haines (3): security: Add GPRS Tunneling Protocol (GTP) security hooks gtp: Add LSM hooks to

[PATCH 1/3] security: Add GPRS Tunneling Protocol (GTP) security hooks

2020-10-15 Thread Richard Haines
The GTP security hooks are explained in: Documentation/security/GTP.rst Signed-off-by: Richard Haines --- Documentation/security/GTP.rst | 39 Documentation/security/index.rst | 1 + include/linux/lsm_hook_defs.h| 3 +++ include/linux/lsm_hooks.h

[PATCH 2/3] gtp: Add LSM hooks to GPRS Tunneling Protocol (GTP)

2020-10-15 Thread Richard Haines
Add security hooks to allow security modules to exercise access control over GTP. The 'struct gtp_dev' has been moved to include/net/gtp.h so that it is visible to LSM security modules where their security blob is stored. Signed-off-by: Richard Haines --- drivers/net/

Re: [PATCH 3/3] selinux: Add SELinux GTP support

2020-10-13 Thread Richard Haines
On Tue, 2020-10-13 at 09:55 -0400, Paul Moore wrote: > On Mon, Oct 12, 2020 at 5:40 AM Harald Welte > wrote: > > Hi Paul, > > > > On Sun, Oct 11, 2020 at 10:09:11PM -0400, Paul Moore wrote: > > > Harald, Pablo - I know you both suggested taking a slow iterative > > > approach to merging functiona

Re: [PATCH 3/3] selinux: Add SELinux GTP support

2020-09-30 Thread Richard Haines
Open 5G I thought adding MAC support might be useful somewhere along the line. > however one comment from the point of view of somebody who is working > on GGSN/P-GW > software using the GTP kernel module: > > On Wed, Sep 30, 2020 at 10:49:34AM +0100, Richard Haines

Re: [PATCH 0/3] Add LSM/SELinux support for GPRS Tunneling Protocol (GTP)

2020-09-30 Thread Richard Haines
On Wed, 2020-09-30 at 12:17 +0200, Pablo Neira Ayuso wrote: > On Wed, Sep 30, 2020 at 10:49:31AM +0100, Richard Haines wrote: > > These patches came about after looking at 5G open source in > > particular > > the updated 5G GTP driver at [1]. As this driver is still under &

Re: [PATCH v2 1/3] selinux: add AF_UNSPEC and INADDR_ANY checks to selinux_socket_bind()

2018-05-11 Thread Richard Haines
On Fri, 2018-05-11 at 20:15 +0300, Alexey Kodanev wrote: > Commit d452930fd3b9 ("selinux: Add SCTP support") breaks > compatibility > with the old programs that can pass sockaddr_in structure with > AF_UNSPEC > and INADDR_ANY to bind(). As a result, bind() returns EAFNOSUPPORT > error. > This was f

[PATCH] selinux: Fix ltp test connect-syscall failure

2018-03-02 Thread Richard Haines
ess family ; returned -1 (expected -1), errno 22 (expected 97) INFO: ltp-pan reported some tests FAIL LTP Version: 20180118 Reported-by: Anders Roxell Signed-off-by: Richard Haines --- security/selinux/hooks.c | 42 ++ 1 file changed, 30 insertions(+), 12 deleti

Re: Regression found when running LTP connect01 on next-20180301

2018-03-02 Thread Richard Haines
On Thu, 2018-03-01 at 13:03 -0500, Paul Moore wrote: > On March 1, 2018 9:36:37 AM Richard Haines et.com> wrote: > > On Thu, 2018-03-01 at 08:42 -0500, Paul Moore wrote: > > > On Thu, Mar 1, 2018 at 3:33 AM, Anders Roxell > > ro.o > > > rg> wrote: > >

Re: Regression found when running LTP connect01 on next-20180301

2018-03-01 Thread Richard Haines
On Thu, 2018-03-01 at 08:42 -0500, Paul Moore wrote: > On Thu, Mar 1, 2018 at 3:33 AM, Anders Roxell rg> wrote: > > Hi, > > > > I was running LTP's testcase connect01 [1] and found a regression > > in linux-next > > (next-20180301). Bisect gave me this patch as the problematic > > patch (sha > >

[PATCH V8 2/4] sctp: Add ip option support

2018-02-24 Thread Richard Haines
Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 and CALIPSO/IPv6 services. Signed-off-by: Richard Haines --- All SCTP lksctp-tools/src/func_tests run correctly in enforcing mode. All "./sctp-tests run" obtained from: https://github.com/sctp/sctp-tests pass.

[PATCH V7 2/4] sctp: Add ip option support

2018-02-20 Thread Richard Haines
Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 and CALIPSO/IPv6 services. Signed-off-by: Richard Haines --- All SCTP lksctp-tools/src/func_tests run correctly in enforcing mode. All "./sctp-tests run" obtained from: https://github.com/sctp/sctp-tests pass.

Re: [PATCH V6 2/4] sctp: Add ip option support

2018-02-18 Thread Richard Haines
gt; > wrote: > > > > On Thu, Feb 15, 2018 at 09:15:40AM -0500, Neil Horman wrote: > > > > > On Tue, Feb 13, 2018 at 08:54:44PM +, Richard Haines > > > > > wrote: > > > > > > Add ip option support to allow LS

[PATCH V6 4/4] selinux: Add SCTP support

2018-02-13 Thread Richard Haines
The SELinux SCTP implementation is explained in: Documentation/security/SELinux-sctp.rst Signed-off-by: Richard Haines --- Documentation/security/SELinux-sctp.rst | 157 ++ security/selinux/hooks.c| 280 +--- security/selinux/include

[PATCH V6 3/4] sctp: Add LSM hooks

2018-02-13 Thread Richard Haines
Add security hooks allowing security modules to exercise access control over SCTP. Signed-off-by: Richard Haines --- include/net/sctp/structs.h | 10 include/uapi/linux/sctp.h | 1 + net/sctp/sm_make_chunk.c | 12 + net/sctp/sm_statefuns.c| 18 ++ net/sctp

[PATCH V6 2/4] sctp: Add ip option support

2018-02-13 Thread Richard Haines
Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 and CALIPSO/IPv6 services. Signed-off-by: Richard Haines --- include/net/sctp/sctp.h| 4 +++- include/net/sctp/structs.h | 2 ++ net/sctp/chunk.c | 12 +++- net/sctp/ipv6.c| 42

[PATCH V6 0/4] Add SELinux SCTP protocol support

2018-02-13 Thread Richard Haines
SCTP updates since kernel 4.14. [1] https://marc.info/?l=selinux&m=151061619115945&w=2 [2] https://marc.info/?l=selinux&m=150962470215797&w=2 [3] https://marc.info/?l=selinux&m=151198281817779&w=2 Richard Haines (4): security: Add support for SCTP security hooks sctp:

[PATCH V6 1/4] security: Add support for SCTP security hooks

2018-02-13 Thread Richard Haines
The SCTP security hooks are explained in: Documentation/security/LSM-sctp.rst Signed-off-by: Richard Haines --- Documentation/security/LSM-sctp.rst | 175 include/linux/lsm_hooks.h | 36 include/linux/security.h| 25

PATCH V5 4/4] selinux: Add SCTP support

2018-01-11 Thread Richard Haines
The SELinux SCTP implementation is explained in: Documentation/security/SELinux-sctp.rst Signed-off-by: Richard Haines --- V5 Change: Rework selinux_netlbl_socket_connect() and selinux_netlbl_socket_connect_locked as requested by Paul. Documentation/security/SELinux-sctp.rst | 157

Re: [PATCH V4 4/4] selinux: Add SCTP support

2018-01-10 Thread Richard Haines
On Wed, 2018-01-10 at 11:37 -0500, Paul Moore wrote: > On Sat, Dec 30, 2017 at 12:20 PM, Richard Haines > wrote: > > The SELinux SCTP implementation is explained in: > > Documentation/security/SELinux-sctp.rst > > > > Signed-off-by: Richard Haines > > ---

[PATCH V4 1/4] security: Add support for SCTP security hooks

2017-12-30 Thread Richard Haines
The SCTP security hooks are explained in: Documentation/security/LSM-sctp.rst Signed-off-by: Richard Haines --- Documentation/security/LSM-sctp.rst | 175 include/linux/lsm_hooks.h | 36 include/linux/security.h| 25

[PATCH V4 4/4] selinux: Add SCTP support

2017-12-30 Thread Richard Haines
The SELinux SCTP implementation is explained in: Documentation/security/SELinux-sctp.rst Signed-off-by: Richard Haines --- Documentation/security/SELinux-sctp.rst | 157 ++ security/selinux/hooks.c| 280 +--- security/selinux/include

[PATCH V4 2/4] sctp: Add ip option support

2017-12-30 Thread Richard Haines
Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 and CALIPSO/IPv6 services. Signed-off-by: Richard Haines --- include/net/sctp/sctp.h| 4 +++- include/net/sctp/structs.h | 2 ++ net/sctp/chunk.c | 13 - net/sctp/ipv6.c| 42

[PATCH V4 3/4] sctp: Add LSM hooks

2017-12-30 Thread Richard Haines
Add security hooks to allow security modules to exercise access control over SCTP. Signed-off-by: Richard Haines --- include/net/sctp/structs.h | 10 include/uapi/linux/sctp.h | 1 + net/sctp/sm_make_chunk.c | 12 + net/sctp/sm_statefuns.c| 18 ++ net/sctp

[PATCH V4 0/4] Add SELinux SCTP protocol support

2017-12-30 Thread Richard Haines
15945&w=2 [2] https://marc.info/?l=selinux&m=150962470215797&w=2 [3] https://marc.info/?l=selinux&m=151198281817779&w=2 Richard Haines (4): security: Add support for SCTP security hooks sctp: Add ip option support sctp: Add LSM hooks selinux:

Re: [PATCH v3 1/4] security: Add support for SCTP security hooks

2017-12-27 Thread Richard Haines
On Fri, 2017-12-22 at 15:45 -0200, Marcelo Ricardo Leitner wrote: > On Fri, Dec 22, 2017 at 09:20:45AM -0800, Casey Schaufler wrote: > > On 12/22/2017 5:05 AM, Marcelo Ricardo Leitner wrote: > > > From: Richard Haines > > > > > > The SCTP security hooks a

[PATCH V2] selinux: Add SCTP support

2017-12-06 Thread Richard Haines
The SELinux SCTP implementation is explained in: Documentation/security/SELinux-sctp.rst Signed-off-by: Richard Haines --- V2 Changes Remove lock from selinux_sctp_assoc_request() Fix selinux_sctp_sk_clone() kbuild test robot catch [1] [1] https://marc.info/?l=selinux&m=151198281817779

Re: [PATCH 4/4] selinux: Add SCTP support

2017-12-04 Thread Richard Haines
On Tue, 2017-11-28 at 14:59 -0500, Stephen Smalley wrote: > On Tue, 2017-11-28 at 14:39 -0500, Stephen Smalley wrote: > > On Mon, 2017-11-27 at 19:32 +, Richard Haines wrote: > > > The SELinux SCTP implementation is explained in: > > > Documentatio

[PATCH 2/4] sctp: Add ip option support

2017-11-27 Thread Richard Haines
Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 and CALIPSO/IPv6 services. Signed-off-by: Richard Haines --- include/net/sctp/structs.h | 2 ++ net/sctp/chunk.c | 13 - net/sctp/ipv6.c| 42

[PATCH 4/4] selinux: Add SCTP support

2017-11-27 Thread Richard Haines
The SELinux SCTP implementation is explained in: Documentation/security/SELinux-sctp.rst Signed-off-by: Richard Haines --- Documentation/security/SELinux-sctp.rst | 104 security/selinux/hooks.c| 278 +--- security/selinux/include

[PATCH 3/4] sctp: Add LSM hooks

2017-11-27 Thread Richard Haines
Add security hooks to allow security modules to exercise access control over SCTP. Signed-off-by: Richard Haines --- include/net/sctp/structs.h | 10 include/uapi/linux/sctp.h | 1 + net/sctp/sm_make_chunk.c | 12 + net/sctp/sm_statefuns.c| 18 ++ net/sctp

[PATCH 0/4] Add SELinux SCTP protocol support

2017-11-27 Thread Richard Haines
oc_request(). Remove unused parameter from security_sctp_assoc_request(). Use address->sa_family == AF_INET in *_bind and *_connect to ensure correct address type. Minor cleanups. [1] https://marc.info/?l=selinux&m=151061619115945&w=2 [2] https://marc.info/?l=selinux&m=1509624702157

[PATCH 1/4] security: Add support for SCTP security hooks

2017-11-27 Thread Richard Haines
The SCTP security hooks are explained in: Documentation/security/LSM-sctp.rst Signed-off-by: Richard Haines --- Documentation/security/LSM-sctp.rst | 194 include/linux/lsm_hooks.h | 35 +++ include/linux/security.h| 25

Re: [RFC PATCH 5/5] selinux: Add SCTP support

2017-11-21 Thread Richard Haines
On Mon, 2017-11-20 at 16:55 -0500, Paul Moore wrote: > On Tue, Nov 14, 2017 at 4:52 PM, Richard Haines > wrote: > > On Mon, 2017-11-13 at 17:40 -0500, Paul Moore wrote: > > > On Mon, Nov 13, 2017 at 5:05 PM, Richard Haines > > > wrote: > > > > On Mon, 2

Re: [RFC PATCH 5/5] selinux: Add SCTP support

2017-11-14 Thread Richard Haines
On Mon, 2017-11-13 at 17:40 -0500, Paul Moore wrote: > On Mon, Nov 13, 2017 at 5:05 PM, Richard Haines > wrote: > > On Mon, 2017-11-06 at 19:09 -0500, Paul Moore wrote: > > > On Tue, Oct 17, 2017 at 9:59 AM, Richard Haines > > > wrote: > > > > The S

Re: [RFC PATCH 5/5] selinux: Add SCTP support

2017-11-13 Thread Richard Haines
On Mon, 2017-11-06 at 19:09 -0500, Paul Moore wrote: > On Tue, Oct 17, 2017 at 9:59 AM, Richard Haines > wrote: > > The SELinux SCTP implementation is explained in: > > Documentation/security/SELinux-sctp.txt > > > > Signed-off-by: Richard Haines > > ---

[PATCH] netlabel: If PF_INET6, check sk_buff ip header version

2017-11-13 Thread Richard Haines
When resolving a fallback label, check the sk_buff version as it is possible (e.g. SCTP) to have family = PF_INET6 while receiving ip_hdr(skb)->version = 4. Signed-off-by: Richard Haines --- net/netlabel/netlabel_unlabeled.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/

Re: [RFC PATCH 4/5] netlabel: Add SCTP support

2017-11-13 Thread Richard Haines
On Mon, 2017-11-06 at 18:15 -0500, Paul Moore wrote: > On Tue, Oct 17, 2017 at 9:58 AM, Richard Haines > wrote: > > Add support to label SCTP associations and cater for a situation > > where > > family = PF_INET6 with an ip_hdr(skb)->version = 4. > >

Re: [RFC PATCH 1/5] security: Add support for SCTP security hooks

2017-11-01 Thread Richard Haines
On Tue, 2017-10-31 at 14:41 -0200, Marcelo Ricardo Leitner wrote: > On Tue, Oct 17, 2017 at 03:02:47PM +0100, Richard Haines wrote: > > The SCTP security hooks are explained in: > > Documentation/security/LSM-sctp.txt > > > > Signed-off-by: Richard Haines > > --

Re: [RFC PATCH 2/5] sctp: Add ip option support

2017-11-01 Thread Richard Haines
On Tue, 2017-10-31 at 15:06 -0200, Marcelo Ricardo Leitner wrote: > Hello, > > On Tue, Oct 17, 2017 at 02:58:06PM +0100, Richard Haines wrote: > > Add ip option support to allow LSM security modules to utilise > > CIPSO/IPv4 > > and CALIPSO/IPv6 services. > >

Re: [RFC PATCH 5/5] selinux: Add SCTP support

2017-11-01 Thread Richard Haines
On Tue, 2017-10-31 at 15:16 -0200, Marcelo Ricardo Leitner wrote: > On Tue, Oct 17, 2017 at 02:59:53PM +0100, Richard Haines wrote: > > The SELinux SCTP implementation is explained in: > > Documentation/security/SELinux-sctp.txt > > > > Signed-off-by: Richard Haines

Re: [RFC PATCH 3/5] sctp: Add LSM hooks

2017-10-24 Thread Richard Haines
On Fri, 2017-10-20 at 21:14 +0800, Xin Long wrote: > On Fri, Oct 20, 2017 at 8:04 PM, Richard Haines > wrote: > > On Fri, 2017-10-20 at 07:16 -0400, Neil Horman wrote: > > > On Wed, Oct 18, 2017 at 11:05:09PM +0800, Xin Long wrote: > > > > On Tue, Oct 17

Re: [RFC PATCH 5/5] selinux: Add SCTP support

2017-10-24 Thread Richard Haines
On Fri, 2017-10-20 at 15:00 -0400, Stephen Smalley wrote: > On Tue, 2017-10-17 at 14:59 +0100, Richard Haines wrote: > > The SELinux SCTP implementation is explained in: > > Documentation/security/SELinux-sctp.txt > > > > Signed-off-by: Richard Haines > > --- &g

Re: [RFC PATCH 3/5] sctp: Add LSM hooks

2017-10-20 Thread Richard Haines
On Fri, 2017-10-20 at 07:16 -0400, Neil Horman wrote: > On Wed, Oct 18, 2017 at 11:05:09PM +0800, Xin Long wrote: > > On Tue, Oct 17, 2017 at 9:58 PM, Richard Haines > > wrote: > > > Add security hooks to allow security modules to exercise access > > > control >

[RFC PATCH 1/5] security: Add support for SCTP security hooks

2017-10-17 Thread Richard Haines
The SCTP security hooks are explained in: Documentation/security/LSM-sctp.txt Signed-off-by: Richard Haines --- Documentation/security/LSM-sctp.txt | 212 include/linux/lsm_hooks.h | 37 +++ include/linux/security.h| 27

[RFC PATCH 0/5] Add SELinux SCTP protocol support

2017-10-17 Thread Richard Haines
tests The selinux-testsuite patch also adds remote tests (that need some manual configuration). These are useful for testing CIPSO/CALIPSO over a network with a number of categories to produce large ip option fields with various message sizes forcing fragmentation etc.. Richard Haines (5): sec

[RFC PATCH 3/5] sctp: Add LSM hooks

2017-10-17 Thread Richard Haines
Add security hooks to allow security modules to exercise access control over SCTP. Signed-off-by: Richard Haines --- include/net/sctp/structs.h | 10 include/uapi/linux/sctp.h | 1 + net/sctp/sm_make_chunk.c | 12 + net/sctp/sm_statefuns.c| 14 ++- net/sctp

[RFC PATCH 4/5] netlabel: Add SCTP support

2017-10-17 Thread Richard Haines
Add support to label SCTP associations and cater for a situation where family = PF_INET6 with an ip_hdr(skb)->version = 4. Signed-off-by: Richard Haines --- include/net/netlabel.h| 3 ++ net/netlabel/netlabel_kapi.c | 80 +++ net/netla

[RFC PATCH 2/5] sctp: Add ip option support

2017-10-17 Thread Richard Haines
Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 and CALIPSO/IPv6 services. Signed-off-by: Richard Haines --- include/net/sctp/structs.h | 2 ++ net/sctp/chunk.c | 7 --- net/sctp/ipv6.c| 37 ++--- net/sctp

[RFC PATCH 5/5] selinux: Add SCTP support

2017-10-17 Thread Richard Haines
The SELinux SCTP implementation is explained in: Documentation/security/SELinux-sctp.txt Signed-off-by: Richard Haines --- Documentation/security/SELinux-sctp.txt | 108 + security/selinux/hooks.c| 268 ++-- security/selinux/include

[PATCH] net/ipv6: Fix CALIPSO causing GPF with datagram support

2017-06-05 Thread Richard Haines
When using CALIPSO with IPPROTO_UDP it is possible to trigger a GPF as the IP header may have moved. Also update the payload length after adding the CALIPSO option. Signed-off-by: Richard Haines --- net/ipv6/calipso.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net