[PATCH] iavh: fix a typo

2018-09-23 Thread Rami Rosen
This trivial patch fixes a typo in iavf.h. Signed-off-by: Rami Rosen --- drivers/net/ethernet/intel/iavf/iavf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf.h b/drivers/net/ethernet/intel/iavf/iavf.h index a512f7521841..272d76b733aa

[PATCH net-next] net: fix two typos in net_device_ops documentation.

2017-08-31 Thread Rami Rosen
This patch fixes two trivial typos in net_device_ops documentation, related to ndo_xdp_flush callback. Signed-off-by: Rami Rosen --- include/linux/netdevice.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index

[PATCH net-next] i40e: fix a typo in i40e_pf documentation.

2017-08-18 Thread Rami Rosen
This patch fixes a typo in i40e_pf object documentation; num_req_vfs refers to the number of VFs requested for the PF. Signed-off-by: Rami Rosen --- drivers/net/ethernet/intel/i40e/i40e.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e.h

[PATCH net-next] net/packet: remove unused PGV_FROM_VMALLOC definition.

2017-07-18 Thread Rami Rosen
flags"); but it was added back by mistake later on, in commit f6fb8f100b80 ("af-packet: TPACKET_V3 flexible buffer implementation"). Signed-off-by: Rami Rosen --- net/packet/af_packet.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/packet/af_packet.c b/net/packet/

[PATCH net-next] net/packet: remove unneeded declaraion of tpacket_snd().

2017-06-10 Thread Rami Rosen
This patch removes unneeded forward declaration of tpacket_snd() in net/packet/af_packet.c. Signed-off-by: Rami Rosen --- net/packet/af_packet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index 82ca49fba336..f9349a495caf 100644 --- a/net

[PATCH v2 net-next] genetlink: remove ops_list from genetlink header.

2017-06-04 Thread Rami Rosen
ixes it by removing ops_list from genl_ops documentation. Signed-off-by: Rami Rosen --- include/net/genetlink.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/net/genetlink.h b/include/net/genetlink.h index 68b8819..c59a098 100644 --- a/include/net/genetlink.h +++ b/include/net/g

[PATCH net-next] genetlink: remove ops_list from genetlink header.

2017-06-04 Thread Rami Rosen
y removing ops_list from genl_ops documentation. Signed-off-by: Rami Rosen --- include/net/genetlink.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/net/genetlink.h b/include/net/genetlink.h index 68b8819..c59a098 100644 --- a/include/net/genetlink.h +++ b/include/net/genetlink.h

[PATCH net-next] net/packet: remove unused parameter in prb_curr_blk_in_use().

2017-05-24 Thread Rami Rosen
This patch removes unused parameter from prb_curr_blk_in_use() method in net/packet/af_packet.c. Signed-off-by: Rami Rosen --- net/packet/af_packet.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c index e3eeed1

[PATCH net-next] net: socket: fix a typo in sockfd_lookup().

2017-05-21 Thread Rami Rosen
This patch fixes a typo in sockfd_lookup() in net/socket.c. Signed-off-by: Rami Rosen --- net/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/socket.c b/net/socket.c index cb355a7..8f9dab3 100644 --- a/net/socket.c +++ b/net/socket.c @@ -461,7 +461,7

Re: [PATCH 0/9] net: thunderx: Adds XDP support

2017-05-03 Thread Rami Rosen
Thanks, Sunil. >with network stack: 0.32 Mpps >with XDP (XDP_TX): 3 Mpps >and XDP_DROP: 3.8 Mpps Interesting; May I ask - which packet size did you use ? Regards, Rami Rosen

Re: SO_BINDTODEVICE in VRFs not working?

2017-03-18 Thread Rami Rosen
ns.com/source/Documentation/networking/vrf.txt#L97 Regards, Rami Rosen

Re: [PATCH v4 net-next 4/6] drivers: net: xgene-v2: Add base driver

2017-03-07 Thread Rami Rosen
UFS; + + return 0; +} Regards, Rami Rosen

Re: [PATCH v7 11/13] net: ethernet: aquantia: Ethtool support

2017-01-20 Thread Rami Rosen
+1 Many times this information is needed, and "ethtool -i" is a convenient way to get it. Rami Rosen

Re: [PATCH v5 05/13] net: ethernet: aquantia: Support for NIC-specific code

2017-01-14 Thread Rami Rosen
//tools.ietf.org/html/rfc791 ... Every internet module must be able to forward a datagram of 68 octets without further fragmentation. This is because an internet header may be up to 60 octets, and the minimum fragment is 8 octets. ... Regards, Rami Rosen

Re: [PATCH v2 01/13] net: ethernet: aquantia: Make and configuration files.

2017-01-11 Thread Rami Rosen
_nic.o \ > + aq_vec.o \ > + aq_ring.o \ ... ... Regards, Rami Rosen

Re: [PATCH v2 03/12] net: ethernet: aquantia: Add ring support code

2017-01-08 Thread Rami Rosen
--- /dev/null > +++ b/drivers/net/ethernet/aquantia/aq_ring.h > @@ -0,0 +1,147 @@ > +/* > + * aQuantia Corporation Network Driver > + * Copyright (C) 2014-2016 aQuantia Corporation. All rights reserved > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2, as published by the Free Software Foundation. > + */ > + File name should be aq_ring.h: > +/* File aq_pci_ring.h: Declaration of functions for Rx/Tx rings. */ > + > +#ifndef AQ_RING_H > +#define AQ_RING_H > + > +#include "aq_common.h" > + > +struct page; > + > +/* TxC SOPDX EOP > + * +--+--+--+--- > + * 8bytes|len l3,l4 | pa | pa | pa > + * +--+--+--+--- > + * 4/8bytes|len pkt |len pkt | | skb > + * +--+--+--+--- > + * 4/8bytes|is_txc|len,flags |len |len,is_eop > + * +--+--+--+--- > + * > + * This aq_ring_buff_s doesn't have endianness dependency. Typo: chache->cache > + * It is __packed for chache line optimisations. Regards, Rami Rosen

Re: [PATCH 05/12] Support for NIC-specific code

2016-12-27 Thread Rami Rosen
; +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.h > @@ -0,0 +1,111 @@ > +/* > + * Aquantia Corporation Network Driver > + * Copyright (C) 2014-2016 Aquantia Corporation. All rights reserved > + * > + * This program is free software; you can redistribute it and/or modify it > + * under the terms and conditions of the GNU General Public License, > + * version 2, as published by the Free Software Foundation. > + */ > + > +/* Should be, of course, aq_nic.h: > + * File aq_nic.c: Declaration of common code for NIC. > + */ > + Regards, Rami Rosen

Re: [PATCH 01/12] Make and configuration files.

2016-12-27 Thread Rami Rosen
lean Don't think I ever encountered load/unload targets in Linux Kernel Makefiles (not talking about out of tree projects): >+load: >+ insmod ./$(TARGET).ko >+ >+unload: >+ rmmod ./$(TARGET).ko Regards, Rami Rosen

Re: [PATCH iproute2 v2 1/3] ifstat: Add extended statistics to ifstat

2016-12-16 Thread Rami Rosen
Hi, >Thanks, I'll fix it. Another minor nit, on this occasion: bool is_extanded should be: bool is_extended Regards, Rami Rosen

Re: iproute2 public git outdated?

2016-12-01 Thread Rami Rosen
Hi Phil, I suggest that you will try again now, it seems that the iproute2 git repo was updated in the last 2-4 hours, and "git log" in master shows now a patch from 30 of November (actually it is your "Add notes about dropped IPv4 route cache" patch) Regards, Rami Rosen O

Re: [PATCH net-next] cgroup, bpf: remove unnecessary #include

2016-11-26 Thread Rami Rosen
Acked-by: Rami Rosen On 26 November 2016 at 09:23, Alexei Starovoitov wrote: > this #include is unnecessary and brings whole set of > other headers into cgroup-defs.h. Remove it. > > Fixes: 3007098494be ("cgroup: add support for eBPF programs") > Signed-o

Re: [PATCH v3 net-next 1/2] net: ethernet: slicoss: add slicoss gigabit ethernet driver

2016-11-26 Thread Rami Rosen
dev_err(&sdev->pdev->dev, > + "invalid rcv-sequencer firmware size %zu\n", > fw->size); > + err = -EINVAL; Again, in the release label, always 0 is returned: > + goto release; > + } > + > > +release: > + release_firmware(fw); > + > + return 0; > +} > + Regards, Rami Rosen

Re: [PATCH v9 2/6] cgroup: add support for eBPF programs

2016-11-23 Thread Rami Rosen
is currently attached, if any. @prog is then made > + * the effective program of type @type in that cgroup. > + * > + * If @prog is %NULL, the currently attached program of type @type is > released, > + * and the effective program of the parent cgroup (if any) is inherited to > + * @cgrp. > + * Regard, Rami Rosen

Re: [PATCH v2] cpsw: ethtool: add support for getting/setting EEE registers

2016-11-23 Thread Rami Rosen
Acked-by: Rami Rosen

Re: [PATCH] cpsw: ethtool: add support for getting/setting EEE registers

2016-11-23 Thread Rami Rosen
Hi, Yegor, Minor comment: these methods should be static. +int cpsw_get_eee(struct net_device *ndev, struct ethtool_eee *edata) +{ ... ... +int cpsw_set_eee(struct net_device *ndev, struct ethtool_eee *edata) ... Regards, Rami Rosen

Re: [PATCH] iproute2: Nr. of packets and octets for macsec tx stats were swapped.

2016-11-22 Thread Rami Rosen
Hi, Daniel Acked-by: Rami Rosen Agreed about Sabrina comments about adding iproute2 and about the newlines. Regards, R

Re: ip -s macsec show: Statistics for OutOctets... and OutPkts... switched

2016-11-21 Thread Rami Rosen
+1 Rami Rosen

Re: [PATCH] netns: fix get_net_ns_by_fd(int pid) typo

2016-11-18 Thread Rami Rosen
On 18 November 2016 at 11:41, Stefan Hajnoczi wrote: > The argument to get_net_ns_by_fd() is a /proc/$PID/ns/net file > descriptor not a pid. Fix the typo. > Acked-by: Rami Rosen

Re: [PATCH v4 01/10] ethernet: add sun8i-emac driver

2016-10-23 Thread Rami Rosen
> + u64 tx_used_desc; > + u64 napi_schedule; > + u64 napi_underflow; > +}; > + Trivial: typo, should be: can transfer > +/* The datasheet said that each descriptor can transfers up to 4096bytes > + * But latter, a register documentation reduce that value to 2048 Regards, Rami Rosen

Re: [PATCH net] xfrm: Fix memory leak of aead algorithm name

2016-09-18 Thread Rami Rosen
Acked-by: Rami Rosen On 18 September 2016 at 10:42, Ilan Tayari wrote: > commit 1a6509d99122 ("[IPSEC]: Add support for combined mode algorithms") > introduced aead. The function attach_aead kmemdup()s the algorithm > name during xfrm_state_construct(). > However this

Re: [PATCH v4 2/6] cgroup: add support for eBPF programs

2016-09-06 Thread Rami Rosen
/egress) ... > +void __cgroup_bpf_update(struct cgroup *cgrp, > +struct cgroup *parent, > +struct bpf_prog *prog, > +enum bpf_attach_type type) > +{ Regards, Rami Rosen

Re: [PATCH net-next] rtnetlink: fdb dump: optimize by saving last interface markers

2016-09-02 Thread Rami Rosen
Hi Eric, Nice catch! This warning does not occur under certain gcc versions. For example, gcc 4.8.4 (ubuntu 14.04); it does occur, for example, under gcc 5.3.1 for example (Fedora 24). I just sent a patch to fix this. Regards, Rami Rosen

[PATCH net-next] switchdev: Fix return value of switchdev_port_fdb_dump().

2016-09-02 Thread Rami Rosen
warning is due to commit d297653dd6f07afbe7e6c702a4bcd7615680002e ("rtnetlink: fdb dump: optimize by saving last interface markers"). Signed-off-by: Rami Rosen --- include/net/switchdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/switchdev.h b/inc

Re: [PATCH] [v9] net: emac: emac gigabit ethernet controller driver

2016-08-27 Thread Rami Rosen
e and tx_mcast_byte are not used. > + u64 tx_bcast_byte; /* broadcast packets byte count (without FCS) > */ > + u64 tx_mcast_byte; /* multicast packets byte count (without FCS) > */ Thanks for your good work, it seems that the driver is almost done! Regards, Rami Rosen

Re: [PATCH v3 0/6] Add eBPF hooks for cgroups

2016-08-27 Thread Rami Rosen
ax cc list length for patches). Regards, Rami Rosen On 26 August 2016 at 22:58, Daniel Mack wrote: > This is v3 of the patch set to allow eBPF programs for network > filtering and accounting to be attached to cgroups, so that they apply > to all sockets of all tasks placed in that cgr

[PATCH] net: ena: change the return type of ena_set_push_mode() to be void.

2016-08-23 Thread Rami Rosen
This patch changes the return type of ena_set_push_mode() to be void, as it always returns 0. Signed-off-by: Rami Rosen --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c

Re: [ethtool PATCH v1 2/2] ethtool:QSFP Plus/QSFP28 Diagnostics Information Support

2016-06-26 Thread Rami Rosen
. A valid temperature reading > +* is used as existence for TX/RX power. Should it be: SFF-8472/8079 (without "$")? > + * > + * Common utilities across SFF-8436/8636 and SFF-8472/8079$ > + * are defined in this file > + * Regards, Rami Rosen

Re: [PATCH iproute2 net-next v4 0/5] bridge: json support for fdb and vlan show

2016-06-24 Thread Rami Rosen
rking stack control plane. And it seems that Rest API and JSON (and maybe other APIs, like python based APIs) are natural candidates for such an interface nowadays. Regards, Rami Rosen http://ramirose.wix.com/ramirosen

[PATCH net-next] i40e: remove broken link.

2016-02-20 Thread Rami Rosen
This patch removes a broken link from Documentation/networking/i40e.txt. Signed-off-by: Rami Rosen --- Documentation/networking/i40e.txt | 9 - 1 file changed, 9 deletions(-) diff --git a/Documentation/networking/i40e.txt b/Documentation/networking/i40e.txt index a251bf4..09f8f3b

[PATCH net-next] core: remove unneded headers for net cgroup controllers.

2016-02-14 Thread Rami Rosen
commit 3ed80a6 (cgroup: drop module support) made including module.h redundant in the net cgroup controllers, netclassid_cgroup.c and netprio_cgroup.c. This patch removes them. Signed-off-by: Rami Rosen --- net/core/netclassid_cgroup.c | 1 - net/core/netprio_cgroup.c| 1 - 2 files

[PATCH net-next v2] bridge: Fix setting a flag in br_fill_ifvlaninfo_range().

2015-07-21 Thread Rami Rosen
_END assignement. Signed-off-by: Rami Rosen --- net/bridge/br_netlink.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index 364bdc9..793d247 100644 --- a/net/bridge/br_netlink.c +++ b/net/bridge/br_netlink.c @@ -164,8 +164,6 @@ static

Re: [PATCH v6] NET: Add ezchip ethernet driver

2015-06-22 Thread Rami Rosen
info(dev, "(rx/tx=%d)\n", priv->irq); + return 0; + +out_netif_api: + netif_napi_del(&priv->napi); +out_netdev: + if (err) + free_netdev(ndev); + + return err; +} Regards, Rami Rosen -- To unsubscribe from this list: send the line "unsubscribe netdev" in

Re: [PATCH net-next] bridge: del external_learned fdbs from device on flush or ageout

2015-06-14 Thread Rami Rosen
Hi, I will try to find time, will notify you if starting work on it ;) Regards, Rami Rosen -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH net-next] bridge: del external_learned fdbs from device on flush or ageout

2015-06-14 Thread Rami Rosen
Hi, You mention bridge doing ageing vs. device doing ageing. AFAIK, there is no way to prevent a bridge from doing aging by a sysfs entry. Do you think that preventing bridge aging via sysfs is needed? Regards, Rami Rosen -- To unsubscribe from this list: send the line "unsubscribe netde

[PATCH] [NETLABEL] Minor cleanup: remove unused method definition

2008-02-19 Thread Rami Rosen
Hi, This patch removes definition of netlbl_cfg_cipsov4_del() method in netlabel/netlabel_kapi.c and in include/net/netlabel.h as it is not used. Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/include/net/netlabel.h b/include/net/netlabel.h index 0

[PATCH] [IPV6] Minor cleanup: remove unused method declaration (net/ndisc.h).

2008-02-10 Thread Rami Rosen
Hi, This patch removes unused declaration of dflt_rt_lookup() method in include/net/ndisc.h Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/include/net/ndisc.h b/include/net/ndisc.h index 6684f7e..59b7062 100644 --- a/include/net/ndisc.h +++ b/inclu

[PATCH] [NETNS] Remove unused member (dst_net) of dst_ops.

2008-02-08 Thread Rami Rosen
Hi, This patches removes dst_net member (a pointer to struct net) of dst_ops (/include/net/dst.h). Current network namespace implementation does not use it at all. Denis - any comments ? Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff -

[PATCH] [IPV6] Replace using the magic constant "1024" with IP6_RT_PRIO_USER for fc_metric.

2008-02-08 Thread Rami Rosen
Hi, This patch replaces the explicit usage of the magic constant "1024" with IP6_RT_PRIO_USER in the IPV6 tree. Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 513f72e..6e7b56e 100644 --- a/net/ipv6/r

[PATCH] [IPV6] Minor cleanup: remove unused definitions in net/ip6_fib.h

2008-02-07 Thread Rami Rosen
Hi, This patch removes some unused definitions and one method typedef declaration (f_pnode) in include/net/ip6_fib.h, as they are not used in the kernel. Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/include/net/ip6_fib.h b/include/net/ip6_fib.h index d

[PATCH] [IPV6] Minor clenup: remove two unused definitions in net/ip6_route.h

2008-02-07 Thread Rami Rosen
Hi, Remove IP6_RT_PRIO_FW and IP6_RT_FLOW_MASK definitions in include/net/ip6_route.h, as they are not used in the kernel. Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h index faac0ee..f99e4f0 100644 --- a/i

[PATCH] [PPPOL2TP] Label unused warning when CONFIG_PROC_FS is not set.

2008-02-05 Thread Rami Rosen
is warning by adding appropriate #ifdef. Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/drivers/net/pppol2tp.c b/drivers/net/pppol2tp.c index 1b51bb6..5aa0a80 100644 --- a/drivers/net/pppol2tp.c +++ b/drivers/net/pppol2tp.c @@ -2468,9 +2468,10 @@ static int

Re: 2.6.24-mm1 - Build failure at net/sched/cls_flow.c:598

2008-02-04 Thread Rami Rosen
Hello, I had sent a patch recently (which is currently pending) which solves this problem. see: http://www.spinics.net/lists/netdev/msg54455.html Regards, Rami Rosen On Feb 5, 2008 1:25 AM, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 04 Feb 2008 23:32:49 +0100 > Ti

Fwd: [PATCH] [NET_SCHED] Add #ifdef CONFIG_NET_EMATCH in net/sched/cls_flow.c (latest git broken build)

2008-02-03 Thread Rami Rosen
-- Forwarded message -- From: Rami Rosen <[EMAIL PROTECTED]> Date: Feb 3, 2008 10:51 AM Subject: [PATCH] [NET_SCHED] Add #ifdef CONFIG_NET_EMATCH in net/sched/cls_flow.c (latest git broken build) To: David Miller <[EMAIL PROTECTED]>, [EMAIL PROTECTED], [EMAIL PROTEC

[PATCH net-2.6.25] [MACVLAN] Setting macvlan_handle_frame_hook to NULL when rtnl_link_register() fails.

2008-01-29 Thread Rami Rosen
, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 6ef6b8b..f651a81 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -508,7 +508,7 @@ static int __init macvlan_init_module(void) got

[PATCH net-2.6.25] [NETNS] change net/Kconfig to avoid a broken build when building with network namesapce support.

2008-01-29 Thread Rami Rosen
ies in net/Kconfig. This way, if CONFIG_RCU_TRACE is set, ( or other configuration items which selects DEBUG_FS), we cannot set CONFIG_NET_NS. Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/net/Kconfig b/net/Kconfig index b6a5d45..82337e2 100644 --- a/net

[PATCH net-2.6.25] [PKTGEN] Remove an unused definition in pktgen.c.

2008-01-23 Thread Rami Rosen
/archives/netdev/2002-09/msg00184.html Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/net/core/pktgen.c b/net/core/pktgen.c index eebccdb..b7f2de1 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -170,8 +170,6 @@ #define VERSION "pktgen v2

[PATCH net-2.6.25] [XFRM] Remove unneeded export of xfrm_output_resume() and remove its declaration from net/xfrm.h.

2008-01-19 Thread Rami Rosen
Hi, The method xfrm_output_resume() is used only in net/xfrm/xfrm_output.c. This patch removes using unneeded EXPORT_SYMBOL_GPL to export it in net/xfrm/xfrm_output.c and also removes its declaration in net/xfrm.h. Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff -

[PATCH net-2.6.25] [BRIDGE] Remove unused include of a header file in ebtables.c

2008-01-18 Thread Rami Rosen
Hi, In net/bridge/netfilter/ebtables.c, - remove unused include of a header file (linux/tty.h) and remove the corresponding comment above it. Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/net

[PATCH net-2.6.25] [XFRM] Remove unused definition XFRM_POLICY_LOCALOK in linux/xfrm.h + typos in net/xfrm.h

2008-01-15 Thread Rami Rosen
Hi, - XFRM_POLICY_LOCALOK in linux/xfrm.h is unused definition. - correct 4 typos in net/xfrm.h Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/include/linux/xfrm.h b/include/linux/xfrm.h index 9b5b00c..f5cfb75 100644 --- a/include/linux/xfrm.h +++ b/include

[PATCH net-2.6.25] [XFRM] Remove unused XFRM_STATE_VOID and typos (net/xfrm.h)

2008-01-12 Thread Rami Rosen
Hi, In net/xfrm.h: - remove XFRM_STATE_VOID (not in use) - correct 3 typos Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/include/net/xfrm.h b/include/net/xfrm.h index 860fe4a..432c5c8 100644 --- a/include/net/xfrm.h +++ b/include/net/xfrm.h @@

[PATCH net-2.6.25] [IPVS] Added include for ip_vs.h for ctl_path (build was broken)

2008-01-09 Thread Rami Rosen
ctl_path. This patch added #include to ip_vs_.h to avoid it Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h index 02ab7ca..56f3c94 100644 --- a/include/net/ip_vs.h +++ b/include/net/ip_vs.h @@ -9,

[PATCH net-2.6.25] [BRIDGE] Remove unused macros from ebt_vlan.c

2008-01-08 Thread Rami Rosen
Hi, Remove two unused macros, INV_FLAG and SET_BITMASK from net/bridge/netfilter/ebt_vlan.c. Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/net/bridge/netfilter/ebt_vlan.c b/net/bridge/netfilter/ebt_vlan.c index a43c697..0ddf749 100644 --- a/net/

[PATCH net-2.6.25] [IPV4] Remove unused member of dst_entry

2008-01-06 Thread Rami Rosen
Hi, The info placeholder member of dst_entry seems to be unused in the network stack. Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/include/net/dst.h b/include/net/dst.h index 31468c9..e03ea0c 100644 --- a/include/net/dst.h +++ b/inclu

[PATCH net-2.6.25] [IPV4] Remove unsupported DNAT (RTCF_NAT and RTCF_NAT) in IPV4

2008-01-02 Thread Rami Rosen
Hi, - The DNAT (Destination NAT) is not implemented in IPV4. - This patch remove the code which checks these flags in net/ipv4/arp.c and net/ipv4/route.c. The RTCF_NAT and RTCF_NAT should stay in the header (linux/in_route.h) because they are used in DECnet. Regards, Rami Rosen Signed-off-by

Re: [PATCH net-2.6.25] [BRIDGE] Remove useless code in net/bridge/br_netfilter.c

2008-01-01 Thread Rami Rosen
And I missed the intention here. It could be implemnted differently but since it not marked as superfluous anywhere I suggest to leave it as it is. Sorry, Regards, Rami Rosen On Jan 2, 2008 7:20 AM, David Miller <[EMAIL PROTECTED]> wrote: > From: "Rami Rosen" <[EMAIL P

[PATCH net-2.6.25] [BRIDGE] Remove useless code in net/bridge/br_netfilter.c

2008-01-01 Thread Rami Rosen
rds, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/net/bridge/br_netfilter.c b/net/bridge/br_netfilter.c index 32ac035..288e102 100644 --- a/net/bridge/br_netfilter.c +++ b/net/bridge/br_netfilter.c @@ -664,8 +664,6 @@ static unsigned int br_nf_forward_arp(unsigned

[PATCH net-2.6.25] [IPV4] Remove declaration of unimplemented method and remove unused definition from include/net/ip_vs.h

2008-01-01 Thread Rami Rosen
Hi, In include/net/ip_vs.h: - The ip_vs_secure_tcp_set() method is not implemented anywhere. - IP_VS_APP_TYPE_FTP is an unused definition. Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h index 8a7d59b..3de6d1e

[PATCH net-2.6.25] [IPV4] Remove three declarations of unimplemented methods and correct a typo in include/net/ip.h

2008-01-01 Thread Rami Rosen
his header. Regards, Rami Rosen Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/include/net/ip.h b/include/net/ip.h index 5fab3a1..8be48c8 100644 --- a/include/net/ip.h +++ b/include/net/ip.h @@ -82,8 +82,6 @@ struct packet_type; struct rtable; struct sockaddr

[PATCH net-2.6.25] [IPV4] Remove unused multipath cached routing defintion in net/flow.h

2007-12-31 Thread Rami Rosen
Hi, The FLOWI_FLAG_MULTIPATHOLDROUTE definition in include/net/flow.h is an unused definition. It belongs to IPV4 multipath cached routing support, which has been dropped recently for 2.6.23 kernel (July 2007). Regards, Rami Rosen http://www.linux-foundation.org/en

[PATCH net-2.6.25] [NEIGH] Remove unused method from include/net/neighbour.h

2007-12-28 Thread Rami Rosen
o consider removing the neigh_is_valid() method. Regards, Rami Rosen http://www.linux-foundation.org/en/Net:Network_Overview Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/include/net/neighbour.h b/include/net/neighbour.h index 11590f2..a9dda29 100644 --- a/include/net/neighbour

[PATCH net-2.6.25] [IPv4] Remove unused define in include/net/arp.h (HAVE_ARP_CREATE)

2007-12-28 Thread Rami Rosen
Hello, It seems to me that the HAVE_ARP_CREATE (empty) definition, from include/net/arp.h, can be removed, since it is not used anywhere in the kernel. Regards, Rami Rosen http://www.linux-foundation.org/en/Net:Network_Overview Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> diff --git a/i

Re: [PATCH] [IPv4] Reply net unreachable ICMP message

2007-12-06 Thread Rami Rosen
; e_inval: err = -EINVAL; e_nobufs: err = -ENOBUFS; So I don't think anything is incorrect here. Regards, Rami Rosen On Dec 6, 2007 9:49 AM, Jarek Poplawski <[EMAIL PROTECTED]> wrote: > > On 06-12-2007 07:31, Mitsuru Chinen wrote: > > IPv4 stack d

Re: Get the IP address of an interface with a given name

2007-11-20 Thread Rami Rosen
if_info->ifa_address=%x\n",if_info->ifa_address); break; } } Yous should of course add check for NULL, etc. Regards, Rami Rosen On Nov 20, 2007 10:09 AM, Giacomo <[EMAIL PROTECTED]> wrote: > Good morning. > > I have written a

Re: IPSec on Linux Kernel

2007-09-27 Thread Rami Rosen
Hi,Fabio, - Assuming that you intend to deal with IPV4, I suggest that you will start by looking at the ah4.ko module sources, which are in net/ipv4/ah.c, especially at the ah_output() and the ah_input() methods. (for ipv6 there are the ah6.c in net/ipv6). - May I ask: are you aware that the A

[RFC][PATCH] Removal of FASTROUTE definition include/linux/if_packet.h

2007-08-02 Thread Rami Rosen
Hi, It seems that PACKET_FASTROUTE definition should be removed due to that fastroute is no longer supported. Regards, Rami Rosen -- Signed-off-by: Rami Rosen <[EMAIL PROTECTED]> --- linux-2.6.23-rc1-clean/include/linux/if_packet.h2007-05-03 12:07:59.000

Re: [linux-usb-devel] [PATCH RFC] ZyDAS ZD1211 USB-WLAN driver

2006-06-04 Thread Rami Rosen
E2P_48M_INT_VALUE1 E2P_48M_INT_VALUE2 E2P_48M_INT_VALUE3 E2P_48M_INT_VALUE4 E2P_54M_CAL_VALUE2 E2P_54M_CAL_VALUE3 E2P_54M_CAL_VALUE4 E2P_54M_INT_VALUE1 E2P_54M_INT_VALUE2 E2P_54M_INT_VALUE3 E2P_54M_INT_VALUE4 FW_SOFT_RESET FW_FLASH_CHK Regards, Rami Rosen On 6/4/06, Oliver Neukum <[EM