Re: [PATCH 20/21] phonet: exit_net cleanup check added

2017-11-05 Thread Rémi Denis-Courmont
Le 5 novembre 2017 12:02:34 GMT+02:00, Vasily Averin a écrit : >Be sure that pndevs.list initialized in net_init hook was return >to initial state. > >Signed-off-by: Vasily Averin >--- > net/phonet/pn_dev.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/net/phonet/pn_dev.c b/net/phonet

Re: [PATCH v2 1/2] net: phonet: mark header_ops as const

2017-09-30 Thread Rémi Denis-Courmont
.create = pn_header_create, > .parse = pn_header_parse, > }; Acked-by: Rémi Denis-Courmont -- Rémi Denis-Courmont

Re: [PATCH net-next v2 7/9] net: use core MTU range checking in misc drivers

2016-10-20 Thread Rémi Denis-Courmont
Acked-by: Rémi Denis-Courmont -- Rémi Denis-Courmont http://www.remlab.net/CV.pdf

Re: [PATCH] Make sure sockets implement splice_read

2008-02-15 Thread Rémi Denis-Courmont
ce from a non-TCP socket. > >> > >> Signed-off-by: Rémi Denis-Courmont <[EMAIL PROTECTED]> > > > > Applied, thank you. > > That's also a stable candidate, isn't it? Should go to 2.6.25-rc2, but the offending code is not in any stable release.

[PATCH] Make sure sockets implement splice_read

2008-02-14 Thread Rémi Denis-Courmont
Fixes a segmentation fault when trying to splice from a non-TCP socket. Signed-off-by: Rémi Denis-Courmont <[EMAIL PROTECTED]> --- net/socket.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/net/socket.c b/net/socket.c index 7651de0..b6d35cd 100644 --- a/net/so

Re: [PATCH] IPv6: ipv6_addr_type() doesn't know about RFC4193 addresses

2007-07-26 Thread Rémi Denis-Courmont
t & htonl(0xFE00)) == htonl(0xFC00)) > > + return (IPV6_ADDR_UNICAST | > > + IPV6_ADDR_SCOPE_TYPE(IPV6_ADDR_SCOPE_GLOBAL)); > > /* RFC 4193 */ > > But ULA's scope isn't global, shouldn't it be IPV6_ADDR_SCOP

Re: No cmsg for SOCK_STREAM?

2007-07-14 Thread Rémi Denis-Courmont
er-packet is only defined for DGRAM and RAW sockets. You have to raw sockets, or better yet, BPF to do this. -- Rémi Denis-Courmont http://www.remlab.net/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread Rémi Denis-Courmont
lt, the next unsolicited RA can be anytime from now to after 10 minutes, so that's not sufficient. I wouldn't personnaly care, but... -- Rémi Denis-Courmont http://www.remlab.net/ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a messag

Re: [PATCH] IPv6: optionaly validate RAs on raw sockets

2007-07-11 Thread Rémi Denis-Courmont
may end up accepting something when it should not). I might be missing something because I am a notoriously arrogant moron but it looks like Linux IPv6 is in a dead-end for the time being :-( What do you propose then? -- Rémi Denis-Courmont - To unsubscribe from this list: send the line "

[PATCH net-2.6.23 take 3] Per-datagram TTL and TOS via sendmsg()

2007-07-08 Thread Rémi Denis-Courmont
IPV6_TCLASS). Signed-off-by: Rémi Denis-Courmont <[EMAIL PROTECTED]> diff --git a/include/net/inet_sock.h b/include/net/inet_sock.h index 62daf21..7a6dc33 100644 --- a/include/net/inet_sock.h +++ b/include/net/inet_sock.h @@ -140,6 +140,8 @@ struct inet_sock {

[PATCH net-2.6.23 take 2] Per-datagram TTL and TOS via sendmsg()

2007-07-08 Thread Rémi Denis-Courmont
IPV6_TCLASS). Signed-off-by: Rémi Denis-Courmont <[EMAIL PROTECTED]> diff --git a/include/net/inet_sock.h b/include/net/inet_sock.h index 62daf21..7a6dc33 100644 --- a/include/net/inet_sock.h +++ b/include/net/inet_sock.h @@ -140,6 +140,8 @@ struct inet_sock { int

[PATCH] Fix handling of IPv6 RH with 0 segments left

2007-07-07 Thread Rémi Denis-Courmont
->pkt_type != PACKET_HOST) { + IP6_INC_STATS_BH(ip6_dst_idev(skb->dst), +IPSTATS_MIB_INADDRERRORS); + kfree_skb(skb); + return -1; } /* -- 1.5.2.3 -- Rémi Denis-Courmont http://www.remlab.net/ - To

[PATCH net-2.6.23] Per-datagram TTL and TOS via sendmsg()

2007-07-07 Thread Rémi Denis-Courmont
This patch adds support for specifying IPv4 Time-To-Live (IP_TTL) and/or Type-Of-Service (IP_TOS) values on a per datagram basis through sendmsg() ancilliary data. Until then, it only worked for IPv6 sockets (using IPV6_HOPLIMIT and IPV6_TCLASS). Signed-off-by: Rémi Denis-Courmont <[EM

Re: [PATCH net-2.6.23 take2] UDP: Cleanup UDP encapsulation code

2007-07-06 Thread Rémi Denis-Courmont
On Thursday 05 July 2007 20:25:50 ext James Chapman wrote: > Rémi Denis-Courmont wrote: > > By the way, couldn't encap_type be remove altogether (using two slightly > > different callbacks for ESP) from udp_sock? > > The notion of encap_type is needed for the setsockopt

Re: [PATCH net-2.6.23 take2] UDP: Cleanup UDP encapsulation code

2007-07-05 Thread Rémi Denis-Courmont
pdate after comments from Patrick. Fix encapsulated transport mode > > case and remove stupid file history comment change. > > Looks good, thanks. By the way, couldn't encap_type be remove altogether (using two slightly different callbacks for ESP) from udp_sock? -- Rémi Denis-Courmont signature.asc Description: This is a digitally signed message part.

Re: [RFD] First draft of RDNSS-in-RA support for IPv6 DNS autoconfiguration

2007-06-23 Thread Rémi Denis-Courmont
udge would be to send a RS from userland, but that's not so great considering routers are rate-limiting their RAs. The only way is for the kernel to remember "something" about the last processed RA. That disqualifies raw ICMPv6 sockets. -- Rémi Denis-Courmont http://www.remlab.net/ signature.asc Description: This is a digitally signed message part.

Re: [RFD] First draft of RDNSS-in-RA support for IPv6 DNS autoconfiguration

2007-06-23 Thread Rémi Denis-Courmont
needed to parse DNS messages by itself. My point is raw IPv6 sockets are not usable for the time being, and I do not see anyway to fix without modifying the kernel. The userspace DNS configuration daemon might need to be started later than the kernel autoconf - another issue that needs help fro

Re: [RFD] First draft of RDNSS-in-RA support for IPv6 DNS autoconfiguration

2007-06-23 Thread Rémi Denis-Courmont
herwise, I don't believe you > have to do anything but read the socket and process the RDNS header > on RAs you receive. To reiterate: How do I authenticate SeND RA? How do I deal with the link going down before the expiration? How do I know "this" interface is doing autoconf

Re: [RFD] First draft of RDNSS-in-RA support for IPv6 DNS autoconfiguration

2007-06-23 Thread Rémi Denis-Courmont
the kernel does not provide any interface for userland to do it properly at the moment. -- Rémi Denis-Courmont http://www.remlab.net/ signature.asc Description: This is a digitally signed message part.

Re: Fw: [Bugme-new] [Bug 7665] New: getsockopt(IPV6_*CAST_HOPS) returns -1

2006-12-12 Thread Rémi Denis-Courmont
ing your patch would fix much more apps than it is going to break. Hopefully those not handling -1 will somehow cast it to 255 if it is ever re-used, but I can also imagine some broken SDP-or-similar with "/-1" or "/4294967295" as a hop limit. Thanks, -- Rémi Denis-Courmont

Re: Fw: [Bugme-new] [Bug 7665] New: getsockopt(IPV6_*CAST_HOPS) returns -1

2006-12-12 Thread Rémi Denis-Courmont
ve, but at least the two other cases should be ok, particularly the last one. -- Rémi Denis-Courmont - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] Accept -1 for IPV6_TCLASS

2006-09-03 Thread Rémi Denis-Courmont
@@ case IPV6_TCLASS: val = np->tclass; + if (val < 0) + val = 0; break; case IPV6_RECVTCLASS: -- Rémi Denis-Courmont http://www.remlab.net/ -- VGER BF report: U 0.93636 - To unsubscribe from this list: se