[PATCH net-next] net: dsa: b53: spi: add missing MODULE_DEVICE_TABLE

2021-03-25 Thread Qinglang Miao
This patch adds missing MODULE_DEVICE_TABLE definition which generates correct modalias for automatic loading of this driver when it is built as an external module. Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/net/dsa/b53/b53_spi.c | 1 + 1 file changed, 1 insertion

[PATCH] can: mcp251xfd: fix wrong check in mcp251xfd_handle_rxif_one

2021-01-12 Thread Qinglang Miao
If alloc_canfd_skb returns NULL, 'cfg' is an uninitialized variable, so we should check 'skb' rather than 'cfd' after calling alloc_canfd_skb(priv->ndev, &cfd). Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN") Sig

Re: [v2] net: qrtr: fix null pointer dereference in qrtr_ns_remove

2021-01-06 Thread Qinglang Miao
在 2021/1/6 16:09, Markus Elfring 写道: A null-ptr-deref bug is reported by Hulk Robot like this: Can it be clearer to use the term “null pointer dereference” for the final commit message? This advice is too detailed for 'null-ptr-deref' is known as a general phrase This key word was provid

Re: [PATCH v2] net: qrtr: fix null pointer dereference in qrtr_ns_remove

2021-01-05 Thread Qinglang Miao
Hi Markus, I'd like to take some of your advice in this patch, but I noticed that this one has been applied. Some of your advice would be considered kindly on my future work. Thanks. 在 2021/1/5 21:14, Markus Elfring 写道: A null-ptr-deref bug is reported by Hulk Robot like this: Can it be c

Re: [PATCH] net: qrtr: fix null-ptr-deref in qrtr_ns_remove

2021-01-04 Thread Qinglang Miao
I sent a v2 on this one because of the redundant braces in qrtr_proto_init, sorry for the noise. 在 2021/1/5 10:40, Qinglang Miao 写道: A null-ptr-deref bug is reported by Hulk Robot like this: -- KASAN: null-ptr-deref in range [0x0128-0x012f] Call Trace

[PATCH v2] net: qrtr: fix null-ptr-deref in qrtr_ns_remove

2021-01-04 Thread Qinglang Miao
qrtr_proto_init. Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- v1->v2: remove redundant braces for single statement blocks. net/qrtr/ns.c | 7 --- net/qrtr/qrtr.c | 16 +++- net/qrtr/qrtr.h | 2 +- 3 files changed, 16 insertions(+), 9 deletions(-) diff --git a/net/q

[PATCH] net: qrtr: fix null-ptr-deref in qrtr_ns_remove

2021-01-04 Thread Qinglang Miao
qrtr_proto_init. Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- net/qrtr/ns.c | 7 --- net/qrtr/qrtr.c | 14 +++--- net/qrtr/qrtr.h | 2 +- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/net/qrtr/ns.c b/net/qrtr/ns.c index 56aaf8cb6..8d00dfe81 100644 --- a

[PATCH] net: cw1200: fix missing destroy_workqueue() on error in cw1200_init_common

2020-11-18 Thread Qinglang Miao
Add the missing destroy_workqueue() before return from cw1200_init_common in the error handling case. Fixes:a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") Reported-by: Hulk Robot Signed-off-by: Qinglang Miao --- drivers/net/wireless/st/cw1200/ma

[PATCH -next] connector: simplify the return expression of cn_add_callback()

2020-09-21 Thread Qinglang Miao
Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/connector/connector.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/connector/connector.c b/drivers/connector/connector.c index 2d22d6bf5..7d59d18c6 100644 --- a/drivers/connector

[PATCH -next] net/mlx5: simplify the return expression of mlx5_ec_init()

2020-09-21 Thread Qinglang Miao
Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/net/ethernet/mellanox/mlx5/core/ecpf.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/ecpf.c b/drivers/net/ethernet/mellanox/mlx5/core/ecpf.c index

[PATCH -next] mlxsw: spectrum_acl_tcam: simplify the return expression of ishtp_cl_driver_register()

2020-09-21 Thread Qinglang Miao
Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_acl_tcam.c b/drivers/net/ethernet/mellanox/mlxsw

[PATCH -next] enetc: simplify the return expression of enetc_vf_set_mac_addr()

2020-09-21 Thread Qinglang Miao
Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/net/ethernet/freescale/enetc/enetc_vf.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/freescale/enetc/enetc_vf.c b/drivers/net/ethernet/freescale/enetc/enetc_vf.c index

[PATCH -next] mlxsw: spectrum_router: simplify the return expression of __mlxsw_sp_router_init()

2020-09-21 Thread Qinglang Miao
Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw

[PATCH -next] net: qlcnic: simplify the return expression of qlcnic_83xx_shutdown

2020-09-21 Thread Qinglang Miao
Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c b/drivers/net/ethernet/qlogic/qlcnic

[PATCH -next] ice: simplify the return expression of ice_finalize_update()

2020-09-21 Thread Qinglang Miao
Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/net/ethernet/intel/ice/ice_fw_update.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_fw_update.c b/drivers/net/ethernet/intel/ice/ice_fw_update.c index

[PATCH -next] net: hns3: simplify the return expression of hclgevf_client_start()

2020-09-21 Thread Qinglang Miao
Signed-off-by: Qinglang Miao --- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c b/drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c index

[PATCH -next] zd1201: simplify the return expression of zd1201_set_maxassoc()

2020-09-21 Thread Qinglang Miao
Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/net/wireless/zydas/zd1201.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/wireless/zydas/zd1201.c b/drivers/net/wireless/zydas/zd1201.c index 41641fc2b..718c4ee86 100644 --- a

[PATCH -next] chelsio: simplify the return expression of t3_ael2020_phy_prep()

2020-09-21 Thread Qinglang Miao
Simplify the return expression. Signed-off-by: Qinglang Miao --- drivers/net/ethernet/chelsio/cxgb3/ael1002.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb3/ael1002.c b/drivers/net/ethernet/chelsio/cxgb3/ael1002.c index dadf11e3d

[PATCH -next v2] mt7601u: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- .../net/wireless/mediatek/mt7601u/debugfs.c | 34 --- 1 file changed, 6 insertions(+), 28 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt7601u/debugfs.c b/drivers/net/wireless

[PATCH -next v2] mt76: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- .../wireless/mediatek/mt76/mt7603/debugfs.c | 18 +++--- .../wireless/mediatek/mt76/mt7615/debugfs.c | 17 ++ .../wireless/mediatek/mt76/mt76x02_debugfs.c | 34 --- 3 files

[PATCH -next v2] dpaa2-eth: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-17 Thread Qinglang Miao
Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. .../freescale/dpaa2/dpaa2-eth-debugfs.c | 63 ++- 1 file changed, 6 insertions(+), 57 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2

[PATCH -next v2] net: hsr: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-17 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. net/hsr/hsr_debugfs.c | 21 ++--- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/net/hsr

[PATCH -next] dpaa2-eth: Convert to DEFINE_SHOW_ATTRIBUTE

2020-07-16 Thread Qinglang Miao
From: Yongqiang Liu Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yongqiang Liu --- .../freescale/dpaa2/dpaa2-eth-debugfs.c | 63 ++- 1 file changed, 6 insertions(+), 57 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth-debug

[PATCH -next] hsr: Convert to DEFINE_SHOW_ATTRIBUTE

2020-07-16 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- net/hsr/hsr_debugfs.c | 20 ++-- 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/net/hsr/hsr_debugfs.c b/net/hsr/hsr_debugfs.c index d994c83b0..ed7f53475 100644 --- a/net/hsr