Re: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

2021-03-16 Thread Punit Agrawal
Hi Greg, Greg KH writes: > On Thu, Feb 25, 2021 at 09:54:06AM +0900, Punit Agrawal wrote: >> From: Corinna Vinschen >> >> commit 2643e6e90210e16c978919617170089b7c2164f7 upstream >> >> TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP >

[PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

2021-02-24 Thread Punit Agrawal
From: Corinna Vinschen commit 2643e6e90210e16c978919617170089b7c2164f7 upstream TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000 secs on 80576 (45 bit SYSTIM). This wrap event sets the TSICR.SysWrap bit uncondi

Re: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

2021-02-24 Thread Punit Agrawal
Jakub Kicinski writes: > On Wed, 24 Feb 2021 11:28:59 +0900 Punit Agrawal wrote: >> > It makes sense to me for htis to apply to those stable trees as well. >> >> Thanks Jake. >> >> Networking maintainers - It's been a couple of weeks this patch is on

Re: [PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

2021-02-23 Thread Punit Agrawal
[ * dropping Jeff Kirsher as his email is bouncing * Adding networking maintainers ] "Keller, Jacob E" writes: >> -Original Message- >> From: Punit Agrawal >> Sent: Tuesday, February 09, 2021 5:35 PM >> To: netdev@vger.kernel.org >> C

[PATCH v4.4.y, v4.9.y] igb: Remove incorrect "unexpected SYS WRAP" log message

2021-02-09 Thread Punit Agrawal
From: Corinna Vinschen commit 2643e6e90210e16c978919617170089b7c2164f7 upstream TSAUXC.DisableSystime is never set, so SYSTIM runs into a SYS WRAP every 1100 secs on 80580/i350/i354 (40 bit SYSTIM) and every 35000 secs on 80576 (45 bit SYSTIM). This wrap event sets the TSICR.SysWrap bit uncondi

Re: [PATCH] e1000e: Relax condition to trigger reset for ME workaround

2020-05-21 Thread Punit Agrawal
Hi Aaron, "Brown, Aaron F" writes: >> From: netdev-ow...@vger.kernel.org On >> Behalf Of Punit Agrawal >> Sent: Thursday, May 14, 2020 9:31 PM >> To: Kirsher, Jeffrey T >> Cc: daniel.sangor...@toshiba.co.jp; Punit Agrawal >> ; Alexand

[PATCH] e1000e: Relax condition to trigger reset for ME workaround

2020-05-14 Thread Punit Agrawal
. The extra condition can lead to inconsistency between the state of hardware as expected by the driver. Fix this by dropping the check for number of delay iterations. While at it, also make __ew32_prepare() static as it's not used anywhere else. Signed-off-by: Punit Agrawal Reviewed-by: Alexa

Re: [RFC] e1000e: Relax condition to trigger reset for ME workaround

2020-05-14 Thread Punit Agrawal
Alexander Duyck writes: > On Mon, May 11, 2020 at 9:45 PM Punit Agrawal > wrote: >> >> It's an error if the value of the RX/TX tail descriptor does not match >> what was written. The error condition is true regardless the duration >> of the interference from

[RFC] e1000e: Relax condition to trigger reset for ME workaround

2020-05-11 Thread Punit Agrawal
extra condition can lead to inconsistency between the state of hardware as expected by the driver. Fix this by dropping the check for number of delay iterations. Signed-off-by: Punit Agrawal Cc: Jeff Kirsher Cc: "David S. Miller" Cc: intel-wired-...@lists.osuosl.org Cc: netdev@vge