Re: [5/5] e1000e: Avoid receiver overrun interrupt bursts

2017-10-24 Thread Philip Prindeville
> On Oct 24, 2017, at 11:20 AM, Lennart Sorensen > wrote: > > On Tue, Sep 19, 2017 at 09:41:02PM +0200, Benjamin Poirier wrote: >> On 2017/09/19 12:38, Philip Prindeville wrote: >>> Hi. >>> >>> We’ve been running this patchset (all 5) for about as

Re: [5/5] e1000e: Avoid receiver overrun interrupt bursts

2017-09-19 Thread Philip Prindeville
Hi. We’ve been running this patchset (all 5) for about as long as they’ve been under review… about 2 months. And in a burn-in lab with heavy traffic. We’ve not seen a single link-flap in hundreds of ours of saturated traffic. Would love to see some resolution soon on this as we don’t want to s

Re: [PATCH 5/5] e1000e: Avoid receiver overrun interrupt bursts

2017-08-11 Thread Philip Prindeville
> On Aug 11, 2017, at 8:13 PM, Philip Prindeville > wrote: > >> >> On Jul 21, 2017, at 12:48 PM, Lennart Sorensen >> wrote: >> >> On Fri, Jul 21, 2017 at 11:36:27AM -0700, Benjamin Poirier wrote: >>> When e1000e_poll() is not fast enough t

Re: [PATCH 5/5] e1000e: Avoid receiver overrun interrupt bursts

2017-08-11 Thread Philip Prindeville
> On Jul 21, 2017, at 12:48 PM, Lennart Sorensen > wrote: > > On Fri, Jul 21, 2017 at 11:36:27AM -0700, Benjamin Poirier wrote: >> When e1000e_poll() is not fast enough to keep up with incoming traffic, the >> adapter (when operating in msix mode) raises the Other interrupt to signal >> Receive

Re: commit 16ecba59 breaks 82574L under heavy load.

2017-07-24 Thread Philip Prindeville
> On Jul 20, 2017, at 5:44 PM, Benjamin Poirier wrote: > > [snip] > Could you please test the following patch and let me know if it: > 1) reduces the interrupt rate of the Other msi-x vector > 2) avoids the link flaps > or > 3) logs some dmesg warnings of the form "Other interrupt with unhandled

Re: [PATCH v3] iproute2: add support for GRE ignore-df knob

2017-07-20 Thread Philip Prindeville
> On Jul 20, 2017, at 6:26 PM, Stephen Hemminger > wrote: > > On Thu, 20 Jul 2017 13:06:10 -0600 > "Philip Prindeville" wrote: > >> From: Philip Prindeville >> >> In the presence of firewalls which improperly block ICMP Unreachable >> (

[PATCH v3] iproute2: add support for GRE ignore-df knob

2017-07-20 Thread Philip Prindeville
From: Philip Prindeville In the presence of firewalls which improperly block ICMP Unreachable (including Fragmentation Required) messages, Path MTU Discovery is prevented from working. The workaround is to handle IPv4 payloads opaquely, ignoring the DF bit. Kernel commit

[PATCH v2 1/1] iroute2: Add support for GRE ignore-df knob

2017-07-19 Thread Philip Prindeville
From: Philip Prindeville In the presence of firewalls which improperly block ICMP Unreachable (including Fragmentation Required) messages, Path MTU Discovery is prevented from working. The workaround is to handle IPv4 payloads opaquely, ignoring the DF bit. Reviewed-by: Stephen Hemminger

Re: [PATCH v5 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-08 Thread Philip Prindeville
Inline... On 08/08/2016 06:37 PM, f...@48lvckh6395k16k5.yundunddos.com wrote: From: Gao Feng The PPTP is encapsulated by GRE header with that GRE_VERSION bits must contain one. But current GRE RPS needs the GRE_VERSION must be zero. So RPS does not work for PPTP traffic. In my test environme

Re: [PATCH v3 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-03 Thread Philip Prindeville
Inline… > On Aug 3, 2016, at 8:52 AM, f...@48lvckh6395k16k5.yundunddos.com wrote: > > From: Gao Feng > > The PPTP is encapsulated by GRE header with that GRE_VERSION bits > must contain one. But current GRE RPS needs the GRE_VERSION must be > zero. So RPS does not work for PPTP traffic. > > In

Re: [PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

2016-08-02 Thread Philip Prindeville
In this case they both mean the same thing. > On Aug 2, 2016, at 6:28 PM, Feng Gao wrote: > > Just a reminder, the version description is "contain 1", not "set 1". > > Best Regards > Feng signature.asc Description: Message signed with OpenPGP using GPGMail

[PATCH v2 net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-14 Thread Philip Prindeville
From: Philip Prindeville In the presence of firewalls which improperly block ICMP Unreachable (including Fragmentation Required) messages, Path MTU Discovery is prevented from working. A workaround is to handle IPv4 payloads opaquely, ignoring the DF bit--as is done for

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-13 Thread Philip Prindeville
> On Jun 11, 2016, at 12:02 AM, David Miller wrote: > > From: "Philip Prindeville" > Date: Tue, 7 Jun 2016 13:48:46 -0600 > >> From: Philip Prindeville >> >> In the presence of firewalls which improperly block ICMP Unreachable >> (inc

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Philip Prindeville
> On Jun 7, 2016, at 9:22 PM, Alexander Duyck wrote: > > On Tue, Jun 7, 2016 at 12:48 PM, Philip Prindeville > wrote: >> From: Philip Prindeville >> >> In the presence of firewalls which improperly block ICMP Unreachable >> (including Fragmentation Requi

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Philip Prindeville
On 06/07/2016 04:23 PM, Hannes Frederic Sowa wrote: On 07.06.2016 22:42, Philip Prindeville wrote: On 06/07/2016 02:23 PM, Hannes Frederic Sowa wrote: On Tue, Jun 7, 2016, at 21:48, Philip Prindeville wrote: static struct rtnl_link_ops ipgre_link_ops __read_mostly = { diff --git a/net

Re: [PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Philip Prindeville
On 06/07/2016 02:23 PM, Hannes Frederic Sowa wrote: On Tue, Jun 7, 2016, at 21:48, Philip Prindeville wrote: static struct rtnl_link_ops ipgre_link_ops __read_mostly = { diff --git a/net/ipv4/ip_tunnel.c b/net/ipv4/ip_tunnel.c index d8f5e0a..95649eb 100644 --- a/net/ipv4/ip_tunnel.c +++ b

[PATCH iproute2] net-next: Add support for GRE ignore-df knob

2016-06-07 Thread Philip Prindeville
From: Philip Prindeville In the presence of firewalls which improperly block ICMP Unreachable (including Fragmentation Required) messages, Path MTU Discovery is prevented from working. The workaround is to handle IPv4 payloads opaquely, ignoring the DF bit. There is a corresponding kernel

[PATCH net-next] net: ipv4: Add ability to have GRE ignore DF bit in IPv4 payloads

2016-06-07 Thread Philip Prindeville
From: Philip Prindeville In the presence of firewalls which improperly block ICMP Unreachable (including Fragmentation Required) messages, Path MTU Discovery is prevented from working. A workaround is to handle IPv4 payloads opaquely, ignoring the DF bit--as is done for other payloads like