On Sat, 17 Jun 2017 11:38:05 +0800
Haishuang Yan wrote:
> Same as ip_gre, geneve and vxlan, use key->tos as traffic class value.
>
> CC: Peter Dawson
> Fixes: 0e9a709560db ("ip6_tunnel, ip6_gre: fix setting of DSCP on
> encapsulated packets”)
> Signed-off-by: Haishua
On Thu, 15 Jun 2017 10:30:29 +0800
Haishuang Yan wrote:
> Same as ip_gre, geneve and vxlan, use key->tos as tos value.
>
> CC: Peter Dawson
> Fixes: 0e9a709560db ("ip6_tunnel, ip6_gre: fix setting of DSCP on
> encapsulated packets”)
> Suggested-by: Daniel Borkmann
On Wed, 14 Jun 2017 10:54:31 +0800
严海双 wrote:
> > Changes since v2:
> > * mask key->tos with RT_TOS() suggested by Daniel
Can you help me understand the rationale for this change? Is there are bug
introduced by dsfield = ip6_tclass(key->label); ?
The RT_TOS masks out 4bits of the 8bit tos fi
Signed-off-by: Liam McBirnie
Concur with this patch. Testing that I performed on Commit: 0e9a709560db
("ip6_tunnel, ip6_gre: fix setting of DSCP on encapsulated packets") did not
cover the case were DSCP-based routing policy is applied to the tunneled
packets.
Acked-by: Peter Dawson
osed the incorrect handling of the DSCP portion of the
flowlabel in ip6_tunnel and ip6_gre.
Fixes: 90427ef5d2a4 ("ipv6: fix flow labels when the traffic class is non-0")
Signed-off-by: Peter Dawson
---
net/ipv6/ip6_gre.c| 13 +++--
net/ipv6/ip6_tunnel.c | 21 +
he DSCP value always being set to 0.
Commit 90427ef5d2a4 caused the regression by masking out the flowlabel
which exposed the incorrect the handling of the DSCP portion of the
flowlabel in ip6_tunnel and ip6_gre.
Fixes: 90427ef5d2a4 ("ipv6: fix flow labels when the traffic class is non-0")
Signed-off-by: Peter Dawson
On Thu, 25 May 2017 12:11:17 -0400 (EDT)
David Miller wrote:
> > Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=195661
>
> This is not the correct way to use the Fixes: tag.
>
> You should specify the commit that introduced the regression
> between 4.9.x and 4.10.x, and that you are fixin
in ip6_tnl_xmit was
incorrect and resulted in the DSCP value always being set to 0.
Fixes: https://bugzilla.kernel.org/show_bug.cgi?id=195661
Signed-off-by: Peter Dawson
---
net/ipv6/ip6_gre.c| 13 +++--
net/ipv6/ip6_tunnel.c | 21 +
2 files changed, 20 inserti
bs and other junk. Please run checkpatch.pl, look at the
> results and resubmit.
Thanks. I've run checkpatch.pl over this updated file with no errors.
Regards
Peter
From f12adb265f683d53ae071725e657dab17d26ed8d Mon Sep 17 00:00:00 2001
From: Peter Dawson
Date: Thu, 18 May 2017 11:52:22
