Re: [RFD] Layering: Use-Case Composers (was: DRBD - what is it, anyways? [compare with e.g. NBD + MD raid])

2007-08-12 Thread Paul Clements
Iustin Pop wrote: On Sun, Aug 12, 2007 at 07:03:44PM +0200, Jan Engelhardt wrote: On Aug 12 2007 09:39, [EMAIL PROTECTED] wrote: now, I am not an expert on either option, but three are a couple things that I would question about the DRDB+MD option 1. when the remote machine is down, how does M

Re: [PATCH 2/2] nbd: change a parameter's type to remove a memcpy call

2007-07-19 Thread Paul Clements
Denis Cheng wrote: this memcpy looks so strange, in fact it's merely a pointer dereference, so I change the parameter's type to refer it more directly, this could make the memcpy not needed anymore. in the function nbd_read_stat where nbd_find_request is only once called, the parameter served sh

Re: [PATCH 1/2] nbd: use list_for_each_entry_safe to make it more consolidated and readable

2007-07-19 Thread Paul Clements
Denis Cheng wrote: Thus the traverse of the loop may delete nodes, use the safe version. Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- drivers/block/nbd.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index c129510..