RE: Severe performance regression in "net: macsec: preserve ingress frame ordering"

2020-08-25 Thread Van Leeuwen, Pascal
> -Original Message- > From: Andrew Lunn > Sent: Monday, August 24, 2020 3:02 PM > To: Van Leeuwen, Pascal > Cc: Sabrina Dubroca ; Scott Dial ; > linux-cry...@vger.kernel.org; Ryan Cox > ; netdev@vger.kernel.org; da...@davemloft.net; Antoine > Tenart ; > eb

RE: Severe performance regression in "net: macsec: preserve ingress frame ordering"

2020-08-24 Thread Van Leeuwen, Pascal
> -Original Message- > From: linux-crypto-ow...@vger.kernel.org > On Behalf Of Andrew Lunn > Sent: Wednesday, August 12, 2020 2:42 PM > To: Van Leeuwen, Pascal > Cc: Sabrina Dubroca ; Scott Dial ; > linux-cry...@vger.kernel.org; Ryan Cox > ; netdev@vger.kernel.

Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

2020-08-23 Thread Pascal Bouchareine
On Sat, Aug 22, 2020 at 2:01 PM David Miller wrote: > > About the pid part - > > On top of multiple pids to scan for a given socket, there's also the > > security provided by /proc - I'm not sure what inet_diag does for that > > So maybe users calling it will need to scan /proc for a long time any

Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

2020-08-22 Thread Pascal Bouchareine
On Sat, Aug 22, 2020 at 1:19 PM Pascal Bouchareine wrote: > > On Sat, Aug 22, 2020 at 12:59 PM Pascal Bouchareine wrote: > > > Would it make sense to also make UDIAG_SHOW_NAME use sk_description? > > (And keep the existing change - setsockopt + show_fd_info via > > /p

Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

2020-08-22 Thread Pascal Bouchareine
On Sat, Aug 22, 2020 at 12:59 PM Pascal Bouchareine wrote: > Would it make sense to also make UDIAG_SHOW_NAME use sk_description? > (And keep the existing change - setsockopt + show_fd_info via > /proc/.../fdinfo/..) Ah,very wrong example - to be more precise, I suppose that'

Re: [PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

2020-08-22 Thread Pascal Bouchareine
Thank you, On Sat, Aug 22, 2020 at 12:36 PM David Miller wrote: > > We ignore optlen and constrain the string to a static max size > > > > Signed-off-by: Pascal Bouchareine > > This change is really a non-starter unless the information gets > published somewhere wh

Re: [PATCH v2 1/2] mm: add GFP mask param to strndup_user

2020-08-22 Thread Pascal Bouchareine
Thanks for taking a look! On Fri, Aug 21, 2020 at 8:51 PM Andrew Morton wrote: > Why change all existing callsites so that one callsite can pass in a > different gfp_t? My initial thought was to change strndup_user to use GFP_KERNEL_ACCOUNT (or GFP_USER | __GFP_ACCOUNT ?) unconditionally. (Woul

[PATCH v2 2/2] net: socket: implement SO_DESCRIPTION

2020-08-21 Thread Pascal Bouchareine
ignore optlen and constrain the string to a static max size Signed-off-by: Pascal Bouchareine --- include/net/sock.h| 4 +++ include/uapi/asm-generic/socket.h | 2 ++ net/core/sock.c | 53 +++ net/socket.c | 5

[PATCH v2 1/2] mm: add GFP mask param to strndup_user

2020-08-21 Thread Pascal Bouchareine
Let caller specify allocation. Preserve existing calls with GFP_USER. Signed-off-by: Pascal Bouchareine --- Updating patch 1/ and 2/ to address comments drivers/dma-buf/dma-buf.c | 2 +- drivers/gpu/drm/i915/i915_debugfs_params.c | 2 +- drivers/gpu/drm/vc4/vc4_bo.c

Re: [PATCH 2/2] net: socket: implement SO_DESCRIPTION

2020-08-16 Thread Pascal Bouchareine
On Sun, Aug 16, 2020 at 11:15 AM Eric Dumazet wrote: > > 1) You also ignored what would happen at accept() time. > > Please test your patches with ASAN. Ouch, I will look into it - thanks for pointing that out & 3/ > > 2) Also, why is that description specific to sockets ? fcntl on struct file

[PATCH 2/2] net: socket: implement SO_DESCRIPTION

2020-08-15 Thread Pascal Bouchareine
ignore optlen and constrain the string to a static max size Signed-off-by: Pascal Bouchareine --- include/net/sock.h| 4 include/uapi/asm-generic/socket.h | 2 ++ net/core/sock.c | 23 +++ net/socket.c | 5 + 4

[PATCH 1/2] mm: add GFP mask param to strndup_user

2020-08-15 Thread Pascal Bouchareine
Let caller specify allocation. Preserve existing calls with GFP_USER. Signed-off-by: Pascal Bouchareine --- drivers/dma-buf/dma-buf.c | 2 +- drivers/gpu/drm/i915/i915_debugfs_params.c | 2 +- drivers/gpu/drm/vc4/vc4_bo.c | 3 +- drivers/input/misc/uinput.c

[RFC PATCH 0/2] proc,socket: attach description to sockets

2020-08-15 Thread Pascal Bouchareine
Checking to see if this could fit in struct sock. This goes against v5.8 I tried to make it tl;dr in commit 2/2 but motivation is also described a bit in https://lore.kernel.org/linux-api/CAGbU3_nVvuzMn2wo4_ZKufWcGfmGsopVujzTWw-Bbeky=xs...@mail.gmail.com/

RE: Severe performance regression in "net: macsec: preserve ingress frame ordering"

2020-08-12 Thread Van Leeuwen, Pascal
hand, the caller to the new API could > > explicitly declare a fallback algorithm (e.g., > > "gcm_base(ctr(aes-aesni),ghash-generic)"), which probably is the correct > > answer anyways -- > > I would try to avoid that, it seems too error-prone to me. > > > what are the c

Re: linux/atm_zatm.h not really usable in userspace since cf00713a655d3019be7faa184402f16c43a0fed3

2016-10-15 Thread Pascal Terjan
On 15 October 2016 at 16:10, Mikko Rapeli wrote: > On Sat, Oct 15, 2016 at 03:33:22PM +0100, Pascal Terjan wrote: >> On 15 October 2016 at 15:09, Mikko Rapeli wrote: >> > On Sat, Oct 15, 2016 at 01:05:10PM +0100, Pascal Terjan wrote: >> >> It is no longer po

Re: linux/atm_zatm.h not really usable in userspace since cf00713a655d3019be7faa184402f16c43a0fed3

2016-10-15 Thread Pascal Terjan
On 15 October 2016 at 15:09, Mikko Rapeli wrote: > On Sat, Oct 15, 2016 at 01:05:10PM +0100, Pascal Terjan wrote: >> It is no longer possible to include + userspace >> headers using time, for example , this broke for example >> the build of linux-atm. >> >&g

linux/atm_zatm.h not really usable in userspace since cf00713a655d3019be7faa184402f16c43a0fed3

2016-10-15 Thread Pascal Terjan
It is no longer possible to include + userspace headers using time, for example , this broke for example the build of linux-atm. Reproducer: $ cat test.c #include #include $ gcc -c test.c In file included from /usr/include/sys/select.h:43:0, from /usr/include/sys/types.h:219

userspace build broken by include changes

2016-10-15 Thread Pascal Terjan
rp-pppoe plugin of ppp no longer builds: In file included from pppoe.h:87:0, from plugin.c:29: /usr/include/linux/in.h:28:3: error: redeclaration of enumerator 'IPPROTO_IP' IPPROTO_IP = 0, /* Dummy protocol for TCP */ ^ /usr/include/netinet/in.h:42:5: note: previous defini

[PATCH] Temporary patch for arpd

2016-10-11 Thread Pascal
Hello. I found wonderful bug in arpd daemon of iproute2 package. Somehow arpd is absolute unworkable if run program with -f flag. On my amd64 server i got "Segmentation fault" regardless -f mac-list.txt file content. The source of misc/arpd.c is not hard and i found that cause of this bug is commit

[PATCH] ethernet:ti:cpsw: fix phy identification with multiple slaves on fixed-phy

2015-12-04 Thread Pascal Speck (Iktek)
ame unique meaning. Signed-off-by: Pascal Speck --- --- a/drivers/net/ethernet/ti/cpsw.c 2015-11-30 03:58:26.0 +0100 +++ b/drivers/net/ethernet/ti/cpsw.c 2015-12-04 16:42:02.075450234 +0100 @@ -2047,7 +2047,7 @@ static int cpsw_probe_dt(struct cpsw_

Followup: PROBLEM: TI CPSW driver hanging up when setting mac-address to early

2015-12-04 Thread Pascal Speck (Iktek)
As I didn't find the maintainer for this cpsw-driver ( cy...@ti.com mail came back ) I'll try this way. In addition I tested this issue with 4.4-rc3 again and it still seems to be there. Regards Pascal Speck Am 04.12.2015 um 09:44 schrieb i...@iktek.de: Dear Mr. Cyril, Dear M

Re: need some help on a backport of r8169

2007-03-02 Thread Pascal GREGIS
[EMAIL PROTECTED] a écrit, le Thu 01 Mar 2007 à 10:57:11AM : > Hello Ueimor, > [...] > > Once you have logged the ifconfig/ethtool dump, you can try the serie > > or the patch at: > > > > http://www.fr.zoreil.com/people/francois/backport/r8169/20070228-00 > Hum... ok I might have enough time to c

Re: need some help on a backport of r8169

2007-02-27 Thread Pascal GREGIS
Francois Romieu a écrit, le Tue 27 Feb 2007 à 12:48:31AM : > Pascal GREGIS <[EMAIL PROTECTED]> : > [...] > > Could anyone take a look at my patch and tell me what is missing, > > - It lacks the adequate registers init sequence for a 8168 for instance. > - Fix went i

need some help on a backport of r8169

2007-02-26 Thread Pascal GREGIS
el for the moment. Here you can find my patch : http://www.synerway.net/patch/r8169-backport.patch it adds mii-tool support and TRIES to add RTL8168 support. Thank you for any help Pascal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message

Re: [Bugme-new] [Bug 7962] New: oops in port_carrier_check

2007-02-09 Thread Pascal Terjan
2007/2/9, Stephen Hemminger <[EMAIL PROTECTED]>: The carrier_check is canceled by removal of port from bridge. Perhaps there is something broken in rcu assumptions under Qemu If that can help: I started /stopped qemu several times. Maybe I started /stopped qemu several times as I was testing ne