Re: [PATCH nf-next] netfilter: flowtable: separate replace, destroy and stats to different workqueues

2021-03-25 Thread Oz Shlomo
Hi Marcelo, On 3/24/2021 11:20 PM, Marcelo Ricardo Leitner wrote: On Wed, Mar 24, 2021 at 01:24:53PM +0200, Oz Shlomo wrote: Hi, Hi, On 3/24/2021 3:38 AM, Pablo Neira Ayuso wrote: Hi Marcelo, On Mon, Mar 22, 2021 at 03:09:51PM -0300, Marcelo Ricardo Leitner wrote: On Wed, Mar 03, 2021

Re: [PATCH nf-next] netfilter: flowtable: separate replace, destroy and stats to different workqueues

2021-03-24 Thread Oz Shlomo
Hi, On 3/24/2021 3:38 AM, Pablo Neira Ayuso wrote: Hi Marcelo, On Mon, Mar 22, 2021 at 03:09:51PM -0300, Marcelo Ricardo Leitner wrote: On Wed, Mar 03, 2021 at 05:11:47PM +0100, Pablo Neira Ayuso wrote: [...] Or probably make the cookie unique is sufficient? The cookie refers to the memory a

[PATCH nf-next] netfilter: flowtable: separate replace, destroy and stats to different workqueues

2021-03-03 Thread Oz Shlomo
stats workqueues to avoid backlogs of non-dependent actions. Provide sysfs control over the workqueue attributes, allowing userspace applications to control the workqueue cpumask. Signed-off-by: Oz Shlomo Reviewed-by: Paul Blakey --- net/netfilter/nf_flow_table_offload.c | 44

Re: [net-next 08/15] net/mlx5e: CT: Preparation for offloading +trk+new ct rules

2021-01-26 Thread Oz Shlomo
On 1/22/2021 4:16 AM, Marcelo Ricardo Leitner wrote: On Fri, Jan 22, 2021 at 02:18:34AM +0100, Pablo Neira Ayuso wrote: Hi Oz, On Wed, Jan 20, 2021 at 06:09:48PM +0200, Oz Shlomo wrote: On 1/14/2021 11:50 PM, Marcelo Ricardo Leitner wrote: Thoughts? I wonder if we should develop a

Re: [net-next 08/15] net/mlx5e: CT: Preparation for offloading +trk+new ct rules

2021-01-20 Thread Oz Shlomo
On 1/14/2021 11:50 PM, Marcelo Ricardo Leitner wrote: On Thu, Jan 14, 2021 at 04:03:43PM +0200, Oz Shlomo wrote: On 1/14/2021 3:02 PM, Marcelo Ricardo Leitner wrote: On Tue, Jan 12, 2021 at 11:27:04AM +0200, Oz Shlomo wrote: On 1/12/2021 1:51 AM, Marcelo Ricardo Leitner wrote: On Sun

Re: [net-next 08/15] net/mlx5e: CT: Preparation for offloading +trk+new ct rules

2021-01-14 Thread Oz Shlomo
On 1/14/2021 3:02 PM, Marcelo Ricardo Leitner wrote: On Tue, Jan 12, 2021 at 11:27:04AM +0200, Oz Shlomo wrote: On 1/12/2021 1:51 AM, Marcelo Ricardo Leitner wrote: On Sun, Jan 10, 2021 at 09:52:55AM +0200, Roi Dayan wrote: On 2021-01-10 9:45 AM, Roi Dayan wrote: On 2021-01-08 11:48

Re: [net-next 08/15] net/mlx5e: CT: Preparation for offloading +trk+new ct rules

2021-01-12 Thread Oz Shlomo
On 1/12/2021 1:51 AM, Marcelo Ricardo Leitner wrote: On Sun, Jan 10, 2021 at 09:52:55AM +0200, Roi Dayan wrote: On 2021-01-10 9:45 AM, Roi Dayan wrote: On 2021-01-08 11:48 PM, Marcelo Ricardo Leitner wrote: Hi, On Thu, Jan 07, 2021 at 09:30:47PM -0800, Saeed Mahameed wrote: From: Roi

Re: [net-next V2 09/15] net/mlx5e: CT: Use the same counter for both directions

2020-12-07 Thread Oz Shlomo
Hi Marcelo, On 12/1/2020 11:41 PM, Saeed Mahameed wrote: On Fri, 2020-11-27 at 11:01 -0300, Marcelo Ricardo Leitner wrote: On Wed, Sep 23, 2020 at 03:48:18PM -0700, sa...@kernel.org wrote: From: Oz Shlomo Sorry for reviving this one, but seemed better for the context. A connection is

Re: [PATCH net-next v2] net/mlx5e: add conntrack offload rules only in ct or ct_nat flow table

2020-05-31 Thread Oz Shlomo
Hi Wenxu, Just saw v2. Please see my comment in v1. On 5/30/2020 9:27 AM, we...@ucloud.cn wrote: From: wenxu In the ct offload all the conntrack entry offload rules will be add to both ct ft and ct_nat ft twice. It is not make sense. The driver can distinguish NAT from non-NAT conntrack throu

Re: [PATCH net-next 2/2] net/mlx5e: add ct_metadata.nat support in ct offload

2020-05-31 Thread Oz Shlomo
Hi Wenxu, On 5/28/2020 10:15 AM, we...@ucloud.cn wrote: From: wenxu In the ct offload all the conntrack entry offload rules will be add to both ct ft and ct_nat ft twice. It is not makesense. The ct_metadat.nat will tell driver Adding the connection to both tables is required because the us

Re: The size of ct offoad mlx5_flow_table in mlx5e driver

2020-05-31 Thread Oz Shlomo
Hi Wenxu, I'll reply on behalf of Paul On 5/28/2020 7:02 AM, wenxu wrote: HiĀ  Paul, I have a question about the size of ct and ct nat flow table. There are two global mlx5_flow_table tables ct and ct_nat for act_ct offload. The ct and ct_nat flow table create through mlx5_esw_chains_creat

Re: [Patch net-next] net_sched: fold tcf_block_cb_call() into tc_setup_cb_call()

2018-12-12 Thread Oz Shlomo
eter 'exts'. > > Fixes: 69bd48404f25 ("net/sched: Remove egdev mechanism") > Cc: Oz Shlomo > Cc: Jiri Pirko > Signed-off-by: Cong Wang Acked-by: Oz Shlomo