Re: [PATCH] net/vmw_vsock: fix NULL pointer dereference

2021-02-05 Thread Norbert Slusarek
Forgot to send it to the networking maintainer, +CC Jakub Kicinski

[PATCH] net/vmw_vsock: fix NULL pointer dereference

2021-02-05 Thread Norbert Slusarek
From: Norbert Slusarek Date: Fri, 5 Feb 2021 13:12:06 +0100 Subject: [PATCH] net/vmw_vsock: fix NULL pointer dereference In vsock_stream_connect(), a thread will enter schedule_timeout(). While being scheduled out, another thread can enter vsock_stream_connect() as well and set vsk->transport

[PATCH] net/vmw_vsock: improve locking in vsock_connect_timeout()

2021-02-05 Thread Norbert Slusarek
From: Norbert Slusarek Date: Fri, 5 Feb 2021 13:14:05 +0100 Subject: [PATCH] net/vmw_vsock: improve locking in vsock_connect_timeout() A possible locking issue in vsock_connect_timeout() was recognized by Eric Dumazet which might cause a null pointer dereference in vsock_transport_cancel_pkt

Re: [PATCH] net/vmw_vsock: fix NULL pointer deref and improve locking

2021-02-05 Thread Norbert Slusarek
> As I suggested, I think is better to split this patch in two patches > since we are fixing two issues. This should also simplify to attach the > proper 'Fixes' tag. > Splitting also allows to put the reporter in the right issue he > reported. I agree it makes sense to split it. I will send sepa

Re: [PATCH] net/vmw_vsock: fix NULL pointer deref and improve locking

2021-02-04 Thread Norbert Slusarek
should format my response to include it to the final patch message, in case I should specifically format it, just let me know. For now: Fixes: 380feae0def7e6a115124a3219c3ec9b654dca32 (vsock: cancel packets when failing to connect) Reported-by: Norbert Slusarek Reported-by: Eric Dumazet

[PATCH] net/vmw_vsock: fix NULL pointer deref and improve locking

2021-02-04 Thread Norbert Slusarek
From: Norbert Slusarek Date: Thu, 4 Feb 2021 18:49:24 +0100 Subject: [PATCH] net/vmw_vsock: fix NULL pointer deref and improve locking In vsock_stream_connect(), a thread will enter schedule_timeout(). While being scheduled out, another thread can enter vsock_stream_connect() as well and set vsk