Hi Florian
> > diff --git a/drivers/net/phy/microchip_t1.c
> > b/drivers/net/phy/microchip_t1.c new file mode 100644 index
> > 000..1f6f299
> > --- /dev/null
> > +++ b/drivers/net/phy/microchip_t1.c
> > @@ -0,0 +1,88 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
>
> This is not the standard
Hi Andrew,
> > Fine, will change the filename.
>
> > The reason for moving to separate file is that we have a series of
> > T1 standard PHYs, which support cable diagnostics, signal quality
> > indicator(SQI) and sleep and wakeup (TC10) support etc. we planned to
> > keep all T1 standard PHYs sep
Hi Florian
> On 04/25/2018 11:49 AM, Nisar Sayed wrote:
> > Add driver for Microchip LAN87XX T1 PHYs
> >
> > This patch support driver for Microchp T1 PHYs.
> > There will be followup patches to this driver to support T1 PHY
> > features such as cable diagnostics, signal quality indicator(SQI),
>
Hi Phil,
> Hi Nisar,
>
> On 10/04/2018 15:16, nisar.sa...@microchip.com wrote:
> > Thanks Phil, for identifying the issues.
> >
> >> - ret = lan78xx_reset(dev);
> >> - if (ret < 0)
> >> - goto done;
> >> -
> >>phy_start(net->phydev);
> >>
> >>netif_dbg(dev, ifup, dev->net, "phy
Thanks Phil, for identifying the issues.
> - ret = lan78xx_reset(dev);
> - if (ret < 0)
> - goto done;
> -
> phy_start(net->phydev);
>
> netif_dbg(dev, ifup, dev->net, "phy initialised successfully");
> --
You may need to start the interrupts before "phy_start" in
Hi Alexander,
Thanks for the patch.
> @@ -2575,13 +2571,7 @@ static int lan78xx_stop(struct net_device *net)
> if (timer_pending(&dev->stat_monitor))
> del_timer_sync(&dev->stat_monitor);
>
> - phy_unregister_fixup_for_uid(PHY_KSZ9031RNX, 0xfff0);
> - phy_unregist
Thanks Sergei, I will update it and submit next version.
- Nisar
> Hello!
>
> On 09/19/2017 01:02 AM, Nisar Sayed wrote:
>
> > Allow EEPROM write for less than MAX_EEPROM_SIZE
> >
> > Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to
> > 10/100/1000 Ethernet device driver")
> > Signe
> > From: Nisar Sayed
> >
> > Fix for eeprom read/write when device auto suspend
> >
> > Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to
> > 10/100/1000 Ethernet device driver")
> > Signed-off-by: Nisar Sayed
> > ---
> > drivers/net/usb/lan78xx.c | 22 ++
> > 1 fi
From: Nisar Sayed
Allow EEPROM write for less than MAX_EEPROM_SIZE
Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000
Ethernet device driver")
Signed-off-by: Nisar Sayed
---
drivers/net/usb/lan78xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/
From: Nisar Sayed
Use default value loaded from EEPROM/OTP when resetting
The LAN78xx allows platform configurations to be loaded from EEPROM/OTP.
Ex: When external phy is connected, the MAC can be configured to
have speed, duplex, polarity configurations loadded from the EEPROM/OTP.
Fixes: 55d
From: Nisar Sayed
Fix for eeprom read/write when device auto suspend
Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000
Ethernet device driver")
Signed-off-by: Nisar Sayed
---
drivers/net/usb/lan78xx.c | 22 ++
1 file changed, 18 insertions(+), 4 delet
From: Nisar Sayed
This series of patches are for lan78xx driver.
These patches fixes potential issues associated with lan78xx driver
v2
- Added patch version information
- Added fixes tag
- Updated patch description
- Updated changes as per comments
v1
- Spitted patches as per comments
- Dropp
From: Nisar Sayed
Configure pause time to 0x when tx flow control enabled
Set pause time to 0x in the pause frame to indicate the
partner to stop sending the packets. When RX buffer frees up,
the device sends pause frame with pause time zero for partner to
resume transmission.
Fixes: 2f
> On Mon, Sep 11, 2017 at 12:32:10PM +, nisar.sa...@microchip.com
> wrote:
> > From: Nisar Sayed
> >
> > Configure pause time to 0x when tx flow control enabled
> >
> > Set pause time to 0x in the pause frame to indicate the partner to
> > stop sending the packets. When RX buffer frees
From: Nisar Sayed
Configure pause time to 0x when tx flow control enabled
Set pause time to 0x in the pause frame to indicate the
partner to stop sending the packets. When RX buffer frees up,
the device sends pause frame with pause time zero for partner to
resume transmission.
Signed-of
> On Thu, Sep 07, 2017 at 07:11:50AM +, nisar.sa...@microchip.com
> wrote:
> > From: Nisar Sayed
> >
> > Use default value loaded from EEPROM/OTP when resetting
>
> Hi Nisar
>
> Subject: [PATCH 3/3]
>
> Is this a fix for net, or further development for net-next?
>
> Why do we want the defa
> On Thu, Sep 07, 2017 at 06:51:37AM +, nisar.sa...@microchip.com
> wrote:
> > From: Nisar Sayed
> >
> > Configure pause time to 0x when tx flow control enabled
>
> Hi Nisar
>
> You should explain the 'Why' in the commit message. Why do we want a
> pause time of 0x?
>
> Andrew
From: Nisar Sayed
Use default value loaded from EEPROM/OTP when resetting
Signed-off-by: Nisar Sayed
---
drivers/net/usb/lan78xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 94ef943..8fd7c2f 100644
--- a/drivers/net/usb/lan78x
From: Nisar Sayed
This series of patches are for lan78xx driver.
These patches fixes potential issues associated with lan78xx driver
Nisar Sayed (3):
Fix for eeprom read/write when device autosuspend
Allow EEPROM write for less than MAX_EEPROM_SIZE
Use default value loaded from EEPROM/OTP
From: Nisar Sayed
Allow EEPROM write for less than MAX_EEPROM_SIZE
Signed-off-by: Nisar Sayed
---
drivers/net/usb/lan78xx.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index baf91c7..94ef943 100644
--- a/drivers/net/usb/lan78xx.
From: Nisar Sayed
Fix for eeprom read/write when device autosuspend
Signed-off-by: Nisar Sayed
---
drivers/net/usb/lan78xx.c | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index b99a7fb..baf91c7
From: Nisar Sayed
Configure pause time to 0x when tx flow control enabled
Signed-off-by: Nisar Sayed
---
drivers/net/usb/smsc95xx.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
index 340c134..309b88a
Thanks, will make separate patch.
> Hi Nisar
>
> > + else if ((ee->magic == LAN78XX_EEPROM_MAGIC) &&
> > +(ee->offset >= 0 && ee->offset < MAX_EEPROM_SIZE) &&
> > +(ee->len > 0 && (ee->offset + ee->len) <=
> MAX_EEPROM_SIZE))
> > + ret = lan78xx_write_raw_eepro
Thanks Andrew, will try to change as suggested.
> On Wed, Sep 06, 2017 at 10:51:44AM +, nisar.sa...@microchip.com
> wrote:
> > From: Nisar Sayed
> >
> > Add fixed_phy device support for LAN7801 device
> >
> > When LAN7801 device connected to PHY Device which does not have
> > MDIO/MDC access,
Thanks Andrew inputs.
> On Wed, Sep 06, 2017 at 10:51:31AM +, nisar.sa...@microchip.com
> wrote:
> > From: Nisar Sayed
> >
> > Fix for crash associated with System suspend
> >
> > Since ndo_stop removes phydev which makes phydev NULL.
> > Whenever system suspend is initiated or after "ifconf
From: Nisar Sayed
Fix for eeprom read/write when device autosuspend
Signed-off-by: Nisar Sayed
---
drivers/net/usb/lan78xx.c | 26 ++
1 file changed, 22 insertions(+), 4 deletions(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 6242cb7..e04e
From: Nisar Sayed
Fix for crash associated with System suspend
Since ndo_stop removes phydev which makes phydev NULL.
Whenever system suspend is initiated or after "ifconfig down",
if set_wol or get_wol is triggered phydev is NULL leads system crash.
Hence phy_start/phy_stop for ndo_start/ndo_s
From: Nisar Sayed
Use default value loaded from EEPROM/OTP when resetting
the chip
Signed-off-by: Nisar Sayed
---
drivers/net/usb/lan78xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index e04ec23..84491e7 100644
--- a/drivers/net/
From: Nisar Sayed
Add fixed_phy device support for LAN7801 device
When LAN7801 device connected to PHY Device which does not have
MDIO/MDC access, fixex_phy device will be added.
Signed-off-by: Nisar Sayed
---
drivers/net/usb/Kconfig | 10
drivers/net/usb/lan78xx.c | 59 +++
From: Nisar Sayed
This series of patches are for lan78xx driver.
These patches supports fixes and enhancements to lan78xx driver
Nisar Sayed (4):
Fix for crash associated with System suspend
Add fixed_phy device support for LAN7801 device
Fix for eeprom read/write when device autosuspend
From: Nisar Sayed
Fix to handle hard_header_len update
When ifconfig up/down sequence is initiated hard_header_len
get updated incrementally for each ifconfig up /down sequence,
this leads invalid hard_header_len, moving to lan78xx_bind
to have one time update of hard_header_len addresses the is
From: Nisar Sayed
USB fast connect/disconnect crash fix
When USB plugged/unplugged at fast rate,
lan78xx_mdio_init() in lan78xx_bind() failing case is not handled.
Whenever lan78xx_mdio_init() failed, dev->mdiobus will be freed, however
since lan78xx_bind() not consider as error and try to proc
From: Nisar Sayed
This series of patches are for lan78xx driver.
These patches fixes potential issues associated with lan78xx driver
Nisar Sayed (2):
USB fast connect/disconnect crash fix
Fix to handle hard_header_len update
drivers/net/usb/lan78xx.c | 18 +-
1 file change
> > When TX checksum offload is used, if the computed checksum is 0 the
> > LAN95xx device do not alter the checksum to 0x. In the case of ipv4
> > UDP checksum, it indicates to receiver that no checksum is calculated.
> > Under ipv6, UDP checksum yields a result of zero must be changed to
> >
From: Nisar Sayed
When TX checksum offload is used, if the computed checksum is 0 the
LAN95xx device do not alter the checksum to 0x. In the case of ipv4
UDP checksum, it indicates to receiver that no checksum is calculated.
Under ipv6, UDP checksum yields a result of zero must be changed to
35 matches
Mail list logo
