[PATCH] i40e: only register client on iWarp-capable devices

2017-04-04 Thread Mitch Williams
The client interface is only intended for use on devices that support iWarp). Only register with the client if this is the case. This fixes a panic when loading i40iw on X710 devices. Signed-off-by: Mitch Williams Reported-by: Stefan Assmann --- drivers/net/ethernet/intel/i40e/i40e_main.c

[PATCH 1/3] Kernel support for flexible wakeup filters

2008-01-29 Thread Mitch Williams
Add ethtool infrastructure support for Wake-on-Lan flexible filters. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h index 71d4ada..70b86da 100644 --- a/include/linux/ethtool.h +++ b/include/linux/ethtool.h @@ -56,6

[PATCH 3/3] Add flexible wake filter support to ethtool-6

2008-01-29 Thread Mitch Williams
-f ethx Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff --git a/ethtool-copy.h b/ethtool-copy.h index 3a63224..dbad8dc 100644 --- a/ethtool-copy.h +++ b/ethtool-copy.h @@ -55,6 +55,16 @@ struct ethtool_wolinfo { __u8sopass[SOPASS_MAX]; /* SecureOn(tm) password */ }; +#

[PATCH 2/3] Add flexible wake filter support to e1000e

2008-01-29 Thread Mitch Williams
Add support to e1000e for Wake-on-Lan flexible filters. This feature is supported by all hardware that the driver supports. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff --git a/drivers/net/e1000e/defines.h b/drivers/net/e1000e/defines.h index 6232c3e..3c18a09 100644 --- a/drive

[PATCH 0/3] Add flexible wake filter support

2008-01-29 Thread Mitch Williams
where is a string of hex digits (or xx for ignore) describing bytes from the beginning of the expected packet. For example: $ ethtool -F eth0 0 00a055667788449976xx32 To show a filter: $ ethtool -f ethx This feature gives more wakeup flexibility for people who need it. Signed-off-by:

[PATCH 2.6.24] e1000e: add new wakeup cababilities

2008-01-29 Thread Mitch Williams
Ethtool supports wake-on-ARP and wake-on-link, and so does the hardware supported by e1000e. This patch just introduces the two. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff --git a/drivers/net/e1000e/defines.h b/drivers/net/e1000e/defines.h index f2175ea..6232c3e 100644 --- a/d

[PATCH 1/2] HW VLAN filtering control (resend)

2007-07-27 Thread Mitch Williams
Add support to the VLAN subsystem for enabling/disabling hardware VLAN filtering at runtime. This is useful for debugging purposes. The existing vconfig utility can be used without modification. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.22.1

[PATCH 2/2] HW VLAN filtering control (resend)

2007-07-27 Thread Mitch Williams
Add support to e1000 for enabling/disabling hardware VLAN filtering at runtime. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.22.1-clean/drivers/net/e1000/e1000_main.c linux-2.6.22.1/drivers/net/e1000/e1000_main.c --- linux-2.6.22.1-clean/drivers/net

[PATCH 0/2] HW VLAN filtering control (resend)

2007-07-27 Thread Mitch Williams
terface] 2 0 will enable filtering. (Now with non-mangled goodness.) Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 0/2] HW VLAN filtering control

2007-07-27 Thread Mitch Williams
On Fri, 2007-07-27 at 14:06 -0700, Ben Greear wrote: > This looks fine to me. > > Ben > Grr. Except that Evolution mangled them. I'll have to repost. -Mitch - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 2/2] HW VLAN filtering control

2007-07-27 Thread Mitch Williams
Add support to e1000 for enabling/disabling hardware VLAN filtering at runtime. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.22.1-clean/drivers/net/e1000/e1000_main.c linux-2.6.22.1/drivers/net/e1000/e1000_main.c --- linux-2.6.22.1-clean/drivers/net

[PATCH 1/2] HW VLAN filtering control

2007-07-27 Thread Mitch Williams
Add support to the VLAN subsystem for enabling/disabling hardware VLAN filtering at runtime. This is useful for debugging purposes. The existing vconfig utility can be used without modification. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.22.1

[PATCH 0/2] HW VLAN filtering control

2007-07-27 Thread Mitch Williams
terface] 2 0 will enable filtering. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/7] bonding: Add 10 Gig support

2006-09-07 Thread Mitch Williams
Note to self: Do not use Pine EVER AGAIN. Sorry for the badness. Evolution is my new best friend. -Mitch On Wed, 2006-09-06 at 12:22 -0700, Jay Vosburgh wrote: > > [Trying again; /usr/bin/patch didn't complain about Mitch's > original; here's a cg-diff generated from where I checked his

Re: [PATCH 1/7] bonding: Add 10 Gig support

2006-09-06 Thread Mitch Williams
Add 10 Gig support to bonding. Resent due to corrupt patch. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> Acked-by: Jay Vosburgh <[EMAIL PROTECTED]> diff -urpN -X linux-2.6.18-rc4-clean/Documentation/dontdiff linux-2.6.18-rc4-clean/drivers/net/bonding/bond_3ad.c linux-2.6.18

[RFC] Wake-on-LAN flex filters

2006-08-31 Thread Mitch Williams
Most modern Ethernet hardware supports flexible filters for wake-on-LAN, probably because it's a requirement for certification with Another Operating System. This patch implements this feature on e1000 via Ethtool. The kernel portion of this code is fairly well polished, but the changes to the to

[RFC] Enable/Disable VLAN HW filters

2006-08-31 Thread Mitch Williams
We've had a few internal requests for a way to enable and disable the hardware VLAN filter at runtime. I'm posting it here for discussion and to see if anybody else is interested in this feature. Originally I had planned to do this as an Ethtool ioctl, but decided instead to handle it through the

Re: bonding: cannot remove certain named devices

2006-08-15 Thread Mitch Williams
On Tue, 15 Aug 2006, David Miller wrote: > > I agree that whitespace in device names push the limits of sanity. > > But if we believe that, we should enforce it in dev_valid_name(). > > Does anyone really mind if I add the whitespace check there? > I have no objections. It would certainly make

Re: bonding: cannot remove certain named devices

2006-08-15 Thread Mitch Williams
On Tue, 15 Aug 2006, Bill Nottingham wrote: > > Stephen Hemminger ([EMAIL PROTECTED]) said: > > > They're certainly allowed, and the sysfs directory structure, files, > > > etc. handle it ok. Userspace tends to break in a variety of ways. > > > > > > I believe the only invalid character in an inter

Re: bonding: cannot remove certain named devices

2006-08-15 Thread Mitch Williams
On Tue, 15 Aug 2006, Bill Nottingham wrote: > 2.6.17-rc4+. > > Trivial example: > > # modprobe bonding (creates bond0) > # ip link set bond0 name "a b" > # echo "-a b" > /sys/class/net/bonding_masters > bonding: unable to delete non-existent bond a > bash: echo: write error: No such device > Yuc

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-15 Thread Mitch Williams
Andy Grover <[EMAIL PROTECTED]> is the guy. I'm not sure when he'll be working on this; it's somewhere in his TODO pile. On Thu, 15 Jun 2006, John W. Linville wrote: > > On Wed, Jun 14, 2006 at 04:44:56PM -0700, Mitch Williams wrote: > > > One of our eng

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-14 Thread Mitch Williams
On Wed, 14 Jun 2006, Neil Horman wrote: > Hey, as promised, I've done some rudimentary performance benchmarking on > various > ways that we have talked about to solve this problem. As I previously > mentioned We see the same results here, Neil. However, we've got a much less invasive patch

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-12 Thread Mitch Williams
On Sun, 2006-06-11 at 17:13 -0700, Neil Horman wrote: > Any further thoughts on this guys? I still think my last solution > solves all of > the netpoll problems, and isn't going to have any noticable impact on > performance. > I haven't had time to evaluate performance on your patch (sorry!), but

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-08 Thread Mitch Williams
On Wed, 2006-06-07 at 11:54 -0700, John W. Linville wrote: > Pedantic objection, but I think this would read easier w/o the extra > newline before disable_irq. Heh. I prefer to have a newline between declarations and code. The real problem is the position of the #ifdef -- that's what makes it d

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-08 Thread Mitch Williams
On Wed, 2006-06-07 at 11:44 -0700, Jeff Moyer wrote: > That patch locks around the tx clean routine. As such, it doesn't > prevent > the problem. The call to netif_rx_schedule_prep provides locking because it sets the __LINK_STATE_RX_SCHED bit atomically. The spinlock around e1000_clean_tx_irq

Re: [PATCH 1/2] e1000: fix netpoll with NAPI

2006-06-06 Thread Mitch Williams
On Tue, 2006-06-06 at 09:52 -0400, Neil Horman wrote: > I've been speaking about this fix with a Jeff Moyer, and we've come up with > some > concerns regarding its implementation. Specifically the call to > adapter->clean_rx in the case of the e1000 driver is rather a layering > violation in the

[PATCH 2.6.16.11] updated bonding documentation

2006-04-26 Thread Mitch Williams
Added new section describing the sysfs interface. Renumbered sections to be sequential (section 4 was AWOL). Minor spelling corrections. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN linux-2.6.16.11-clean/Documentation/networking/bonding.txt linux-2.6.16.11/Documen

[PATCH 2.6.14 11/18] move bond creation into separate function

2005-11-09 Thread Mitch Williams
The sysfs interface can create bonds at runtime, so we need a separate function to do this, instead of just doing it in the module init code. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bonding.h linux-2.6.14/drive

[PATCH 2.6.14 10/18] make functions not static

2005-11-09 Thread Mitch Williams
The sysfs code needs access these functions, so make them not static, and move the protos to the header file. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bonding.h linux-2.6.14/drivers/net/bonding/bonding.h --- linux-

[PATCH 2.6.14 16/18] version update

2005-11-09 Thread Mitch Williams
Update the version number for the bonding module. Since we've just added a significant new feature (sysfs support), bump the major number. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bonding.h linux-2.6.14/

[PATCH 2.6.14 8/18] explicitly clear RLB flag during ALB init

2005-11-09 Thread Mitch Williams
Explicitly clear RLB flag during ALB init. This is needed for sysfs support, since the bond mode can be changed at runtime via sysfs. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X linux-2.6.13/Documentation/dontdiff linux-2.6.14-rc2-clean/drivers/net/bonding/bond

[PATCH 2.6.14 14/18] add ARP entries to /proc

2005-11-09 Thread Mitch Williams
Make the /proc files show which ARP targets are in use by each bond. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bond_main.c linux-2.6.14/drivers/net/bonding/bond_main.c --- linux-2.6.14-release/drivers/net/b

[PATCH 2.6.14 9/18] expose some structs

2005-11-09 Thread Mitch Williams
The sysfs code needs to know what these structs look like, so make them not static, and move the definition to the header. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X linux-2.6.13/Documentation/dontdiff linux-2.6.14-rc2-clean/drivers/net/bonding/bonding.h linux-2.6.

[PATCH 2.6.14 15/18] add sysfs functionality to bonding (large)

2005-11-09 Thread Mitch Williams
. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bonding.h linux-2.6.14/drivers/net/bonding/bonding.h --- linux-2.6.14-release/drivers/net/bonding/bonding.h 2005-11-08 11:24:27.0 -0800 +++ linux-2.6.14/drivers/net/b

[PATCH 2.6.14 17/18] spelling and whitespace corrections

2005-11-09 Thread Mitch Williams
Minor spelling and whitespace corrections. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bond_alb.c linux-2.6.14/drivers/net/bonding/bond_alb.c --- linux-2.6.14-release/drivers/net/bonding/bond_alb.c 2005-11-08

[PATCH 2.6.14 12/18] make bond_init not __init

2005-11-09 Thread Mitch Williams
The sysfs interface can create bonds at runtime, and __init code goes away after module init. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bond_main.c linux-2.6.14/drivers/net/bonding/bond_main.c --- linux-2.6.14-r

[PATCH 2.6.14 7/18] move kmalloc out of spinlock in ALB init

2005-11-09 Thread Mitch Williams
Move memory allocations out of the spinlock during ALB init. This gets rid of a sleeping-inside-spinlock warning and accompanying stack dump. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X linux-2.6.13/Documentation/dontdiff linux-2.6.14-rc2-clean/drivers/net/b

[PATCH 2.6.14 18/18] comments and changelog

2005-11-09 Thread Mitch Williams
Bonding source files still have changelogs in the comments. This, then, is an update to that changelog. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bonding.h linux-2.6.14/drivers/net/bonding/bonding.h --- linux-

[PATCH 2.6.14 13/18] Allow ARP target table to have empty entries

2005-11-09 Thread Mitch Williams
With the sysfs interface, the user can remove entries from the ARP table at runtime. The ARP monitor code now allows for empty entries in the table. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bond_main.c linux-

[PATCH 2.6.14 4/18] expand module param descriptions

2005-11-09 Thread Mitch Williams
Expand and correct the parameter descriptions shown by modinfo. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bond_main.c linux-2.6.14/drivers/net/bonding/bond_main.c --- linux-2.6.14-release/drivers/net/bonding/bond_

[PATCH 2.6.14 5/18] Add transmit policy to /proc

2005-11-09 Thread Mitch Williams
Adds information about the recently-added transmit policy setting to each bond's /proc file. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/net/bonding/bond_main.c linux-2.6.14/drivers/net/bonding/bond_main.c --- linux-2.6

[PATCH 2.6.14 3/18] add bond name to all error messages

2005-11-09 Thread Mitch Williams
Add the bond name to all error messages so we can tell which one is complaining. Also reformats some error messages to be more consistent. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X linux-2.6.13/Documentation/dontdiff linux-2.6.14-rc2-clean/drivers/net/bonding/bond

[PATCH 2.6.14 2/18] make dev_valid_name public

2005-11-09 Thread Mitch Williams
dev_valid_name() is a useful function. Make it public. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-clean/include/linux/netdevice.h linux-2.6.14/include/linux/netdevice.h --- linux-2.6.14-clean/include/linux/netdevice.h2005-10-27

[PATCH 2.6.14 6/18] get slave name from actual slave instead of param list

2005-11-09 Thread Mitch Williams
Take the primary slave name shown in /proc from the actual slave dev instead of from the command-line parameter, which won't be present if the bond is created via sysfs. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-release/drivers/

[PATCH 2.6.14 0/18] Yet Another Bonding Sysfs patchset

2005-11-09 Thread Mitch Williams
Jay says he's finally ready to take this patch. So here we go again. Rebased against 2.6.14 final. Which turned out to be way more work than I expected. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe netdev&q

[PATCH 2.6.14 1/18] allow newline terminated IP addresses in in_aton

2005-11-09 Thread Mitch Williams
in_aton() gives weird results if it sees a newline at the end of the input. This patch makes it able to handle such input correctly. Signed-off-by: Mitch Williams <[EMAIL PROTECTED]> diff -urpN -X dontdiff linux-2.6.14-clean/net/core/utils.c linux-2.6.14/net/core/utils.c --- linux-2.6.14

Re: [PATCH 2.6.13-rc1 8/17] bonding: SYSFS INTERFACE (large)

2005-07-08 Thread Mitch Williams
(Adding vger to Cc: list, so as to spread the joy around.) On Thu, 7 Jul 2005, Greg KH wrote: > > > > Moving the individual bond directories to a bonds/ directory > > is problematic. Because each bond shows up a just another network > > interface, they show up in /sys/class/net automatically. W